Re: [pve-devel] [PATCH manager] api2: network: anybridge: re-add regular bridges

2022-04-27 Thread Thomas Lamprecht
On 27.04.22 14:32, DERUMIER, Alexandre wrote: > I didn' see, but Thomas have reworked it: > https://git.proxmox.com/?p=pve-manager.git;a=commit;h=640c0b26891c408d0456c355b3724c1be18cc75f > > and the behaviour seem to be different: argh, sorry, the can_access_vnet sub should also had an: return 1

Re: [pve-devel] [PATCH manager] api2: network: anybridge: re-add regular bridges

2022-04-27 Thread DERUMIER, Alexandre
> given that > - we can't require some new ACL path/priv for regular bridges until > the > next major release (as that would be quite the breaking change ;)) > - removing access to the last VNET would suddenly make all regular > bridges available (again) with your original patch, which is

Re: [pve-devel] [PATCH manager] api2: network: anybridge: re-add regular bridges

2022-04-27 Thread Fabian Grünbichler
On April 27, 2022 2:32 pm, DERUMIER, Alexandre wrote: > Hi Fabian > Le mercredi 27 avril 2022 à 13:36 +0200, Fabian Grünbichler a écrit : >> commit 052fbb2a4d1bdeb490b2e3b67cd7555e460ebe93 introduced permission >> > checks here that caused all regular bridges to be removed from the >> > returned li

Re: [pve-devel] [PATCH manager] api2: network: anybridge: re-add regular bridges

2022-04-27 Thread DERUMIER, Alexandre
Hi Fabian Le mercredi 27 avril 2022 à 13:36 +0200, Fabian Grünbichler a écrit : > commit 052fbb2a4d1bdeb490b2e3b67cd7555e460ebe93 introduced permission > > checks here that caused all regular bridges to be removed from the > > returned list as soon as the SDN package is installed, unless the > > us

[pve-devel] [PATCH manager] api2: network: anybridge: re-add regular bridges

2022-04-27 Thread Fabian Grünbichler
commit 052fbb2a4d1bdeb490b2e3b67cd7555e460ebe93 introduced permission checks here that caused all regular bridges to be removed from the returned list as soon as the SDN package is installed, unless the user is root@pam or there exists a VNET with the same ID. this is arguably a breaking change, s