On 4/29/25 11:15, Fiona Ebner wrote:
Am 29.04.25 um 10:37 schrieb Daniel Kral:
On 4/25/25 16:06, Fiona Ebner wrote:
Am 11.04.25 um 13:04 schrieb Daniel Kral:
On 4/3/25 14:16, Fabian Grünbichler wrote:
On March 25, 2025 4:12 pm, Daniel Kral wrote:
Also, I was curious about how that would work
Am 29.04.25 um 10:37 schrieb Daniel Kral:
> On 4/25/25 16:06, Fiona Ebner wrote:
>> Am 11.04.25 um 13:04 schrieb Daniel Kral:
>>> On 4/3/25 14:16, Fabian Grünbichler wrote:
On March 25, 2025 4:12 pm, Daniel Kral wrote:
>>> Also, I was curious about how that would work out for the case where a
On 4/25/25 16:05, Fiona Ebner wrote:
Not much to add to Fabian's review :)
Am 25.03.25 um 16:12 schrieb Daniel Kral:
diff --git a/src/PVE/HA/Rules/Colocation.pm b/src/PVE/HA/Rules/Colocation.pm
new file mode 100644
index 000..808d48e
--- /dev/null
+++ b/src/PVE/HA/Rules/Colocation.pm
@@ -0,
Agree with all here, but I propose to remove the merging for any
colocation rules in the last comment, if there's nothing speaking
against it.
On 4/25/25 16:06, Fiona Ebner wrote:
Am 11.04.25 um 13:04 schrieb Daniel Kral:
On 4/3/25 14:16, Fabian Grünbichler wrote:
On March 25, 2025 4:12 pm,
Am 11.04.25 um 13:04 schrieb Daniel Kral:
> On 4/3/25 14:16, Fabian Grünbichler wrote:
>> On March 25, 2025 4:12 pm, Daniel Kral wrote:
>>> +sub check_services_count {
>>> + my ($rules) = @_;
>>> +
>>> + my $conflicts = [];
>>> +
>>> + foreach_colocation_rule($rules, sub {
>>> + my ($ru
Not much to add to Fabian's review :)
Am 25.03.25 um 16:12 schrieb Daniel Kral:
> diff --git a/src/PVE/HA/Rules/Colocation.pm b/src/PVE/HA/Rules/Colocation.pm
> new file mode 100644
> index 000..808d48e
> --- /dev/null
> +++ b/src/PVE/HA/Rules/Colocation.pm
> @@ -0,0 +1,391 @@
> +package PVE::
Thanks for the review, Fabian!
Sorry for the wait, I was more focused on testing other patch series
which were already ready to merge for PVE 8.4 ;). But I'm going to be
working on this again now, so that it will be ready for the next release
or even before that :)
Thanks for the suggestions
On March 25, 2025 4:12 pm, Daniel Kral wrote:
> Add the colocation rule plugin to allow users to specify inter-service
> affinity constraints.
>
> These colocation rules can either be positive (keeping services
> together) or negative (keeping service separate). Their strictness can
> also be spec
Add the colocation rule plugin to allow users to specify inter-service
affinity constraints.
These colocation rules can either be positive (keeping services
together) or negative (keeping service separate). Their strictness can
also be specified as either a MUST or a SHOULD, where the first
specif
