Re: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers

2021-07-20 Thread Wolfgang Bumiller
On Tue, Jul 20, 2021 at 01:59:45PM +0200, Thomas Lamprecht wrote: > or we can avoid further hacks, separate the plugin ABI in an actual > "interface only" > module which base and a new unmanaged plugin depends on, so that we can > actually drop > that special case and with it all the `return if

Re: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers

2021-07-20 Thread Thomas Lamprecht
On 20.07.21 13:51, Oguz Bektas wrote: > On Tue, Jul 20, 2021 at 01:49:45PM +0200, Thomas Lamprecht wrote: >> On 20.07.21 13:40, Wolfgang Bumiller wrote: >>> On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote: unmanaged containers should run the unified cgroupv2 code from our base

Re: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers

2021-07-20 Thread Oguz Bektas
On Tue, Jul 20, 2021 at 01:49:45PM +0200, Thomas Lamprecht wrote: > On 20.07.21 13:40, Wolfgang Bumiller wrote: > > On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote: > >> unmanaged containers should run the unified cgroupv2 code from our base > >> plugin so that they can start correctly

Re: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers

2021-07-20 Thread Wolfgang Bumiller
On Tue, Jul 20, 2021 at 01:40:59PM +0200, Wolfgang Bumiller wrote: > On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote: > > unmanaged containers should run the unified cgroupv2 code from our base > > plugin so that they can start correctly instead of erroring out > > > > Tested-by: Stoik

Re: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers

2021-07-20 Thread Thomas Lamprecht
On 20.07.21 13:40, Wolfgang Bumiller wrote: > On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote: >> unmanaged containers should run the unified cgroupv2 code from our base >> plugin so that they can start correctly instead of erroring out >> >> Tested-by: Stoiko Ivanov >> Reviewed-by: St

Re: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers

2021-07-20 Thread Thomas Lamprecht
On 20.07.21 13:29, Oguz Bektas wrote: > > any news here? > feels to much like a hack to me, sprinkling that side effects of setting the plugin to base for the whole worker in some "random" helper is far to subtle and dangerous... If, it should have been set only locally, not writing to the $sel

Re: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers

2021-07-20 Thread Wolfgang Bumiller
On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote: > unmanaged containers should run the unified cgroupv2 code from our base > plugin so that they can start correctly instead of erroring out > > Tested-by: Stoiko Ivanov > Reviewed-by: Stoiko Ivanov > Signed-off-by: Oguz Bektas > --- >

Re: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers

2021-07-20 Thread Oguz Bektas
any news here? On Wed, Jul 14, 2021 at 11:51:51AM +0200, Oguz Bektas wrote: > unmanaged containers should run the unified cgroupv2 code from our base > plugin so that they can start correctly instead of erroring out > > Tested-by: Stoiko Ivanov > Reviewed-by: Stoiko Ivanov > Signed-off-by: Og

[pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers

2021-07-14 Thread Oguz Bektas
unmanaged containers should run the unified cgroupv2 code from our base plugin so that they can start correctly instead of erroring out Tested-by: Stoiko Ivanov Reviewed-by: Stoiko Ivanov Signed-off-by: Oguz Bektas --- v2-> v3: * added comment from stoiko's reply src/PVE/LXC/Setup.pm | 4 +++