Re: [pve-devel] [PATCH container] setup: make randomize_crontab a state subroutine

2021-05-26 Thread Thomas Lamprecht
On 26.05.21 10:48, Oguz Bektas wrote: > On Tue, May 25, 2021 at 03:26:12PM +0200, Thomas Lamprecht wrote: >> On 25.05.21 15:15, Oguz Bektas wrote: >>> for consistency in post_create_hook. still works as expected >>> >> >> what's the reason/benefit again? > > it looked a bit ugly otherwise with all

Re: [pve-devel] [PATCH container] setup: make randomize_crontab a state subroutine

2021-05-26 Thread Oguz Bektas
On Tue, May 25, 2021 at 03:26:12PM +0200, Thomas Lamprecht wrote: > On 25.05.21 15:15, Oguz Bektas wrote: > > for consistency in post_create_hook. still works as expected > > > > what's the reason/benefit again? it looked a bit ugly otherwise with all the other ones being state subs, so it's jus

Re: [pve-devel] [PATCH container] setup: make randomize_crontab a state subroutine

2021-05-25 Thread Thomas Lamprecht
On 25.05.21 15:15, Oguz Bektas wrote: > for consistency in post_create_hook. still works as expected > what's the reason/benefit again? > Signed-off-by: Oguz Bektas > --- > src/PVE/LXC/Setup/Base.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/PVE/LXC/Set

[pve-devel] [PATCH container] setup: make randomize_crontab a state subroutine

2021-05-25 Thread Oguz Bektas
for consistency in post_create_hook. still works as expected Signed-off-by: Oguz Bektas --- src/PVE/LXC/Setup/Base.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm index d73335b..be41874 100644 --- a/src/PVE/LXC/Se