Re: [pve-devel] [PATCH common] run_command: untaint end of buffer

2021-06-22 Thread Thomas Lamprecht
On 22.06.21 18:52, Stoiko Ivanov wrote: > On Tue, 22 Jun 2021 17:15:08 +0200 > Thomas Lamprecht wrote: > >> On 22.06.21 17:10, Stoiko Ivanov wrote: >>> I had a patch for untainting the individual values in >>> PVE::Storage::Plugin::volume_size_info but then went with this patch, >> >> I'd rathe

Re: [pve-devel] [PATCH common] run_command: untaint end of buffer

2021-06-22 Thread Stoiko Ivanov
On Tue, 22 Jun 2021 17:15:08 +0200 Thomas Lamprecht wrote: > On 22.06.21 17:10, Stoiko Ivanov wrote: > > I had a patch for untainting the individual values in > > PVE::Storage::Plugin::volume_size_info but then went with this patch, > > I'd rather have that patch, especially for back-porting t

Re: [pve-devel] [PATCH common] run_command: untaint end of buffer

2021-06-22 Thread Thomas Lamprecht
On 22.06.21 17:10, Stoiko Ivanov wrote: > I had a patch for untainting the individual values in > PVE::Storage::Plugin::volume_size_info but then went with this patch, I'd rather have that patch, especially for back-porting to stable. I mean, else we can probably just turn of the taint mode comple

Re: [pve-devel] [PATCH common] run_command: untaint end of buffer

2021-06-22 Thread Stoiko Ivanov
On Tue, 22 Jun 2021 16:41:50 +0200 Thomas Lamprecht wrote: > On 22.06.21 16:28, Stoiko Ivanov wrote: > > The performance improvements added in > > cb9db10c1a9855cf40ff13e81f9dd97d6a9b2698 changed the output handling > > to not remove the taintedness (see perlsec (1)) of the complete output > > an

Re: [pve-devel] [PATCH common] run_command: untaint end of buffer

2021-06-22 Thread Thomas Lamprecht
On 22.06.21 16:28, Stoiko Ivanov wrote: > The performance improvements added in > cb9db10c1a9855cf40ff13e81f9dd97d6a9b2698 changed the output handling > to not remove the taintedness (see perlsec (1)) of the complete output > anymore. > > This results in a few bugs which show up every now and then

[pve-devel] [PATCH common] run_command: untaint end of buffer

2021-06-22 Thread Stoiko Ivanov
The performance improvements added in cb9db10c1a9855cf40ff13e81f9dd97d6a9b2698 changed the output handling to not remove the taintedness (see perlsec (1)) of the complete output anymore. This results in a few bugs which show up every now and then, and are usually quite tedious to hunt down - usual