Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-21 Thread Christoph Heiss
On Wed, Nov 15, 2023 at 02:30:06PM +0100, Thomas Lamprecht wrote: > > Am 15/11/2023 um 13:23 schrieb Markus Frank: > > Change regex from "m/^[a-zA-Z0-9]+$/" to "m/^[a-zA-Z0-9\-]+$/" > > to allow hyphen in ldap attribute names for pve & pmg. > > [..] > > --- a/src/PVE/JSONSchema.pm > > +++ b/src/P

Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-15 Thread Thomas Lamprecht
Am 15/11/2023 um 16:12 schrieb Stefan Sterz: > just to through this out there, my last attempt at validating this [1] > looked something like this: > > ``` > my $escaped = qr!\\(?:[ "#+,;<=>\\]|[0-9a-fA-F]{2})!; > my $start= qr!(?:${escaped}|[^"+,;<>\\\0 #])!; > my $middle = qr!(?:${escaped

Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-15 Thread Stefan Sterz
On 15.11.23 15:49, Thomas Lamprecht wrote: > Am 15/11/2023 um 14:28 schrieb Stefan Sterz: >> On 15.11.23 13:23, Markus Frank wrote: -- >8 snip 8< -- >> >>> src/PVE/JSONSchema.pm | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSch

Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-15 Thread Stefan Sterz
On 15.11.23 14:28, Stefan Sterz wrote: >> src/PVE/JSONSchema.pm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm >> index 49e0d7a..ef58b62 100644 >> --- a/src/PVE/JSONSchema.pm >> +++ b/src/PVE/JSONSchema.pm >> @@ -408,7 +408

Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-15 Thread Thomas Lamprecht
Am 15/11/2023 um 14:28 schrieb Stefan Sterz: > On 15.11.23 13:23, Markus Frank wrote: >> Change regex from "m/^[a-zA-Z0-9]+$/" to "m/^[a-zA-Z0-9\-]+$/" >> to allow hyphen in ldap attribute names for pve & pmg. >> >> Signed-off-by: Markus Frank >> --- >> There does not seem to be a regex for LDAP a

Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-15 Thread Thomas Lamprecht
Am 15/11/2023 um 13:23 schrieb Markus Frank: > Change regex from "m/^[a-zA-Z0-9]+$/" to "m/^[a-zA-Z0-9\-]+$/" > to allow hyphen in ldap attribute names for pve & pmg. > > Signed-off-by: Markus Frank > --- > There does not seem to be a regex for LDAP attributes in pbs. > Should a regex be added fo

Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-15 Thread Stefan Sterz
On 15.11.23 13:23, Markus Frank wrote: > Change regex from "m/^[a-zA-Z0-9]+$/" to "m/^[a-zA-Z0-9\-]+$/" > to allow hyphen in ldap attribute names for pve & pmg. > > Signed-off-by: Markus Frank > --- > There does not seem to be a regex for LDAP attributes in pbs. > Should a regex be added for this

[pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-15 Thread Markus Frank
Change regex from "m/^[a-zA-Z0-9]+$/" to "m/^[a-zA-Z0-9\-]+$/" to allow hyphen in ldap attribute names for pve & pmg. Signed-off-by: Markus Frank --- There does not seem to be a regex for LDAP attributes in pbs. Should a regex be added for this? src/PVE/JSONSchema.pm | 2 +- 1 file changed, 1 i