Re: [pve-devel] [PATCH cluster 2/4] fix #4886: SSH: pin node's host key if available

2024-01-18 Thread Esi Y via pve-devel
6, 2024 at 01:39:56PM +, Esi Y via pve-devel wrote: > Date: Tue, 16 Jan 2024 13:39:56 + > From: Esi Y > To: pve-devel@lists.proxmox.com > Subject: Re: [pve-devel] [PATCH cluster 2/4] fix #4886: SSH: pin node's > host key if available > > Thank you for the respo

Re: [pve-devel] [PATCH cluster 2/4] fix #4886: SSH: pin node's host key if available

2024-01-16 Thread Esi Y via pve-devel
--- Begin Message --- Thank you for the responses below, I just want to explain all the fuss in my reasoning, i.e. why I am bringing it up before this goes into a release. The original way of handling SSH was meant to be pretty transparent to the user: A. If they ran plain ssh, without any extra

Re: [pve-devel] [PATCH cluster 2/4] fix #4886: SSH: pin node's host key if available

2024-01-16 Thread Fabian Grünbichler
> Esi Y via pve-devel hat am 15.01.2024 15:31 CET > geschrieben: > On Mon, Jan 15, 2024 at 12:51:48PM +0100, Fabian Grünbichler wrote: > > > On Thu, Jan 11, 2024 at 11:51:16AM +0100, Fabian Grünbichler wrote: > > > > if the target node has already stored their SSH host key on pmxcfs, pin > > > >

Re: [pve-devel] [PATCH cluster 2/4] fix #4886: SSH: pin node's host key if available

2024-01-15 Thread Esi Y via pve-devel
--- Begin Message --- On Mon, Jan 15, 2024 at 12:51:48PM +0100, Fabian Grünbichler wrote: > > On Thu, Jan 11, 2024 at 11:51:16AM +0100, Fabian Grünbichler wrote: > > > if the target node has already stored their SSH host key on pmxcfs, pin > > > it and > > > ignore the global known hosts informati

Re: [pve-devel] [PATCH cluster 2/4] fix #4886: SSH: pin node's host key if available

2024-01-15 Thread Fabian Grünbichler
> On Thu, Jan 11, 2024 at 11:51:16AM +0100, Fabian Grünbichler wrote: > > if the target node has already stored their SSH host key on pmxcfs, pin it > > and > > ignore the global known hosts information. > > > > Signed-off-by: Fabian Grünbichler > > --- > > src/PVE/SSHInfo.pm | 15 +

Re: [pve-devel] [PATCH cluster 2/4] fix #4886: SSH: pin node's host key if available

2024-01-15 Thread Esi Y via pve-devel
--- Begin Message --- On Thu, Jan 11, 2024 at 11:51:16AM +0100, Fabian Grünbichler wrote: > if the target node has already stored their SSH host key on pmxcfs, pin it and > ignore the global known hosts information. > > Signed-off-by: Fabian Grünbichler > --- > src/PVE/SSHInfo.pm | 15 ++

[pve-devel] [PATCH cluster 2/4] fix #4886: SSH: pin node's host key if available

2024-01-11 Thread Fabian Grünbichler
if the target node has already stored their SSH host key on pmxcfs, pin it and ignore the global known hosts information. Signed-off-by: Fabian Grünbichler --- src/PVE/SSHInfo.pm | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/PVE/SSHInfo.pm b/src/PVE/SSHI