Re: [pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode

2024-01-09 Thread DERUMIER, Alexandre
>> >>I managed to port it over, and in the second patch I squashed both >>changes into one diff hunk, those two hunks touching the same file >>confused me slightly initially ^^ oh, sorry, it was 2 patches from the initial github PR, and I have merged them in the same patch manually, not cleanly

Re: [pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode

2024-01-09 Thread Thomas Lamprecht
Am 09/01/2024 um 16:46 schrieb DERUMIER, Alexandre: > oh, I have tested with 17.2.7-pve1 > > > I'll look for 18.2 I managed to port it over, and in the second patch I squashed both changes into one diff hunk, those two hunks touching the same file confused me slightly initially ^^

Re: [pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode

2024-01-09 Thread DERUMIER, Alexandre
oh, I have tested with 17.2.7-pve1 I'll look for 18.2 Message initial De: Thomas Lamprecht À: Proxmox VE development discussion , Alexandre Derumier Objet: Re: [pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode Date: 09/01/2024 16:39:52 Am 09/01/2024 um

Re: [pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode

2024-01-09 Thread Thomas Lamprecht
Am 09/01/2024 um 15:50 schrieb Alexandre Derumier: > They are a bug in current debian packaging, > where rocksdb is build in debug mode (not inheriting from cmake flags) > > patch 1 already exist in ubuntu > patch 2 is a newer patch commited in ceph recently > > (patch 2 should be enough, but I'm

[pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode

2024-01-09 Thread Alexandre Derumier
They are a bug in current debian packaging, where rocksdb is build in debug mode (not inheriting from cmake flags) patch 1 already exist in ubuntu patch 2 is a newer patch commited in ceph recently (patch 2 should be enough, but I'm keeping patch1 by security). I have tested it, 4k randwrite io