--- Begin Message ---
Hannes,
I appreciate the swift review. I talked with my colleague in Cc and there's no
issue with being co-authors. So let's go forward with your proposition. Thank
you for taking care of it!
Best regards
De : Hannes Dürr
Envoyé : me
In general the plugin implementation seems sensible, the only thing I
didn't quite understand is the need for `get_status_ip`, more on that
inline.
The series no longer applies to master, as there have been patches that
add a fingerprint parameter to the API request [0].
For testing purposes I
--- Begin Message ---
Re Hannes,
You're welcome :)
Sorry for the "from:", my mistake, must've slipped through before sending the
patches (I may have forgot to signoff).
Noted for the Co-developed-by.
Would it be OK for you to edit that in or do I have to resend the patch series?
MfG
__
sorry my mistake, it looked to me as if the mail did not go to the
mailing list, but it did.
On 3/6/25 12:08, lou.lecriv...@orange.fr wrote:
From: Lou Lecrivain
Following review from Hannes,
I have made some improvements to the form of the code for the pve-network part.
No functional changes
I will review and test the series and then you can add it to the next
version if necessary. Otherwise we can also edit it.
On 3/6/25 14:11, lou.lecriv...@wdz.de wrote:
Re Hannes,
You're welcome :)
Sorry for the "from:", my mistake, must've slipped through before sending the
patches (I ma
Hi,
and thanks to the both of you!
Can you please resend the mail to our mailing list so that it is
available for everyone please?
Another tiny thing, we don't use "From: Lou Lecrivain
" but "Signed-off-by: Lou Lecrivain
"
which indicates that contribution was created in whole or in part by
--- Begin Message ---
From: Lou Lecrivain
Following review from Hannes,
I have made some improvements to the form of the code for the pve-network part.
No functional changes.
Related changes to pve-manager and pve-docs are also included the email thread.
BR
Lou Lecrivain (3):
ipam: nautobot
