Re: [pve-devel] [PATCH] fix #957 iscsi: don't check tcp connection directly

2025-03-07 Thread Mira Limbeck
On 3/7/25 12:59, Mira Limbeck wrote: > Thank you for the patch! > > some comments inline > >> +sub iscsi_test_session { >> +my ($portal, $sid) = @_; >> +my $cmd = [$ISCSIADM, '--mode', 'session', '--sid', $sid, '-P1']; >> + >> +my $res = 0; >> +eval { >> +run_command($cmd,

Re: [pve-devel] [PATCH] fix #957 iscsi: don't check tcp connection directly

2025-03-07 Thread Mira Limbeck
Thank you for the patch! some comments inline > +sub iscsi_test_session { > +my ($portal, $sid) = @_; > +my $cmd = [$ISCSIADM, '--mode', 'session', '--sid', $sid, '-P1']; > + > +my $res = 0; > +eval { > +run_command($cmd, errmsg => 'iscsi session test failed', outfunc =>

[pve-devel] [PATCH] fix #957 iscsi: don't check tcp connection directly

2025-03-05 Thread Victor Seva via pve-devel
--- Begin Message --- pvestatd is checking this every 10 seconds. This check produces a lot of noise at the iscsi server logging. Use iscsiadm command to check the sessions status instead Signed-off-by: Victor Seva --- src/PVE/Storage/ISCSIPlugin.pm | 28 +--- 1 file cha