--- Begin Message ---
25.10.2023 17:45, Dominik Csapak пишет:
One nit inline, but that could be fixed up when applying too probably?
Hi, Dominik!
Thanks for review! Should I send v6 with the fix for hash?
--
Best regards, Yuri Konotopov
--- End Message ---
_
--- Begin Message ---
Changes since v4:
* rebased on top of master branch
Changes since v3:
* drop redundant `m` modifier from `ISCSI_TARGET_RE` regexp
* drop redundant group from `iscsi_session_list` regexp
* improve stop loop condition in `iscsi_discovery`
Changes since v2:
* custom config
--- Begin Message ---
With this patch Proxmox now tries to login to all discovered portals in
case some of them are not logged yet.
In case of multipath configuration when initially configured portal is
missing for some reason Proxmox don't lose iscsi storage now and can
succesfully restore iscsi c
--- Begin Message ---
23.10.2023 12:11, Dominik Csapak пишет:
Hi,
Hi, Dominik!
sorry but I just noticed that it seems you did not create this patch
on top of our current master?
at least here it does not apply cleanly, since the files got moved to
src/
(in may already)
so could you pleas
--- Begin Message ---
With this patch Proxmox now tries to login to all discovered portals in
case some of them are not logged yet.
In case of multipath configuration when initially configured portal is
missing for some reason Proxmox don't lose iscsi storage now and can
succesfully restore iscsi c
--- Begin Message ---
Changes since v3:
* drop redundant `m` modifier from `ISCSI_TARGET_RE` regexp
* drop redundant group from `iscsi_session_list` regexp
* improve stop loop condition in `iscsi_discovery`
Changes since v2:
* custom configuration file is removed in favor of open-iscsi query
--- Begin Message ---
20.10.2023 13:23, Dominik Csapak пишет:
hi,
Hi, Dominik!
Thanks for review! I will address all issues in the next patch version.
in case the configured portal is not accessible, any new node
in the cluster (or one that did not activate the storage until then)
will not
--- Begin Message ---
Changes since v2:
* custom configuration file is removed in favor of open-iscsi query
* restored `portal` property format since we should not rely on initial
configuration but should use discovered configuration instead
* changed check_connection() to query all available
--- Begin Message ---
With this patch Proxmox now tries to login to all discovered portals in
case some of them are not logged yet.
In case of multipath configuration when initially configured portal is
missing for some reason Proxmox don't lose iscsi storage now and can
succesfully restore iscsi c
--- Begin Message ---
16.10.2023 17:58, Dominik Csapak пишет:
i would favor an approach that uses an 'array' instead of the '-list'
types.
While working more on this patch I came to conclusion we don't need to
modify portal property
format at all (nor -list, nor -array).
What we need for
--- Begin Message ---
17.10.2023 11:07, Fiona Ebner пишет:
Am 16.10.23 um 18:08 schrieb Yuri Konotopov:
It looks like the return value of iscsi_discovery is not used. So we can
drop
$res completely and regex too.
It is used by the scan/iscsi API endpoint via scan_iscsi() in Storage.pm.
Than
--- Begin Message ---
16.10.2023 17:58, Dominik Csapak пишет:
hi,
Hi, Dominik!
Thanks for your review. I will try to address all issues.
Some comments are below.
a few high level comments:
first:
is the iscsi.cfg really necessary? couldn't we just lookup on demand
like we do now?
Unti
--- Begin Message ---
10.10.2023 16:54, Fiona Ebner пишет:
Hi,
Hi, Fiona!
Thanks for your review! I will send updated patch soon.
thank you for the contribution! Please prepend the commit title with
"fix #254: ".
Am 16.08.23 um 13:56 schrieb ykonoto...@gnome.org:
From: Yuri Konotopov
Fi
--- Begin Message ---
From: Yuri Konotopov
Signed-off-by: Yuri Konotopov
---
PVE/API2/Storage/Scan.pm | 2 +-
PVE/Storage.pm | 10 +-
PVE/Storage/ISCSIPlugin.pm | 207 -
3 files changed, 187 insertions(+), 32 deletions(-)
diff --git a/PVE/AP
--- Begin Message ---
From: Yuri Konotopov
Hello!
Here is v2 patch that allows to specify multiple comma-separated ISCSI portals
using Proxmox UI, adds support for storing discovered portals and adds ability
to login to all discovered portals in case some of them are not logged yet.
With that pa
15 matches
Mail list logo
