Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]

2025-03-07 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Fri, Mar 07, 2025 at 09:24:25AM +0100, Roland Kammerer wrote: > On Tue, Feb 25, 2025 at 11:50:31AM +0100, Max Carrara wrote: > > 6. Is there any other things you'd like to mention? Feedback, critique > >and such are all welcome! something I forgot: the last time I chec

Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]

2025-03-07 Thread Roland Kammerer via pve-devel
--- Begin Message --- Hi Max, took me a bit longer than expected, but here we go... On Tue, Feb 25, 2025 at 11:50:31AM +0100, Max Carrara wrote: > Thanks a lot for the offer! I do actually have a couple questions. It > would be nice if you could answer them, as it would aid in cleaning all > this

Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]

2025-02-07 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Fri, Feb 07, 2025 at 10:18:42AM +0100, Fabian Grünbichler wrote: > > > Roland Kammerer via pve-devel hat am > > 07.02.2025 10:02 CET geschrieben: > > Hi all, > > > > rather simple question I guess, but I could not find the answer in

[pve-devel] storage plugins: what is plugindata()->{content}[1]

2025-02-07 Thread Roland Kammerer via pve-devel
--- Begin Message --- Hi all, rather simple question I guess, but I could not find the answer in https://pve.proxmox.com/wiki/Storage_Plugin_Development and linked documents and looks like my grep foo is lacking today, so here we go: I guess I know what the first hash in the 'content' array is, bu

Re: [pve-devel] DRBD integration but without LINSTOR

2024-08-19 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Mon, Aug 19, 2024 at 03:37:43PM +0200, sjanssens via pve-devel wrote: > I am about to complete my internship at Evolix, during which I worked on a > project to integrate DRBD into Proxmox. This involved manipulating DRBD > resources and using basic drbd-utils tools. I have

Re: [pve-devel] DRBD integration but without LINSTOR

2024-08-18 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Fri, Aug 16, 2024 at 04:43:03PM +0200, Dietmar Maurer wrote: > > Hello, i wan't to make a patch for proxmox to implements DRBD, in a > > different way that LINSTOR do. I want to discuss about its usefulness > > and implementation with the community. > > I think you shoul

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-03-15 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Wed, Mar 13, 2024 at 04:38:57PM +0100, Wolfgang Bumiller wrote: > My thoughts on this: (TLDR: we should just merge it and probably also > consider adding a separate method to get the *format* of a volid) > > - Adding the parameter itself is fine, not thinking about how/why

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-03-06 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Tue, Mar 05, 2024 at 01:13:08PM +0100, Fabian Grünbichler wrote: > I wonder whether the following wouldn't also work? > > - keep the volume name on the PVE side like the other storage plugins > (which means - encode vital information about the volume there so that > it's p

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-03-05 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Fri, Mar 01, 2024 at 11:14:31AM +0100, Roland Kammerer wrote: > On Fri, Mar 01, 2024 at 10:45:37AM +0100, Dietmar Maurer wrote: > > > > > On 29.2.2024 16:09 CET Roland Kammerer via pve-devel > > > wrote: > > > All in all, ye

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-03-01 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Fri, Mar 01, 2024 at 10:45:37AM +0100, Dietmar Maurer wrote: > > > On 29.2.2024 16:09 CET Roland Kammerer via pve-devel > > wrote: > > All in all, yes, this is specific for our use case, otherwise > > parse_volname would already have that addi

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-02-29 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Thu, Feb 29, 2024 at 02:29:51PM +0100, Fiona Ebner wrote: > Am 23.02.24 um 10:24 schrieb Roland Kammerer: > > This passes the well known $scfg to parse_volname and bumps the API > > versions accordingly. This allows plugins to access their configuration > > if necessary. >

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-02-29 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Fri, Feb 23, 2024 at 10:24:36AM +0100, Roland Kammerer wrote: > This passes the well known $scfg to parse_volname and bumps the API > versions accordingly. This allows plugins to access their configuration > if necessary. Hi devs, just a ping as this did not get any feedb

[pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-02-23 Thread Roland Kammerer via pve-devel
--- Begin Message --- This passes the well known $scfg to parse_volname and bumps the API versions accordingly. This allows plugins to access their configuration if necessary. Signed-off-by: Roland Kammerer --- ApiChangeLog | 7 +++ src/PVE/Storage.pm | 18 +- 2 files

[pve-devel] [PATCH storage 0/1] pass scfg to parse_volname

2024-02-23 Thread Roland Kammerer via pve-devel
--- Begin Message --- Dear PVE devs, I'm currently trying to implement "Disk Action" -> "Reassign Owner" for the LINSTOR plugin. This traditionally means implementing "rename_volume", which moves a disk from something like vm-100-disk-1 to vm-101-disk-1, which can then be parsed back by a regex to