The new checkbox allows users to create a HA resource for the CT right
away. The 'state' of the HA resource will match the value of the "Start
after creation" checkbox.
Signed-off-by: Michael Köppl
---
www/manager6/lxc/CreateWizard.js | 17 ++---
1 file changed,
Matching the checkbox in the CreateWizard dialogs for VMs and CTs, add
the option to create a HA resource when restoring a guest.
Signed-off-by: Michael Köppl
---
www/manager6/window/Restore.js | 12
1 file changed, 12 insertions(+)
diff --git a/www/manager6/window/Restore.js b
On Tue Sep 30, 2025 at 12:00 PM CEST, Thomas Lamprecht wrote:
> Am 24.09.25 um 18:17 schrieb Michael Köppl:
>> The ConfirmRemoveDialog window covers the SafeDestroy window's
>> functionality, but makes it more general-purpose/flexible. It can be
>> used for both ye
Superseded-by:
https://lore.proxmox.com/pve-devel/20250930145848.263162-1-m.koe...@proxmox.com/
On 9/24/25 6:07 PM, Michael Köppl wrote:
> This patch series aims to fix #6613 [0]. Although an implementation was
> proposed in the past, it was not applied since it was unclear how to
> h
This is made obsolete by:
https://lore.proxmox.com/pve-devel/20250930145848.263162-1-m.koe...@proxmox.com/
On 9/24/25 6:17 PM, Michael Köppl wrote:
> This is a follow-up to another series implementing an additional purge
> param for resource removal [0].
>
> The ConfirmRemoveD
. SafeDestroy is now a special case of ConfirmRemoveDialog. This
also avoids changes for dialog windows extending SafeDestroy.
Also makes ConfirmRemoveDialog a non-dangerous yes/no dialog by default,
setting dangerous = true and the "Remove" in SafeDestroy explicitly.
Signed-off-by: Mic
This is done to make extending SafeDestroy with additional functionality
easier.
Signed-off-by: Michael Köppl
---
No functional change intended here. I mostly split the widget-toolkit
patches up into multiple parts to make review of the individual
extensions of the dialog easier. This is the
This allows users to additionally choose whether they want to purge
referenced rules that only include the resource that is to be deleted.
Signed-off-by: Michael Köppl
---
www/manager6/ha/Resources.js | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/www
Signed-off-by: Michael Köppl
Tested-by: Daniel Kral
Reviewed-by: Daniel Kral
---
src/PVE/API2/HA/Resources.pm | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/HA/Resources.pm b/src/PVE/API2/HA/Resources.pm
index 894fe90..09fe954 100644
--- a/src/PVE
On Fri Sep 26, 2025 at 4:15 PM CEST, Daniel Kral wrote:
> I think it's a good idea to combine these, but at the same time it's a
> bit hard to review not seeing the diff from Proxmox.window.SafeDestroy
> here directly..
>
> I diffed them locally and if it's not too much work, it might be nice to
>
This covers the case where users want to delete a VM that is also a HA
resource. If the purge param is set, the HA resource will also be
removed from the affinity rules referencing the resource. If the
affected rule only contains this one resource, the rule is also deleted.
Signed-off-by: Michael
The ConfirmRemoveDialog offers additional customization, but covers
SafeDestroy's feature set. This is done mostly to streamline the
implementation, basing dialogs to remove guests, storage, or resources
on the same component.
Signed-off-by: Michael Köppl
---
www/manager6/w
Superseded-by:
https://lore.proxmox.com/pve-devel/20250924160747.430018-1-m.koe...@proxmox.com/
On 9/17/25 1:53 PM, Michael Köppl wrote:
> This patch series aims to fix #6613 [0]. Although an implementation was
> proposed in the past, it was not applied since it was unclear how to
> h
On Tue Sep 23, 2025 at 9:50 AM CEST, Daniel Kral wrote:
> On Wed Sep 17, 2025 at 1:53 PM CEST, Michael Köppl wrote:
>> This allows users to additionally choose whether they want to purge
>> referenced rules that only include the resource that is to be deleted.
>>
>> S
The check icon should not be clickable since it is misleading if
clicking it triggers no action, so add a class to the element that
disables pointer events if there is no error.
Signed-off-by: Michael Köppl
---
www/manager6/ha/Rules.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Signed-off-by: Michael Köppl
---
www/manager6/ha/ResourceEdit.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/ha/ResourceEdit.js b/www/manager6/ha/ResourceEdit.js
index 428672a82..18ed166ad 100644
--- a/www/manager6/ha/ResourceEdit.js
+++ b/www/manager6/ha/ResourceEdit.js
This does not only improve visual feedback to the user in the form of
red highlighting, but also disables the "Add" button while the field is
still empty.
Signed-off-by: Michael Köppl
---
www/manager6/ha/ResourceEdit.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/m
allow blank
inputs, giving users better visual feedback.
pve-manager:
Michael Köppl (2):
ui: ha: remove focus from VM/CT dropdown in resource edit window
ui: ha: do not allow an empty VM/CT dropdown in resource edit window
www/manager6/ha/ResourceEdit.js | 2 ++
1 file changed, 2 insertions
such elements appear as non-clickable and the second
patch applies this class to the status icon for rules.
proxmox-widget-toolkit:
Michael Köppl (1):
css: add class for making elements unclickable
src/proxmox-dark/scss/proxmox/_general.scss | 5 +
1 file changed, 5 insertions(+)
pve
This is useful for elements which have a click handler defined, but the
action of that handler is dependent on some condition. Without adding
pointer-events:none; the element would be displayed as clickable.
Signed-off-by: Michael Köppl
---
src/proxmox-dark/scss/proxmox/_general.scss | 5
On Fri Sep 19, 2025 at 4:41 PM CEST, Daniel Kral wrote:
> Just to link these here, there were two community forum posts [0] and
> [1], which added some more viewpoints how HA groups are/were used and
> what could still be improved for the HA rules.
>
> The pain points were primarily that users coul
ompared to finding the group for information that can be
be viewed in a less cluttered manner on the rules page.
pve-manager:
Michael Köppl (1):
ui: ha: remove group info from HA status string in guest status view
www/manager6/Utils.js | 3 ---
1 file changed, 3 deletions(-)
proxmox-widg
Groups have been replaced by rules. Since the guest status view no
longer displays information about rules, this mapping can also be
removed.
Signed-off-by: Michael Köppl
---
src/Utils.js | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/Utils.js b/src/Utils.js
index a0c6ca5..beb9df2
Groups have been replaced by rules. Since rules are no longer displayed
as part of the service status and fetching the relevant rules would add
more complexity compared to getting the group, this information is
omitted altogether.
Signed-off-by: Michael Köppl
---
src/PVE/HA/Config.pm | 1 -
1
, finding the rules of which the resource is a part of
adds a lot more complexity than getting the group did. Thus, the
information is omitted from the status text altogether.
Signed-off-by: Michael Köppl
---
www/manager6/Utils.js | 3 ---
1 file changed, 3 deletions(-)
diff --git a/www/manager6
Signed-off-by: Michael Köppl
---
src/PVE/API2/HA/Resources.pm | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/HA/Resources.pm b/src/PVE/API2/HA/Resources.pm
index 894fe90..09fe954 100644
--- a/src/PVE/API2/HA/Resources.pm
+++ b/src/PVE/API2/HA
resources no longer exist.
Signed-off-by: Michael Köppl
---
src/PVE/HA/Config.pm | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Config.pm b/src/PVE/HA/Config.pm
index 301c62f..9a7ed0e 100644
--- a/src/PVE/HA/Config.pm
+++ b/src/PVE/HA/Config.pm
Add an extended removal dialog for HA resources, which also allows
setting a purge parameter through the checkbox. By default, the purge
option is enabled, updating rules referencing the resource and deleting
any rules that only have this resource left.
Signed-off-by: Michael Köppl
---
www
This allows users to additionally choose whether they want to purge
referenced rules that only include the resource that is to be deleted.
Signed-off-by: Michael Köppl
---
www/manager6/ha/Resources.js | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/www
m/pve-devel/c004b755-ba3c-46cd-b559-ee2c131d9...@proxmox.com
pve-ha-manager:
Michael Köppl (2):
fix #6613: update rules containing the resource to be deleted
api: add purge parameter for resource deletion
src/PVE/API2/HA/Resources.pm | 10 +-
src/PVE/HA/Config.pm | 15
Signed-off-by: Michael Köppl
---
ha-manager.adoc | 4
pct.adoc| 3 +++
qm.adoc | 3 +++
3 files changed, 10 insertions(+)
diff --git a/ha-manager.adoc b/ha-manager.adoc
index ea477cc0..5c17f115 100644
--- a/ha-manager.adoc
+++ b/ha-manager.adoc
@@ -220,6 +220,10 @@ the
This covers the case where users want to delete a CT that is also a HA
resource. If the purge param is set, the HA resource will also be
removed from the affinity rules referencing the resource. If the
affected rule only contains this one resource, the rule is also deleted.
Signed-off-by: Michael
This covers the case where users want to delete a VM that is also a HA
resource. If the purge param is set, the HA resource will also be
removed from the affinity rules referencing the resource. If the
affected rule only contains this one resource, the rule is also deleted.
Signed-off-by: Michael
Without this change, only the value of the type variable would be used
as the task description for task types without an entry in the
task_desc_table.
Signed-off-by: Michael Köppl
---
src/Utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Utils.js b/src/Utils.js
Since I was just now encountering this problem, gave this a quick spin.
Works as advertised, did not notice anything off.
Tested-by: Michael Köppl
On Fri Sep 12, 2025 at 1:32 PM CEST, Dominik Csapak wrote:
> the recent commit
> d2660fc7 (ui: resource tree: improve performance on initial
Since the v2 of this series features only minor changes to the commit
messages that I suggested in my review of v1, please consider this:
Reviewed-by: Michael Köppl
Tested-by: Michael Köppl
On Thu Sep 4, 2025 at 12:09 PM CEST, Shan Shaji wrote:
> The app was not honoring the user instal
Tested this by manually calling both API endpoints. With the patches
applied, the returned filename now contains the data sources provided in
the params and also returns data for the image again.
Tested-by: Michael Köppl
On Thu Aug 28, 2025 at 2:58 PM CEST, Aaron Lauterer wrote:
> This ser
such scenarios,
but could IMO also be added in a separate patch.
With my comment for proxmox_dart_api_client 1/2 addressed consider this:
Tested-by: Michael Köppl
Reviewed-by: Michael Köppl
On Tue Sep 2, 2025 at 12:17 PM CEST, Shan Shaji wrote:
> The app was not honoring the user instal
On Tue Sep 2, 2025 at 12:17 PM CEST, Shan Shaji wrote:
> In android when a user installs a custom certificate the app was not
> honoring the installed certificate and was still throwing
> `HandShakeException`.
>
> To fix the issue, used the `crone_http` [0] package which will honor the
nit: s/cron
Gave this a spin in my Android emulator. Works as expected. I also
checked that there's no state change, etc. when rotating to landscape
and back and that options are locked again upon re-opening the VM/LXC
options view. Did not notice anything off.
Consider this
Tested-by: Michael Köppl
I
On Fri Aug 29, 2025 at 3:42 PM CEST, Daniel Kral wrote:
>>> diff --git a/src/PVE/HA/Rules.pm b/src/PVE/HA/Rules.pm
>>> index a075feac..d7593532 100644
>>> --- a/src/PVE/HA/Rules.pm
>>> +++ b/src/PVE/HA/Rules.pm
>>> @@ -47,6 +47,12 @@ Each I is required to implement the methods
>>> C>,
>>> C>, and
During my review I was wondering why 16/18 and 17/18 added similar
checks to both the manager's and the API's active service counting and
why they're not combined into a single helper function, only to then
notice that the final patch does exactly that. Is there a reason it's
done in this order? Ot
It seems this patch does not apply anymore due to f263217.
On Wed Jul 30, 2025 at 2:37 PM CEST, Shan Shaji wrote:
> On the options page for VMs and CTs it was easy to change the
> configs by mistake. To avoid that, added an edit button on the top
> of the screen. The toggle buttons will only be en
ture.
With my comments on the individual patches addressed, please consider
this series
Reviewed-by: Michael Köppl
Tested-by: Michael Köppl
On Thu Aug 21, 2025 at 4:35 PM CEST, Daniel Kral wrote:
> I put the patches in decreasing priority:
>
> PATCH 1fix output of get_resource_inf
2 comments inline
On Thu Aug 21, 2025 at 4:35 PM CEST, Daniel Kral wrote:
> sub write_rules_config {
> @@ -391,8 +391,9 @@ sub get_resource_motion_info {
> my $ss = $manager_status->{service_status};
> my $ns = $manager_status->{node_status};
>
> -my $rules = read_and_
One nit inline
On Thu Aug 21, 2025 at 4:35 PM CEST, Daniel Kral wrote:
> @@ -248,58 +255,6 @@ __PACKAGE__->register_check(
>
> =cut
>
> -my $sort_by_lowest_resource_id = sub {
> -my ($rules) = @_;
> -
> -my $lowest_rule_resource_id = {};
> -for my $ruleid (keys %$rules) {
> -
On Thu Aug 21, 2025 at 4:35 PM CEST, Daniel Kral wrote:
> The variable is only used in the try_persistent_group_migration(...)
> helper. While at it, add a comment and change the name to make its
> meaning clearer.
>
> Signed-off-by: Daniel Kral
> ---
> src/PVE/HA/Manager.pm | 11 ++-
> 1
2 minor suggestions inline
On Thu Aug 21, 2025 at 4:35 PM CEST, Daniel Kral wrote:
> Some rule checks depend on the list of cluster nodes, e.g., to check
> whether a negative resource affinity rule doesn't specify more HA
> resources than cluster nodes.
>
> The HA Manager retranslate rules only in
Superseded by v2:
https://lore.proxmox.com/pve-devel/20250826155854.344897-1-m.koe...@proxmox.com
On 8/26/25 4:45 PM, Michael Köppl wrote:
> Signed-off-by: Michael Köppl
> ---
> Note that I left the translation of "Now refreshing" marked as fuzzy
> since I'd per
Signed-off-by: Michael Köppl
---
I think the translation for "Now refreshing" is a bit clumsy. Maybe
someone's more creative regarding this one, but personally I'd prefer to
change the original text to "Refreshing..." and translate it as
"Aktualisiert..."
Signed-off-by: Michael Köppl
---
Note that I left the translation of "Now refreshing" marked as fuzzy
since I'd personally prefer changing the original string to something
like "Refreshing..." because otherwise the German translation (maybe
other languages as well)
Signed-off-by: Michael Köppl
---
de.po | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/de.po b/de.po
index 8808913..5aa5a57 100644
--- a/de.po
+++ b/de.po
@@ -483,7 +483,7 @@ msgstr "Knoten hinzufügen"
#: proxmox-datacenter-mana
Apart from a typo I noted on 5/5 and the comments already made by
Hannes, I did not notice any errors and the changes improve the
comprehensibility of the docs IMO, so consider these changes:
Reviewed-by: Michael Köppl
On 8/4/25 16:12, Daniel Kral wrote:
> Suggested-by: Hannes Dürr
>
On 8/4/25 16:12, Daniel Kral wrote:
> Signed-off-by: Daniel Kral
> ---
> ha-manager.adoc | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/ha-manager.adoc b/ha-manager.adoc
> index 5d75287..e18a14d 100644
> --- a/ha-manager.adoc
> +++ b/ha-manager.adoc
> @@ -787,6 +787,11 @@ HA resou
1 typo noted inline
On 8/4/25 16:12, Daniel Kral wrote:
> As HA groups are replaced by HA node affinity rules and user can
> implement new CRS behavior with HA resource affinity rules now, update
> texts that reference HA groups with references to HA rules instead.
>
> While at it, also replace r
: Michael Köppl
---
Note: I moved the stores from the RulesBaseView outside to the
RulesView, which encapsulates the NodeAffinityRulesView and the
ResourceAffinityRulesView. I did this to make it easier to refresh both
stores when the datachanged event is fired. Open to suggestions, though.
www/manager6
Signed-off-by: Michael Köppl
---
www/manager6/ha/Rules.js | 175 +++
1 file changed, 86 insertions(+), 89 deletions(-)
diff --git a/www/manager6/ha/Rules.js b/www/manager6/ha/Rules.js
index c8d4c1dac..5fd02b7ba 100644
--- a/www/manager6/ha/Rules.js
+++ b/www
formatting through `make tidy`.
pve-manager:
Michael Köppl (2):
ui: ha: refresh rules lists on edit to display conflicts immediately
run make tidy
www/manager6/ha/Rules.js | 118 ---
1 file changed, 73 insertions(+), 45 deletions(-)
Summary over all repositories
warning was not displayed anymore. Looks good
to me.
Consider this:
Tested-by: Michael Köppl
On 8/1/25 11:13, Shannon Sterz wrote:
> the find command previously also found the already migrated rrd files
> under `pve-{vm,node,storage}-9.0` and reported them as needing to
> migrate
Gave this version another spin today, focusing on the migration from
groups to rules. I tested this 3-node and 5-node clusters. Went through
the following scenarios:
1) At least one of the nodes in the cluster not at minimum version
required for migration to rules
2) At least one node offline duri
On 7/30/25 12:39, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval
> ---
> ui/src/dashboard/top_entities.rs | 1 +
> ui/src/pve/qemu.rs | 2 ++
> ui/src/remotes/add_wizard.rs | 1 +
> 3 files changed, 4 insertions(+)
>
> diff --git a/ui/src/dashboard/top_entiti
On 7/4/25 20:20, Daniel Kral wrote:
>
> diff --git a/src/PVE/HA/Rules.pm b/src/PVE/HA/Rules.pm
> index 3121424..892e7aa 100644
> --- a/src/PVE/HA/Rules.pm
> +++ b/src/PVE/HA/Rules.pm
> @@ -6,6 +6,7 @@ use warnings;
> use PVE::JSONSchema qw(get_standard_option);
> use PVE::Tools;
>
> +use PVE::
Superseded-by:
https://lore.proxmox.com/pve-devel/20250723153524.288508-1-m.koe...@proxmox.com
On 7/22/25 18:54, Michael Köppl wrote:
> These 2 patches are meant as a follow-up for the HA affinity rules
> series [0]. During testing, I encountered some errors during the
> persistent
On 7/22/25 18:38, Michael Köppl wrote:
> The migrations based on the persisted rules seemed to work (apart from
> failback). Of course, without the second series, the current state is
> that the groups are migrated and then are simply gone and there is
> nothing to replace them, so it&
When exclude_disabled_rules was enabled, rules would be excluded from
the check even if the value was actually false, since it still existed.
The check now makes sure that the rule is really disabled before
excluding it.
Signed-off-by: Michael Köppl
---
src/PVE/HA/Rules.pm | 2 +-
1 file
Prepend /etc/pve/ to the path, as is done for other read and write
functions for the groups.cfg file. Otherwise, removing the file does not
work.
Signed-off-by: Michael Köppl
---
src/PVE/HA/Config.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Config.pm b
Add the rules overview that replaces the groups overview and displays
node affinity rules. In addition, the edit dialogs for node affinity
rules are added, allowing both creation and editing of node affinity
rules.
Signed-off-by: Michael Köppl
Originally-by: Daniel Kral
---
This is based on the
Signed-off-by: Michael Köppl
---
src/PVE/API2/HA/Rules.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/API2/HA/Rules.pm b/src/PVE/API2/HA/Rules.pm
index 2e5e382..817aa1d 100644
--- a/src/PVE/API2/HA/Rules.pm
+++ b/src/PVE/API2/HA/Rules.pm
@@ -25,6 +25,7 @@ my $get_api_ha_rule
y.
- Add UI part for pve-manager
pve-ha-manager:
Michael Köppl (4):
config: use entire path to groups.cfg path in delete_group_config
ha: decode JSON string with version info returned by get_node_kv
api: return disable field for rules endpoint
ha: check for actual disable value during r
The value returned by get_node_kv is a JSON string and has to be decoded
to read the version of the node.
Signed-off-by: Michael Köppl
---
src/PVE/HA/Env/PVE2.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE/HA/Env/PVE2.pm
index aecffc0
The changes good to me. I think this also improves clarity and I did not
notice any typos or grammatical errors.
Reviewed-by: Michael Köppl
On 7/23/25 11:54, Lukas Wagner wrote:
> The latest updates to the backup-job UI completely drop the term
> "Notification System" from th
On 7/22/25 18:38, Michael Köppl wrote:
> This results in the following error:
> Abort HA group migration: failed to remove group config: No such file
> or directory
>
> The value in $ha_groups_config is only part of the path to the
> groups.cfg file. It works for the r
-manager.git:
Michael Köppl (2):
config: use entire path to groups.cfg path in delete_group_config
ha: decode JSON string with version info returned by get_node_kv
src/PVE/HA/Config.pm | 3 ++-
src/PVE/HA/Env/PVE2.pm | 4 +++-
2 files changed, 5 insertions(+), 2 deletions(-)
Summary over all
The version info entries for each node returned by get_node_kv are JSON
strings and need to be decoded to read the version of the node.
Signed-off-by: Michael Köppl
---
src/PVE/HA/Env/PVE2.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE
Prepend /etc/pve/ to the path, as is done for other read and write
functions for the groups.cfg file. Otherwise, removing the file does not
work.
Signed-off-by: Michael Köppl
---
src/PVE/HA/Config.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Config.pm b
Left 2 comments inline.
On 7/4/25 20:16, Daniel Kral wrote:
>
> diff --git a/src/PVE/HA/Config.pm b/src/PVE/HA/Config.pm
> index 424a6e1..59bafd7 100644
> --- a/src/PVE/HA/Config.pm
> +++ b/src/PVE/HA/Config.pm
> @@ -234,6 +234,11 @@ sub read_group_config {
> return cfs_read_file($ha_groups_
I've had a look at this series without looking at the second series that
extends this (yet). As Dano noted, there are multiple TODOs for the
final ha-manager patch in this series that tries to persist the
migration from groups to rules. During my testing I quickly ran into
some problems with this p
Left 2 comments inline, just some minor nits.
On 7/4/25 20:16, Daniel Kral wrote:
> Migrate the currently configured groups to node affinity rules
> in-memory, so that they can be applied as such in the next patches and
> therefore replace HA groups internally.
>
> HA node affinity rules in their
Missed some of the original changes, sorry about that.
Superseded-by:
https://lore.proxmox.com/pve-devel/20250716104351.46784-1-m.koe...@proxmox.com
On 7/16/25 12:30, Michael Köppl wrote:
> To avoid artificially limiting what users can do, remove the checks
> that ascertain if a su
-off-by: Michael Köppl
---
proxmox-auto-installer/tests/parse-answer.rs | 2 --
.../parse_answer/ipv4_and_subnet_31.json | 19 --
.../parse_answer/ipv4_and_subnet_31.toml | 18 --
.../ipv4_and_subnet_addr_is_network.json | 3
-off-by: Michael Köppl
---
proxmox-auto-installer/tests/parse-answer.rs | 1 -
.../ipv4_and_subnet_addr_is_network.json | 3 --
.../ipv4_and_subnet_addr_is_network.toml | 18 ---
proxmox-installer-common/src/utils.rs | 32 ---
4 files changed, 54
On 7/8/25 13:09, Lukas Wagner wrote:
> Something that I have noticed is that when you have a second disk/mountpoint
> on
> some storage, detach the disk/mountpoint, remove the storage and then
> try to remove the unused disk, there is a difference in behavior between
> containers and VMs. For VMs,
Superseded-by:
https://lore.proxmox.com/pve-devel/20250715094021.154914-1-m.koe...@proxmox.com
On 7/11/25 18:27, Michael Köppl wrote:
> The goal of this series is to add additional sanity checks to the
> auto-installer and the TUI and GUI installers. The following checks were
> added:
On 7/11/25 19:54, Thomas Lamprecht wrote:
> Am 11.07.25 um 18:27 schrieb Michael Köppl:
>> Check that the configured swapsize is not greater than hdsize / 8 as
>> stated in the admin guide [0]. Define the behavior for the auto-installer as
>> well as the TUI and GUI installers
Check that the configured swapsize is not greater than hdsize / 8 as
stated in the admin guide [0]. Define the behavior for the auto-installer as
well as the TUI and GUI installers.
[0] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#advanced_lvm_options
Signed-off-by: Michael Köppl
the user experience by avoiding failure during
the actual installation.
Signed-off-by: Michael Köppl
---
proxmox-auto-install-assistant/src/main.rs| 3 +-
proxmox-auto-installer/src/utils.rs | 18 ++-
proxmox-auto-installer/tests/parse-answer.rs | 4
Adapt the return type of CidrAddressEditView's get_value implementation
for the FormViewGetValue trait to handle errors in case of invalid CIDR
similarly to other (parsing) errors done in the TUIs network dialog.
Signed-off-by: Michael Köppl
---
proxmox-tui-installer/src/main.rs
Signed-off-by: Michael Köppl
---
proxmox-auto-installer/src/utils.rs | 12 +++-
proxmox-auto-installer/tests/parse-answer.rs | 1 +
.../parse_answer_fail/duplicate_disk.json | 3 +++
.../parse_answer_fail/duplicate_disk.toml | 15 +++
4
cks, relax the documentation regarding this requirement
and instead refer to the defaults used during installation to provide
guidance for users.
[0] https://lore.proxmox.com/pve-devel/d9p1yxb42lgj.ulii1huip...@proxmox.com/
Signed-off-by: Michael Köppl
---
pve-installation.adoc | 4 +++-
1 f
the 2 available addresses to be valid host addresses.
[0] https://datatracker.ietf.org/doc/html/rfc3021
Signed-off-by: Michael Köppl
---
proxmox-auto-installer/tests/parse-answer.rs | 3 +
.../parse_answer/ipv4_and_subnet_31.json | 19 +
.../parse_answer/ipv4_and_subnet_31.toml
Instead of having parts of the RAID setup checks scattered in multiple
places, move the core of the checks to implementations of the
ZfsRaidLevel and BtrfsRaidLevel enums. Additionally, also move the unit
tests accordingly.
Signed-off-by: Michael Köppl
---
proxmox-installer-common/src
Adapt error messages around these checks to follow a similar structure
as in the TUI (: ) instead of displaying them as
warnings, since they actually stop users from continuing anyway.
Signed-off-by: Michael Köppl
---
This is mostly to have both the TUI and GUI display actual errors with
context
pve-docs:
Michael Köppl (1):
installation: remove maxroot size requirement and mention default
instead
pve-installation.adoc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
pve-installer:
Michael Köppl (8):
auto: add early answer file sanity check for RAID configurations
move
Signed-off-by: Michael Köppl
---
proxmox-installer-common/src/utils.rs | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/proxmox-installer-common/src/utils.rs
b/proxmox-installer-common/src/utils.rs
index 8adcec0..1f225c8 100644
--- a/proxmox-installer
Adapt error messages around these checks to follow a similar structure
as in the TUI (: ) instead of displaying them as
warnings, since they actually stop users from continuing anyway.
Signed-off-by: Michael Köppl
---
This is mostly to have both the TUI and GUI display actual errors with
context
Signed-off-by: Michael Köppl
---
proxmox-auto-installer/src/utils.rs | 12 +++-
proxmox-auto-installer/tests/parse-answer.rs | 1 +
.../parse_answer_fail/duplicate_disk.json | 3 +++
.../parse_answer_fail/duplicate_disk.toml | 15 +++
4
Signed-off-by: Michael Köppl
---
proxmox-installer-common/src/utils.rs | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/proxmox-installer-common/src/utils.rs
b/proxmox-installer-common/src/utils.rs
index 8adcec0..1f225c8 100644
--- a/proxmox-installer
the 2 available addresses to be valid host addresses.
[0] https://datatracker.ietf.org/doc/html/rfc3021
Signed-off-by: Michael Köppl
---
proxmox-auto-installer/tests/parse-answer.rs | 3 +
.../parse_answer/ipv4_and_subnet_31.json | 19 +
.../parse_answer/ipv4_and_subnet_31.toml
Instead of having parts of the RAID setup checks scattered in multiple
places, move the core of the checks to implementations of the
ZfsRaidLevel and BtrfsRaidLevel enums. Additionally, also move the unit
tests accordingly.
Signed-off-by: Michael Köppl
---
proxmox-installer-common/src
Check that the configured swapsize is not greater than hdsize / 8 as
stated in the admin guide [0]. Define the behavior for the auto-installer as
well as the TUI and GUI installers.
[0] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#advanced_lvm_options
Signed-off-by: Michael Köppl
1 - 100 of 253 matches
Mail list logo
