--- Begin Message ---
Re Hannes,
I took some time today to test the new implementation, but I believe there are
still some issues with it.
Here's what I did:
1. Create IPAM entry with Nautobot plugin
2. Create a zone of type simple with Nautobot as an IPAM
3. Create a VNet in said zone, with a /
--- Begin Message ---
Re,
Ok, thanks for clarifying. Indeed the offset parameter is ineffective (I have
looked at the Nautobot code this morning). Tbqh I don't really like having to
create then delete an object in Nautobot for this, but I guess there's no other
way, given the limitations we're
--- Begin Message ---
Hannes,
Thank you for helping with getting the Netbox plugin in good shape, it's
appreciated, really :)
I just have two questions regarding the lack of range support in Nautobot:
- Was there an issue with the original workaround code? I find this one way
more complex,
b
--- Begin Message ---
Regarding the Accept header,
>> sub default_headers {
>> my ($plugin_config) = @_;
>> my $token = $plugin_config->{token};
>> return [
>> 'Content-Type' => "application/json", 'Authorization' => "token
$token",
>> 'Accept' => "application/json"
>>
--- Begin Message ---
Hannes,
I appreciate the swift review. I talked with my colleague in Cc and there's no
issue with being co-authors. So let's go forward with your proposition. Thank
you for taking care of it!
Best regards
De : Hannes Dürr
Envoyé : me
--- Begin Message ---
Re,
Ok so. Answering on that.
By default, the status "Active" already exists for fresh installs. However,
since the users are free to define whatever status they want (and delete the
pre-existing ones!), I thought it'd be best if we checked it did exist first.
There could be
--- Begin Message ---
Re Hannes,
You're welcome :)
Sorry for the "from:", my mistake, must've slipped through before sending the
patches (I may have forgot to signoff).
Noted for the Co-developed-by.
Would it be OK for you to edit that in or do I have to resend the patch series?
MfG
__
/wiki/Perl_Style_Guide
On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
> ___
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re Hannes,
No problem. I myself wasn't
--- Begin Message ---
Co-Authored-by: jonatan crystall
Signed-off-by: lou lecrivain
---
www/manager6/Makefile | 1 +
www/manager6/Utils.js | 5 +++
www/manager6/sdn/ipams/NautobotEdit.js | 52 ++
3 files changed, 58 insertions(+)
creat
--- Begin Message ---
From: Lou Lecrivain
Signed-off-by: Lou Lecrivain
Co-Authored-by: Jonatan Crystall
---
pvesdn.adoc | 19 +++
1 file changed, 19 insertions(+)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index 5d5d27b..d4744ab 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -561,
--- Begin Message ---
added error handling in helpers
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 126 ++--
1 file changed, 113 insertions(+), 13 deletions(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams
--- Begin Message ---
add support for subnet allocation without ranges,
where it was previously not supported.
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 68 +
1 file changed, 68 insertions(+)
diff --git a/src/PVE/Network/SDN/Ipams/Nautobo
--- Begin Message ---
this is needed in order to not accidentally use another
subnet or IP which might be in another namespace.
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 40 +
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a
--- Begin Message ---
check that prefix/subnet is empty (only gateway IPs should remain)
before deletion.
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 60 -
1 file changed, 58 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Network/SDN/Ip
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
index f736bad..3d60265 100644
---
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/test/ipams/nautobot/expected.add_ip | 11 +
.../ipams/nautobot/expected.add_ip_notgateway | 11 +
.../ipams/nautobot/expected.add_next_freeip | 11 +
src/test/ipams/nautobot/expected.add_subnet | 11 +
--- Begin Message ---
This is the initial Nautobot plugin, based on the Netbox
plugin implementation.
Signed-off-by: lou lecrivain
---
src/PVE/API2/Network/SDN/Ipams.pm | 1 +
src/PVE/Network/SDN/Ipams.pm| 3 +
src/PVE/Network/SDN/Ipams/Makefile | 2 +-
s
--- Begin Message ---
Re,
Sorry for the previous thread, I got another patch mixed up and I didn't
realized. This one is the correct one.
BR
Lou Lecrivain (7):
ipam: nautobot support initial commit
ipam: nautobot: implement plain prefix allocation
ipam: nautobot: add testing for nautobot
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
index f736bad..3d60265 100644
---
--- Begin Message ---
added error handling in helpers
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 126 ++--
1 file changed, 113 insertions(+), 13 deletions(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Ipams/PVEPlugin.pm
b/src/PVE/Network/SDN/Ipams/PVEPlugin.pm
index 742f1b1..c225655 100644
--- a/src/PVE/Netwo
--- Begin Message ---
This is the initial Nautobot plugin, based on the Netbox
plugin implementation.
Signed-off-by: lou lecrivain
---
src/PVE/API2/Network/SDN/Ipams.pm | 1 +
src/PVE/Network/SDN/Ipams.pm| 3 +
src/PVE/Network/SDN/Ipams/Makefile | 2 +-
s
--- Begin Message ---
this is needed in order to not accidentally use another
subnet or IP which might be in another namespace.
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 40 +
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a
--- Begin Message ---
check that prefix/subnet is empty (only gateway IPs should remain)
before deletion.
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 60 -
1 file changed, 58 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Network/SDN/Ip
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/test/run_test_subnets.pl| 24 +---
src/test/run_test_vnets_blackbox.pl | 6 ++
2 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/src/test/run_test_subnets.pl b/src/test/run_test_subnets.pl
in
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/test/ipams/nautobot/expected.add_ip | 11 +
.../ipams/nautobot/expected.add_ip_notgateway | 11 +
.../ipams/nautobot/expected.add_next_freeip | 11 +
src/test/ipams/nautobot/expected.add_subnet | 11 +
--- Begin Message ---
add support for subnet allocation without ranges,
where it was previously not supported.
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 68 +
1 file changed, 68 insertions(+)
diff --git a/src/PVE/Network/SDN/Ipams/Nautobo
--- Begin Message ---
(configure_range is now noop)
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Dhcp.pm | 3 ++-
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 23 ++-
2 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/src/PVE/Network/SDN/Dhcp.pm b/src/
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Vnets.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/PVE/Network/SDN/Vnets.pm b/src/PVE/Network/SDN/Vnets.pm
index 45292e3..4e795f2 100644
--- a/src/PVE/Network/SDN/Vnets.pm
+++ b/src/PVE/Netw
--- Begin Message ---
Hello all,
Following december's discussions related to the v1 of Nautobot Support
for Proxmox SDN, please find v2 of this patch herein.
I have edited the commit history to be more readable and also made the
requested changes + some improvements since the last time.
Document
--- Begin Message ---
From: Lou Lecrivain
Signed-off-by: lou lecrivain
Tested-by: Stefan Hanreich
Reviewed-by: Stefan Hanreich
---
src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Ipams/PVEPlugin.pm
b/src/PVE/
--- Begin Message ---
From: Lou Lecrivain
Signed-off-by: lou lecrivain
Tested-by: Stefan Hanreich
Reviewed-by: Stefan Hanreich
---
src/test/run_test_subnets.pl| 24 +---
src/test/run_test_vnets_blackbox.pl | 6 ++
2 files changed, 23 insertions(+), 7 deletions
--- Begin Message ---
From: Lou Lecrivain
(configure_range is now noop)
Signed-off-by: lou lecrivain
Tested-by: Stefan Hanreich
Reviewed-by: Stefan Hanreich
---
src/PVE/Network/SDN/Dhcp.pm | 1 -
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 23 ++-
2 files changed, 10 i
--- Begin Message ---
From: Lou Lecrivain
Signed-off-by: lou lecrivain
Tested-by: Stefan Hanreich
Reviewed-by: Stefan Hanreich
---
src/PVE/Network/SDN/Vnets.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/PVE/Network/SDN/Vnets.pm b/src/PVE/Network/SDN/Vnets.pm
ind
--- Begin Message ---
Re,
> but shouldn't theses ranges be added when the dhcp ranges are submitted
> on subnet create/update api call ? (I'm not 100% sure, but I think it
> was missing a hook to call the sdn api when submitting the dhcp ranges)
Yes, I do think this should be the case too.
BR
__
* Apart from the tests, the documentation (pve-docs/pvesdn.adoc) is also
missing.
On 11/27/24 17:17, Lou Lecrivain via pve-devel wrote:
> ___
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Ipams/PVEPlugin.pm
b/src/PVE/Network/SDN/Ipams/PVEPlugin.pm
index 742f1b1..c225655 100644
--- a/src/PVE/Netwo
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/test/run_test_subnets.pl| 24 +---
src/test/run_test_vnets_blackbox.pl | 6 ++
2 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/src/test/run_test_subnets.pl b/src/test/run_test_subnets.pl
in
--- Begin Message ---
Second version of the patch, changes made as seen with Stefan.
this patch series re-enables a previously disabled code path in order to
allow IP allocation directly from a prefix when no DHCP ranges are
configured for a subnet.
MfG
--
Lou Lecrivain
WDZ GmbH
Lou Lecrivain (
--- Begin Message ---
(configure_range is now noop)
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Dhcp.pm | 3 ++-
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 23 ++-
2 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/src/PVE/Network/SDN/Dhcp.pm b/src/
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Vnets.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/PVE/Network/SDN/Vnets.pm b/src/PVE/Network/SDN/Vnets.pm
index 45292e3..4e795f2 100644
--- a/src/PVE/Network/SDN/Vnets.pm
+++ b/src/PVE/Netw
--- Begin Message ---
Re,
Seems like I did not test this enough, whoops.
> Maybe it would make sense to move the whole code of configure_range to
> configure_subnet in the Dnsmasq plugin, since the whole subnet gets
> configured anyway and make configure_range a noop?
Yes, do agree on this one. I
--- Begin Message ---
functions were returning undef despite API calls being successfull,
due to eval blocks return values not being taken into account.
Co-authored-by: Jacob Green
Signed-off-by: Lou Lecrivain
Tested-by: Stefan Hanreich
---
src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 8 ++-
--- Begin Message ---
Re,
Yes, was a typo on my end. Meant to type #5496.
It isn't a hard requirement, more like "there will be no API calls made if the
other fix isn't present".
But, in itself, the patch will not fix the whole issue, since if no API calls
are made we'll still have errors, even
--- Begin Message ---
Hey Stefan,
Thanks for your input. I'll add this in the commit and submit a v2.
BR
De : Stefan Hanreich
Envoyé : jeudi 5 décembre 2024 16:47
À : Proxmox VE development discussion
Cc : Lecrivain, Lou (WDZ) ; jacobgr...@corporatetool
--- Begin Message ---
functions were returning undef despite API calls being successfull,
due to eval blocks return values not being taken into account.
Co-authored-by: jacobgr...@corporatetools.com
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 8 ++--
1 file c
--- Begin Message ---
this patch series re-enables a previously disabled code path in order to
allow IP allocation directly from a prefix when no DHCP ranges
are configured for a subnet.
2nd commit is a workaround for dnsmasq crash when a dhcp lease is
updated via dbus and no dhcp-range is configu
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Dhcp.pm | 6 --
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 5 -
src/PVE/Network/SDN/Dhcp/Plugin.pm | 2 +-
3 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/PVE/Network/SDN/Dhcp.pm b/src/PVE/Ne
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Vnets.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Network/SDN/Vnets.pm b/src/PVE/Network/SDN/Vnets.pm
index 45292e3..30e8fdb 100644
--- a/src/PVE/Network/SDN/Vnets.pm
+++ b/src/PVE/Ne
--- Begin Message ---
+ use default_headers to avoid code repetition
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 45 ++---
1 file changed, 39 insertions(+), 6 deletions(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Netw
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
index ebdc07b..083ab20 100644
--- a/src/PVE/Netwo
--- Begin Message ---
+ bugfix (return from eval was garbage-collected, callers got undef)
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 30 -
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlug
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/API2/Network/SDN/Ipams.pm | 1 +
src/PVE/Network/SDN/Ipams.pm| 3 ++
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 37 +
3 files changed, 41 insertions(+)
create mode 100644 src/PVE/Net
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
index 7efccaf..d923269 100644
--- a/src/PVE/N
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
index e3ba57c..22867df 100644
--- a/src/PVE/Network/SDN
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
index 53190bc..ee0ad49 100644
--- a/src
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 69 -
1 file changed, 66 insertions(+), 3 deletions(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
index ee0ad49..6
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 24 +
1 file changed, 24 insertions(+)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
index e328c9f..69e7897 100644
--
--- Begin Message ---
offset has to be fixed - we can't guarantee correct start
if IPs outside range have been boked
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 25 +
1 file changed, 25 insertions(+)
diff --git a/src/PVE/Network/SDN/Ipams/N
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 45 +
1 file changed, 45 insertions(+)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
index 6597bfe..ebdc07b 100644
--
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
index 083ab20..5
--- Begin Message ---
Nautobot can infer object IDs itself
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
b/src/PVE/Network/SDN/Ipams/Nautobot
--- Begin Message ---
since nautobot lacks support for IP ranges,
this feature could be dropped / marked unsupported
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 26 -
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/src/PVE/Net
--- Begin Message ---
This patch series introduce support for Nautobot as an IPAM.
Please note that:
- Some stuff could still be refined, in my opinion.
I would be happy to receive some comments, as I'm a
Perl beginner.
- Test code has not been written *yet*.
- Nautobot itself has some restric
--- Begin Message ---
+ minimal module
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 22 -
src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 2 +-
2 files changed, 1 insertion(+), 23 deletions(-)
diff --git a/src/PVE/Network/SDN/Ipams/NautobotPl
--- Begin Message ---
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Ipams/Makefile
b/src/PVE/Network/SDN/Ipams/Makefile
index 4e7d65f..75e5b9a 100644
--- a/src/PVE/Network/SDN/Ipams/Make
--- Begin Message ---
Hello Stefan,
Thank you very much for your answer and for the details, it's appreciated. We
have already signed the CLA, Proxmox should have received it.
> So a good starting point could be extending the Netbox plugin and overriding
> the methods that have changed.
I'll t
--- Begin Message ---
Dear PVE-Devel list members,
We (WDZ GmbH) would like to extend SDN feature by adding support for Nautobot
IPAM. Nautobot is a fork of Netbox from NetworkToCode
https://networktocode.com/nautobot/ that is used by some of our customers.
Implementation should only differ sli
68 matches
Mail list logo
