[pve-devel] [PATCH v5 manager 1/5] ui: move upload window into UploadToStorage.js

2021-11-08 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/storage/ContentView.js| 195 + www/manager6/window/UploadToStorage.js | 192 3 files

[pve-devel] [PATCH v5 manager 3/5] fix #3505: ui/UploadToStorage: add checksum and algorithm

2021-11-08 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- www/manager6/window/UploadToStorage.js | 40 ++ 1 file changed, 40 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js

[pve-devel] [PATCH v5 manager 4/5] ui/UploadToStorage: add TaskViewer

2021-11-08 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- www/manager6/window/UploadToStorage.js | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window

[pve-devel] [PATCH v5 manager 0/5] fix #3505: add checksum and algorithm to iso upload

2021-11-08 Thread Lorenz Stechauner
call to cleanup_reqchange() is now updated Lorenz Stechauner (5): ui: move upload window into UploadToStorage.js ui: refactor UploadToStorage.js fix #3505: ui/UploadToStorage: add checksum and algorithm ui/UploadToStorage: add TaskViewer ui/UplaodToStorage: check file extension

[pve-devel] [PATCH v5 manager 2/5] ui: refactor UploadToStorage.js

2021-11-08 Thread Lorenz Stechauner
ubmit() is also not necessary. Signed-off-by: Lorenz Stechauner Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- www/manager6/storage/ContentView.js| 2 +- www/manager6/window/UploadToStorage.js | 346 ++--- 2 files changed, 196 insertions(+), 152 deletions(-)

[pve-devel] [PATCH v5 manager 5/5] ui/UplaodToStorage: check file extension

2021-11-08 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- www/manager6/window/UploadToStorage.js | 5 + 1 file changed, 5 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index e79092f2..4cfd40fd

[pve-devel] [PATCH v3 storage 2/2] storage/plugin: factoring out regex for backup extension re

2021-10-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/Storage.pm| 12 +++- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 4e1b1f7..5688dd7 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -108,6 +108,8

[pve-devel] [PATCH v3 manager 1/1] api: aplinfo: rename REs for iso and vztmpl extensions

2021-10-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/APLInfo.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/APLInfo.pm b/PVE/APLInfo.pm index 5cee1af8..1eff7107 100644 --- a/PVE/APLInfo.pm +++ b/PVE/APLInfo.pm @@ -84,7 +84,7 @@ sub read_aplinfo_from_fh { my $template

[pve-devel] [PATCH-SERIES v3 storage/manager] factoring out RE for backup extension

2021-10-22 Thread Lorenz Stechauner
changes to v2: * rebased to current master * kept old $vztmpl_extension_re to not break pve-manager and added # FIXME [...] changes to v1: * also renamed iso/vztmpl REs * new naming schema: $_EXT_RE_<# of capture groups> for example: $BACKUP_EXT_RE_2 pve-storage Lorenz Stechau

[pve-devel] [PATCH v3 storage 1/2] storage: rename REs for iso and vztmpl extensions

2021-10-22 Thread Lorenz Stechauner
these changes make it more clear, how many capture groups each RE inclues. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 8 PVE/Storage.pm | 14 ++ PVE/Storage/Plugin.pm | 8 3 files changed, 18 insertions(+), 12 deletions

Re: [pve-devel] [PATCH v3 storage 1/2] fix #3633: pvesm: use print_api_result

2021-10-21 Thread Lorenz Stechauner
On 21.10.21 14:49, Lorenz Stechauner wrote: Signed-off-by: Lorenz Stechauner --- changes to v2: * ordering rows for pvesm {status|list} PVE/CLI/pvesm.pm | 158 +-- 1 file changed, 30 insertions(+), 128 deletions(-) diff --git a/PVE/CLI

[pve-devel] [PATCH v3 storage 2/2] pvesm: using $API instead of PVE::API2::Storage

2021-10-21 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/CLI/pvesm.pm | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 94847cd..78fc51b 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -523,43 +523,45 @@ my

[pve-devel] [PATCH v3 storage 1/2] fix #3633: pvesm: use print_api_result

2021-10-21 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/CLI/pvesm.pm | 158 +-- 1 file changed, 30 insertions(+), 128 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 190de91..94847cd 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -178,68

Re: [pve-devel] [PATCH manager v3 0/7] multi disk/mp in wizard

2021-10-19 Thread Lorenz Stechauner
Hi, everything looks and works as expected. No disk/mount point window looks broken. Tested VM/CT creation wizard and adding of disks/mount points afterwards. Tested-By: Lorenz Stechauner On 05.10.21 13:28, Dominik Csapak wrote: this series is a continuation of my previous multi tab

[pve-devel] [PATCH v4 manager 2/2] fix 3850: ui: storage: using PreallocationSelector for file based storage types

2021-10-12 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner Reviewed-by: Fabian Ebner Tested-by: Fabian Ebner --- www/manager6/controller/StorageEdit.js | 6 ++ www/manager6/storage/Base.js | 20 www/manager6/storage/NFSEdit.js| 2 +- 3 files changed, 27 insertions(+), 1

[pve-devel] [PATCH v4 storage 1/1] fix #3580: plugins: make preallocation mode selectable for qcow2 and raw images

2021-10-12 Thread Lorenz Stechauner
alt value was chosen to be * qcow2: metadata (as previously) * raw: off when using 'metadata' as preallocation mode, for raw images 'off' is used. [0] https://qemu.readthedocs.io/en/latest/system/images.html#disk-image-file-formats Signed-off-by: Lorenz Stechauner Reviewed-b

[pve-devel] [PATCH v4 manager 1/2] ui: add PreallocationSelector

2021-10-12 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner Reviewed-by: Fabian Ebner Tested-by: Fabian Ebner --- www/manager6/Makefile | 1 + www/manager6/form/PreallocationSelector.js | 11 +++ 2 files changed, 12 insertions(+) create mode 100644 www/manager6/form

[pve-devel] [PATCH-SERIES v4 storage/manager] fix #3580: make preallocation mode selectable for qcow2 and raw images

2021-10-12 Thread Lorenz Stechauner
allocation api description * moved sub preallocation_cmd_option above `# Storage implementation` * updated PreallocationSelector to work with `default` * reworked placement of Prealloc.Selector in Base.js pve-storage: Lorenz Stechauner (1): fix #3580: plugins: make preallocation mode selectable

[pve-devel] [PATCH v3 storage 1/1] fix #3580: plugins: make preallocation mode selectable for qcow2 and raw images

2021-10-11 Thread Lorenz Stechauner
alt value was chosen to be * qcow2: metadata (as previously) * raw: off when using 'metadata' as preallocation mode, for raw images 'off' is used. [0] https://qemu.readthedocs.io/en/latest/system/images.html#disk-image-file-formats Signed-off-by: Lorenz Stechauner --- PV

[pve-devel] [PATCH v3 manager 1/2] ui: add PreallocationSelector

2021-10-11 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/form/PreallocationSelector.js | 11 +++ 2 files changed, 12 insertions(+) create mode 100644 www/manager6/form/PreallocationSelector.js diff --git a/www/manager6/Makefile b/www/manager6

[pve-devel] [PATCH-SERIES v3 storage/manager] fix #3580: make preallocation mode selectable for qcow2 and raw images

2021-10-11 Thread Lorenz Stechauner
PreallocationSelector to work with `default` * reworked placement of Prealloc.Selector in Base.js pve-storage: Lorenz Stechauner (1): fix #3580: plugins: make preallocation mode selectable for qcow2 and raw images PVE/Storage/BTRFSPlugin.pm | 1 + PVE/Storage/CIFSPlugin.pm | 1 + PVE

[pve-devel] [PATCH v3 manager 2/2] fix 3850: ui: storage: using PreallocationSelector for file based storage types

2021-10-11 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/controller/StorageEdit.js | 6 ++ www/manager6/storage/Base.js | 20 www/manager6/storage/NFSEdit.js| 2 +- 3 files changed, 27 insertions(+), 1 deletion(-) diff --git a/www/manager6/controller

[pve-devel] [PATCH v2 manager] ui: storage/PBSEdit: add port to server field

2021-10-11 Thread Lorenz Stechauner
this gives users the chance to supply the port nr in the gui, without having to add a extra new field to the panel. using the same implementation as in RemoteEdit.js in PBS. Signed-off-by: Lorenz Stechauner --- www/manager6/storage/PBSEdit.js | 58 ++--- 1 file

[pve-devel] [PATCH manager] ui: storage/PBSEdit: add port field

2021-10-07 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/storage/PBSEdit.js | 7 +++ 1 file changed, 7 insertions(+) diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js index fcbc9548..0d7b8033 100644 --- a/www/manager6/storage/PBSEdit.js +++ b/www/manager6/storage

[pve-devel] [PATCH v2 storage 1/1] fix #3580: plugins: make preallocation mode selectable for qcow2 and raw images

2021-09-28 Thread Lorenz Stechauner
used. [0] https://qemu.readthedocs.io/en/latest/system/images.html#disk-image-file-formats Signed-off-by: Lorenz Stechauner --- PVE/Storage/BTRFSPlugin.pm | 1 + PVE/Storage/CIFSPlugin.pm | 1 + PVE/Storage/DirPlugin.pm | 1 + PVE/Storage/GlusterfsPlugin.pm | 4 ++- PVE/Storag

[pve-devel] [PATCH v2 manager 1/2] ui: add PreallocationSelector

2021-09-28 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/form/PreallocationSelector.js | 11 +++ 2 files changed, 12 insertions(+) create mode 100644 www/manager6/form/PreallocationSelector.js diff --git a/www/manager6/Makefile b/www/manager6

[pve-devel] [PATCH-SERIES v2 storage/manager] fix #3580: make preallocation mode selectable for qcow2 and raw images

2021-09-28 Thread Lorenz Stechauner
changes to v1: * adjusted preallocation api description * moved sub preallocation_cmd_option above `# Storage implementation` * updated PreallocationSelector to work with `default` * reworked placement of Prealloc.Selector in Base.js pve-storage Lorenz Stechauner (1): fix #3580: plugins: make

[pve-devel] [PATCH v2 manager 2/2] fix 3850: ui: storage: using PreallocationSelector for file based storage types

2021-09-28 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/controller/StorageEdit.js | 6 ++ www/manager6/storage/Base.js | 18 ++ www/manager6/storage/NFSEdit.js| 2 +- 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/www/manager6/controller

[pve-devel] [PATCH i18n] update Maximal Workers -> Maximum Workers

2021-09-28 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- ar.po| 2 +- ca.po| 2 +- da.po| 2 +- de.po| 2 +- es.po| 2 +- eu.po| 2 +- fa.po| 2 +- fr.po| 2 +- gl.po| 2 +- he.po| 2 +- hu.po| 2 +- it.po| 2 +- ja.po| 2 +- kr.po| 2 +- nb.po| 2

[pve-devel] [PATCH manager] ui: dc/OptionView: maximal -> maximum

2021-09-28 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/dc/OptionView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js index edae97ea..a8f1ea6a 100644 --- a/www/manager6/dc/OptionView.js +++ b/www/manager6/dc

[pve-devel] [PATCH v2 storage 2/2] pvesm: using $API instead of PVE::API2::Storage

2021-09-27 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/CLI/pvesm.pm | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 6c0a1b2..28be91c 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -511,43 +511,45 @@ my

[pve-devel] [PATCH v2 storage 1/2] fix #3633: pvesm: use print_api_result

2021-09-27 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/CLI/pvesm.pm | 146 ++- 1 file changed, 18 insertions(+), 128 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 190de91..6c0a1b2 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -178,68

[pve-devel] [PATCH storage 2/2] fix #3633: pvesm: use print_api_results

2021-09-27 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/CLI/pvesm.pm | 144 ++- 1 file changed, 18 insertions(+), 126 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 7afbe22..7bb363c 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -178,68

[pve-devel] [PATCH storage 1/2] pvesm: reformat cmd definitions

2021-09-27 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/CLI/pvesm.pm | 343 ++- 1 file changed, 223 insertions(+), 120 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 190de91..7afbe22 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm

Re: [pve-devel] [PATCH manager 00/10] multi tab disk panel & multi disk wizard

2021-09-21 Thread Lorenz Stechauner
Hi, tested this series a bit. everything seems to work as advertised, except the VM creation wizard. After submitting I get an error: Parameter verification failed. (400) textfield-4006-inputEl: property is not defined in schema and the schema does not allow additional properties other smal

Re: [pve-devel] [PATCH pve-docs 2/2] pmxcfs: add more config files and discuss symlinks

2021-09-14 Thread Lorenz Stechauner
also looks good, one comment inline On 13.09.21 18:00, Dylan Whyte wrote: adds an entry for some config files found in /etc/pve, which were missing. alphabetize the list, for better readability and add some minor fixes also adds an introduction section to the symbolic links section, to clarify t

Re: [pve-devel] [PATCH pve-docs 1/2] pmxcfs: language and style fixup

2021-09-14 Thread Lorenz Stechauner
patch looks good to me in general. see inline for notes On 13.09.21 18:00, Dylan Whyte wrote: minor language fixup replace usage of 'Proxmox VE' with '{pve}' Signed-off-by: Dylan Whyte --- pmxcfs.adoc | 62 ++--- 1 file changed, 30 insertions

Re: [pve-devel] [PATCH storage 1/1] fix #3580: plugins: make preallocation mode selectable for qcow2 and raw images

2021-09-09 Thread Lorenz Stechauner
On 09.09.21 14:04, Fabian Ebner wrote: Am 09.09.21 um 13:11 schrieb Lorenz Stechauner: On 09.09.21 12:25, Fabian Ebner wrote: Am 08.09.21 um 10:11 schrieb alexandre derumier: Hi, it can be done too with ceph rbd with "rbd create ... –thick-provision" Hi, there also is t

Re: [pve-devel] [PATCH storage 1/1] fix #3580: plugins: make preallocation mode selectable for qcow2 and raw images

2021-09-09 Thread Lorenz Stechauner
prealloc=metadata sounds good. Le lundi 06 septembre 2021 à 15:15 +0200, Lorenz Stechauner a écrit : the plugins for file based storages   * BTRFS   * CIFS   * Dir   * Glusterfs   * NFS now allow the option 'preallocation'. 'preallocation' can have four values:   * defaul

[pve-devel] [PATCH storage 1/1] fix #3580: plugins: make preallocation mode selectable for qcow2 and raw images

2021-09-06 Thread Lorenz Stechauner
used. [0] https://qemu.readthedocs.io/en/latest/system/images.html#disk-image-file-formats Signed-off-by: Lorenz Stechauner --- PVE/Storage/BTRFSPlugin.pm | 1 + PVE/Storage/CIFSPlugin.pm | 1 + PVE/Storage/DirPlugin.pm | 1 + PVE/Storage/GlusterfsPlugin.pm | 4 ++- PVE/Storag

[pve-devel] [PATCH manager 2/2] fix 3850: ui: storage: using PreallocationSelector for file based storage types

2021-09-06 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/controller/StorageEdit.js | 6 ++ www/manager6/storage/Base.js | 18 ++ 2 files changed, 24 insertions(+) diff --git a/www/manager6/controller/StorageEdit.js b/www/manager6/controller/StorageEdit.js index 4246d363

[pve-devel] [PATCH manager 1/2] ui: add PreallocationSelector

2021-09-06 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/form/PreallocationSelector.js | 14 ++ 2 files changed, 15 insertions(+) create mode 100644 www/manager6/form/PreallocationSelector.js diff --git a/www/manager6/Makefile b/www

[pve-devel] [PATCH-SERIES storage/manager] fix #3580: make preallocation mode selectable for qcow2 and raw images

2021-09-06 Thread Lorenz Stechauner
this series allows users to configure the `qemu-img` preallocation mode per storage. this only applies to file-based storages and the file types 'qcow2' and 'raw'. pve-storage: Lorenz Stechauner (1): fix #3580: plugins: make preallocation mode selectable for qcow2 and

[pve-devel] [PATCH v4 manager 1/5] ui: move upload window into UploadToStorage.js

2021-08-31 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/storage/ContentView.js| 195 + www/manager6/window/UploadToStorage.js | 192 3 files changed, 194 insertions(+), 194 deletions(-) create mode

[pve-devel] [PATCH v4 manager 2/5] ui: refactor UploadToStorage.js

2021-08-31 Thread Lorenz Stechauner
ubmit() is also not necessary. Signed-off-by: Lorenz Stechauner --- www/manager6/storage/ContentView.js| 2 +- www/manager6/window/UploadToStorage.js | 346 ++--- 2 files changed, 196 insertions(+), 152 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/ww

[pve-devel] [PATCH v4 storage 3/4] fix #3505: status: add checksum and algorithm to file upload

2021-08-31 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 37 + 1 file changed, 37 insertions(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index 6493d22..41b3696 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage

[pve-devel] [PATCH v4 manager 3/5] fix #3505: ui/UploadToStorage: add checksum and algorithm

2021-08-31 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 40 ++ 1 file changed, 40 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index e7db41fb..489be9dc 100644 --- a/www/manager6/window

[pve-devel] [PATCH v4 manager 5/5] ui/UplaodToStorage: check file extension

2021-08-31 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 5 + 1 file changed, 5 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index f0c6186f..ec83c581 100644 --- a/www/manager6/window/UploadToStorage.js +++ b

[pve-devel] [PATCH v4 manager 4/5] ui/UploadToStorage: add TaskViewer

2021-08-31 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index 489be9dc..f0c6186f 100644 --- a/www/manager6

[pve-devel] [PATCH-SERIES v4 http-server/storage/manager] fix #3505: add checksum and algorithm to iso upload

2021-08-31 Thread Lorenz Stechauner
changes to v3: * added comment regarding tmpfile cleanup * added commit fixing the cleanup of tmpfile * fixed commit in http-server; every call to cleanup_reqchange() is now updated Lorenz Stechauner (1): anyevent: move unlink from http-server to endpoint src/PVE/APIServer/AnyEvent.pm

[pve-devel] [PATCH v4 storage 1/4] status: move unlink from http-server to enpoint

2021-08-31 Thread Lorenz Stechauner
this is the first step in which not the http server removes the temporary file, but the worker itself. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index b838461

[pve-devel] [PATCH v4 http-server 1/1] anyevent: move unlink from http-server to endpoint

2021-08-31 Thread Lorenz Stechauner
ete. this change breaks all pve-manager versions, in which the worker does not unlink the temp file itself. Signed-off-by: Lorenz Stechauner --- src/PVE/APIServer/AnyEvent.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE

[pve-devel] [PATCH v4 storage 2/4] status: remove sleep(1) in file upload

2021-08-31 Thread Lorenz Stechauner
h the tmpfile gets not automatically removed anymore. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index cc8ed5a..6493d22 100644 --- a/PVE/API2/St

[pve-devel] [PATCH v4 storage 4/4] status: fix tmpfile cleanup

2021-08-31 Thread Lorenz Stechauner
$tmpfilename already gets unlinked after executing the cmd. furthermore, because this is a local file, it is wrong to delete it via the ssh command on a remote node. small change: added \n to the error message. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 4 ++-- 1 file

Re: [pve-devel] [PATCH v3 storage 1/3] status: move unlink from http-server to enpoint

2021-08-30 Thread Lorenz Stechauner
On 26.08.21 18:30, Thomas Lamprecht wrote: On 03/08/2021 14:16, Lorenz Stechauner wrote: this is the first step in which not the http server removes the temporary file, but the worker itself. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 1 + 1 file changed, 1

Re: [pve-devel] [PATCH v2 storage 1/2] storage: rename REs for iso and vztmpl extensions

2021-08-16 Thread Lorenz Stechauner
On 13.08.21 12:09, Fabian Ebner wrote: Am 05.08.21 um 09:34 schrieb Lorenz Stechauner: these changes make it more clear, how many capture groups each RE inclues. Signed-off-by: Lorenz Stechauner ---   PVE/API2/Storage/Status.pm |  8   PVE/Storage.pm | 11

[pve-devel] [PATCH common] fix #2368: network: extend infiniband recognition in regex

2021-08-06 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- src/PVE/Network.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index bb574e0..c6d3ee1 100644 --- a/src/PVE/Network.pm +++ b/src/PVE/Network.pm @@ -16,7 +16,7 @@ use Socket qw(NI_NUMERICHOST

[pve-devel] [PATCH firewall] fix #2721: remove reject tcp 43 from default drop and reject actions

2021-08-05 Thread Lorenz Stechauner
pecifically this one port. [0] https://gitlab.com/shorewall/code/-/blob/4.6.13/Shorewall/action.Drop#L66 https://gitlab.com/shorewall/code/-/blob/4.6.13/Shorewall/Macros/macro.Auth Signed-off-by: Lorenz Stechauner --- src/PVE/Firewall.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/s

[pve-devel] [PATCH v2 manager 1/1] api: aplinfo: rename REs for iso and vztmpl extensions

2021-08-05 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/APLInfo.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/APLInfo.pm b/PVE/APLInfo.pm index 5cee1af8..1eff7107 100644 --- a/PVE/APLInfo.pm +++ b/PVE/APLInfo.pm @@ -84,7 +84,7 @@ sub read_aplinfo_from_fh { my $template

[pve-devel] [PATCH v2 storage 2/2] storage/plugin: factoring out regex for backup extension re

2021-08-05 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/Storage.pm| 12 +++- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index b5c2460..9bc799d 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -108,6 +108,8

[pve-devel] [PATCH v2 storage 1/2] storage: rename REs for iso and vztmpl extensions

2021-08-05 Thread Lorenz Stechauner
these changes make it more clear, how many capture groups each RE inclues. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 8 PVE/Storage.pm | 11 +++ PVE/Storage/Plugin.pm | 8 3 files changed, 15 insertions(+), 12 deletions

[pve-devel] [PATCH-SERIES v2 storage/manager] factoring out RE for backup extension

2021-08-05 Thread Lorenz Stechauner
changes to v1: * also renamed iso/vztmpl REs * new naming schema: $_EXT_RE_<# of capture groups> for example: $BACKUP_EXT_RE_2 pve-storage: Lorenz Stechauner (2): storage: rename REs for iso and vztmpl extensions storage/plugin: factoring out regex for backup extension re PV

Re: [pve-devel] [PATCH v2 storage] storage/plugin: factoring out regex for backup extension rey

2021-08-04 Thread Lorenz Stechauner
On 03.08.21 09:15, Wolfgang Bumiller wrote: On Mon, Aug 02, 2021 at 12:52:36PM +0200, Lorenz Stechauner wrote: Signed-off-by: Lorenz Stechauner --- changes to v1: * factored $compressor_extension_re out of $backup_extension_re should now be less confusing not sure about less confusing

[pve-devel] [PATCH v3 manager 2/5] ui: refactor UploadToStorage.js

2021-08-03 Thread Lorenz Stechauner
ubmit() is also not necessary. Signed-off-by: Lorenz Stechauner --- www/manager6/storage/ContentView.js| 2 +- www/manager6/window/UploadToStorage.js | 346 ++--- 2 files changed, 196 insertions(+), 152 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/ww

[pve-devel] [PATCH v3 manager 1/5] ui: move upload window into UploadToStorage.js

2021-08-03 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/storage/ContentView.js| 195 + www/manager6/window/UploadToStorage.js | 192 3 files changed, 194 insertions(+), 194 deletions(-) create mode

[pve-devel] [PATCH v3 manager 3/5] fix #3505: ui/UploadToStorage: add checksum and algorithm

2021-08-03 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 40 ++ 1 file changed, 40 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index e7db41fb..489be9dc 100644 --- a/www/manager6/window

[pve-devel] [PATCH v3 storage 1/3] status: move unlink from http-server to enpoint

2021-08-03 Thread Lorenz Stechauner
this is the first step in which not the http server removes the temporary file, but the worker itself. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index b838461

[pve-devel] [PATCH v3 http-server 1/1] anyevent: move unlink from http-server to endpoint

2021-08-03 Thread Lorenz Stechauner
ete. this change breaks all pve-manager versions, in which the worker does not unlink the temp file itself. Signed-off-by: Lorenz Stechauner --- src/PVE/APIServer/AnyEvent.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE

[pve-devel] [PATCH-SERIES v3 http-server/storage/manager] fix #3505: add checksum and algorithm to iso upload

2021-08-03 Thread Lorenz Stechauner
ange function note: two commits in total state that they break/require some versions of other repos. please do not forget to bump those and create the accoring 'breaks' or 'requires'. pve-http-server: Lorenz Stechauner (1): anyevent: move unlink from http-server to endp

[pve-devel] [PATCH v3 manager 5/5] ui/UplaodToStorage: check file extension

2021-08-03 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 5 + 1 file changed, 5 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index f0c6186f..ec83c581 100644 --- a/www/manager6/window/UploadToStorage.js +++ b

[pve-devel] [PATCH v3 storage 3/3] fix #3505: status: add checksum and algorithm to file upload

2021-08-03 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 34 ++ 1 file changed, 34 insertions(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index db5a76e..07366cc 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage

[pve-devel] [PATCH v3 manager 4/5] ui/UploadToStorage: add TaskViewer

2021-08-03 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index 489be9dc..f0c6186f 100644 --- a/www/manager6

[pve-devel] [PATCH v3 storage 2/3] status: remove sleep(1) in file upload

2021-08-03 Thread Lorenz Stechauner
h the tmpfile gets not automatically removed anymore. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index a5ac372..db5a76e 100644 --- a/PVE/API2/St

[pve-devel] [PATCH v2 storage] storage/plugin: factoring out regex for backup extension re

2021-08-02 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- changes to v1: * factored $compressor_extension_re out of $backup_extension_re should now be less confusing PVE/Storage.pm| 14 +- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/PVE

[pve-devel] [PATCH v2 manager 2/5] ui: refactor UploadToStorage.js

2021-07-22 Thread Lorenz Stechauner
ubmit() is also not necessary. Signed-off-by: Lorenz Stechauner --- www/manager6/storage/ContentView.js| 2 +- www/manager6/window/UploadToStorage.js | 360 ++--- 2 files changed, 209 insertions(+), 153 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/ww

[pve-devel] [PATCH v2 manager 3/5] ui/UploadToStorage: add checksum and algorithm

2021-07-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 32 ++ 1 file changed, 32 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index fb9850b3..0b4d991a 100644 --- a/www/manager6/window

[pve-devel] [PATCH v2 manager 5/5] ui/UplaodToStorage: check file extension

2021-07-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 17 + 1 file changed, 17 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index c63de16a..3f4596ce 100644 --- a/www/manager6/window

[pve-devel] [PATCH v2 storage 1/1] status: add checksum and algorithm to file upload

2021-07-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 34 ++ 1 file changed, 34 insertions(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index 9cf6e40..4b9fda5 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage

[pve-devel] [PATCH v2 http-server 1/1] anyevent: move unlink from http-server to endpoint

2021-07-22 Thread Lorenz Stechauner
ete. this change breaks all pve-manager versions, in which the worker does not unlink the temp file itself. Signed-off-by: Lorenz Stechauner --- src/PVE/APIServer/AnyEvent.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE

[pve-devel] [PATCH-SERIES v2 http-server/storage/manager] add checksum and algorithm to iso upload

2021-07-22 Thread Lorenz Stechauner
eleting temp file on errors) * check file extention in front end too note: two commits in total state, that they break/require some versions of other repos. please do not forget to bump those and create the accoring 'breaks' or 'requires'. pve-http-server: Lorenz Stechaune

[pve-devel] [PATCH v2 manager 1/5] ui: move upload window into UploadToStorage.js

2021-07-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/storage/ContentView.js| 195 + www/manager6/window/UploadToStorage.js | 192 3 files changed, 194 insertions(+), 194 deletions(-) create mode

[pve-devel] [PATCH v2 storage 2/3] status: remove sleep(1) in file upload

2021-07-22 Thread Lorenz Stechauner
h the tmpfile gets not automatically removed anymore. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index fcf9720..9cf6e40 100644 --- a/PVE/API2/St

[pve-devel] [PATCH v2 manager 4/5] ui/UploadToStorage: add TaskViewer

2021-07-22 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index 0b4d991a..c63de16a 100644 --- a/www/manager6

[pve-devel] [PATCH v2 storage 1/3] status: move unlink from http-server to enpoint

2021-07-22 Thread Lorenz Stechauner
this is the first step in which not the http server removes the temporary file, but the worker itself. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index 16581aa

[pve-devel] [PATCH v2 container] fix #3478: abort container creation on arch detection timeout

2021-07-22 Thread Lorenz Stechauner
-by: Lorenz Stechauner --- changes to v1: * implemented feedback * do not remove `\n` in error message src/PVE/LXC/Create.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index 82d7ad9..e8233b6 100644 --- a/src/PVE/LXC

Re: [pve-devel] [PATCH container] fix #3478: abort container creation on arch detection timeout

2021-07-22 Thread Lorenz Stechauner
ping On 29.06.21 15:53, Lorenz Stechauner wrote: increased the timeout for detect_arch from 5 to 10 seconds. until now, on any error detect_architecture would fall back to amd64. to avoid falling back due to an timeout error this function now dies on timeout errors. additionally minor changes

Re: [pve-devel] [PATCH manager] fix #3426: ui: parser: adapt parseSSHKey to accept "@..." suffix

2021-07-22 Thread Lorenz Stechauner
ping On 07.06.21 12:44, Lorenz Stechauner wrote: also rearranged the regex groups to allow sk-ecdsa-sha2-... note: FIDO keys are now parsable, the backend only supports it with OpenSSH >= 8.2. This may be achieved with upgrading to PVE 7 or using a back port. --- www/manager6/Parser.js

Re: [pve-devel] [PATCH storage] storage/plugin: factoring out regex for backup extension re

2021-07-22 Thread Lorenz Stechauner
ping On 28.06.21 10:37, Lorenz Stechauner wrote: Signed-off-by: Lorenz Stechauner --- PVE/Storage.pm| 12 +++- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index b8e6311..ec29b45 100755 --- a

Re: [pve-devel] [PATCH v2 storage] api: status: fix unlink on file upload

2021-07-22 Thread Lorenz Stechauner
ping On 25.06.21 09:22, Lorenz Stechauner wrote: after an error while copying the file to its destination the local path of the destination was unlinked in every case, even when on the destination was copied to via scp. Signed-off-by: Lorenz Stechauner --- changes to v1: * using 'u

[pve-devel] [PATCH storage] status: add max length and disclaimer to file upload's filename

2021-07-21 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index d16636b..1f44574 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage/Status.pm @@ -381,7

[pve-devel] [PATCH storage] status: add enum for file upload content type

2021-07-21 Thread Lorenz Stechauner
the addition of this enum does not change API behaviour, because it is checked for 'iso' or 'vztmpl' aftwerwards anyway. Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/AP

[pve-devel] [PATCH storage] status: add unlink to worker in file upload

2021-07-21 Thread Lorenz Stechauner
ff-by: Lorenz Stechauner --- a version bump would be helpful, so the older versions can be marked as 'breaks' in the pve-http-server repo after the above mentioned changes. PVE/API2/Storage/Status.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Storage/Status.pm b/P

[pve-devel] [PATCH manager 2/5] ui: move upload window into UploadToStorage.js

2021-07-20 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/Makefile | 1 + www/manager6/storage/ContentView.js| 195 + www/manager6/window/UploadToStorage.js | 192 3 files changed, 194 insertions(+), 194 deletions(-) create mode

[pve-devel] [PATCH manager 3/5] ui: refactor UploadToStorage.js

2021-07-20 Thread Lorenz Stechauner
this also removes the "content" selector from the window. as far as it seems, this selector was never able to select more than one entry, so it was useless. Signed-off-by: Lorenz Stechauner --- www/manager6/storage/ContentView.js| 2 +- www/manager6/window/UploadToStorag

[pve-devel] [PATCH manager 5/5] ui/UploadToStorage.js: add TaskViewer

2021-07-20 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index ca89692e..6a01821f 100644 --- a/www/manager6

[pve-devel] [PATCH storage 3/3] status: add checksum and algorithm to file upload

2021-07-20 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 34 ++ 1 file changed, 34 insertions(+) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index eac5e13..e3bf758 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage

[pve-devel] [PATCH storage 2/3] status: add new-filename to upload

2021-07-20 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index b549d7d..eac5e13 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage/Status.pm

[pve-devel] [PATCH http-server] anyevent: move unlink from http-server to endpoint

2021-07-20 Thread Lorenz Stechauner
e. Signed-off-by: Lorenz Stechauner --- src/PVE/APIServer/AnyEvent.pm | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm index cd77806..8d498c5 100644 --- a/src/PVE/APIServer/AnyEvent.pm +++ b/src/PVE/APIServer/A

[pve-devel] [PATCH storage 1/3] status: move unlink from http-server to endpoint

2021-07-20 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- PVE/API2/Storage/Status.pm | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index 72fd851..b549d7d 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage/Status.pm

[pve-devel] [PATCH manager 4/5] ui/UploadToStorage.js: add checksum and algorithm

2021-07-20 Thread Lorenz Stechauner
Signed-off-by: Lorenz Stechauner --- www/manager6/window/UploadToStorage.js | 42 ++ 1 file changed, 42 insertions(+) diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js index 75423b0f..ca89692e 100644 --- a/www/manager6/window

  1   2   3   >