mapped.
- Hosts
The list of hostnames for the IP.
- Value
The raw line value as it is stored in /etc/hosts.
Entries can be added/edited/removed, and their 'Enabeld' status can be
toggled via the 'Toggle' button.
Signed-off-by: Leo Nunner
---
src/Makefile
nt to change the paths of the API endpoints, since
/cluster/hosts could be a bit confusing.
proxmox-widget-toolkit:
Leo Nunner (1):
introduce abstractions for /etc/hosts view
src/Makefile| 1 +
src/node/HostsView.js | 329
src/
.
Currently, this is always located at the bottom of the file, but this
may be configurable in the future (e.g. by making it configurable,
whether the cluster-wide entries should be an 'override' or a
'fallback').
Signed-off-by: Leo Nunner
---
PVE/API2/Cluster.pm | 6 ++
PVE/A
button, which starts a task to sync the hosts config to each
node in the cluster.
Signed-off-by: Leo Nunner
---
www/manager6/Makefile | 1 +
www/manager6/dc/Config.js | 6 +
www/manager6/dc/Hosts.js | 257 ++
3 files changed, 264 insertions(+)
create mo
Signed-off-by: Leo Nunner
---
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index cfa2583..919215d 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -57,6 +57,7 @@ my $observed
dd supports a 'status' flag, which enables it to show the copied bytes,
duration, and the transfer rate, which then get printed to stderr.
Signed-off-by: Leo Nunner
---
Changes since v2:
- Refactor to new repo structure
- Implement style changes suggested for v2
src/PVE/
Thanks for the review!
On 2023-08-30 10:22, Fiona Ebner wrote:
> Sorry about the late review!
>
> Am 16.11.22 um 12:02 schrieb Leo Nunner:
>> --- a/PVE/Storage.pm
>> +++ b/PVE/Storage.pm
> Needs a rebase, because files got moved to src/
>
>> @@ -821,
the forum:
*
https://forum.proxmox.com/threads/pve-8-pve-firewall-status-no-such-alias.130202/
*
https://forum.proxmox.com/threads/ipset-not-working-for-accepting-cluster-traffic.129599/
Signed-off-by: Leo Nunner
---
src/PVE/API2/Firewall/IPSet.pm | 2 --
src/PVE/Firewall.pm
adds a call to /nodes/{node}/lxc/{vmid}/interfaces and merges the
returned data with the existing configuration. This will update the
IPv4 and IPv6 address, as well as the interface name (in case the
container changed it).
Signed-off-by: Leo Nunner
---
www/manager6/lxc/Network.js | 57
modelled after the QEMU Guest Agent UI. We only show the first
non-loopback IP on the summary page itself.
Signed-off-by: Leo Nunner
---
www/manager6/Makefile | 1 +
www/manager6/lxc/ContainerIPView.js | 194 ++
www/manager6/panel/GuestStatusView.js
s simply return an empty list.
Signed-off-by: Leo Nunner
---
src/PVE/API2/LXC.pm | 50 +
src/PVE/LXC.pm | 26 +++
2 files changed, 76 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 28d14de..8839105 1
Changes since v1:
- fix some style nits
- add a new component to show IPs in the LXC summary page
container:
Leo Nunner (1):
api: network: get interfaces from containers
src/PVE/API2/LXC.pm | 50 +
src/PVE/LXC.pm | 26
in the cluster class, we save the cluster config into the 'fw_conf'
variable, and not into 'cluster_conf', which in turns is set to 'undef'
instead.
Signed-off-by: Leo Nunner
---
src/PVE/API2/Firewall/IPSet.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/
Introduce a new 'scope' field in the return values for the /ref
endpoints. Also add the 'ref' field in the VM endpoint, since it has
been missing up until now.
Signed-off-by: Leo Nunner
---
src/PVE/API2/Firewall/Cluster.pm | 34 +++
src/PVE/API2/Fire
lue') automatically.
pve-firewall:
Leo Nunner (2):
api: fix scoping for ipset endpoint
fix #4556: api: return scoped IPSets and aliases
src/PVE/API2/Firewall/Cluster.pm | 34 +++
src/PVE/API2/Firewall/IPSet.pm | 2 ++
src/PVE/API2/Firewall/VM.pm | 46 +++
and send the scoped value to the firewall when choosing new values.
This happens for both IPSets and aliases.
Signed-off-by: Leo Nunner
---
www/manager6/form/IPRefSelector.js | 35 +++---
1 file changed, 32 insertions(+), 3 deletions(-)
diff --git a/www/manager6/form
…this is v4 of this patch, forgot to put it in the subject prefix, sorry.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Add a separate tab for the storage edit/create panels to set the
recently introduced "content-dirs" property which overrides the
default directory locations. Analogous to the API implementation,
the tab was added for Directory, CIFS and NFS storages.
Signed-off-by: Leo Nunner
---
Cha
give an overview over vtypes and also document the option for
cephfs.
Signed-off-by: Leo Nunner
---
pve-storage-cephfs.adoc | 4
pve-storage-dir.adoc| 20
2 files changed, 24 insertions(+)
diff --git a/pve-storage-cephfs.adoc b/pve-storage-cephfs.adoc
index
looks at the
VM level and then at the Datacenter level.
Signed-off-by: Leo Nunner
---
src/PVE/API2/Firewall/IPSet.pm | 9 --
src/PVE/Firewall.pm| 58 +++---
2 files changed, 46 insertions(+), 21 deletions(-)
diff --git a/src/PVE/API2/Firewall
This will break compatibility with older systems, since the
scoped values cannot be parsed.
firewall:
Leo Nunner (3):
fix #4556: introduce 'dc' and 'vm' prefix for IPSets
fix #4556: introduce 'dc' and 'vm' prefix for aliases
fix #4556: api: return scop
Introduce a new 'scope' field in the return values for the /ref
endpoints. Also add the 'ref' field in the VM endpoint, since it has
been missing up until now.
Signed-off-by: Leo Nunner
---
src/PVE/API2/Firewall/Cluster.pm | 34 +++
src/PVE/API2/Fire
and send the scoped value to the firewall when choosing new values.
This happens for both IPSets and aliases.
Signed-off-by: Leo Nunner
---
www/manager6/form/IPRefSelector.js | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/www/manager6/form/IPRefSelector.js
Uses the previous method of scoping, where it first looks at the
VM level and then at the Datacenter level.
Signed-off-by: Leo Nunner
---
src/PVE/Firewall.pm | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
adds documentation for Cloud-Init for containers. Most of it has been
taken from the VM documentation, since the configuration mostly works
the same. Added a script to extract the cloudinit parameters the same
way it's already done for VMs.
Signed-off-by: Leo Nunner
---
Mak
configuring the network through
cloud-init, since it will clash with whatever configuration we already
did for the container.
Signed-off-by: Leo Nunner
---
src/PVE/API2/LXC.pm| 3 ++
src/PVE/API2/LXC/Config.pm | 7 -
src/PVE/LXC/Config.pm | 61
…the same way as it's already being done for VMs.
Signed-off-by: Leo Nunner
---
gen-pct-cloud-init-opts.pl | 16
1 file changed, 16 insertions(+)
create mode 100755 gen-pct-cloud-init-opts.pl
diff --git a/gen-pct-cloud-init-opts.pl b/gen-pct-cloud-init-opts.pl
new file
Introduce a 'pct cloudinit dump ' command to dump the
generated cloudinit configuration for a section.
Signed-off-by: Leo Nunner
---
src/PVE/API2/LXC.pm | 33 +
src/PVE/CLI/pct.pm | 4
src/PVE/LXC/Cloudinit.pm | 11 +++
3 fil
Adds a cloudinit_config_properties function which dumps the config
parameters from the cloudinit config description. This is called
automatically when generating the docs.
Signed-off-by: Leo Nunner
---
src/PVE/LXC/Config.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/PVE/LXC
Signed-off-by: Leo Nunner
---
www/manager6/qemu/CloudInit.js | 4 ++--
www/manager6/qemu/Config.js| 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/qemu/CloudInit.js b/www/manager6/qemu/CloudInit.js
index 77ff93d41..14117ff6b 100644
--- a/www/manager6/qemu
based on the already existing panel for VMs. Some things have been
changed, there is no network configuration, and a separate "enable"
options toggles cloud-init (simillar to adding/removing a cloud-init
drive for VMs).
Signed-off-by: Leo Nunner
---
www/manager6/Makefile |
tom scripts need to be located inside the snippets directory, and
overwrite the default generated configuration file.
Signed-off-by: Leo Nunner
---
src/PVE/LXC.pm| 1 +
src/PVE/LXC/Cloudinit.pm | 114 ++
src/PVE/LXC/Makefile | 1 +
src/lx
This series introduces basic cloudinit support for containers. All in
all, it works quite similar to VMs, with the caveat that we only allow
network configuration through the alrady existing systems, and not via
cloud-init.
pve-container:
Leo Nunner (4):
cloudinit: introduce config parameters
mapped.
- Hosts
The list of hostnames for the IP.
- Value
The raw line value as it is stored in /etc/hosts.
Entries can be added/edited/removed, and their 'Enabeld' status can be
toggled via the 'Toggle' button.
Signed-off-by: Leo Nunner
---
src/Makefile
'ip' and
'hosts' values). (5) will delete the specified line, and takes a 'move'
parameter which controlls whether the line should simply be replaced
with an empty line, or if it should be deleted (which causes all
proceeding l
This series introduces several endpoints for editing /etc/hosts via the
API. In accordance, the GUI has been adapted to move away from a simple
textarea towards a more complex interface. Details about the endpoints
can be found in the corresponding commit messages.
pve-manager:
Leo Nunner (1
owing entry:
127.0.1.1
Which doesn't seem to cause any issues.
Tested on:
- Ubuntu 23.04
- CentOS 8
- Fedora 38
- Debian 11
- SUSE 15.4
Signed-off-by: Leo Nunner
---
PVE/QemuServer/Cloudinit.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer/Cl
configuring the network through
cloud-init, since it will clash with whatever configuration we already
did for the container.
Signed-off-by: Leo Nunner
---
src/PVE/API2/LXC.pm| 3 ++
src/PVE/API2/LXC/Config.pm | 7 -
src/PVE/LXC/Config.pm | 61
based on the already existing panel for VMs. Some things have been
changed, there is no network configuration, and a separate "enable"
options toggles cloud-init (simillar to adding/removing a cloud-init
drive for VMs).
Signed-off-by: Leo Nunner
---
www/manager6/Makefile |
Introduce a 'pct cloudinit dump ' command to dump the
generated cloudinit configuration for a section.
Signed-off-by: Leo Nunner
---
src/PVE/API2/LXC.pm | 33 +
src/PVE/CLI/pct.pm | 4
src/PVE/LXC/Cloudinit.pm | 11 +++
3 fil
tom scripts need to be located inside the snippets directory, and
overwrite the default generated configuration file.
Signed-off-by: Leo Nunner
---
src/PVE/LXC.pm| 1 +
src/PVE/LXC/Cloudinit.pm | 114 ++
src/PVE/LXC/Makefile | 1 +
src/lx
state and I'd like some feedback on how I currently handle things. Are
there any other parameters/features that are needed here? Is the current
mechanism for providing the configuration to the container optimal, or
is there a better way?
container:
Leo Nunner (3):
cloudinit: introduce c
Signed-off-by: Leo Nunner
---
www/manager6/qemu/CloudInit.js | 4 ++--
www/manager6/qemu/Config.js| 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/qemu/CloudInit.js b/www/manager6/qemu/CloudInit.js
index 77ff93d4..14117ff6 100644
--- a/www/manager6/qemu
to the endpoint being broken when used through 'qm' and
'pvesh'. Using the API works fine, because the format doesn't get
verified there. Reverting this change brings the advantage that we can
also use PVE::GuestHelpers::format_pending when calling the endpoint
through qm ag
viour.
[1]
https://forum.proxmox.com/threads/how-to-prevent-automatic-apt-upgrade-during-the-first-boot-with-cloud-init.68472/
[2] https://forum.proxmox.com/threads/cloud-init-ohne-package-upgrade.123841/
Signed-off-by: Leo Nunner
---
PVE/QemuServer.pm | 5 +
PVE/QemuServer/Cloudi
to control the newly introduced "ciupgrade" config parameter.
Signed-off-by: Leo Nunner
---
www/manager6/qemu/CloudInit.js | 18 ++
1 file changed, 18 insertions(+)
diff --git a/www/manager6/qemu/CloudInit.js b/www/manager6/qemu/CloudInit.js
index 77ff93d4..c9065
Until now, we explicitly enabled "package_upgrade" in our generated
cloud-init configuration. This has been requested to be changed several
times, and it seems like making it toggleable will be the best choice.
qemu-server:
Leo Nunner (1):
fix #3428: cloudinit: add parameter for
s simply return an empty list.
Signed-off-by: Leo Nunner
---
src/PVE/API2/LXC.pm | 50 +
src/PVE/LXC.pm | 26 +++
2 files changed, 76 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 50c9eaf..078d506 1
This patch adds an endpoint to the LXC API to read the current
interface configuration (with current name, ipv(4|6), mac) from
inside a running container. The GUI fetches this data, merges it with
the existing configuration and then displays it.
pve-container:
Leo Nunner (1):
api: network: get
adds a call to /nodes/{node}/lxc/{vmid}/interfaces and merges the
returned data with the existing configuration. This will update the
IPv4 and IPv6 address, as well as the interface name (in case the
container changed it).
Signed-off-by: Leo Nunner
---
RFC: I *hope* that the MAC can serve as the
Add a separate tab for the storage edit/create panels to set the
recently introduced "content-dirs" property which overrides the
default directory locations. Analogous to the API implementation,
the tab was added for Directory, CIFS and NFS storages.
Signed-off-by: Leo Nunner
---
Cha
Thanks for the review!
On 2023-03-15 15:05, Wolfgang Bumiller wrote:
> On Wed, Mar 01, 2023 at 10:12:26AM +0100, Leo Nunner wrote:
>> Implements support for passing values to the fw_cfg argument for QEMU.
>> If the value looks like a file, the backend checks for the correct
>
Signed-off-by: Leo Nunner
---
PVE/Storage/CephFSPlugin.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/Storage/CephFSPlugin.pm b/PVE/Storage/CephFSPlugin.pm
index 944f0b8..79106cc 100644
--- a/PVE/Storage/CephFSPlugin.pm
+++ b/PVE/Storage/CephFSPlugin.pm
@@ -137,6 +137,7 @@ sub
Add a separate tab for the storage edit/create panels to set the
recently introduced "content-dirs" property which overrides the
default directory locations. Analogous to the API implementation,
the tab was added for Directory, CIFS and NFS storages.
Signed-off-by: Leo Nunner
---
ww
Changes from v1:
- make it clear that all paths are relative to the mountpoint by
removing the requirement to have a preceeding / for paths.
storage:
Leo Nunner (1):
config: use relative paths for content overrides
PVE/Storage/Plugin.pm | 6 +++---
test/get_subdir_test.pm | 4
Remove the requirement for paths to start with a /, as it might be
confusing to users.
Signed-off-by: Leo Nunner
---
RFC: I'm not really sure how much input validation we want to do here.
e.g., should we keep the user from appending or prepending slashes (e.g.
setting the override as /dir/
Signed-off-by: Leo Nunner
---
pve-storage-dir.adoc | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/pve-storage-dir.adoc b/pve-storage-dir.adoc
index 4eb8dcd..3367394 100644
--- a/pve-storage-dir.adoc
+++ b/pve-storage-dir.adoc
@@ -57,8 +57,7 @@ in the following format
The hardcoded filename check for cluster file access needs to include
'vzdump.conf', since vzdump now always tries to read that file when
parsing configurations.
Signed-off-by: Leo Nunner
---
test/vzdump_new_test.pl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --
Changes from v1:
- Remove automatic generation of cluster config from setup
- Fix vzdump regression tests
- Reword docs to be more straightforward
cluster:
Leo Nunner (1):
fix #4234: vzdump: add cluster-wide configuration
data/PVE/Cluster.pm | 1 +
data/src/status.c | 1 +
2
+ change the wording from "Global configuration" to "Node-wide
configuration"
Signed-off-by: Leo Nunner
---
vzdump.adoc | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/vzdump.adoc b/vzdump.adoc
index ce46529..6c2023d 100644
--- a/vzdump.ad
The different config files get merged in the following order:
/etc/vzdump.conf <- /etc/pve/vzdump.conf <- default values
So the local configuration takes the highest precedence, then the
cluster-wide config, and finally the default values.
Signed-off-by: Leo Nunner
---
PVE/VZDump.p
Introduce a cluster-wide vzdump.conf file which gets filled with the
default vzdump configuration.
Signed-off-by: Leo Nunner
---
data/PVE/Cluster.pm | 1 +
data/src/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
index 0154aae..efca58f
Changes from v1:
- rename property from "cuser" to "creation-user"
- introduce the meta property for containers too
container:
Leo Nunner (2):
cleanup: json config: factor out ignored properties into hash
feature #3937: config: introduce meta property
src/PV
Signed-off-by: Leo Nunner
---
src/PVE/LXC/Config.pm | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index af25a96..aca72ae 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -1182,8 +1182,13 @@ sub check_type
Introduces a 'meta' property like the one already existing for VMs.
Currently, it holds the creation time (ctime), the LXC version at the
time of creation, and the user who created the container (cuser).
Signed-off-by: Leo Nunner
---
src/PVE/API2/LXC.pm | 2 ++
src/PVE/LXC/Conf
Adds a field to the "meta" config property which stores the user who
created the VM.
Signed-off-by: Leo Nunner
---
PVE/QemuServer.pm | 8
1 file changed, 8 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 40be44d..0a7a6b0 100644
--- a/PVE/QemuServer.pm
Signed-off-by: Leo Nunner
---
test/cfg2cmd/fw_cfg-files.conf | 15 ++
test/cfg2cmd/fw_cfg-files.conf.cmd | 30
test/cfg2cmd/fw_cfg-strings.conf | 15 ++
test/cfg2cmd/fw_cfg-strings.conf.cmd | 30
4
Signed-off-by: Leo Nunner
---
qm.adoc | 18 ++
1 file changed, 18 insertions(+)
diff --git a/qm.adoc b/qm.adoc
index bd535a2..0c587ad 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -1139,6 +1139,24 @@ http://localhost:9843 in a browser in the guest.
It can help to restart the SPICE
the
guest. Including files requires Datastore.Audit and Datastore.Allocate
on the specific storage.
Signed-off-by: Leo Nunner
---
RFC: I feel like a more implicit option for passing files would be
nicer, but I can't really think of a nice way…
PVE/API2/Qemu.pm | 14 ++
ample application for this parameter is for provisioning CoreOS
systems [1].
Files are currently passed through if the user specifies the value as
"storage:snippets/file", there is no implicit file flag.
[1] https://coreos.github.io/ignition/
qemu-server:
Leo Nunner (2):
fix #4068: im
Introduces a new UI element to set/edit/delete any number of fw_cfg
arguments in a table-like manner.
Signed-off-by: Leo Nunner
---
www/manager6/Makefile| 1 +
www/manager6/qemu/FirmwareCfgEdit.js | 224 +++
www/manager6/qemu/Options.js | 6
On 2023-02-14 10:41, Thomas Lamprecht wrote:
> On 13/02/2023 11:24, Leo Nunner wrote:
>> Adds a field to the "meta" config property which stores the user who
>> created the VM.
> Should also get this finally added to CTs, I know it's a bit unfair to
> add
Adds a field to the "meta" config property which stores the user who
created the VM.
Signed-off-by: Leo Nunner
---
PVE/QemuServer.pm | 8
1 file changed, 8 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index a0e16dc..28ed8e7 100644
--- a/PVE/QemuServer.pm
+ change the wording from "Global configuration" to "Node-wide
configuration"
Signed-off-by: Leo Nunner
---
The wording was previously already changed by Fiona but hasn't been
merged yet:
https://lists.proxmox.com/pipermail/pve-devel/2022-December/055123.html
vzdump.
/etc/pve/vzdump.conf <- default values
so the local configuration takes the highest priority.
manager:
Leo Nunner (1):
fix #4235: vzdump: add cluster-wide configuration
PVE/VZDump.pm | 50 --
1 file changed, 36 insertions(+), 14 deletions(-)
cl
The different config files get merged in the following order:
/etc/vzdump.conf <- /etc/pve/vzdump.conf <- default values
So the local configuration takes the highest precedence, then the
cluster-wide config, and finally the default values.
Signed-off-by: Leo Nunner
---
RFC: I'm not
Introduce a cluster-wide vzdump.conf file which gets filled with the
default vzdump configuration.
Signed-off-by: Leo Nunner
---
data/PVE/Cluster.pm | 1 +
data/PVE/Cluster/Setup.pm | 32 +---
data/src/status.c | 1 +
3 files changed, 31 insertions
Signed-off-by: Leo Nunner
---
pve-storage-cifs.adoc | 5 +
1 file changed, 5 insertions(+)
diff --git a/pve-storage-cifs.adoc b/pve-storage-cifs.adoc
index e0d4106..df63b58 100644
--- a/pve-storage-cifs.adoc
+++ b/pve-storage-cifs.adoc
@@ -61,6 +61,10 @@ content-dirs::
Overrides for the
makes it possible to optionally set the 'subdir' parameter when adding a
new CIFS storage.
Signed-off-by: Leo Nunner
---
Changes from v1:
- use gettext for the Subdirectory label
www/manager6/storage/CIFSEdit.js | 11 +++
1 file changed, 11 insertions(+)
diff --git a/ww
Changes from v1:
- Rebase docs so that it applies again
- Use gettext instead of a plain string in the manager patch
manager:
Leo Nunner (1):
fix #2641: expose CIFS subdir parameter through GUI
www/manager6/storage/CIFSEdit.js | 11 +++
1 file changed, 11 insertions(+)
docs
On 2022-12-01 12:32, Leo Nunner wrote:
> CIFS supports mounting subdirectories inside a share, so it makes sense
> to also have the 'subdir' parameter for the CIFS backend. I'm also
> looking into allowing overrides for all the fixed directories, but
> even then, I thin
Add a separate tab for the storage edit/create panels to set the
recently introduced "content-dirs" property which overrides the
default directory locations. Analogous to the API implementation,
the tab was added for Directory, CIFS and NFS storages.
Signed-off-by: Leo Nunner
---
RFC:
This patch fixes the issue that when the user supplied any non-standard
repositories, the changelogs often wouldn't load. For example, providing
both pve-no-subscription and pbs-no-subscription broke the changelog
API, since the URL built for pbs-no-subscription was invalid.
Signed-off-by
On 2023-01-28 14:56, Thomas Lamprecht wrote:
> Am 27/01/2023 um 11:41 schrieb Fabian Grünbichler:
>> a few improvements possible here:
>> - it should be enough that one of the components matches (e.g., I could have
>> pvetest and pve-no-subscription configured in a single entry)
>> - this should on
On 2023-01-27 12:41, Wolfgang Bumiller wrote:
> On Thu, Jan 26, 2023 at 03:30:19PM +0100, Leo Nunner wrote:
>> This patch restructures the parsed config structure a bit to be more
>> consistent across objects.
>>
>> group_comments and ipset_comments were removed from
is locked, passed to the function and then
written.
Signed-off-by: Leo Nunner
---
src/PVE/API2/Firewall/Aliases.pm | 52 +++---
src/PVE/API2/Firewall/Groups.pm | 54 ++--
src/PVE/API2/Firewall/IPSet.pm | 47 +--
src
one. Rebased accordingly.
Note that this patch depends on _all_ the patches in [1], so also
the optional one. In case that isn't needed, I'll rebase this
patch.
[1] https://lists.proxmox.com/pipermail/pve-devel/2023-January/055596.html
firewall:
Leo Nunner (2):
allo
Signed-off-by: Leo Nunner
---
src/PVE/API2/Firewall/Aliases.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/Firewall/Aliases.pm b/src/PVE/API2/Firewall/Aliases.pm
index 9f8e71e..c84c348 100644
--- a/src/PVE/API2/Firewall/Aliases.pm
+++ b/src/PVE/API2
Signed-off-by: Leo Nunner
---
www/manager6/grid/FirewallAliases.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/grid/FirewallAliases.js
b/www/manager6/grid/FirewallAliases.js
index 00d0d74b..a1409d93 100644
--- a/www/manager6/grid/FirewallAliases.js
+++ b/www/manager6/grid
=> {
comment => <...>,
[entries|rules] => { <...> },
}
We don't need to store separate instances of the original + the
lower-case name for aliases anymore, so the structure was changed to
=> {
comment => <...>,
cidr => <...>,
i
Signed-off-by: Leo Nunner
---
src/PVE/API2/Firewall/Aliases.pm | 20 ++--
src/PVE/API2/Firewall/Groups.pm | 53
src/PVE/API2/Firewall/IPSet.pm | 39 ---
3 files changed, 56 insertions(+), 56 deletions(-)
diff --git a/src/PVE/API2
legacy handling for the aliases here, since rules/… will
contain the lower-case name for them, while the definition itself has the
original name. As such, internally, the names still get lower-cased while
resolving aliases; this has no effect on the user.
Signed-off-by: Leo Nunner
---
src/PVE/API2
Signed-off-by: Leo Nunner
---
src/PVE/API2/Firewall/Aliases.pm | 2 +-
src/PVE/API2/Firewall/Groups.pm | 2 +-
src/PVE/API2/Firewall/IPSet.pm | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PVE/API2/Firewall/Aliases.pm b/src/PVE/API2/Firewall/Aliases.pm
index
structure.
firewall:
Leo Nunner (4):
api: factor out renaming parameters to more descriptive names
docs: clarify usage of 'rename' parameters
config: make groups, IPSets and aliases case-insensitive
config: combine group/ipset and their comments
src/PVE/API2/Firewall/Aliase
This patch fixes the issue that when the user supplied any non-standard
repositories, the changelogs often wouldn't load. For example, providing
both pve-no-subscription and pbs-no-subscription broke the changelog
API, since the URL built for pbs-no-subscription was invalid.
Signed-off-by
they are relative to the mountpoint of
the storage.
Signed-off-by: Leo Nunner
---
PVE/Storage/CIFSPlugin.pm | 2 +-
PVE/Storage/DirPlugin.pm | 2 +-
PVE/Storage/NFSPlugin.pm | 2 +-
PVE/Storage/Plugin.pm | 18 +-
test/get_subdir_test.pm | 4 ++--
5 files changed, 1
The "dirs" parameter was renamed to "content-dirs" for clarity.
Changed the separator for overrides to '=' instead of ':' (so,
"vtype=/dir"), and remove a misleading error message talking about
absolute paths; rationale in commit message
Chagne the name of the "dirs" parameter to "content-dirs" and be less
misleading with "absolute paths".
Signed-off-by: Leo Nunner
---
pve-storage-cifs.adoc | 2 +-
pve-storage-dir.adoc | 13 +++--
pve-storage-nfs.adoc | 2 +-
3 files changed, 9 inser
ectory, CIFS and NFS
backends.
Signed-off-by: Leo Nunner
---
PVE/Storage/CIFSPlugin.pm | 1 +
PVE/Storage/DirPlugin.pm | 1 +
PVE/Storage/NFSPlugin.pm | 1 +
PVE/Storage/Plugin.pm | 49 +++
test/get_subdir_test.pm | 7 ++
5 files changed, 55 insert
Signed-off-by: Leo Nunner
---
pve-storage-cifs.adoc | 4
pve-storage-dir.adoc | 19 ++-
pve-storage-nfs.adoc | 4
3 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/pve-storage-cifs.adoc b/pve-storage-cifs.adoc
index bb4b902..4d93727 100644
--- a/pve
1 - 100 of 134 matches
Mail list logo
