Re: [pve-devel] [PATCH many v3 00/34] Expand and migrate RRD data and add/change summary graphs

2025-07-23 Thread Laurențiu Leahu-Vlăducu
I tested this patch series on a fully up-to-date Proxmox VE 8.4.5 cluster of 3 nodes which I then updated to 9.0 BETA. I tested: - Having both patched and unpatched nodes - Migrating VMs from patched nodes to unpatched nodes. - Having only patched nodes. My test results and remarks: 1. The upd

Re: [pve-devel] [PATCH proxmox-offline-mirror] Add possibility to create named snapshots

2025-05-08 Thread Laurențiu Leahu-Vlăducu
Thanks for your feedback! Some answers inline. On 08.05.25 11:14, Fabian Grünbichler wrote: On May 6, 2025 11:09 am, Laurențiu Leahu-Vlăducu wrote: In addition to the existing timed snapshots, it is now possible to create named snapshots. For some use cases, it makes sense to give snapshots a

[pve-devel] [PATCH proxmox-offline-mirror] Add possibility to create named snapshots

2025-05-06 Thread Laurențiu Leahu-Vlăducu
purpose (for example, further testing). Partially fixes #6252 Signed-off-by: Laurențiu Leahu-Vlăducu --- src/bin/proxmox-offline-mirror-helper.rs | 6 +- src/bin/proxmox_offline_mirror_cmds/mirror.rs | 32 --- src/medium.rs | 4 +- src/mirror.rs

Re: [pve-devel] [PATCH manager v14 10/12] ui: add resource mapping view for directories

2025-04-05 Thread Laurențiu Leahu-Vlăducu
Some comments inline Otherwise, please consider: Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu On 04.03.25 12:58, Markus Frank wrote: Signed-off-by: Markus Frank --- v14: * return HTML encoded comment www/manager6/Makefile | 1 + www/manager6/dc

Re: [pve-devel] [PATCH manager v14 12/12] ui: add options to add virtio-fs to qemu config

2025-04-04 Thread Laurențiu Leahu-Vlăducu
Some comments inline Otherwise, please consider: Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu On 04.03.25 12:58, Markus Frank wrote: Signed-off-by: Markus Frank --- v14: * disable expose-xattr when expose-acl is set * added missing writeback cache option www

Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v14 0/12] virtiofs

2025-04-02 Thread Laurențiu Leahu-Vlăducu
-by: Laurențiu Leahu-Vlăducu Reviewed-by: Laurențiu Leahu-Vlăducu On 04.03.25 12:57, Markus Frank wrote: Virtio-fs is a shared file system that enables sharing a directory between host and guest VMs. It takes advantage of the locality of virtual machines and the hypervisor to get a higher

Re: [pve-devel] [PATCH docs v14 3/12] add doc section for the shared filesystem virtio-fs

2025-04-02 Thread Laurențiu Leahu-Vlăducu
virtualization software also allow automatically mounting such things, so I think it makes sense to at least explain how to do it, even if we don't do it by default. Some further comments inline Otherwise, please consider: Reviewed-by: Laurențiu Leahu-Vlăducu On 04.03.25 12:57, Markus

Re: [pve-devel] [PATCH pve_flutter_frontend] Fix #6231: Removed whitespace-trimming from password entry field

2025-03-13 Thread Laurențiu Leahu-Vlăducu
repository instead. Other than that, please consider: Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu On 11.03.25 12:52, Alexander Abraham wrote: A user reported a bug where they were attempting to login into our app for PVE and they used a password with two spaces at the end

[pve-devel] Strategy for Active Directory and OpenID Connect groups and usernames with spaces and other special characters

2025-03-05 Thread Laurențiu Leahu-Vlăducu
Hello everyone, I would need some feedback on a feature that was requested multiple times by different users over the years. Specifically, many people have complained that synchronizing Active Directory groups to PVE partially/mostly fails due to many groups containing spaces by default: http

[pve-devel] [RFC PATCH pve-storage/common] fix #3256: allow special characters in storage-related config files

2025-02-14 Thread Laurențiu Leahu-Vlăducu
nals with its UTF-16 encoding. pve-common: Laurențiu Leahu-Vlăducu (2): fix #3256: SectionConfig: ensure UTF-8 encoding for general configs SectionConfig: add unit test for UTF-8 configs src/PVE/SectionConfig.pm| 10 +++--- test/section_config_test.pl | 25 +

[pve-devel] [RFC PATCH pve-storage 1/1] fix #3256: Storage: PBS: ensure passwords are saved and loaded as UTF-8

2025-02-14 Thread Laurențiu Leahu-Vlăducu
://perldoc.perl.org/perlunifaq#When-should-I-decode-or-encode? Signed-off-by: Laurențiu Leahu-Vlăducu --- src/PVE/Storage/PBSPlugin.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm index 0808bcc..6d89440 100644 --- a/src/PVE

[pve-devel] [RFC PATCH pve-common 1/2] fix #3256: SectionConfig: ensure UTF-8 encoding for general configs

2025-02-14 Thread Laurențiu Leahu-Vlăducu
expect bytes instead of UTF-8. Also, config files are now explicitly encoded as UTF-8 when writing the config, preventing issues the other way around. For more information, please read: https://perldoc.perl.org/perlunifaq#When-should-I-decode-or-encode? Signed-off-by: Laurențiu Leahu-Vlăducu

[pve-devel] [RFC PATCH pve-common 2/2] SectionConfig: add unit test for UTF-8 configs

2025-02-14 Thread Laurențiu Leahu-Vlăducu
The unit test should prevent the issues explained in bug #3256 from happening in the future. Signed-off-by: Laurențiu Leahu-Vlăducu --- test/section_config_test.pl | 25 + 1 file changed, 25 insertions(+) diff --git a/test/section_config_test.pl b/test