[pve-devel] [PATCH qemu-server v3] fix #3588: helper: consider NIC count for config-specific timeout

2024-11-26 Thread Hannes Laimer
chosen. Signed-off-by: Hannes Laimer --- changes since v3: * move scalar() to wrap grep... * match against `\d+` instead of `\d{1,2}` PVE/QemuServer/Helpers.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm index 15e2496c

Re: [pve-devel] [PATCH qemu-server v2] fix #3588: helper: consider NIC count for config-specific timeout

2024-11-26 Thread Hannes Laimer
On 11/25/24 16:15, Fiona Ebner wrote: Am 21.11.24 um 16:13 schrieb Hannes Laimer: diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm index 0afb6317..1888487e 100644 --- a/PVE/QemuServer/Helpers.pm +++ b/PVE/QemuServer/Helpers.pm @@ -167,6 +167,15 @@ sub config_aware_timeout

Re: [pve-devel] [PATCH qemu-server] fix #3588: helper: consider NIC count for config-specific timeout

2024-11-21 Thread Hannes Laimer
sent a v2 [1] [1] https://lore.proxmox.com/pve-devel/20241121151335.130711-1-h.lai...@proxmox.com/T/#u On 11/15/24 11:00, Hannes Laimer wrote: There have been some reports about `qm start` timeouts on VMs that have a lot of NICs assigned. This patch considers the number of NICs when

[pve-devel] [PATCH qemu-server v2] fix #3588: helper: consider NIC count for config-specific timeout

2024-11-21 Thread Hannes Laimer
chosen. Signed-off-by: Hannes Laimer --- v2: thanks @Fiona * fix typo * mention user reports in comment * use scalar * match for `^net\d{1,2}`, not just `^net` PVE/QemuServer/Helpers.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer

[pve-devel] [PATCH proxmox-firewall] firewall: apply `nt_conntrack_allow_invalid` option to guest table

2024-11-15 Thread Hannes Laimer
So it behaves the same way the 'old' firewall did. Since currently ct state invalid are always dropped on the guest table, regardless of the option. The host behaviour is not changed as it would require `forward` to match the 'old' behaviour. Signed-off-by: Hannes Laime

[pve-devel] [PATCH] firewall: resources: accept invalid ct state by default

2024-11-15 Thread Hannes Laimer
them when checking for the option and keeping them blocked by default. I chose to change the 'default' as it has the same result but is simpler a change. Signed-off-by: Hannes Laimer --- relevant code[1] ``` if self.config.host().block_invalid_conntrack() { log::d

[pve-devel] [PATCH qemu-server] fix #3588: helper: consider NIC count for config-specific timeout

2024-11-15 Thread Hannes Laimer
chosen. Signed-off-by: Hannes Laimer --- PVE/QemuServer/Helpers.pm | 8 1 file changed, 8 insertions(+) diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm index 0afb6317..99cb3ab8 100644 --- a/PVE/QemuServer/Helpers.pm +++ b/PVE/QemuServer/Helpers.pm @@ -167,6 +167,14

Re: [pve-devel] [PATCH storage 1/2] fix #3873: btrfs: check for correct subvolume taking snapshot

2024-08-20 Thread Hannes Laimer
Tested these two patches on PVE 8 and they work as advertised, fixing the problem described in [1]. So, consider this Tested-by: Hannes Laimer code also looks good, but I don't think R-b is warranted here. [1] https://bugzilla.proxmox.com/show_bug.cgi?id

[pve-devel] [PATCH pve-manager] node: use configured proxy for https when downloading files

2024-03-08 Thread Hannes Laimer
... for both the downloading itself and the 'Query URL' part Signed-off-by: Hannes Laimer --- PVE/API2/Nodes.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index cc5ee65e..b35e042d 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm

[pve-devel] [PATCH pve-cluster] docs: update http_proxy option description

2024-02-28 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/PVE/DataCenterConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm index c80872c..1f1291c 100644 --- a/src/PVE/DataCenterConfig.pm +++ b/src/PVE/DataCenterConfig.pm @@ -343,7

[pve-devel] [PATCH proxmox-acme/pve-cluster 0/2] Add support to use a http proxy for acme dns challenges

2024-02-28 Thread Hannes Laimer
tdiff;h=4ed79f7b4cd3e77ec9764f6233ce83098ace60d9;hp=e1088f616ffc73a96ee3433f0ea07639ef7513e7 - proxmox-acme Hannes Laimer (1): dns-challenge: use configured datacenter http_proxy for acme dns challenges src/PVE/ACME/DNSChallenge.pm | 4 1 file changed, 4 insertions(+) - pve-cluster H

[pve-devel] [PATCH proxmox-acme 1/1] dns-challenge: use configured datacenter http_proxy for acme dns challenges

2024-02-28 Thread Hannes Laimer
the proxy is added to the plugin config so the `proxmox-acme` script exports it and it'll be used by curl when requests are made. Based on e1088f616ffc73a96ee3433f0ea07639ef7513e7 (reverted). Signed-off-by: Hannes Laimer --- src/PVE/ACME/DNSChallenge.pm | 4 1 file changed, 4 inser

[pve-devel] [PATCH v2 pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

2024-02-23 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- came up in enterprise support, and I don't think there is a reason to not have it in the UI, while having it in the API v2: - use Aaron's improved help text www/manager6/storage/DirEdit.js | 12 1 file changed, 12 insertions(+) diff -

Re: [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

2024-02-23 Thread Hannes Laimer
On Fri Feb 23, 2024 at 12:51 PM CET, Aaron Lauterer wrote: > Overall good idea :) > > On 2/23/24 12:45, Hannes Laimer wrote: > > Signed-off-by: Hannes Laimer > > --- > > > > came up in enterprise support, and I don't think there is a reason to > > n

[pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

2024-02-23 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- came up in enterprise support, and I don't think there is a reason to not have it in the UI, while having it in the API www/manager6/storage/DirEdit.js | 12 1 file changed, 12 insertions(+) diff --git a/www/manager6/storage/DirEdit.js

[pve-devel] [PATCH v2 pve-manager 2/2] ui: add bulk suspend support

2023-11-13 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- www/manager6/Utils.js | 1 + www/manager6/node/CmdMenu.js | 15 +++ www/manager6/node/Config.js | 14 ++ www/manager6/window/BulkAction.js | 5 +++-- 4 files changed, 33 insertions(+), 2 deletions(-) diff --git a

[pve-devel] [PATCH v2 pve-manager 0/2] add bulk suspend

2023-11-13 Thread Hannes Laimer
Adds support for bulk suspending VMs as it already exists for stop. v2, thanks @Thomas: * api: skip CTs + fix permission checks * ui: disable `suspendall` button if user isn;t allowed to use it * ui: use new bulk action filtering Hannes Laimer (2): api: add suspendall endpoint ui: add bulk

[pve-devel] [PATCH v2 pve-manager 1/2] api: add suspendall endpoint

2023-11-13 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/API2/Nodes.pm | 124 ++ 1 file changed, 124 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index a73fca3f..0956eb0a 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -289,6 +289,7

[pve-devel] [PATCH pve-manager 1/2] api: add suspendall endpoint

2023-10-18 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- code is mostly taken from the already existing stopal endpoint, since all checks are basically the same for both suspend and stop. PVE/API2/Nodes.pm | 118 ++ 1 file changed, 118 insertions(+) diff --git a/PVE/API2

[pve-devel] [PATCH pve-manager 2/2] ui: add bulk suspend support

2023-10-18 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- www/manager6/Utils.js | 1 + www/manager6/form/VMSelector.js | 4 www/manager6/node/CmdMenu.js | 14 ++ www/manager6/node/Config.js | 14 ++ www/manager6/window/BulkAction.js | 2 +- 5 files changed, 34

[pve-devel] [PATCH pve-manager 0/2] add bulk suspend

2023-10-18 Thread Hannes Laimer
Adds support for bulk suspending VMs as it already exists for stop. Hannes Laimer (2): api: add suspendall endpoint ui: add bulk suspend support PVE/API2/Nodes.pm | 118 ++ www/manager6/Utils.js | 1 + www/manager6/form/VMSelector.js

[pve-devel] [PATCH proxmox-kernel-helper] boot tool: fix grep misinterpretation of arguments starting with a hyphen

2023-06-22 Thread Hannes Laimer
`proxmox-boot-tool kernel remove --help`, or any version agrument that started with a '-', lead to the grep usage message being written into /etc/kernel/proxmox-boot-manual-kernels. The problem was `grep` interpreted the kernel version agrument as an option since it starts with '-'. --- src/bin/pr

[pve-devel] [PATCH proxmox-widget-toolkit/pve-storage] replace '(mounted)' string by boolean field

2022-06-08 Thread Hannes Laimer
mountpoint instead of a boolean, the data is already there, but I'm not sure if that's something that makes sense to display in the grid, might end up looking a little 'cluttered'. * pve-storage Hannes Laimer (1): api2: disks: add mounted boolean field PVE/API2/Disks.p

[pve-devel] [PATCH pve-storage 1/1] api2: disks: add mounted boolean field

2022-06-08 Thread Hannes Laimer
... and remove '(mounted)' from usage string Signed-off-by: Hannes Laimer --- PVE/API2/Disks.pm | 1 + PVE/Diskmanage.pm | 7 +++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Disks.pm b/PVE/API2/Disks.pm index b618057..bde6132 100644 --- a/PVE/API2/Disk

[pve-devel] [PATCH proxmox-widget-toolkit 1/1] ui: disks: add 'mounted' column

2022-06-08 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/panel/DiskList.js | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js index eb8b1a8..76d92cd 100644 --- a/src/panel/DiskList.js +++ b/src/panel/DiskList.js @@ -35,7 +35,7 @@ Ext.define(

[pve-devel] [PATCH pve-access-control] api2: ticket: don't require TFA if the only one is disabled

2022-04-11 Thread Hannes Laimer
If TFA was added and disabled afterwards it was not possible to login again. Signed-off-by: Hannes Laimer --- This was reported on the forum. src/PVE/API2/AccessControl.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/AccessControl.pm b/src/PVE/API2

[pve-devel] [PATCH pve-manager 3/3] jobs: move to pve-cluster and pve-guest-common

2022-03-22 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/Jobs.pm| 282 - PVE/Jobs/Makefile | 16 --- PVE/Jobs/Plugin.pm | 101 PVE/Jobs/VZDump.pm | 87 -- PVE/Makefile | 3 +- 5 files changed, 1 insertion(+), 488 deletions

[pve-devel] [PATCH pve-cluster 1/3] jobs: move base plugin from pve-manager

2022-03-22 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- data/PVE/Jobs/Makefile | 11 data/PVE/Jobs/Plugin.pm| 101 + data/PVE/Makefile | 2 +- debian/pve-cluster.install | 1 + 4 files changed, 114 insertions(+), 1 deletion(-) create mode 100644 data/PVE

[pve-devel] [PATCH pve-guest-common 2/3] jobs: move VZDump plugin from pve-manager

2022-03-22 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/Makefile | 4 + src/PVE/Jobs.pm| 282 + src/PVE/Jobs/VZDump.pm | 87 + 3 files changed, 373 insertions(+) create mode 100644 src/PVE/Jobs.pm create mode 100644 src/PVE/Jobs/VZDump.pm

[pve-devel] [PATCH-SERIES] move jobs from pve-manager

2022-03-22 Thread Hannes Laimer
used in many places. Version bumps are needed. pve-cluster: Hannes Laimer (1): jobs: move base plugin from pve-manager data/PVE/Jobs/Makefile | 11 data/PVE/Jobs/Plugin.pm| 101 + data/PVE/Makefile | 2 +- debian/pve

[pve-devel] [PATCH pve-manager v4 1/3] fix #3903: jobs: add remove vmid from jobs helper

2022-03-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- v3->v4: - fix signature in base plugin - die in base plugin PVE/Jobs.pm| 21 - PVE/Jobs/Plugin.pm | 6 ++ PVE/Jobs/VZDump.pm | 13 + 3 files changed, 39 insertions(+), 1 deletion(-) diff --git a/PVE/Jobs.pm b/

[pve-devel] [PATCH pve-manager v3 1/3] fix #3903: jobs: add remove vmid from jobs helper

2022-03-14 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/Jobs.pm| 21 - PVE/Jobs/Plugin.pm | 7 +++ PVE/Jobs/VZDump.pm | 13 + 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/PVE/Jobs.pm b/PVE/Jobs.pm index ba3685ec..5b2c4c7b 100644 --- a/PVE/Jobs.pm +++ b

[pve-devel] [PATCH qemu-server v3 3/3] fix #3903: api2: remove vmid from jobs.cfg

2022-03-14 Thread Hannes Laimer
... on destroy if 'purge' is selected Signed-off-by: Hannes Laimer --- v2->v3: no changes PVE/API2/Qemu.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 9be1caf..465abc2 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -31,6

[pve-devel] [PATCH pve-container v3 2/3] fix #3903: api2: remove vmid from jobs.cfg

2022-03-14 Thread Hannes Laimer
... on destroy if 'purge' is selected Signed-off-by: Hannes Laimer --- v2->v3: no changes src/PVE/API2/LXC.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 84712f7..095f421 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PV

[pve-devel] [PATCH-SERIES v3] fix #3903: remove vmid from jobs.cfg on destroy

2022-03-14 Thread Hannes Laimer
rewrote remove_vmid_from_jobs sub - add missing 'use' statements pve-manager: Hannes Laimer (1): fix #3903: jobs: add remove vmid from jobs helper PVE/Jobs.pm| 21 - PVE/Jobs/Plugin.pm | 7 +++ PVE/Jobs/VZDump.pm | 13 + 3 files change

[pve-devel] [PATCH pve-manager v2] fix #3903: jobs: add remove vmid from jobs helper

2022-03-06 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- changed back to v1, but without the unnecessary stuff. Thanks for the feedback @Fabian Ebner PVE/Jobs.pm | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/PVE/Jobs.pm b/PVE/Jobs.pm index ba3685ec..db6fa97d 100644 --- a/PVE

[pve-devel] [PATCH pve-manager v2 1/3][FIXUP] fix #3903: jobs: add remove vmid from jobs helper

2022-03-03 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- FIXUP: sort was not needed and should not have been there PVE/Jobs.pm | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/PVE/Jobs.pm b/PVE/Jobs.pm index ba3685ec..ea41523b 100644 --- a/PVE/Jobs.pm +++ b/PVE/Jobs.pm @@ -4,7

[pve-devel] [PATCH pve-container v2 2/3] fix #3903: api2: remove vmid from jobs.cfg

2022-03-03 Thread Hannes Laimer
... on destroy if 'purge' is selected Signed-off-by: Hannes Laimer --- src/PVE/API2/LXC.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 84712f7..095f421 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -16,6 +16,7

[pve-devel] [PATCH qemu-server v2 3/3] fix #3903: api2: remove vmid from jobs.cfg

2022-03-03 Thread Hannes Laimer
... on destroy if 'purge' is selected Signed-off-by: Hannes Laimer --- PVE/API2/Qemu.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 9be1caf..465abc2 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -31,6 +31,7 @@ use PVE::Acc

[pve-devel] [PATCH-SERIES v2] fix #3903: remove vmid from jobs.cfg on destroy

2022-03-03 Thread Hannes Laimer
... if 'purge'. v2, based on Fabian Ebner 's feedback: - rewrote remove_vmid_from_jobs sub - add missing 'use' statements pve-manager: Hannes Laimer (1): fix #3903: jobs: add remove vmid from jobs helper PVE/Jobs.pm | 18 +- 1 file changed, 17

[pve-devel] [PATCH pve-manager v2 1/3] fix #3903: jobs: add remove vmid from jobs helper

2022-03-03 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/Jobs.pm | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/PVE/Jobs.pm b/PVE/Jobs.pm index ba3685ec..a2a84095 100644 --- a/PVE/Jobs.pm +++ b/PVE/Jobs.pm @@ -4,7 +4,7 @@ use strict; use warnings; use JSON; -use PVE

Re: [pve-devel] [PATCH pve-container 2/3] fix #3903: api2: remove vmid from jobs.cfg

2022-03-02 Thread Hannes Laimer
Am 02.03.22 um 11:16 schrieb Fabian Ebner: Am 01.03.22 um 09:51 schrieb Hannes Laimer: ... on destroy if 'purge' is selected Signed-off-by: Hannes Laimer --- src/PVE/API2/LXC.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm ind

[pve-devel] [PATCH pve-manager 1/3] fix #3903: jobs-plugin: add remove vmid from jobs helper

2022-03-01 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/Jobs/Plugin.pm | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/PVE/Jobs/Plugin.pm b/PVE/Jobs/Plugin.pm index 6098360b..4883a193 100644 --- a/PVE/Jobs/Plugin.pm +++ b/PVE/Jobs/Plugin.pm @@ -3,7 +3,7 @@ package PVE::Jobs

[pve-devel] [PATCH qemu-server 3/3] fix #3903: api2: remove vmid from jobs.cfg

2022-03-01 Thread Hannes Laimer
... on destroy if 'purge' is selected Signed-off-by: Hannes Laimer --- PVE/API2/Qemu.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 9be1caf..f100d2c 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1696,6 +1696,7 @@ _

[pve-devel] [PATCH-SERIES] fix #3903: remove vmid from jobs.cfg on destroy

2022-03-01 Thread Hannes Laimer
... if 'purge'. pve-manager: Hannes Laimer (1): fix #3903: jobs-plugin: add remove vmid from jobs helper PVE/Jobs/Plugin.pm | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) pve-conatiner: Hannes Laimer (1): fix #3903: api2: remove vmid from jobs.cfg

[pve-devel] [PATCH pve-container 2/3] fix #3903: api2: remove vmid from jobs.cfg

2022-03-01 Thread Hannes Laimer
... on destroy if 'purge' is selected Signed-off-by: Hannes Laimer --- src/PVE/API2/LXC.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 84712f7..2e4146e 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -75

[pve-devel] [PATCH pve-manager v3] api: add 'type' parameter to pool GET endpoint

2022-01-31 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- v3: - fix logic, eq -> ne v2(based on Thomas Lamprecht 's feedback): - remove openzv - optimize loops This was asked in a forum post, and it does not interfere with anything else AFAIK. PVE/API2/Pool.pm | 33 -

[pve-devel] [PATCH pve-manager v2] api: add 'type' parameter to pool GET endpoint

2022-01-31 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- v2(based on Thomas Lamprecht 's feedback): - remove openzv - optimize loops This was asked in a forum post, and it does not interfere with anything else AFAIK. PVE/API2/Pool.pm | 33 - 1 file changed, 20 insertions(+

[pve-devel] [PATCH pve-manager] api: add 'type' parameter to pool GET endpoint

2022-01-25 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- This was asked in a forum post, and it does not interfere with anything else AFAIK. PVE/API2/Pool.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm index 28c29ab8..b190d134 100644 --- a/PVE/API2

Re: [pve-devel] [PATCH v3 guest-common 2/2] snapshots: delete parent property if new snapshot name is already a parent to existing one

2021-11-29 Thread Hannes Laimer
Tested-by: Hannes Laimer Works as advertised, only affects old configs created before the first patch was applied. Am 14.10.21 um 11:29 schrieb Oguz Bektas: > Signed-off-by: Oguz Bektas > --- > v2->v3: > * automatically delete the 'parent' property for an existi

[pve-devel] [PATCH pve-storage] fix #3555: BTRFSPlugin: call free_image correctly

2021-07-30 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/Storage/BTRFSPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/BTRFSPlugin.pm b/PVE/Storage/BTRFSPlugin.pm index 4596b30..411cab9 100644 --- a/PVE/Storage/BTRFSPlugin.pm +++ b/PVE/Storage/BTRFSPlugin.pm @@ -410,7 +410,7

[pve-devel] [PATCH pve-manager] api2: add name to return type spec of resources

2021-06-28 Thread Hannes Laimer
VM names are returned by the endpoint anyway, therefore it makes sense to add it to the endpoint specification so it also appears in the API docs and is visible when using pvesh with text output. Signed-off-by: Hannes Laimer --- PVE/API2/Cluster.pm | 5 + 1 file changed, 5 insertions

[pve-devel] [PATCH pve-manager] api2: add name to return type spec of resources

2021-06-28 Thread Hannes Laimer
VM names are returned by the endpoint anyway, therefore it makes sense to add it to the endpoint specification so it also appears in the API docs and is visible when using pvesh with text output. Signed-off-by: Hannes Laimer --- PVE/API2/Cluster.pm | 5 + 1 file changed, 5 insertions

[pve-devel] [PATCH v2 pve-manager 1/2] api2: add suspendall endpoint

2021-02-09 Thread Hannes Laimer
Handels pause and hibernation, the reason for not splitting it was to mirror the behaviour of the already existing suspend endpoint for single VMs. Signed-off-by: Hannes Laimer --- Endpoint code is mostly taken from already existing ednpoints, namely stopall and startall. PVE/API2/Nodes.pm

[pve-devel] [PATCH v2 pve-manager 2/2] ui: add bulk hibernate action

2021-02-09 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- The bulk action name usually matches the endpoint it will call, here, however, the corresponding endpoint is responsible for hibernate and pause, therefore in order to distinguish both actions the name does not match the endpoint here. This also allows to

[pve-devel] [PATCH v2 pve-manager 0/2] add bulk hibernation action

2021-02-09 Thread Hannes Laimer
Adds suspendall endpoint which is resposible for hibernation and pause of multiple VMs, this was done to mirror the behaviour of the suspend endpoint for single VMs(which also handels hibernation and pause). The UI buttons for bulk hibernation were added. Hannes Laimer (2): api2: add

[pve-devel] [PATCH pve-manager 1/2] api2: add suspendall endpoint

2021-02-05 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/API2/Nodes.pm | 113 ++ 1 file changed, 113 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 8172231e..0c11fe35 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1943,6 +1943,119

[pve-devel] [PATCH pve-manager 0/2] add pause bulk action

2021-02-05 Thread Hannes Laimer
Add "Pause" to available bulk actions, only VMs can be paused(suspended). Hannes Laimer (2): api2: add suspendall endpoint ui: add "Bulk Pause" action to node PVE/API2/Nodes.pm | 113 www/manager6/Utils.js | 1

[pve-devel] [PATCH pve-manager 2/2] ui: add "Bulk Pause" action to node

2021-02-05 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- www/manager6/Utils.js | 1 + www/manager6/form/VMSelector.js | 10 ++ www/manager6/node/CmdMenu.js| 15 +++ www/manager6/node/Config.js | 13 + 4 files changed, 39 insertions(+) diff --git a/www/manager6

[pve-devel] [PATCH v2 qemu-server] api: qemu: make resize_vm async close #2315

2021-01-12 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- Resize is now done in a task. v1 -> v2: pass code that should be executed correctly to fork_worker PVE/API2/Qemu.pm | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index e8de4ea..0c5d50c 100

[pve-devel] [PATCH qemu-server] api: qemu: make resize_vm async close #2315

2021-01-12 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- Resizing is now done asynchronous in a task. PVE/API2/Qemu.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index e8de4ea..379f34a 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -3730,7

[pve-devel] [PATCH proxmox] correct email in changelog

2020-12-07 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- `E: librust-proxmox-dev: debian-changelog-file-contains-invalid-email-address root@elsa` prevented a proper install proxmox/debian/changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox/debian/changelog b/proxmox/debian/changelog

[pve-devel] [PATCH v4 proxmox-widget-toolkit 1/10] safe-destroy: move SafeDestroy from pve-manager here

2020-09-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/Makefile | 1 + src/window/SafeDestroy.js | 194 ++ 2 files changed, 195 insertions(+) create mode 100644 src/window/SafeDestroy.js diff --git a/src/Makefile b/src/Makefile index 12dda30..ea71647 100644

[pve-devel] [PATCH v4 pve-manager 7/10] safe-destroy: use SafeDestroy from proxmox-widget-toolkit

2020-09-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- www/manager6/ceph/Pool.js | 5 +++-- www/manager6/lxc/Config.js | 5 +++-- www/manager6/qemu/Config.js | 5 +++-- www/manager6/storage/ContentView.js | 5 +++-- 4 files changed, 12 insertions(+), 8 deletions(-) diff --git a/www

[pve-devel] [PATCH v4 proxmox-widget-toolkit 4/10] safe-destroy: replace var with let/const

2020-09-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/window/SafeDestroy.js | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js index fb27659..39706b9 100644 --- a/src/window/SafeDestroy.js +++ b/src/window

[pve-devel] [PATCH v4 proxmox-widget-toolkit 2/10] safe-destroy: eslint --fix

2020-09-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/window/SafeDestroy.js | 58 +++ 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js index 4cc1d89..dfb0185 100644 --- a/src/window/SafeDestroy.js +++ b/src

[pve-devel] [PATCH v4 proxmox-backup 10/10] ui: add remove-button for directories/mount-units

2020-09-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- www/DirectoryList.js | 25 + 1 file changed, 25 insertions(+) diff --git a/www/DirectoryList.js b/www/DirectoryList.js index 00531fd0..e605a685 100644 --- a/www/DirectoryList.js +++ b/www/DirectoryList.js @@ -21,6 +21,24 @@ Ext.define

[pve-devel] [PATCH v4 proxmox-backup 09/10] api2: add name of mount-point to DatastoreMountInfo

2020-09-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/api2/node/disks/directory.rs | 4 1 file changed, 4 insertions(+) diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/directory.rs index 0d9ddeef..38a0ba74 100644 --- a/src/api2/node/disks/directory.rs +++ b/src/api2/node/disks

[pve-devel] [PATCH v4 proxmox-widget-toolkit 0/10] removal of directories in PBS WebUI

2020-09-15 Thread Hannes Laimer
; SafeDestroy (keep original name) - generalized SafeDestroy - fixed eslint related issues - split patch [3/5]v1 into two patches proxmox-widget-toolkit: Hannes Laimer (6): safe-destroy: move SafeDestroy from pve-manager here safe-destroy: eslint --fix safe-destroy: replace

[pve-devel] [PATCH v4 proxmox-widget-toolkit 5/10] safe-destroy: add possibility to show a small note

2020-09-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/window/SafeDestroy.js | 28 1 file changed, 28 insertions(+) diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js index 39706b9..87f81b7 100644 --- a/src/window/SafeDestroy.js +++ b/src/window/SafeDestroy.js

[pve-devel] [PATCH v4 proxmox-widget-toolkit 3/10] safe-destroy: replace type with purgeable and taskName

2020-09-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/window/SafeDestroy.js | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js index dfb0185..fb27659 100644 --- a/src/window/SafeDestroy.js +++ b/src/window

[pve-devel] [PATCH v4 proxmox-widget-toolkit 6/10] utils: add task description for directory removal

2020-09-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/Utils.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Utils.js b/src/Utils.js index 8595cce..9017277 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -645,6 +645,7 @@ utilities: { stopall: ['', gettext('Stop all VMs

[pve-devel] [PATCH v4 pve-manager 8/10] remove SafeDestroy from pve-manager

2020-09-15 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- www/manager6/Makefile | 1 - www/manager6/window/SafeDestroy.js | 194 - 2 files changed, 195 deletions(-) delete mode 100644 www/manager6/window/SafeDestroy.js diff --git a/www/manager6/Makefile b/www/manager6

[pve-devel] [PATCH v1 series 0/5] limit out and inrate of network device

2020-09-11 Thread Hannes Laimer
stent due to the nature of ingress traffic shaping(ingress of tap/outrate of VM) pve-common: Hannes Laimer (2): replace rate with out/in-rate in setup_tc_rate_limit and tap_rate_limit add out/in-rate parameter to tap_plug sub, keep version with just rate param src/PVE/Network.pm | 43 +

[pve-devel] [PATCH v1 pve-common 2/5] add out/in-rate parameter to tap_plug sub, keep version with just rate param

2020-09-11 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/PVE/Network.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index 3e7a1c1..3b09cec 100644 --- a/src/PVE/Network.pm +++ b/src/PVE/Network.pm @@ -389,6 +389,11 @@ my $cleanup_firewall_bridge

[pve-devel] [PATCH v1 pve-network 3/5] add out/in-rate parameter to tap_plug sub, keep version with just rate param

2020-09-11 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/Network/SDN/Zones.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/Network/SDN/Zones.pm b/PVE/Network/SDN/Zones.pm index 143d6e5..0fe6098 100644 --- a/PVE/Network/SDN/Zones.pm +++ b/PVE/Network/SDN/Zones.pm @@ -278,10

[pve-devel] [PATCH v1 pve-common 1/5] replace rate with out/in-rate in setup_tc_rate_limit and tap_rate_limit

2020-09-11 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/PVE/Network.pm | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index 12536c7..3e7a1c1 100644 --- a/src/PVE/Network.pm +++ b/src/PVE/Network.pm @@ -82,7 +82,7

[pve-devel] [PATCH v1 qemu-server 4/5] add fields inrate and outrate to net_fmt, map rate of old configs to out/inrate

2020-09-11 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- PVE/QemuServer.pm | 35 +-- vm-network-scripts/pve-bridge | 9 ++--- 2 files changed, 35 insertions(+), 9 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 2747c66..ff59d78 100644 --- a/PVE

[pve-devel] [PATCH v1 pve-manager 5/5] out/in-rate in network edit, keep rate to still be able to open old configs

2020-09-11 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- www/manager6/Parser.js | 18 ++ www/manager6/qemu/NetworkEdit.js | 27 --- 2 files changed, 42 insertions(+), 3 deletions(-) diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js index b793a28e..eac31f2f

[pve-devel] [PATCH v3 proxmox-backup 8/9] api2: add name of mount-point to DatastoreMountInfo

2020-08-28 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- for the removal of dirs the id/name is needed in the frontend, therefore it has to be returned by the api src/api2/node/disks/directory.rs | 4 1 file changed, 4 insertions(+) diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks

[pve-devel] [PATCH v3 proxmox-widget-toolbox 2/9] safe-destroy: replace type with purgeable and taskName

2020-08-28 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- type is replaced with the two fields purgeable and taskName, type was pve-manager specific src/window/SafeDestroy.js | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/src/window/SafeDestroy.js b/src/window

[pve-devel] [PATCH v3 proxmox-widget-toolbox 3/9] safe-destroy: replace var with let/const

2020-08-28 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- all instances of var are replaced with either let or const src/window/SafeDestroy.js | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js index 71dce24..a6ad458

[pve-devel] [PATCH v3 pve-manager 5/9] safe-destroy: use SafeDestroy from proxmox-widget-toolkit

2020-08-28 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- SafeDestroy from proxmox-widget-toolkit is now used instead of the one from pve-manager www/manager6/ceph/Pool.js | 5 +++-- www/manager6/lxc/Config.js | 5 +++-- www/manager6/qemu/Config.js | 5 +++-- www/manager6/storage

[pve-devel] [PATCH v3 proxmox-backup 9/9] ui: add remove-button for directories/mount-units

2020-08-28 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- add remove button to ui, all previous patches are needed for this one www/DirectoryList.js | 25 + 1 file changed, 25 insertions(+) diff --git a/www/DirectoryList.js b/www/DirectoryList.js index 00531fd0..51b30c78 100644 --- a/www

[pve-devel] [PATCH v3 pve-manager 6/9] remove SafeDestroy from pve-manager

2020-08-28 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- remove SafeDestroy.js file since it was moved to proxmox-widget-toolkit, entry for SafeDestroy.js in Makefile also removed www/manager6/Makefile | 1 - www/manager6/window/SafeDestroy.js | 194 - 2 files changed, 195

[pve-devel] [PATCH v3 proxmox-widget-toolbox 1/9] safe-destroy: move SafeDestroy from pve-manager here

2020-08-28 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- the file was just moved, nothing except the define changed ('PVE.window.SafeDestroy' -> 'Proxmox.window.SafeDestroy') src/Makefile | 1 + src/window/SafeDestroy.js | 194 ++ 2 files

[pve-devel] [PATCH v3 proxmox-widget-toolbox 4/9] safe-destroy: add possibility to show a small note

2020-08-28 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- add field to set the note and add ui-container for displaying it src/window/SafeDestroy.js | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js index a6ad458..0027e98 100644 --- a

[pve-devel] [PATCH v3 proxmox-widget-toolbox 7/9] utils: add task description for directory removal

2020-08-28 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- add task description for the removal of directories, so it may be used in the new version of SafeDestroy src/Utils.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Utils.js b/src/Utils.js index 4be95b2..6373440 100644 --- a/src/Utils.js +++ b/src

[pve-devel] [PATCH v3 proxmox-widget-toolbox 0/9] removal of directories in PBS WebUI

2020-08-28 Thread Hannes Laimer
ginal name) - generalized SafeDestroy - fixed eslint related issues - split patch [3/5]v1 into two patches proxmox-widget-toolkit: Hannes Laimer (5): safe-destroy: move here from pve-manager safe-destroy: replace type with purgeable and taskName safe-destroy: replace

[pve-devel] [PATCH v2 proxmox-widget-toolbox 2/6] safe-destroy: add possibility display small note in dialog

2020-08-19 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- v1->v2: - split into two patches: [3/5]v1 into [2/6]+[3/6]v2 src/window/SafeDestroy.js | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js index 81c7c27..a456aba 100644 --- a/

[pve-devel] [PATCH v2 proxmox-backup 6/6] ui: add remove-button for directories/mount-units

2020-08-19 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- I could not find any, already existing, langstring to use here. "Can I re-add the same one after wards?" No, since the disk contains partitions and data. It has to be cleared before it may be re-"created" again. www/D

[pve-devel] [PATCH v2 proxmox-widget-toolbox 3/6] utils: add task description for directory removal

2020-08-19 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- v1->v2: NEW src/Utils.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Utils.js b/src/Utils.js index 4be95b2..6373440 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -641,6 +641,7 @@ utilities: { stopall: ['', gettext(

[pve-devel] [PATCH v2 proxmox-widget-toolbox 1/6] safe-destroy: moved here from pve-manager and generalized it

2020-08-19 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- v1->v2: - kept name - introduced purgeable and taskName as config in SafeDestroy, in order to avoid having downstream logic here - fixed eslint related issues src/Makefile | 1 + src/win

[pve-devel] [PATCH v2 proxmox-backup 5/6] api2: add name of mount-point to DatastoreMountInfo

2020-08-19 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- v1->v2: - no changes src/api2/node/disks/directory.rs | 5 + 1 file changed, 5 insertions(+) diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/directory.rs index 0d9ddeef..90d0ee76 100644 --- a/src/api2/node/disks/directory.rs +++ b/

[pve-devel] [PATCH v2 pve-manager 4/6] ui: move safe-destroy to proxmox-widget-toolkit and adjust usages

2020-08-19 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- v1->v2: - adjusted usages of SafeDestroy www/manager6/Makefile | 1 - www/manager6/ceph/Pool.js | 5 +- www/manager6/lxc/Config.js | 5 +- www/manager6/qemu/Config.js | 5 +- www/manager6/storage/ContentView

[pve-devel] [PATCH v2 proxmox-widget-toolbox 0/6] removal of directories in PBS WebUI

2020-08-19 Thread Hannes Laimer
eep original name) - generalized SafeDestroy - fixed eslint related issues - split patch [3/5]v1 into two patches proxmox-widget-toolkit: Hannes Laimer (3): safe-destroy: moved here from pve-manager and generalized it safe-destroy: add possibility display small note

[pve-devel] [PATCH pve-manager 2/5] ui refactoring: SafeDestroy moved into widgettoolkit + adjusted usages

2020-08-18 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- www/manager6/Makefile | 1 - www/manager6/ceph/Pool.js | 2 +- www/manager6/lxc/Config.js | 2 +- www/manager6/qemu/Config.js | 2 +- www/manager6/storage/ContentView.js | 2 +- www/manager6/window/SafeDestroy.js

[pve-devel] [PATCH series 0/5] removal of directories in PBS WebUI

2020-08-18 Thread Hannes Laimer
insertions(+) create mode 100644 src/window/SafeRemove.js pve-manager: Hannes Laimer (1): ui refactoring: SafeDestroy moved into widgettoolkit + adjusted usages www/manager6/Makefile | 1 - www/manager6/ceph/Pool.js | 2 +- www/manager6/lxc/Config.js | 2

[pve-devel] [PATCH proxmox-widget-toolkit 1/5] ui refactoring: refactored SafeDestroy from pve-manager into proxmox-widget-toolkit

2020-08-18 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/Makefile | 1 + src/window/SafeRemove.js | 193 +++ 2 files changed, 194 insertions(+) create mode 100644 src/window/SafeRemove.js diff --git a/src/Makefile b/src/Makefile index 12dda30..e7da4eb 100644 --- a

[pve-devel] [PATCH proxmox-backup 5/5] ui: added possiblity to remove directories/mount-units in the WebUI

2020-08-18 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- www/DirectoryList.js | 22 ++ 1 file changed, 22 insertions(+) diff --git a/www/DirectoryList.js b/www/DirectoryList.js index 00531fd0..b4313e49 100644 --- a/www/DirectoryList.js +++ b/www/DirectoryList.js @@ -20,6 +20,21 @@ Ext.define

  1   2   >