Quoting Fiona Ebner (2025-08-05 12:03:24)
> There is a regression regarding the permission for the /run/pve
> directory. In Proxmox VE 8, the directory had root:root 0755
> permissions, being auto-created as the lxc-syscalld runtime directory.
> In Proxmox VE 9, the permissions were restricted to r
/all/20250731114455.995999-1-f.gruenbich...@proxmox.com/
>
> minimally tested on a secure-boot enabled VM, and on one which uses
> p-b-t with systemd-boot.
>
> Co-Authored-by: Fabian Grünbichler
FWIW
Reviewed-by: Fabian Grünbichler
one thing that is not checked here is the combin
On August 1, 2025 10:54 am, Thomas Lamprecht wrote:
> On Fri, 01 Aug 2025 10:37:31 +0200, Fabian Grünbichler wrote:
>> remove the dh_installinit call in d/rules, the existing patch was incomplete
>>
>>
>
> Argh, I saw the maintscript being called and removing it and
remove the dh_installinit call in d/rules, the existing patch was incomplete
Signed-off-by: Fabian Grünbichler
---
...ip-legacy-init.d-ceph-script-anymore.patch | 31 ++-
1 file changed, 23 insertions(+), 8 deletions(-)
diff --git
a/patches/0025-debian-do-not-ship-legacy
On July 31, 2025 2:09 pm, Fiona Ebner wrote:
> Am 31.07.25 um 1:15 PM schrieb Fabian Grünbichler:
>> otherwise a volume like `100/oldstyle-100-disk-0.qcow2` can be snapshotted,
>> but
>> the snapshot file is treated as a volume instead of a snapshot afterwards.
>>
>
the ESP is not mounted.
Signed-off-by: Fabian Grünbichler
---
Notes:
we prepared a fixed systemd-boot package for our repositories, but since
systemd is updated fairly frequently even in Debian stable we either need to
keep doing that or avoid pulling in systemd-boot on p-b-t *using
Signed-off-by: Fabian Grünbichler
---
src/PVE/Storage/Plugin.pm | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index affe7b0..db05e0e 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -702,9
fixes for various issues
Fabian Grünbichler (4):
plugin: fix parse_name_dir regression for custom volume names
fix #6584: plugin: list_images: only include parseable filenames
plugin: extend snapshot name parsing to legacy volnames
plugin: parse_name_dir: drop deprecation warning
src
this gets printed very often if such a volume exists - e.g. adding such a
volume to a config with `qm set` prints it 10 times..
Signed-off-by: Fabian Grünbichler
---
we could maybe just warn in the list_images code path? or add a check to
pve8to9?
src/PVE/Storage/Plugin.pm | 1 -
1 file
by only including filenames that are also valid when actually parsing them,
things like snapshot files or files not following our naming scheme are no
longer candidates for rescanning or included in other output.
Co-authored-by: Shannon Sterz
Signed-off-by: Fabian Grünbichler
---
src/PVE
outright.
Fixes: b63147f5dfd62e398cc206d2f7086d5db38b3c9b "plugin: fix volname parsing"
Co-authored-by: Shannon Sterz
Signed-off-by: Fabian Grünbichler
---
src/PVE/Storage/Plugin.pm | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Storage/Plugin.pm b/src/P
On July 24, 2025 4:35 pm, Thomas Lamprecht wrote:
> Am 24.07.25 um 12:11 schrieb Shannon Sterz:
>> newer isos ship with new deb822 style repository configurations in
>> `/etc/apt/sources.list.d/debian.sources`. make the installer set the
>> mirror in the correct file again.
>>
>> Signed-off-by: Sh
On July 30, 2025 4:49 pm, Max R. Carrara wrote:
> On Wed Jul 30, 2025 at 4:26 PM CEST, Fabian Grünbichler wrote:
>> On July 30, 2025 4:05 pm, Max R. Carrara wrote:
>> > On Wed Jul 30, 2025 at 4:00 PM CEST, Max R. Carrara wrote:
>> >> On Tue Jul 29, 2025 at 1:15 PM
an incoming remote migration is akin to a container creation, so treat it the
same.
Signed-off-by: Fabian Grünbichler
---
src/PVE/API2/LXC.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 951b1c7..2574739 100644
--- a/src/PVE/API2/LXC.pm
restore keeps what is in the backup config, but allows switching to
unprivileged. switching from unprivileged to privileged requires VM.Allocate at
the moment.
the config schema default cannot easily be changed to unprivileged, as that
would break existing configs.
Signed-off-by: Fabian
even if unchecked, since the backend now defaults to unprivileged if not
defined at all.
Signed-off-by: Fabian Grünbichler
---
www/manager6/lxc/CreateWizard.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index 2971991e2
the container
privileged
- in-place restoring of privileged backup over unprivileged config
- restoring of privileged backup into new container
Signed-off-by: Fabian Grünbichler
---
src/PVE/API2/LXC.pm | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/src/PVE
old pve-manager, insofar as privileged
container creation via the UI is not honored.
pve-container:
Fabian Grünbichler (3):
api: create: default to unprivileged containers
create/restore: require Sys.Modify for privileged containers
migration: require Sys.Modify for incoming privileged
On July 30, 2025 4:20 pm, Fiona Ebner wrote:
> Am 30.07.25 um 3:11 PM schrieb Fabian Grünbichler:
>> On July 18, 2025 5:03 pm, Fiona Ebner wrote:
>>> The check_volume_access() method is for checking read access to a
>>> volume. Users should be able to list the i
On July 30, 2025 4:05 pm, Max R. Carrara wrote:
> On Wed Jul 30, 2025 at 4:00 PM CEST, Max R. Carrara wrote:
>> On Tue Jul 29, 2025 at 1:15 PM CEST, Wolfgang Bumiller wrote:
>> > Signed-off-by: Wolfgang Bumiller
>> > --- a/src/PVE/Storage/LvmThinPlugin.pm
>> > +++ b/src/PVE/Storage/LvmThinPlugin.p
On July 30, 2025 3:23 pm, Fiona Ebner wrote:
> In the tests, legacy volids resulting in 'images' vtype will be
> allowed for both 'ct-vol' and 'vm-vol'.
>
> New test cases for new-form guest image volids are added too.
>
> Signed-off-by: Fiona Ebner
> ---
>
> Is based on top of Wolfgang's staff
including a version bump for pve-access-control + versioned dependency
from pve-manager, and a tiny follow-up adding the new priv to the readme
as well ;)
On July 18, 2025 11:30 am, Fiona Ebner wrote:
> Currently, guest replication is guarded with Datastore.Allocate on
> '/storage', which is rathe
thanks!
On July 29, 2025 1:02 pm, Shan Shaji wrote:
> When removing TFA from a user via the command line, the change was not
> reflected in the GUI or in the output of `pveum user list`. Both
> continued to show that TFA was enabled for the user. Fixed the issue
> by updating the user configuratio
On July 18, 2025 5:03 pm, Fiona Ebner wrote:
> The check_volume_access() method is for checking read access to a
> volume. Users should be able to list the images, e.g. to check backup
> health via monitoring like reported in #5492 comment 3, with just an
> audit privilege.
>
> Signed-off-by: Fion
On July 30, 2025 3:00 pm, Thomas Lamprecht wrote:
> Am 30.07.25 um 14:50 schrieb Fabian Grünbichler:
>>> For already running containers, a symbolic link is put into place by
>>> the new version of pve-lxc-syscalld, but newly started ones should
>>> always use the ne
On July 23, 2025 4:40 pm, Fiona Ebner wrote:
> The lxc-syscalld now uses a different runtime directory. Its old
> runtime directory was /run/pve, which was also used for other things,
> e.g. storage tunnel and mtunnel sockets and container stderr logs as
> well as pull metrics. The fact that it wou
On July 30, 2025 11:48 am, Thomas Lamprecht wrote:
> Am 30.07.25 um 07:41 schrieb nansen.su:
>> This patch adds a 'hidden' boolean option to the iSCSI storage plugin.
>> When enabled, it allows hiding the storage from the resource tree in
>> the web interface while keeping it functional for a
On July 29, 2025 1:58 pm, Thomas Lamprecht wrote:
> Hi Josh,
>
> Am 28.07.25 um 16:43 schrieb Joshua Huber:
>> Thanks for creating a Debian bug & cherry-picked MR. Fingers crossed
>> the changes flow through into PVE9. :)
>
> FYI: We just uploaded a build of sg3-utils with your patch included
> i
On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> src/PVE/Storage/ZFSPoolPlugin.pm | 25 -
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/src/PVE/Storage/ZFSPoolPlugin.pm
> b/src/PVE/Storage/ZFSPoolPlugin.p
On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> src/PVE/Storage/BTRFSPlugin.pm | 25
> src/PVE/Storage/ESXiPlugin.pm| 2 +-
> src/PVE/Storage/ISCSIDirectPlugin.pm | 2 +-
> src/PVE/Storage/ISCSIPlugin.pm | 2 +-
> s
On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
> Prepares the stoplevel PVE::Storage API updates as well as adding the
> new vtype subdirs to the base plugin's vtype subdir hash.
>
> The new types are "vm-vol" and "ct-vol". They represent VM and
> container volumes, respectively. The "images"
On July 30, 2025 10:53 am, Wolfgang Bumiller wrote:
> On Wed, Jul 30, 2025 at 10:37:27AM +0200, Fabian Grünbichler wrote:
>> On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
>> > - ESXi, ISCSIDirect, ISCSI:
>> > Volumes are always vm volumes.
>> > - LVM:
&
On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
> Generally we want to allow transitioning from 'images' or 'rootdir' to
> 'vm-vol' or 'ct-vol' respectively, but not the other way round.
> Obviously, staying *within* any of the types is also allowed.
>
> The `is_volume_type` helper is just a co
On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> src/PVE/API2/Qemu.pm | 16 +---
> src/PVE/QemuMigrate.pm | 3 ++-
> src/PVE/QemuServer.pm | 6 --
> 3 files changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/src/PVE/API2/
On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
> Prepares the stoplevel PVE::Storage API updates as well as adding the
> new vtype subdirs to the base plugin's vtype subdir hash.
>
> The new types are "vm-vol" and "ct-vol". They represent VM and
> container volumes, respectively. The "images"
question - do we also want to add them to existing configs on updates?
or on RMW cycles, always implying that as long as images is set vm-vol
is also set, and same for rootdir ct-vol (but obviously not the other
way round ;))?
that might allow us to get rid of some of the extra compat mapping in
c
On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
> - ESXi, ISCSIDirect, ISCSI:
> Volumes are always vm volumes.
> - LVM:
> New volumes use a `vol-vm-` or `vol-ct-` prefix.
> - Dir based, LvmThin, RBD:
> Like LVM, but for base images a `base-` prefix is added
> *additionally*, instead of *
On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
> `list_images()` now takes a vtype.
>
> If it is not set, we act like we did previously by listing *all*
> images. This now includes the vm-vol and ct-vol types ones.
>
> If a new vtype is set (vm-vol or ct-vol), then we list only those.
>
> Fo
On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> src/PVE/Storage/Plugin.pm | 20 ++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
> index 98788d1..047b2fc 10
On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
> Signed-off-by: Wolfgang Bumiller
> ---
> src/PVE/Storage/Common.pm| 31 ++
> src/PVE/Storage/ISCSIDirectPlugin.pm | 5 -
> src/PVE/Storage/ISCSIPlugin.pm | 7 --
> src/PVE/Storage/LVMPlugin.pm
On July 29, 2025 1:15 pm, Wolfgang Bumiller wrote:
> For plugins which follow our new naming scheme.
>
> Signed-off-by: Wolfgang Bumiller
> ---
> src/PVE/Storage/Common.pm | 29 +
> 1 file changed, 29 insertions(+)
>
> diff --git a/src/PVE/Storage/Common.pm b/src/PVE
On July 29, 2025 2:04 pm, Fiona Ebner wrote:
> Am 29.07.25 um 1:53 PM schrieb Fabian Grünbichler:
>> by directly printing the to-be-executed command, instead of copying it which
>> is
>> error-prone.
>>
>> Signed-off-by: Fabian Grünbichler
>> Review
by
https://lore.proxmox.com/pve-devel/20250729115320.579286-1-f.gruenbich...@proxmox.com/T/#t
On July 29, 2025 9:38 am, Fabian Grünbichler wrote:
> we don't want qcow2 files to reference their backing chains via
> absolute paths, as that makes renaming the base dir or VG of
to avoid the resulting qcow2 file referencing its backing file via an absolute
path, which makes renaming the base of the storage impossible.
Signed-off-by: Fabian Grünbichler
---
Notes:
v2: move logic into its own helper
src/PVE/QemuServer/Blockdev.pm | 24 ++--
1
this was copied over from Plugin.pm
Signed-off-by: Fabian Grünbichler
Reviewed-by: Fiona Ebner
---
src/PVE/Storage/LVMPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index c1f5474..5a84e82 100644
--- a
course not be run while the image is being
written by other process or QEMU.
v2: incorporated Fiona's feedback, thanks!
pve-storage:
Fabian Grünbichler (4):
plugin: fix typo in rebase log message
lvm plugin: fix typo in rebase log message
plugin: use relative path for qcow2 rebase command
otherwise the resulting qcow2 file will contain an absolute path, which makes
renaming the backing VG of the storage impossible.
Signed-off-by: Fabian Grünbichler
Reviewed-by: Fiona Ebner
---
Notes:
v2: drop unused variable
src/PVE/Storage/LVMPlugin.pm | 4 ++--
1 file changed, 2
otherwise the resulting qcow2 file will contain an absolute path, which makes
changing the backing path of the directory storage impossible.
Signed-off-by: Fabian Grünbichler
Reviewed-by: Fiona Ebner
Tested-by: Fiona Ebner
---
src/PVE/Storage/Plugin.pm | 4 ++--
1 file changed, 2 insertions
by directly printing the to-be-executed command, instead of copying it which is
error-prone.
Signed-off-by: Fabian Grünbichler
Reviewed-by: Fiona Ebner
---
Notes:
v2: join command instead of fixing manually copied message
src/PVE/Storage/Plugin.pm | 2 +-
1 file changed, 1 insertion
On July 29, 2025 12:26 pm, Shan Shaji wrote:
> Thank you so much for the review and i will update it accordingly.
> Had some doubts which i added as inline comments.
>
> On Tue Jul 29, 2025 at 11:45 AM CEST, Fabian Grünbichler wrote:
>> On July 29, 2025 10:30 am
On July 29, 2025 10:30 am, Shan Shaji wrote:
> When removing TFA from a user via the command line, the change was not
> reflected in the GUI or in the output of `pveum user list`. Both
> continued to show that TFA was enabled for the user. Fixed the issue
> by updating the user configuration file.
to avoid the resulting qcow2 file referencing its backing file via an absolute
path, which makes renaming the base of the storage impossible.
Signed-off-by: Fabian Grünbichler
---
src/PVE/QemuServer/Blockdev.pm | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff
otherwise the resulting qcow2 file will contain an absolute path, which makes
changing the backing path of the directory storage impossible.
Signed-off-by: Fabian Grünbichler
---
src/PVE/Storage/Plugin.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PVE/Storage
otherwise the resulting qcow2 file will contain an absolute path, which makes
renaming the backing VG of the storage impossible.
Signed-off-by: Fabian Grünbichler
---
src/PVE/Storage/LVMPlugin.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Storage
this was copied over from Plugin.pm
Signed-off-by: Fabian Grünbichler
---
src/PVE/Storage/LVMPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index c1f5474..db1be98 100644
--- a/src/PVE/Storage/LVMPlugin.pm
course not be run while the image is being
written by other process or QEMU.
pve-storage:
Fabian Grünbichler (4):
plugin: fix typo in rebase log message
lvm plugin: fix typo in rebase log message
plugin: use relative path for qcow2 rebase command
lvm plugin: use relative path for qcow2 re
the format here is of course qcow2, and the actual command was correct, but the
log message was not.
Signed-off-by: Fabian Grünbichler
---
src/PVE/Storage/Plugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index
On July 28, 2025 3:14 pm, Adam Kalisz wrote:
> On Fri, 2025-07-25 at 14:46 +0200, Fabian Grünbichler wrote:
>> On July 25, 2025 1:23 pm, Adam Kalisz wrote:
>> > Similarly the sync performance between two Proxmox Backup Servers
>> > and
>> > live-migration got me
ts qemu-img invocation.
>
>
Applied, thanks - this filename here is always absolute, even if we
fix up more of the actual referencing to happen via relative paths.
[1/1] plugin: volume snapshot info: untaint snapshot filename
commit: 93f0dfbc756e02984d85d5f301314b987d8388f1
Best reg
On July 28, 2025 1:08 pm, Fiona Ebner wrote:
> Am 28.07.25 um 11:59 AM schrieb Fabian Grünbichler:
>> On July 25, 2025 5:48 pm, Friedrich Weber wrote:
>>> Without untainting, offline-deleting a volume-chain snapshot on a
>>> directory storage via the GUI fails wit
On July 25, 2025 5:48 pm, Friedrich Weber wrote:
> Without untainting, offline-deleting a volume-chain snapshot on a
> directory storage via the GUI fails with an "Insecure dependecy in
> exec [...]" error, because volume_snapshot_delete uses the filename
> its qemu-img invocation.
>
> Signed-off-
use correct cache mode for EFI disk
commit: fb7e0904b715d19d0a01fbeffd8444f71f26e16a
Best regards,
--
Fabian Grünbichler
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On July 27, 2025 2:03 pm, DERUMIER, Alexandre via pve-devel wrote:
> about discard, maybe we should add a note about enabling
> issue_discards=1 in lvm.conf. (don't known if it could be enabled by
> default for new install ?)
yes, maybe. or alternatively, we could call blkdiscard as part of the
re
without the last patch, as discussed off-list - it's a bit involved,
we'll see if we can find a better way to handle this, and for the
current stop-gap measure the simple approach is good enough.
added a FIXME instead so we don't forget.
On July 25, 2025 12:50 pm, Fiona Ebner wrote:
> Changes in
commit: 6d212deaadb83edaffc37b4163ea21c4b9201bae
[2/2] qmp: device unplug: bump timeout for removing virtio scsi controller
commit: 71623e5abcab4485ed2c8bec2fede3d7a5bb6483
Best regards,
--
Fabian Grünbichler
___
pve-devel mailing list
pve-devel@lists.proxm
Signed-off-by: Fabian Grünbichler
---
Notes:
not sure whether we want to also add a note suggesting to (heavily)
overprovision the LUN/backing device on the storage side, so that there is
enough "space" for creating snapshots?
pve-storage-lvm.adoc | 8 ++--
1 file
except for some questions on the last patch, consider this series
Reviewed-by: Fabian Grünbichler
and that last patch Acked-by in principle as well, with those questions
addressed
On July 24, 2025 3:59 pm, Fiona Ebner wrote:
> First part is fixing discard in combination with -blockdev.
On July 24, 2025 3:59 pm, Fiona Ebner wrote:
> Without the 'discard-no-unref', a qcow2 file can grow beyond what
> 'qemu-img measure' reports, because of fragmentation. This can lead to
> IO errors with qcow2 on top of LVM storages, where the containing LV
> is allocated with that size. Guard enabl
..
Signed-off-by: Fabian Grünbichler
---
gave this a quick spin with both dir and lvm based storages, seems to work as
expected..
src/PVE/QemuServer/Blockdev.pm | 21 ++---
1 file changed, 6 insertions(+), 15 deletions(-)
diff --git a/src/PVE/QemuServer/Blockdev.pm b/src/PVE
> Thomas Lamprecht hat am 14.07.2025 13:27 CEST
> geschrieben:
>
>
> Am 14.07.25 um 13:15 schrieb Fabian Grünbichler:
> >> Thomas Lamprecht hat am 14.07.2025 13:11 CEST
> >> geschrieben:
> >> Albeit, taking a step back, I'm not so sure i
> Thomas Lamprecht hat am 14.07.2025 13:11 CEST
> geschrieben:
>
>
> Am 14.07.25 um 13:04 schrieb Fabian Grünbichler:
> >> so I think that a warning in the UI is fine enough if qcow2 format is
> >> selected.
> > would probably need to go into a few pla
> DERUMIER, Alexandre hat am 14.07.2025
> 10:18 CEST geschrieben:
>
>
> >>4. all snapshot volumes on extsnap dir storages will print warnings
> >>like
> >>
> >>`this volume filename is not supported anymore`
> >>
> >>when hitting `parse_namedir` - those can likely be avoided by
> >>skipping
> DERUMIER, Alexandre hat am 14.07.2025
> 08:34 CEST geschrieben:
>
>
> >> sub qemu_img_resize {
> >>- my ($scfg, $path, $format, $size, $timeout) = @_;
> >>+ my ($scfg, $path, $format, $size, $preallocation, $timeout) =
> @_;
>
> you have forgot to remove the $scfg param, so
> it's b
> DERUMIER, Alexandre hat am 14.07.2025
> 10:42 CEST geschrieben:
>
>
> >>6. it's fairly easy to accidentally create qcow2-formatted LVM
> >>volumes, as opposed to the requirement to enable a non-UI storage
> >>option at storage creation time for dir storages, we might want to
> >>add some w
> Alexandre Derumier via pve-devel hat am
> 09.07.2025 18:21 CEST geschrieben:
> This patch series implement qcow2 external snapshot support for files && lvm
> volumes
>
> The current internal qcow2 snapshots have bad write performance because no
> metadatas can be preallocated.
>
> This is
by moving the preallocation handling to the call site, and preparing
them for taking further options like cluster size in the future.
Signed-off-by: Fabian Grünbichler
---
src/PVE/Storage/LVMPlugin.pm | 10 --
src/PVE/Storage/Plugin.pm| 66 ++--
2 files
Signed-off-by: Fabian Grünbichler
---
src/PVE/Storage/Common.pm| 147 ++---
src/PVE/Storage/LVMPlugin.pm | 10 +--
src/PVE/Storage/Plugin.pm| 153 +++
3 files changed, 152 insertions(+), 158 deletions(-)
diff --git a/src/PVE
both source and target snapshot need to be provided when renaming.
Signed-off-by: Fabian Grünbichler
---
src/PVE/Storage.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm
index 53965ee..b3ca094 100755
--- a/src/PVE/Storage.pm
+++ b
> DERUMIER, Alexandre hat am 08.07.2025
> 15:42 CEST geschrieben:
>
>
> >>okay, that means we instead need to become more strict with 'snapext'
> >>storages and restrict the volnames there.. maybe to (vm-|base-)-XXX-
> >>*.fmt?
>
> $plugin->parse_volname($volname) don't have $scfg param cu
> DERUMIER, Alexandre hat am 08.07.2025
> 12:04 CEST geschrieben:
>
>
> > +my sub alloc_backed_image {
> > + my ($class, $storeid, $scfg, $volname, $backing_snap) = @_;
> > +
> > + my $path = $class->path($scfg, $volname, $storeid);
> > + my $backing_path = $class->path($scfg, $volna
> DERUMIER, Alexandre hat am 08.07.2025
> 10:44 CEST geschrieben:
>
>
> > preallocation => { optional => 1 },
> > + snapext => { optional => 1 },
>
> >>needs to be "fixed", as the code doesn't handle mixing internal
> >>and external snapshots on a single storage..
>
> I thin
> DERUMIER, Alexandre hat am 07.07.2025
> 12:18 CEST geschrieben:
> >>for the DirPlugin we need to add another level for the snapshots
> >>on-disk, else we cannot differentiate between weirdly-named image
> >>files and snapshot files..
> >>
> >>so we could add a directory "snapshots" and put a
Reviewed-by: Fabian Grünbichler
although the comment in the postinst (that got moved over)
could be shortened to just say that the entry is unconditionally
rewritten, IMHO ;)
> Lukas Wagner hat am 25.06.2025 14:20 CEST geschrieben:
>
>
> proxmox-mail-forward is not intended to
> DERUMIER, Alexandre hat am 04.07.2025
> 15:22 CEST geschrieben:
> > + #delete external snapshots
> > + if ($scfg->{snapext}) {
> > + my $snapshots = $class->volume_snapshot_info($scfg,
> > $storeid, $volname);
> > + for my $snapid (
> > + sor
> DERUMIER, Alexandre hat am 04.07.2025
> 14:33 CEST geschrieben:
>
>
> >>these should probably stay in Plugin.pm
>
> Ok, will do, no problem (Fiona asked me to move it out of Plugin)
I'd prefer if the helpers there remain low-level helpers
for now, and not config-handling things including
> DERUMIER, Alexandre hat am 04.07.2025
> 14:10 CEST geschrieben:
> >>it would also be great if you could add a patch bumping API version
> >>and age
> I was not sure it was needed, as Fiona has just bumped it in last
> patches and no .deb has been released ?
we could maybe skip bumping twice,
> Alexandre Derumier via pve-devel hat am
> 04.07.2025 08:44 CEST geschrieben:
> This patch series implement qcow2 external snapshot support for files && lvm
> volumes
>
> The current internal qcow2 snapshots have bad write performance because no
> metadatas can be preallocated.
>
> This is
> Alexandre Derumier via pve-devel hat am
> 04.07.2025 08:45 CEST geschrieben:
> allow to rename from|to external snapshot volname
we could consider adding a new API method `rename_snapshot` instead:
my ($class, $scfg, $storeid, $volname, $source_snap, $target_snap) = @_;
for the two plugins
> Alexandre Derumier via pve-devel hat am
> 04.07.2025 08:45 CEST geschrieben:
> This add a $running param to volume_snapshot,
> it can be used if some extra actions need to be done at the storage
> layer when the snapshot has already be done at qemu level.
>
> Note: zfs && rbd plugins already
> Alexandre Derumier via pve-devel hat am
> 04.07.2025 08:45 CEST geschrieben:
> add a snapext option to enable the feature
>
> When a snapshot is taken, the current volume is renamed to snap volname
> and a current image is created with the snap volume as backing file
>
> Signed-off-by: Alex
> Alexandre Derumier via pve-devel hat am
> 04.07.2025 08:44 CEST geschrieben:
> Signed-off-by: Alexandre Derumier
> ---
> src/PVE/Storage/Common.pm | 52 +++
> src/PVE/Storage/Plugin.pm | 47 +--
> 2 files changed, 53 insert
> Alexandre Derumier via pve-devel hat am
> 04.07.2025 08:44 CEST geschrieben:
> and use it for plugin linked clone
>
> This also enable extended_l2=on, as it's mandatory for backing file
> preallocation.
>
> Preallocation was missing previously, so it should increase performance
> for linked
herwise we warn about it and try to parse the json
> + warn $err_output;
> +}
> +return $json;
this is identical to qemu_img_info modulo the generated command, so I'd add a
follow-up to extract the output handling into a helper:
commit 9053bf5593b097d484ce52c3ffe831138c2bb208
Author: Fabian Grünbi
haven't fully managed to get through the qemu-server part, but one small thing
below..
> Alexandre Derumier via pve-devel hat am
> 04.07.2025 08:45 CEST geschrieben:
> fixme:
> - add test for internal (was missing) && external qemu snapshots
> - is it possible to use blockjob transactions for
> Alexandre Derumier via pve-devel hat am
> 04.07.2025 08:45 CEST geschrieben:
> Returns if the volume is supporting qemu snapshot:
> 'internal' : do the snapshot with qemu internal snapshot
> 'external' : do the snapshot with qemu external snapshot
> undef : does not support qemu snaps
> Alexandre Derumier via pve-devel hat am
> 04.07.2025 08:45 CEST geschrieben:
> we format lvm logical volume with qcow2 to handle snapshot chain.
>
> like for qcow2 file, when a snapshot is taken, the current lvm volume
> is renamed to snap volname, and a new current lvm volume is created
> w
thanks!
> Dominik Csapak hat am 03.07.2025 14:24 CEST
> geschrieben:
>
>
> and add the missing features that we had in bookworm and add Touch +
> TouchList that's necessary for newer pwt.
>
> Signed-off-by: Dominik Csapak
> ---
> src/web-sys/debian/changelog | 7 +++
> src/web-sys/debian
thanks!
ended up requiring a bumped versioned dependency from qemu-server to
pve-firewall for unrelated reasons, but that meant not requiring
anything else to force the upgrade/desired constraint here.
> Fabian Grünbichler hat am 03.07.2025 09:37 CEST
> geschrieben:
> > Christoph H
Applied, thanks!
Best regards,
--
Fabian Grünbichler
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> DERUMIER, Alexandre via pve-devel hat am
> 03.07.2025 12:11 CEST geschrieben:
>
> I Just notice this when rebasing my patches ^_^
>
> (sorry my last patch serie was still tab+spaces)
>
>
> I'm trying to install proxmox-perltidy but it depend on perltidy
> 20250311.05
>
> dpkg: dependency
1 - 100 of 1437 matches
Mail list logo
