Re: [pve-devel] [RFC manager 1/2] fix #5244 pveceph: install: add new repository for offline installation

2025-05-28 Thread Aaron Lauterer
Sent a v1: https://lore.proxmox.com/pve-devel/20250528164630.2204379-1-a.laute...@proxmox.com/T/#t ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager v1 3/3] pveceph: print repo metadata when installing from manual

2025-05-28 Thread Aaron Lauterer
By printing the site and component, the person installing it manuall has a final check to see if the correct repository is being used. Signed-off-by: Aaron Lauterer --- Notes: I intially tried to get the repo definition similar to how it is in the .list file and printed by apt-cache

[pve-devel] [PATCH manager v1 1/3] fix #5244 pveceph: install: add new repository for offline installation

2025-05-28 Thread Aaron Lauterer
by adding a 4th repository option called 'offline'. If set, the ceph installation step will not touch the repository configuration. We add a simple version check to make sure that the latest version available (and to be installed) does match the selected major Ceph version. Signed-off

[pve-devel] [PATCH manager v1 2/3] ui: CephInstallWizard: add option and hint for offline repository

2025-05-28 Thread Aaron Lauterer
The new 'offline' repository option will not try to configure the Ceph repositories during installation. Signed-off-by: Aaron Lauterer Tested-by: Christoph Heiss --- Notes: changes since RFC: * renamed option from 'offline' to 'manual' and therefore a

[pve-devel] [PATCH qemu-server 3/4] vmstatus: switch mem stat to PSS of VM cgroup

2025-05-23 Thread Aaron Lauterer
Instead of RSS, let's use the same PSS values as for the specific host view as default, in case this value is not overwritten by the balloon info. Signed-off-by: Aaron Lauterer --- PVE/QemuServer.pm | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer

[pve-devel] [PATCH manager 1/5] api2tools: drop old VM rrd schema

2025-05-23 Thread Aaron Lauterer
pve2.3-vm has been introduced with commit 3b6ad3ac back in 2013. By now there should not be any combination of clustered nodes that still send the old pve2-vm variant. Signed-off-by: Aaron Lauterer --- PVE/API2Tools.pm | 18 +- 1 file changed, 1 insertion(+), 17 deletions

[pve-devel] [PATCH container 1/1] rrddata: use new pve9 rrd location if file is present

2025-05-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- src/PVE/API2/LXC.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 5c6ee57..65a5d4a 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -694,8 +694,10 @@ __PACKAGE__

[pve-devel] [PATCH qemu-server 4/4] rrddata: use new pve9 rrd location if file is present

2025-05-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- PVE/API2/Qemu.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 626cce4..233e69d 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1572,8 +1572,10 @@ __PACKAGE__->register_met

[pve-devel] [PATCH qemu-server 2/4] vmstatus: add memhost for host view of vm mem consumption

2025-05-23 Thread Aaron Lauterer
their PSS data to account for shared libraries used. Signed-off-by: Aaron Lauterer --- PVE/QemuServer.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 5f36772..c5eb5c1 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2867,6 +286

[pve-devel] [PATCH common 3/4] add helper to fetch value from smaps_rollup for pid

2025-05-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- src/PVE/ProcFSTools.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/PVE/ProcFSTools.pm b/src/PVE/ProcFSTools.pm index 382e6c5..185b2b3 100644 --- a/src/PVE/ProcFSTools.pm +++ b/src/PVE/ProcFSTools.pm @@ -344,6 +344,20 @@ sub

[pve-devel] [PATCH manager 3/5] api: nodes: rrd and rrddata fetch from new pve9-node rrd files if present

2025-05-23 Thread Aaron Lauterer
if the new rrd pve9-node files are present, they contain the current data and should be used. Signed-off-by: Aaron Lauterer --- PVE/API2/Nodes.pm | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 791d2dec..dd12c1ce 100644

[pve-devel] [PATCH qemu-server 1/4] metrics: add pressure to metrics

2025-05-23 Thread Aaron Lauterer
From: Folke Gleumes Signed-off-by: Aaron Lauterer --- PVE/QemuServer.pm | 8 1 file changed, 8 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 577959a..5f36772 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2943,6 +2943,14 @@ sub vmstatus

[pve-devel] [PATCH manager 5/5] ui: rrdmodels: add new columns

2025-05-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/data/model/RRDModels.js | 16 1 file changed, 16 insertions(+) diff --git a/www/manager6/data/model/RRDModels.js b/www/manager6/data/model/RRDModels.js index 2240dcab..5504d0af 100644 --- a/www/manager6/data/model/RRDModels.js

[pve-devel] [PATCH manager 2/5] pvestatd: collect and distribute new pve9- metrics

2025-05-23 Thread Aaron Lauterer
* io full * mem some * mem full VMs: * memhost (memory consumption of all processes in the guests cgroup, host view) * pressures: * cpu some * cpu full * io some * io full * mem some * mem full Signed-off-by: Aaron Lauterer --- Notes: this will automatically send the

[pve-devel] [PATCH manager 4/5] api2tools: extract stats: handle existence of new pve9- data

2025-05-23 Thread Aaron Lauterer
and fall back to old pve2-{node,storage} or pve2.3-vm if not present. Signed-off-by: Aaron Lauterer --- PVE/API2Tools.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/API2Tools.pm b/PVE/API2Tools.pm index 37829983..84ba0bf4 100644 --- a/PVE/API2Tools.pm +++ b

[pve-devel] [PATCH storage 1/1] status: rrddata: use new pve9 rrd location if file is present

2025-05-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- src/PVE/API2/Storage/Status.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm index 14915ae..11074bc 100644 --- a/src/PVE/API2/Storage/Status.pm +++ b/src/PVE/API2/Storage

[pve-devel] [PATCH common 4/4] metrics: add buffer and cache to meminfo

2025-05-23 Thread Aaron Lauterer
From: Folke Gleumes Expose buffers and cache as separate metrics instead of including them in memfree and memused. Originally-by: Folke Gleumes [AL: rebased and adapted to changes that happened in the meantime] Signed-off-by: Aaron Lauterer --- src/PVE/ProcFSTools.pm | 4 1 file changed

[pve-devel] [PATCH common 2/4] add functions to retrieve pressures for vm/ct

2025-05-23 Thread Aaron Lauterer
From: Folke Gleumes Originally-by: Folke Gleumes [AL: rebased on current master] Signed-off-by: Aaron Lauterer --- src/PVE/ProcFSTools.pm | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/PVE/ProcFSTools.pm b/src/PVE/ProcFSTools.pm index f9fe3f0..382e6c5 100644

[pve-devel] [PATCH common 1/4] fix error in pressure parsing

2025-05-23 Thread Aaron Lauterer
From: Folke Gleumes Originally-by: Folke Gleumes [AL: rebased] Signed-off-by: Aaron Lauterer --- src/PVE/ProcFSTools.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/ProcFSTools.pm b/src/PVE/ProcFSTools.pm index be9..f9fe3f0 100644 --- a/src/PVE

Re: [pve-devel] [PATCH cluster-pve8 2/2] status: handle new pve9- metrics update data

2025-05-23 Thread Aaron Lauterer
On 2025-05-23 18:00, Aaron Lauterer wrote: For PVE9 there will be additional fields in the metrics that are collected. The new columns/fields are added at the end of the current ones. Therefore, if we get the new format, we need to cut it. Paths to rrd filenames needed to be set manually

[pve-devel] [PATCH cluster 1/1] status: introduce new pve9- rrd and metric format

2025-05-23 Thread Aaron Lauterer
oxmox.com/?p=proxmox-backup.git;a=blob;f=src/server/metric_collection/rrd.rs;h=ed39cc94ee056924b7adbc21b84c0209478bcf42;hb=dc324716a688a67d700fa133725740ac5d3795ce#l76 Signed-off-by: Aaron Lauterer --- src/pmxcfs/status.c | 242 +++- 1 file changed, 217 i

[pve-devel] [PATCH cluster-pve8 2/2] status: handle new pve9- metrics update data

2025-05-23 Thread Aaron Lauterer
e' part instead of the full key, as that could also be 'pve9-...' which does not exists. Signed-off-by: Aaron Lauterer --- src/pmxcfs/status.c | 51 ++--- src/pmxcfs/status.h | 2 ++ 2 files changed, 46 insertions(+), 7 deletions(-) diff --g

[pve-devel] [PATCH pve9-rrd-migration-tool 1/1] introduce rrd migration tool for pve8 -> pve9

2025-05-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- .cargo/config.toml | 8 + .gitignore | 5 + Cargo.toml | 20 ++ build.rs| 29 +++ src/lib.rs | 5 + src/main.rs | 504 src

[pve-devel] [RFC cluster/common/container/manager/pve9-rrd-migration-tool/qemu-server/storage 00/19] Expand and migrate RRD data

2025-05-23 Thread Aaron Lauterer
by one If you uncomment the extra logging in the pmxcfs/status.c you should see how the different situations are handled. In the PVE8 patches start at line 1373, in the later patches for PVE9 it starts at line 1565. cluster-pve8: Aaron Lauterer (2): cfs status.c: drop old pve2-vm rrd sche

[pve-devel] [PATCH cluster-pve8 1/2] cfs status.c: drop old pve2-vm rrd schema support

2025-05-23 Thread Aaron Lauterer
the newer pve2.3-vm schema has been introduced with commit ba9dcfc1 back in 2013. By now there should be no cluster where an older node might still send the old pve2-vm schema. Signed-off-by: Aaron Lauterer --- src/pmxcfs/status.c | 13 +++-- 1 file changed, 3 insertions(+), 10

[pve-devel] [PATCH manager] ui: node: use plug icon for node shutdown

2025-05-07 Thread Aaron Lauterer
this makes it optically different to the guest shutdown and hopefully helps to avoid confusion and accidential node shutdowns. Signed-off-by: Aaron Lauterer --- This came up in the forum and I do like the idea and the change is small enough to just quickly do it https://forum.proxmox.com/threads

Re: [pve-devel] [RFC manager 1/2] fix #5244 pveceph: install: add new repository for offline installation

2025-05-05 Thread Aaron Lauterer
: Christoph Heiss On Wed Apr 23, 2025 at 3:28 PM CEST, Aaron Lauterer wrote: by adding a 4th repository option called 'offline'. If set, the ceph installation step will not touch the repository configuration. We add a simple version check to make sure that the latest version available

Re: [pve-devel] [RFC storage 0/3] rbd: use image-/snap-spec instead of --pool/..

2025-04-30 Thread Aaron Lauterer
is, consider this series Reviewed-By: Aaron Lauterer Tested-By: Aaron Lauterer On 2025-04-23 15:59, Fabian Grünbichler wrote: the 'rbd' CLI tool has two ways of specifying which images/snapshots to operate on: - the deprecated --(dest-)pool, --namespace, --image and --snap parameters

[pve-devel] [PATCH docs 5/7] ha-manager: expand requirements

2025-04-29 Thread Aaron Lauterer
* make it clear that the corosync/cluster communication is important * mark hardware watchdogs as optional Signed-off-by: Aaron Lauterer --- ha-manager.adoc | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ha-manager.adoc b/ha-manager.adoc index 3d6fc4a..592ef96 100644

[pve-devel] [PATCH manager 6/7] ui: cluster create: add recommendations for cluster networks

2025-04-29 Thread Aaron Lauterer
to be. Signed-off-by: Aaron Lauterer --- www/manager6/dc/ClusterEdit.js | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/ClusterEdit.js b/www/manager6/dc/ClusterEdit.js index b56df713..399d2393 100644 --- a/www/manager6/dc/ClusterEdit.js +++ b/www/manage

[pve-devel] [PATCH docs 1/7] pvecm: drop notes about old version incompatibilities

2025-04-29 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- pvecm.adoc | 12 1 file changed, 12 deletions(-) diff --git a/pvecm.adoc b/pvecm.adoc index 18f7389..47e42e2 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -77,18 +77,6 @@ Requirements * Online migration of virtual machines is only supported when

[pve-devel] [PATCH docs 4/7] pvecm: extend cluster Requirements

2025-04-29 Thread Aaron Lauterer
by expanding on best practices with background information as to how and why. Signed-off-by: Aaron Lauterer --- pvecm.adoc | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/pvecm.adoc b/pvecm.adoc index 3b9cfc4..c50ec15 100644 --- a/pvecm.adoc +++ b

[pve-devel] [PATCH docs, manager 0/7] add and expand on cluster recommendations

2025-04-29 Thread Aaron Lauterer
by expanding on it in the docs and the UI. the doc patches have some cleanup and new anchor patches the second ui patch is to fix an external link that I noticed and is just a drive-by patch. docs: Aaron Lauterer (5): pvecm: drop notes about old version incompatibilities pvecm: add anchor

[pve-devel] [PATCH manager 7/7] ui: guest import: make sure an external link has target _blank

2025-04-29 Thread Aaron Lauterer
otherwise it will most likely open in the current tab and not in a new one. Signed-off-by: Aaron Lauterer --- www/manager6/window/GuestImport.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js index

[pve-devel] [PATCH docs 3/7] pvecm: add anchor for corosync exernal vote support

2025-04-29 Thread Aaron Lauterer
so we can reference the chapter. Manually set the automatically generated one to avoid breaking existing deep links. Signed-off-by: Aaron Lauterer --- pvecm.adoc | 1 + 1 file changed, 1 insertion(+) diff --git a/pvecm.adoc b/pvecm.adoc index a38351c..3b9cfc4 100644 --- a/pvecm.adoc +++ b

[pve-devel] [PATCH docs 2/7] pvecm: add anchor for cluster requirements

2025-04-29 Thread Aaron Lauterer
so we can link help buttons to it Signed-off-by: Aaron Lauterer --- pvecm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvecm.adoc b/pvecm.adoc index 47e42e2..a38351c 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -54,7 +54,7 @@ Grouping nodes into a cluster has the

[pve-devel] [RFC manager 2/2] ui: CephInstallWizard: add option and hint for offline repository

2025-04-23 Thread Aaron Lauterer
The new 'offline' repository option will not try to configure the Ceph repositories during installation. Signed-off-by: Aaron Lauterer --- www/manager6/ceph/CephInstallWizard.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/man

[pve-devel] [RFC manager 1/2] fix #5244 pveceph: install: add new repository for offline installation

2025-04-23 Thread Aaron Lauterer
by adding a 4th repository option called 'offline'. If set, the ceph installation step will not touch the repository configuration. We add a simple version check to make sure that the latest version available (and to be installed) does match the selected major Ceph version. Signed-off

Re: [pve-devel] [PATCH storage 1/2] rbd: remove no longer used rados_cmd helper

2025-04-22 Thread Aaron Lauterer
tested both patches: * list contents * snapshot & rollback & delete snapshot of a VM * add new disk, detach & delete * move-disk Consider these two patches Reviewed-By: Aaron Lauterer Tested-By: Aaron Lauterer On 2025-04-22 10:56, Fabian Grünbichler wrote: all librados intera

[pve-devel] [PATCH manager 1/2] fix #6304 ui: qemu: fix validator in DisplayEdit to match serial displays

2025-04-15 Thread Aaron Lauterer
because the value we get is not the config key, but the displayed text. Therefore we fetch the config key from the PVE.Utils.kvm_vga_drivers object. Signed-off-by: Aaron Lauterer --- We have some options here, we could also match and extract the serial ID from the displayed text, but that will

[pve-devel] [PATCH manager 2/2] ui: qemu: make validator warning for serial displays more concrete

2025-04-15 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- feel free to squash this into the first patch if you prefer. www/manager6/qemu/DisplayEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index 7a9a5160..7482ca55 100644

[pve-devel] applied: [PATCH docs] firmware-updates: align apt upgrade to apt full-upgrade

2025-04-11 Thread Aaron Lauterer
Because 'apt-get upgrade' or 'apt upgrade' will not pull in potential new dependencies and that could lead to a broken system. 'apt-get dist-ugprade' or 'apt full-upgrade' will install new dependencies when needed. Signed-off-by: Aaron Lauterer --- firm

[pve-devel] [PATCH docs v3 follow-up] pveceph: add section for rbd namespaces

2025-04-11 Thread Aaron Lauterer
and a few basic examples on how to manage them. Signed-off-by: Aaron Lauterer --- Please use this instead of the original v3 docs patch. It seems I forgot to commit the changes before creating the patch :-/bin changes since v2: * {pve} instead of written out * incorporated other small fixes and

[pve-devel] [PATCH qemu-server, manager v5 0/4] fix #1926 autodetect xtermjs or novnc for VM console

2025-04-10 Thread Aaron Lauterer
cd58f-aba2-4c1e-a6a0-d21828a33...@proxmox.com/ qemu-server: Aaron Lauterer (2): vmstatus_return_properties: add missing serial property api: status/current: add display property PVE/API2/Qemu.pm | 13 + PVE/QemuServer.pm | 5 + 2 files changed, 18 insertions(+) manager: Aaron

[pve-devel] [PATCH qemu-server v5 2/4] api: status/current: add display property

2025-04-10 Thread Aaron Lauterer
ll in one place. Candidates to be moved into the clipboard property are for example the spice and clipboard property. Signed-off-by: Aaron Lauterer --- first introduces with v5 PVE/API2/Qemu.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.p

[pve-devel] [PATCH qemu-server, manager v7 0/4] fix #1926 autodetect xtermjs or novnc for VM console

2025-04-10 Thread Aaron Lauterer
display qemu-server: Aaron Lauterer (2): QemuServer: add new public get_default_vga_type function api: status/current: add display property PVE/API2/Qemu.pm | 13 + PVE/QemuServer.pm | 29 ++--- 2 files changed, 35 insertions(+), 7 deletions(-) manage

[pve-devel] [PATCH manager v5 3/4] fix #1926 ui: vm console: autodetect novnc or xtermjs

2025-04-10 Thread Aaron Lauterer
d once the next API call to status/current finished. Signed-off-by: Aaron Lauterer --- Overall not really less complex than v4 [0] but with the new display property definitely more ready to changes in the future and we save one API call. [0] https://lore.proxmox.com/pve-devel/2025032509185

[pve-devel] [PATCH manager v6 3/4] fix #1926 ui: vm console: autodetect novnc or xtermjs

2025-04-08 Thread Aaron Lauterer
d once the next API call to status/current finished. Signed-off-by: Aaron Lauterer Reviewed-by: Dominik Csapak --- changes since: v5: * introduce PVE.Utils.isSerialDisplay helper * avoid 'rec' assignment in callback when setting the 'xtermjs' variable v4: * use new status/curren

[pve-devel] [PATCH qemu-server, manager v6 0/4] fix #1926 autodetect xtermjs or novnc for VM console

2025-04-08 Thread Aaron Lauterer
elf where we already have the current status of a VM already cached. Changes from v5: implement suggestions: * use get_vga_properties for default VGA * UI: use helper to determine if serial display qemu-server: Aaron Lauterer (2): QemuServer: make get_vga_properties and extract_version public

Re: [pve-devel] [PATCH qemu-server, manager v6 0/4] fix #1926 autodetect xtermjs or novnc for VM console

2025-04-08 Thread Aaron Lauterer
sent a v7 https://lore.proxmox.com/pve-devel/20250408122710.1164112-2-a.laute...@proxmox.com/T/#m54aae8f7595a1478748c2b61180c46d0cf52e38b On 2025-04-08 12:37, Aaron Lauterer wrote: We add a new property in the VM status/current API result that includes the display configurtion of the VM

[pve-devel] [PATCH manager v7 4/4] ui: console: check on activate if display info for VMs is present

2025-04-08 Thread Aaron Lauterer
If we already have the display information for a VM, we can proceed loading the correct console (noVNC or xtermjs). This way, we don't need to wait for the callback of the VM's status/current API call to finish setting up the console. Signed-off-by: Aaron Lauterer --- changes since v

[pve-devel] [PATCH qemu-server v7 2/4] api: status/current: add display property

2025-04-08 Thread Aaron Lauterer
ll in one place. Candidates to be moved into the display property are for example the spice and clipboard property. Signed-off-by: Aaron Lauterer --- changes since v6: * use the new QemuServer::get_default_vga_type function, which means we can drop a lot of boilerplate code v5: *

[pve-devel] [PATCH manager v7 3/4] fix #1926 ui: vm console: autodetect novnc or xtermjs

2025-04-08 Thread Aaron Lauterer
d once the next API call to status/current finished. Signed-off-by: Aaron Lauterer Reviewed-by: Dominik Csapak --- changes since: v6: none v5: * introduce PVE.Utils.isSerialDisplay helper * avoid 'rec' assignment in callback when setting the 'xtermjs' variable v4: * use new statu

[pve-devel] [PATCH qemu-server v7 1/4] QemuServer: add new public get_default_vga_type function

2025-04-08 Thread Aaron Lauterer
by moving that part out of get_vga_properties. We resolve missing parameters if necessary to make it easier to call from another module where we likely only have the VM config ready. Signed-off-by: Aaron Lauterer --- changes since v6: instead of making get_vga_properties and extract_version

Re: [pve-devel] [PATCH qemu-server, manager v5 0/4] fix #1926 autodetect xtermjs or novnc for VM console

2025-04-08 Thread Aaron Lauterer
sent a v6 https://lore.proxmox.com/pve-devel/20250408103715.1081055-1-a.laute...@proxmox.com/ On 2025-04-07 18:27, Aaron Lauterer wrote: This version 5 of the series uses a different approach as discussed [0] in the last interation. We add a new property in the VM status/current API result

[pve-devel] [PATCH qemu-server v6 1/4] QemuServer: make get_vga_properties and extract_version public

2025-04-08 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- newly introduced with v6 PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index ccdceed..b7ef69b 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1159,7 +1159,7 @@ sub

[pve-devel] [PATCH qemu-server v6 2/4] api: status/current: add display property

2025-04-08 Thread Aaron Lauterer
ll in one place. Candidates to be moved into the display property are for example the spice and clipboard property. Signed-off-by: Aaron Lauterer --- Getting all the parameters for get_vga_properties added a bit of boilerplate. Should be get another external call site to it we could think a

[pve-devel] [PATCH manager v6 4/4] ui: console: check on activate if display info for VMs is present

2025-04-08 Thread Aaron Lauterer
If we already have the display information for a VM, we can proceed loading the correct console (noVNC or xtermjs). This way, we don't need to wait for the callback of the VM's status/current API call to finish setting up the console. Signed-off-by: Aaron Lauterer --- changes since

Re: [pve-devel] [PATCH manager v5 4/4] ui: console: check on activate if display info for VMs is present

2025-04-08 Thread Aaron Lauterer
On 2025-04-08 10:10, Dominik Csapak wrote: On 4/7/25 18:27, Aaron Lauterer wrote: If we already have the display information for a VM, we can proceed loading the correct console (noVNC or xtermjs). This way, we don't need to wait for the callback of the VM's status/current A

Re: [pve-devel] [PATCH qemu-server v5 2/4] api: status/current: add display property

2025-04-08 Thread Aaron Lauterer
On 2025-04-08 09:49, Fiona Ebner wrote: Am 07.04.25 um 18:27 schrieb Aaron Lauterer: @@ -3048,8 +3058,11 @@ __PACKAGE__->register_method({ $status->{ha} = PVE::HA::Config::get_service_status("vm:$param->{vmid}"); + $status->{display}->{type} = 's

Re: [pve-devel] [PATCH manager v4] fix #1926 ui: vm console: autodetect novnc or xtermjs

2025-04-07 Thread Aaron Lauterer
sent a v5 https://lore.proxmox.com/pve-devel/20250407162718.495812-1-a.laute...@proxmox.com/ On 2025-04-03 13:03, Thomas Lamprecht wrote: Am 26.03.25 um 13:04 schrieb Aaron Lauterer: I did not find if we already have the full VM config already. AFAICT we go from `qemu/Config.js

[pve-devel] [PATCH qemu-server v5 1/4] vmstatus_return_properties: add missing serial property

2025-04-07 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- first introduces with v5 PVE/QemuServer.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index ea45366..76121d6 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2748,6 +2748,11 @@ our

[pve-devel] [PATCH manager v5 4/4] ui: console: check on activate if display info for VMs is present

2025-04-07 Thread Aaron Lauterer
If we already have the display information for a VM, we can proceed loading the correct console (noVNC or xtermjs). This way, we don't need to wait for the callback of the VM's status/current API call to finish setting up the console. Signed-off-by: Aaron Lauterer --- first introduc

Re: [pve-devel] [PATCH docs v1] package repos: revise Ceph section, introduce 2 attributes

2025-04-05 Thread Aaron Lauterer
On 2025-03-25 12:19, Alexander Zeidler wrote: On Mon Mar 24, 2025 at 5:50 PM CET, Aaron Lauterer wrote: On 2025-02-10 11:36, Alexander Zeidler wrote: * Remove duplicated text to maintain clarity * Mention available installation methods (web-based wizard, CLI tool) * Create a table to

Re: [pve-devel] [PATCH manager v3] ui: vm console: autodetect novnc or xtermjs

2025-04-04 Thread Aaron Lauterer
On 2025-03-24 17:57, Friedrich Weber wrote: On 25/02/2025 16:47, Aaron Lauterer wrote: […] + + if (me.consoleType ==="kvm") { nit: missing space after the === thanks for spotting this + Proxmox.Utils.API2Request({ + url: `/api2/e

Re: [pve-devel] [PATCH manager v3 3/6 follow up] ui: ceph pool: add rbd namespace panel

2025-04-04 Thread Aaron Lauterer
Sorry for the noise. Please ignore this one. I sent it again with the correct in-reply-to to get the threading right. On 2025-04-04 17:18, Aaron Lauterer wrote: This needs a bit of a rework of the Ceph Pool panel because we want to have it right next/below to the pool grid. Additionally we

[pve-devel] [PATCH manager v3 3/6 follow up] ui: ceph pool: add rbd namespace panel

2025-04-04 Thread Aaron Lauterer
grid. This also means that we need to redirect the submenu in Config.js to use the new intermediate Ceph.PoolView panel instead of the pool grid directly. Signed-off-by: Aaron Lauterer --- Please use this follow up instead of the original! I forgot to remove two listeners at the end of the

[pve-devel] [PATCH manager v3 3/6 follow up] ui: ceph pool: add rbd namespace panel

2025-04-04 Thread Aaron Lauterer
grid. This also means that we need to redirect the submenu in Config.js to use the new intermediate Ceph.PoolView panel instead of the pool grid directly. Signed-off-by: Aaron Lauterer --- Please use this follow up instead of the original! I forgot to remove two listeners at the end of the

[pve-devel] [PATCH manager v3 1/6] api: ceph: add rbd namespace management endpoints

2025-04-04 Thread Aaron Lauterer
RBD supports namespaces. To make the management easier and possible via the web UI, we need to add API endpoints to: * list * create * delete namespaces. We only allow creatng namespaces for pools that have the RBD application set. Signed-off-by: Aaron Lauterer --- changes since v2: * use long

Re: [pve-devel] [PATCH manager, docs v2 0/6] Ceph: add RBD Namespace management

2025-04-04 Thread Aaron Lauterer
sent a v3 with your recommendations and feedback. thanks! https://lore.proxmox.com/pve-devel/20250404145339.1067261-1-a.laute...@proxmox.com/T/#u On 2024-12-23 17:00, Aaron Lauterer wrote: The series adds the necessary API endpoints and GUI to manage RBD namespaces in a HCI cluster. The Ceph

[pve-devel] [PATCH manager v3 3/6] ui: ceph pool: add rbd namespace panel

2025-04-04 Thread Aaron Lauterer
grid. This also means that we need to redirect the submenu in Config.js to use the new intermediate Ceph.PoolView panel instead of the pool grid directly. Signed-off-by: Aaron Lauterer --- changes since v2: * make new PoolView declarative * add interface to pveNodeCephRbdNamespacelist that handles

[pve-devel] [PATCH docs v3] pveceph: add section for rbd namespaces

2025-04-04 Thread Aaron Lauterer
and a few basic examples on how to manage them. Signed-off-by: Aaron Lauterer --- changes since v2: * {pve} instead of written out * incorporated other small fixes and style recommendation v1: none pveceph.adoc | 41 + 1 file changed, 41 insertions

[pve-devel] [PATCH manager v3 4/6] ui: utils: add ceph rbd namespace task names

2025-04-04 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- no changes since v1 www/manager6/Utils.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index aa415759..a21ffec7 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1993,11 +1993,13

[pve-devel] [PATCH manager v3 2/6] pveceph: add pool namespace subcommands

2025-04-04 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- changes since v2: * define alias for 'namespace list' correctly v1: none PVE/CLI/pveceph.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm index 488aea04..a549ae80 100755 --- a/PVE/CLI/pveceph.pm

[pve-devel] [PATCH manager, docs v3 0/6] Ceph: add RBD Namespace management

2025-04-04 Thread Aaron Lauterer
. More details in the patch itself. manager: Aaron Lauterer (5): api: ceph: add rbd namespace management endpoints pveceph: add pool namespace subcommands ui: ceph pool: add rbd namespace panel ui: utils: add ceph rbd namespace task names ui: storage rbd: remove hint for manual rbd namespace

[pve-devel] [PATCH manager v3 5/6] ui: storage rbd: remove hint for manual rbd namespace creation

2025-04-04 Thread Aaron Lauterer
they can now be created with proxmox ve tooling directly Signed-off-by: Aaron Lauterer --- no changes since v1 www/manager6/storage/RBDEdit.js | 21 - 1 file changed, 21 deletions(-) diff --git a/www/manager6/storage/RBDEdit.js b/www/manager6/storage/RBDEdit.js index

[pve-devel] applied: [PATCH docs] qm, vzdump: add notes regarding backups of windows and VSS

2025-03-28 Thread Aaron Lauterer
On 2025-01-20 15:35, Aaron Lauterer wrote: VSS in windows guests with additional backup software in the guest can cause problems. By now the guest agent does support to use a different VSS option. This way, one can switch to one that does not interfere with other backup solutions. Mention it

Re: [pve-devel] applied: [PATCH docs v2 1/6] ceph: add anchors for use in troubleshooting section

2025-03-26 Thread Aaron Lauterer
On 2025-03-26 11:20, Max Carrara wrote: On Mon Mar 24, 2025 at 5:42 PM CET, Aaron Lauterer wrote: On 2025-02-05 11:08, Alexander Zeidler wrote: Signed-off-by: Alexander Zeidler --- v2: * add two missing anchors to be usable via xref pve-disk-health-monitoring.adoc | 1

Re: [pve-devel] [PATCH manager v4] fix #1926 ui: vm console: autodetect novnc or xtermjs

2025-03-26 Thread Aaron Lauterer
On 2025-03-25 18:09, Thomas Lamprecht wrote: Am 25.03.25 um 10:18 schrieb Aaron Lauterer: Some users configure their VMs to use serial as their display. The big benefit is that in combination with the xtermjs remote console, copy & paste works a lot better than via novnc. While

[pve-devel] [PATCH manager v4] fix #1926 ui: vm console: autodetect novnc or xtermjs

2025-03-25 Thread Aaron Lauterer
;activated' and 'configLoaded' variables. Signed-off-by: Aaron Lauterer --- Another thing that I noticed is that the property we use to decide if we enable xtermjs for VMs in the top right console button only checks if the VM has a serial device configured. PVE::QemuServer::vms

Re: [pve-devel] [PATCH docs v1] package repos: revise Ceph section, introduce 2 attributes

2025-03-25 Thread Aaron Lauterer
Overall, a nice overhaul to make the section a lot easier to grasp. Thanks! A bit more content wise inline. On 2025-02-10 11:36, Alexander Zeidler wrote: * Remove duplicated text to maintain clarity * Mention available installation methods (web-based wizard, CLI tool) * Create a table to see

Re: [pve-devel] [PATCH manager v3] ui: vm console: autodetect novnc or xtermjs

2025-03-25 Thread Aaron Lauterer
I sent out a v4 with the suggested changes by Friedrich and the bug number that Hannes found. Thanks! https://lore.proxmox.com/pve-devel/20250325091854.1051956-1-a.laute...@proxmox.com/T/#u On 2025-02-25 16:47, Aaron Lauterer wrote: Some users configure their VMs to use serial as their

Re: [pve-devel] [PATCH docs v1] package repos: revise Ceph section, introduce 2 attributes

2025-03-24 Thread Aaron Lauterer
On 2025-02-10 11:36, Alexander Zeidler wrote: * Remove duplicated text to maintain clarity * Mention available installation methods (web-based wizard, CLI tool) * Create a table to see the support state of Ceph releases I am not sure if having this in the rather static documentation is a

[pve-devel] applied: [PATCH docs v2 1/6] ceph: add anchors for use in troubleshooting section

2025-03-24 Thread Aaron Lauterer
On 2025-02-05 11:08, Alexander Zeidler wrote: Signed-off-by: Alexander Zeidler --- v2: * add two missing anchors to be usable via xref pve-disk-health-monitoring.adoc | 1 + pveceph.adoc| 8 pvecm.adoc | 1 + 3 files changed, 10 insert

Re: [pve-devel] [PATCH manager] pvestatd: improve broadcast of node version-info

2025-02-27 Thread Aaron Lauterer
sent a v2 https://lore.proxmox.com/pve-devel/20250227143356.1089350-1-a.laute...@proxmox.com/T/#u On 2025-01-16 17:30, Aaron Lauterer wrote: Until now, the pvestatd did broadcast the pve-manager version only once after startup of the service. But there are some situations, where the local

[pve-devel] [PATCH manager v2] fix #5894: pvestatd: improve broadcast of node version-info

2025-02-27 Thread Aaron Lauterer
again. Signed-off-by: Aaron Lauterer --- changes since v2: * use scalar() around check if keys are present * mention bug this fixes PVE/Service/pvestatd.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index 7fa003fe

Re: [pve-devel] [PATCH manager] pvestatd: improve broadcast of node version-info

2025-02-27 Thread Aaron Lauterer
On 2025-01-16 17:50, Christian Ebner wrote: On 1/16/25 17:38, Aaron Lauterer wrote: On  2025-01-16  17:35, Christian Ebner wrote: On 1/16/25 17:30, Aaron Lauterer wrote: […] This will close issue 5894 I guess [0]? [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5894 Specifically

Re: [pve-devel] [RFC cluster] status: clear stale kv stores upon sync

2025-02-26 Thread Aaron Lauterer
...@proxmox.com/ Consider this Tested-By: Aaron Lauterer On 2022-10-06 14:54, Fiona Ebner wrote: This avoids that stale kv entries stay around when a node leaves the CPG. Now, each kv entry will be something a node sent after (or upon joining) the CPG. This avoids scenarios where a user of

Re: [pve-devel] [PATCH manager] pvestatd: improve broadcast of node version-info

2025-02-26 Thread Aaron Lauterer
On 2025-01-17 13:18, Fiona Ebner wrote: Am 16.01.25 um 17:30 schrieb Aaron Lauterer: Until now, the pvestatd did broadcast the pve-manager version only once after startup of the service. But there are some situations, where the local pmxcfs (pve-cluster) restarts and loses that information

Re: [pve-devel] [PATCH manager v2] proxy: ui: vm console: autodetect novnc or xtermjs

2025-02-25 Thread Aaron Lauterer
I sent a v3 that implements the functionality in the UI alone. https://lore.proxmox.com/pve-devel/20250225154706.1108094-1-a.laute...@proxmox.com/T/#u On 2025-02-03 11:01, Fiona Ebner wrote: Am 25.11.24 um 11:04 schrieb Aaron Lauterer: Some users configure their VMs to use serial as their

[pve-devel] [PATCH manager v3] ui: vm console: autodetect novnc or xtermjs

2025-02-25 Thread Aaron Lauterer
;activated' and 'configLoaded' variables. Signed-off-by: Aaron Lauterer --- Another thing that I noticed is that the property we use to decide if we enable xtermjs for VMs in the top right console button only checks if the VM has a serial device configured. PVE::QemuServer::vms

[pve-devel] applied: [PATCH docs] installation: unattended: sync the section with the wiki introduction

2025-02-19 Thread Aaron Lauterer
On 2025-02-10 15:06, Alexander Zeidler wrote: so that there are not two different versions of the introduction and users mistakenly think they have already read the introduction in the admin guide. Signed-off-by: Alexander Zeidler --- pve-installation.adoc | 25 -

Re: [pve-devel] [PATCH docs] qm, vzdump: add notes regarding backups of windows and VSS

2025-01-21 Thread Aaron Lauterer
On 2025-01-21 13:08, Alexander Zeidler wrote: On Mon Jan 20, 2025 at 3:35 PM CET, Aaron Lauterer wrote: VSS in windows guests with additional backup software in the guest can cause problems. By now the guest agent does support to use a different VSS option. This way, one can switch to one

[pve-devel] [PATCH docs] qm, vzdump: add notes regarding backups of windows and VSS

2025-01-20 Thread Aaron Lauterer
explains it. Signed-off-by: Aaron Lauterer --- qm.adoc | 13 + vzdump.adoc | 4 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/qm.adoc b/qm.adoc index 4bb8f2c..660047a 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1355,14 +1355,19 @@ that calling 'fs-freeze&

Re: [pve-devel] [PATCH manager] pvestatd: improve broadcast of node version-info

2025-01-16 Thread Aaron Lauterer
On 2025-01-16 17:35, Christian Ebner wrote: On 1/16/25 17:30, Aaron Lauterer wrote: […] This will close issue 5894 I guess [0]? [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5894 Specifically, the 'version-info', yes. Are there other prop

[pve-devel] [PATCH manager] pvestatd: improve broadcast of node version-info

2025-01-16 Thread Aaron Lauterer
again. Signed-off-by: Aaron Lauterer --- This patch is preparation to get reliable version infos as I am picking of the patch series of Folke to include more metrics into the RRD data and summary graphs. [0] This was a big blocker and now with the major version change coming up, we at least can

Re: [pve-devel] [PATCH docs v2 6/6] pveceph: add section for rbd namespaces

2025-01-10 Thread Aaron Lauterer
thanks. I can send a follow-up if the rest of the series does not require a v3 On 2025-01-02 14:46, Alexander Zeidler wrote: On Mon Dec 23, 2024 at 5:00 PM CET, Aaron Lauterer wrote: and a few basic examples on how to manage them. Signed-off-by: Aaron Lauterer --- changes since v1: none

Re: [pve-devel] [PATCH manager, docs 0/7] Ceph: add RBD Namespace management

2024-12-23 Thread Aaron Lauterer
sent a v2: https://lore.proxmox.com/pve-devel/20241223160008.218710-1-a.laute...@proxmox.com/T/#m4cf1056451d93fffbb9e427db5c4e459b342df07 On 2024-12-06 14:55, Aaron Lauterer wrote: The first patch in this series is not related, but adds a new column to the ceph pool panel to also display the

[pve-devel] [PATCH manager v2 1/6] api: ceph: add rbd namespace management endpoints

2024-12-23 Thread Aaron Lauterer
RBD supports namespaces. To make the management easier and possible via the web UI, we need to add API endpoints to: * list * create * delete namespaces. We only allow creatng namespaces for pools that have the RBD application set. Signed-off-by: Aaron Lauterer --- changes since v1

[pve-devel] [PATCH manager, docs v2 0/6] Ceph: add RBD Namespace management

2024-12-23 Thread Aaron Lauterer
the RBD storage backend that scans for namespaces. But that only has a tangential relationship to this series. changes since v1: Only on patch 1/6, integrating the feedback received. More details in the patch itself. manager: Aaron Lauterer (5): api: ceph: add rbd namespace management endpoints

  1   2   3   4   5   6   7   8   9   10   >