Re: [pve-devel] [PATCH qemu-server 6/6] fix #6543: use qcow2 'discard-no-unref' option when using snapshot-as-volume-chain

2025-07-24 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Thanks Fiona ! >>While 'snapshot-as-volume-chain' is not the perfect proxy, as that's >>not only for LVM, it's an experimental feature that covers the LVM >>case and it seems like a nice fit to try out the new option on >>file-based storages too. I'll try to do test with qco

Re: [pve-devel] [PATCH docs/proxmox-firewall v2 0/4] migrate proxmox-firewall to proxmox-log + introduce subcommands

2025-07-24 Thread Stefan Hanreich
ping On 5/27/25 15:57, Stefan Hanreich wrote: > Since we now have proxmox-log as the standard crate for logging purposes, > migrate proxmox-firewall to the new logging crate. > > The old logging setup was also tied with the debugging mechanisms described in > the documentation. I used that opport

Re: [pve-devel] [RFC PATCH 1/2] frr: add networking.service as systemd dependency

2025-07-24 Thread Gabriel Goller
ping Hannes and I tried to fix the errors that appear when starting FRR 10.3.1 (even on a blank config). The errors look similar to these: Jul 22 08:36:09 pve1 zebra[845]: libyang Invalid boolean value "". (/frr-vrf:lib/vrf/state/active) Jul 22 08:36:09 pve1 zebra[845]: libyang Invalid

Re: [pve-devel] [PATCH docs] pvecm, network: add section on corosync over bonds

2025-07-24 Thread Friedrich Weber
Thanks for taking a look at this! On 24/07/2025 10:22, Daniel Herzig wrote: > Thanks for documenting this! > > I'd even go one step further and discourage the use of bonds in one of > the sections of 'Cluster Network' in `pvecm.adoc` as well. Best with a > link to the new 'Corosync over Bonds' se

[pve-devel] [PATCH pve-manager 1/2] pvestatd: pull metric: use ip link to detect physical interfaces

2025-07-24 Thread Stefan Hanreich
pve-common now allows arbitrary names for physical interfaces, without being restricted by PHYSICAL_NIC_RE. In order to detect physical interfaces, pvestatd now needs to query 'ip link' for the type of an interface instead of relying on the regular expression. On the receiving end, PullMetric cann

[pve-devel] [PATCH pve-common 1/1] inotify/interfaces: use ip link for detecting physical interfaces

2025-07-24 Thread Stefan Hanreich
The parser for /e/n/i relied on PHYSICAL_NIC_RE for detecting physical interfaces. In order to allow arbitrary interface names for pinning physical interfaces, switch over to detecting physical interfaces via 'ip link' instead. Signed-off-by: Stefan Hanreich --- src/PVE/INotify.pm | 25 +

[pve-devel] [PATCH pve-manager 2/2] network-interface-pinning: allow arbitrary names

2025-07-24 Thread Stefan Hanreich
With the changes to physical interface detection in pve-common and pve-manager, it is now possible to use arbitrary names for physical interfaces in our network stack. This allows the removal of the existing, hardcoded, prefixes. Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interfa

[pve-devel] [RFC common/manager 0/3] arbitrary prefixes for pinning network interfaces

2025-07-24 Thread Stefan Hanreich
This patch series lifts the restriction for naming physical interfaces. Previously we relied on a regex (PHYSICAL_NIC_RE) for determining whether an interface was physical or not. This patch series changes that, by querying the kernel for the type of the interface and using that to determine whethe

[pve-devel] applied: [PATCH qemu-server] fix #6562: fix blockdev_replace for dir-based storages

2025-07-24 Thread Fiona Ebner
Am 24.07.25 um 2:10 PM schrieb Fabian Grünbichler: > avoid calling qemu_blockdev_options on a volid+snapshot that is potentially > already invalid if it has been removed/renamed by the storage layer. instead, > generate the node name of the old node that we want to replace/remove > directly, > sin

Re: [pve-devel] [PATCH installer] install: adapt to changes in repository config when setting mirror

2025-07-24 Thread Thomas Lamprecht
Am 24.07.25 um 12:11 schrieb Shannon Sterz: > newer isos ship with new deb822 style repository configurations in > `/etc/apt/sources.list.d/debian.sources`. make the installer set the > mirror in the correct file again. > > Signed-off-by: Shannon Sterz > --- > only did some rudimentary testing he

[pve-devel] Tested-by: kai.ha...@gmail.com (Requesting permission / capability to test)

2025-07-24 Thread Kai Hamilton via pve-devel
--- Begin Message --- Hello proxmox developers, I am very interested in the steps to build the patch for OIDC integrations such as zitadel which need a custom audiences field as seen in the issues I contained at the footer of this message. I would love to build this in my production proxmox instan

[pve-devel] [PATCH qemu-server 2/6] blockdev: fix discard

2025-07-24 Thread Fiona Ebner
Discard will only work when the setting is applied to all nodes in the throttle->fmt->file chain. Fixes: 2ea50f8b ("blockdev: add helpers to generate blockdev commandline") Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/Blockdev.pm| 10 +++ src/test/cfg2cmd/aio.conf.cmd

Re: [pve-devel] [PATCH qemu-server 1/2] drive device: fix regression with missing '/dev/disk/by-id' paths

2025-07-24 Thread Hannes Duerr
it seems to me that the patch does not apply on the latest master. Does this patch require some other patch be build upon? On 7/23/25 1:11 PM, Fiona Ebner wrote: With the switch to '-blockdev', it is necessary to explicitly specify the device ID for SCSI drives, see also [0]. Otherwise, the dev

[pve-devel] [PATCH qemu-server v3 6/6] test: adapt all tests to use verbose disk size suffixes

2025-07-24 Thread Fiona Ebner
The 'disk-size' format in the JSON schema in pve-common was changed to print more verbose, non-ambiguous disk size suffixes. While the previous commit changed the necessary test cases to not fail, adapt all tests to match how configurations are actually written now. Add a dedicated restore test wh

[pve-devel] [PATCH pve-docs 2/2] Info on RNG required for UEFI/netboot

2025-07-24 Thread Jérôme Avond
--- qm.conf.5-opts.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qm.conf.5-opts.adoc b/qm.conf.5-opts.adoc index ce45ca7..401bfdb 100644 --- a/qm.conf.5-opts.adoc +++ b/qm.conf.5-opts.adoc @@ -107,6 +107,8 @@ by the guest firmware (BIOS/UEFI). If you require multiple disks for bootin

[pve-devel] [PATCH pve-docs 1/2] Add informations on PXE/iPXE/HTTP boot with OVMF uEFI

2025-07-24 Thread Jérôme Avond
--- qm.adoc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/qm.adoc b/qm.adoc index 0548c46..d60e16c 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1136,6 +1136,16 @@ you need to set the client resolution in the OVMF menu (which you can reach with a press of the ESC button during boot),

[pve-devel] [PATCH container 0/1] Doc to enable PXE/iPXE/HTTP boot / OVMF

2025-07-24 Thread Jérôme Avond
*** BLURB HERE *** Jérôme Avond (1): Add informations on PXE/iPXE/HTTP boot with OVMF uEFI qm.adoc | 10 ++ 1 file changed, 10 insertions(+) -- 2.43.0 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bi

[pve-devel] [PATCH pve-docs 0/2] Document the need of RNG for UEFI/netboot

2025-07-24 Thread Jérôme Avond
*** BLURB HERE *** Jérôme Avond (2): Add informations on PXE/iPXE/HTTP boot with OVMF uEFI Info on RNG required for UEFI/netboot qm.adoc | 10 ++ qm.conf.5-opts.adoc | 2 ++ 2 files changed, 12 insertions(+) -- 2.43.0 ___ p

[pve-devel] [PATCH container 1/1] Add informations on PXE/iPXE/HTTP boot with OVMF uEFI

2025-07-24 Thread Jérôme Avond
--- qm.adoc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/qm.adoc b/qm.adoc index 0548c46..d60e16c 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1136,6 +1136,16 @@ you need to set the client resolution in the OVMF menu (which you can reach with a press of the ESC button during boot),

[pve-devel] [PATCH container 1/1] Add informations on PXE/iPXE/HTTP boot with OVMF uEFI

2025-07-24 Thread Jérôme Avond
--- qm.adoc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/qm.adoc b/qm.adoc index 0548c46..d60e16c 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1136,6 +1136,16 @@ you need to set the client resolution in the OVMF menu (which you can reach with a press of the ESC button during boot),

[pve-devel] [PATCH container 0/1] Doc to enable PXE/iPXE/HTTP boot / OVMF

2025-07-24 Thread Jérôme Avond
*** BLURB HERE *** Jérôme Avond (1): Add informations on PXE/iPXE/HTTP boot with OVMF uEFI qm.adoc | 10 ++ 1 file changed, 10 insertions(+) -- 2.43.0 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bi

Re: [pve-devel] [PATCH cluster/network 0/6] Add global locking and configuration rollback to SDN configuration

2025-07-24 Thread Gabriel Goller
Superseded-by: https://lore.proxmox.com/pve-devel/20250724141730.468243-1-g.gol...@proxmox.com/ ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH network v2 0/5] Add global locking and configuration rollback to SDN configuration

2025-07-24 Thread Gabriel Goller
## Introduction This patch series lays the groundwork for the Proxmox Datacenter Manager SDN/EVPN integration on the Proxmox VE side by introducing global locking for the SDN configuration. It is intended to be used by the PDM implementation to prevent concurrent changes to the SDN configuration,

[pve-devel] [PATCH network v2 2/5] api: add lock-secret parameter to all api calls

2025-07-24 Thread Gabriel Goller
From: Stefan Hanreich The parameter is optional, so all existing create/update/delete invocations can work as before, only failing if the global lock is currently set. This ensures backwards-compatibility with the existing calls to the API in the frontend. If the lock is set, users will get an er

[pve-devel] [PATCH network v2 5/5] api: add rollback endpoint

2025-07-24 Thread Gabriel Goller
From: Stefan Hanreich This adds the functionality of rolling back the pending configuration to the currently running configuration, resetting all changes made since last applying the SDN configuration. This is mainly thought as an escape hatch for failed PDM transactions. You can invoke the endp

[pve-devel] [PATCH network v2 1/5] sdn: add global lock for configuration

2025-07-24 Thread Gabriel Goller
From: Stefan Hanreich Add a new cluster-wide lock for SDN that prevents any changes to the configuration if the generated lock-secret is not provided. It works by generating and storing a secret in sdn/.lock which gets checked by lock_sdn_config on every invocation. If the lock file exists, then

[pve-devel] [PATCH network v2 4/5] api: add lock and release endpoints for global configuration lock

2025-07-24 Thread Gabriel Goller
From: Stefan Hanreich This endpoint exposes the newly introduced global lock functionality via the API. It adds endpoints for acquiring and releasing the lock. Acquiring the lock is as simple as: pvesh create /cluster/sdn/lock The flag 'allow-pending' governs whether the lock should be acquir

[pve-devel] [PATCH network v2 3/5] api: add lock secret parameter to apply endpoint

2025-07-24 Thread Gabriel Goller
From: Stefan Hanreich Committing the configuration now requires a lock on the SDN configuration, which was not required before. This is to prevent concurrent callers from applying the SDN configuration, while the lock is held. If there is no lock set, then this function behaves the same as before

[pve-devel] [PATCH qemu-server 6/6] fix #6543: use qcow2 'discard-no-unref' option when using snapshot-as-volume-chain

2025-07-24 Thread Fiona Ebner
Without the 'discard-no-unref', a qcow2 file can grow beyond what 'qemu-img measure' reports, because of fragmentation. This can lead to IO errors with qcow2 on top of LVM storages, where the containing LV is allocated with that size. Guard enabling the option with having 'snapshot-as-volume-chain'

[pve-devel] [PATCH qemu-server 4/6] tests: image convert: properly set snapshot-as-volume-chain option

2025-07-24 Thread Fiona Ebner
The 'lvmqcow2_external_snapshot' test case uses qcow2 on top of LVM which can only be used with that option currently. Signed-off-by: Fiona Ebner --- src/test/run_qemu_img_convert_tests.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/run_qemu_img_convert_tests.pl b/src/test/run_

[pve-devel] [PATCH qemu-server 1/6] blockdev: helper to add common options

2025-07-24 Thread Fiona Ebner
Certain options like read-only need to be set on all nodes in the throttle->fmt->file chain to apply correctly and consistently. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/Blockdev.pm | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/PVE/QemuServ

[pve-devel] [PATCH qemu-server 5/6] tests: image convert: add tests where storages with 'snapshot-as-volume-chain' are the target

2025-07-24 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- src/test/run_qemu_img_convert_tests.pl | 39 +- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/src/test/run_qemu_img_convert_tests.pl b/src/test/run_qemu_img_convert_tests.pl index 4bfcf4fb..64c98327 100755 --- a/src/test/run_

[pve-devel] [PATCH qemu-server 3/6] tests: image convert: avoid hard-coded VM ID in result

2025-07-24 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- src/test/run_qemu_img_convert_tests.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/run_qemu_img_convert_tests.pl b/src/test/run_qemu_img_convert_tests.pl index a3c4cb59..3f7fb98e 100755 --- a/src/test/run_qemu_img_convert_tests.pl +

[pve-devel] [PATCH-SERIES qemu-server 0/6] blockdev and snapshot-as-volume-chain on LVM fixes

2025-07-24 Thread Fiona Ebner
First part is fixing discard in combination with -blockdev. The option needs to be set for the whole throttle->fmt->file chain to make it work. Second part is fixing bug #6543, qcow2 can grow beyond what qemu-img measure reports, because of fragmentation when the discard-no-unref option is not use

[pve-devel] [PATCH qemu-server] fix #6562: fix blockdev_replace for dir-based storages

2025-07-24 Thread Fabian Grünbichler
avoid calling qemu_blockdev_options on a volid+snapshot that is potentially already invalid if it has been removed/renamed by the storage layer. instead, generate the node name of the old node that we want to replace/remove directly, since nothing besides the name is used in this code path anyway..

[pve-devel] applied: [PATCH pve-docs] sdn: fabrics: remove duplicate paragraph in OSPF section

2025-07-24 Thread Thomas Lamprecht
On Thu, 17 Jul 2025 11:12:24 +0200, Hannes Laimer wrote: > Applied, thanks! [1/1] sdn: fabrics: remove duplicate paragraph in OSPF section commit: e043270aa8e99e6f8e1df6d2538f1870e183306b ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] [PATCH installer] install: adapt to changes in repository config when setting mirror

2025-07-24 Thread Shannon Sterz
newer isos ship with new deb822 style repository configurations in `/etc/apt/sources.list.d/debian.sources`. make the installer set the mirror in the correct file again. Signed-off-by: Shannon Sterz --- only did some rudimentary testing here, but fixing this up might be nice in the long run. Pr

Re: [pve-devel] [RFC storage] work-around #6543: do not use preallocation for qcow2 on top of LVM

2025-07-24 Thread Fiona Ebner
This is obsolete, see the recent discussion in the bugzilla entry. I'll work out other patches that use the discard-no-unref option to avoid the issue. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/list

[pve-devel] superseded: [PATCH manager 0/4] improvements to proxmox-network-interface-pinning

2025-07-24 Thread Stefan Hanreich
forgot to run make tidy... https://lore.proxmox.com/pve-devel/20250724093459.76397-1-s.hanre...@proxmox.com/T/#t On 7/24/25 11:32, Stefan Hanreich wrote: > Several improvements to the network interface pinning tool: > * interfaces are now iterated according to ifindex > * output of the mapping is

[pve-devel] [PATCH pve-manager v2 2/4] network-interface-pinning: improve printing mapping

2025-07-24 Thread Stefan Hanreich
Instead of printing a separate line for each altname, the tool now only prints one line per physical interface. The primary name is used as an identifier and the altnames are printed additionally in parentheses (if they exist). Additionally, the output is now sorted by ifindex (just as the pin orde

[pve-devel] [PATCH pve-manager v2 3/4] network-interface-pinning: add target-name parameter

2025-07-24 Thread Stefan Hanreich
If a specific interface is specified via the interface parameter, users can now additionally specify a target-name. This makes it easier for users to assign specific names to specific interfaces, according to their preferences. Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface

[pve-devel] [PATCH pve-manager v2 4/4] network-interface-pinning: add if prefix to list of allowed prefixes

2025-07-24 Thread Stefan Hanreich
'if' has been added as a possible prefix for physical nics in pve-common. Add it as a possible prefix for pinning network interfaces here as well. Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface_pinning.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) d

[pve-devel] [PATCH manager v2 0/4] improvements to proxmox-network-interface-pinning

2025-07-24 Thread Stefan Hanreich
Several improvements to the network interface pinning tool: * interfaces are now iterated according to ifindex * output of the mapping is now sorted and less verbose * users can now set a specific target name * if has been introduced as an additional legal prefix Still looking into removing the PH

[pve-devel] [PATCH pve-manager v2 1/4] network-interface-pinning: use ifindex as order for pinning

2025-07-24 Thread Stefan Hanreich
While ifindex is not guaranteed to be stable across reboots, it seems like a good enough heuristic for making sure interfaces with multiple ports are clamped together when pinning. Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface_pinning.pm | 6 +- 1 file changed, 5 inser

[pve-devel] [PATCH pve-manager 2/4] network-interface-pinning: improve printing mapping

2025-07-24 Thread Stefan Hanreich
Instead of printing a separate line for each altname, the tool now only prints one line per physical interface. The primary name is used as an identifier and the altnames are printed additionally in parentheses (if they exist). Additionally, the output is now sorted by ifindex (just as the pin orde

[pve-devel] [PATCH pve-manager 1/4] network-interface-pinning: use ifindex as order for pinning

2025-07-24 Thread Stefan Hanreich
While ifindex is not guaranteed to be stable across reboots, it seems like a good enough heuristic for making sure interfaces with multiple ports are clamped together when pinning. Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface_pinning.pm | 6 +- 1 file changed, 5 inser

[pve-devel] [PATCH pve-manager 3/4] network-interface-pinning: add target-name parameter

2025-07-24 Thread Stefan Hanreich
If a specific interface is specified via the interface parameter, users can now additionally specify a target-name. This makes it easier for users to assign specific names to specific interfaces, according to their preferences. Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface

[pve-devel] [PATCH pve-manager 4/4] network-interface-pinning: add if prefix to list of allowed prefixes

2025-07-24 Thread Stefan Hanreich
'if' has been added as a possible prefix for physical nics in pve-common. Add it as a possible prefix for pinning network interfaces here as well. Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface_pinning.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) d

[pve-devel] [PATCH manager 0/4] improvements to proxmox-network-interface-pinning

2025-07-24 Thread Stefan Hanreich
Several improvements to the network interface pinning tool: * interfaces are now iterated according to ifindex * output of the mapping is now sorted and less verbose * users can now set a specific target name * if has been introduced as an additional legal prefix Still looking into removing the PH

[pve-devel] [PATCH proxmox 1/2] http: factor out openssl verification callback

2025-07-24 Thread Dominik Csapak
with the 'tls' feature offers a callback method that can be used within openssl's `set_verify_callback` with a given expected fingerprint. The logic is inspired by our perl and proxmox-websocket-tunnel verification logic: Use openssl's verification if no fingerprint is pinned. If a fingerprint is

[pve-devel] [PATCH proxmox{, -backup, -websocket-tunnel} 0/4] unify openssl callback logic

2025-07-24 Thread Dominik Csapak
There are currently 3 slightly different implementations of the openssl verify callback in place. They differ in how an explicit fingerprint would be checked: * pbs-client: if verification was on, a valid certificate would trump a wrong epxlicit fingerprint * proxmox-websocket-tunnel: if an expl

[pve-devel] [PATCH proxmox-backup 1/1] pbs-client: use proxmox-https openssl callback

2025-07-24 Thread Dominik Csapak
instead of implementing it here. This changes the behavior when giving a fingerprint explicitly when the certificate chain is trusted by openssl. Previously this would be accepted due to openssls checks, regardless if the given fingerprint would match or not. With this patch, a given fingerprint h

[pve-devel] [PATCH proxmox 2/2] client: use proxmox-http's openssl verification callback

2025-07-24 Thread Dominik Csapak
This changes the validation logic by always checking the fingerprint of the leaf certificate, ignoring the openssl verification if a fingerprint is configured. This now aligns with our perl implementation and the one for proxmox-websocket-tunnel. Before, a valid certificate chain would have preced

[pve-devel] [PATCH proxmox-websocket-tunnel 1/1] use proxmox-http's openssl callback

2025-07-24 Thread Dominik Csapak
no functional change intended, since the callback there should implement the same behavior. With this, we can drop the dependency on itertools. Signed-off-by: Dominik Csapak --- Cargo.toml | 3 +-- src/main.rs | 67 + 2 files changed, 28 ins

[pve-devel] [PATCH v3 manager] api: create pool: force first character to be a letter for new pools

2025-07-24 Thread Fiona Ebner
Currently, the first character can also be a digit, '.', '-', or '_'. Almost all other configuration IDs in Proxmox VE require starting with a letter, so force this for new pool names too. A pool with ID '0' can be added, but not parsed, because it will evaluate to false in PVE/AccessControl.pm's

Re: [pve-devel] [PATCH docs] pvecm, network: add section on corosync over bonds

2025-07-24 Thread Daniel Herzig
Thanks for documenting this! I'd even go one step further and discourage the use of bonds in one of the sections of 'Cluster Network' in `pvecm.adoc` as well. Best with a link to the new 'Corosync over Bonds' section, with your decent explanation. That way it would be more difficult to miss fo