[pve-devel] TrueNAS Storage Plugin

2025-05-12 Thread Lorne Guse via pve-devel
--- Begin Message --- I'm working on an update to https://github.com/TheGrandWazoo/freenas-proxmox My repo can be found here: https://github.com/boomshankerx/proxmox-truenas I'm considering writing a pure TrueNAS plugin to fully utilize their WebSocket API. I think I have a reasonable grasp on

Re: [pve-devel] [PATCH qemu-server 02/14] blockdev: cmdline: convert drive to blockdev syntax

2025-05-12 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- - > (for example, they are an "size" option on drive not existing on > blockdev for example, I have wrote details on the patch 3/14.) >>I do think we still need the size (would need to be tested), because >>OVMF would get confused when the image is padded/too large. The >>com

[pve-devel] [PATCH pve_flutter_frontend] ui: enable noVNC console on iOS

2025-05-12 Thread Shan Shaji
This patch enables the noVNC console view on iOS devices. It also includes a refactor of the function responsible for displaying the webview. Additionally, an `AppBar` has been added to the console view on iOS to allow users to easily close the view. Signed-off-by: Shan Shaji --- lib/widgets/pve

Re: [pve-devel] [RFC qemu 1/1] block/rbd: add @keyring-file option to BlockdevOptionsRbd

2025-05-12 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > crush_location=host:myhost|datacenter:mydc > read_from_replica=localize >>Those can/should simply be set in the storage's ceph.conf, or do they >>need to be different per-volume or per-VM? read_from_replica=localize ---> it's global for the whole storage in ceph.cfg cru

Re: [pve-devel] [RFC qemu 1/1] block/rbd: add @keyring-file option to BlockdevOptionsRbd

2025-05-12 Thread Fiona Ebner
Am 12.05.25 um 15:39 schrieb DERUMIER, Alexandre: > Am 12.05.25 um 12:57 schrieb DERUMIER, Alexandre: >> for blockdev, do we still use a ceph config file in /var/run for >> potential others rbd client options ? > >>> Not currently, but we can add that later if we consider it worth it. >>> We >>> w

Re: [pve-devel] [RFC qemu 1/1] block/rbd: add @keyring-file option to BlockdevOptionsRbd

2025-05-12 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Am 12.05.25 um 12:57 schrieb DERUMIER, Alexandre: > for blockdev, do we still use a ceph config file in /var/run for > potential others rbd client options ? >>Not currently, but we can add that later if we consider it worth it. >>We >>would need to merge with the storage's a

Re: [pve-devel] [RFC storage 2/3] iscsi direct plugin: implement method to get qemu blockdevice options

2025-05-12 Thread Fiona Ebner
Am 09.05.25 um 16:15 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > > for me, it fails with > VM 102 qmp command 'blockdev-add' failed - LUN is write protected > but adding as a drive fails. Will need to investigate. After fixing up my ACLs on the iSCSI server-side, attaching the bloc

[pve-devel] [PATCH manager 3/5] test: adapt tests to use verbose disk size suffixes

2025-05-12 Thread Fiona Ebner
The 'disk-size' format in the JSON schema in pve-common was changed to print more verbose, non-ambiguous disk size suffixes. Adapt the tests to match how configurations are actually written now. Bump the corresponding build-dependency in d/control. Signed-off-by: Fiona Ebner --- debian/control

Re: [pve-devel] [RFC common/manager/qemu-server 0/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB

2025-05-12 Thread Fiona Ebner
Am 12.05.25 um 14:41 schrieb Fiona Ebner: > Maybe best is to wait for PVE 9 with this and do a parse+write for all > guest configs (including their snapshots) in the pve8to9 script? The > change also breaks backwards migration to a node that doesn't > understand the new suffix. If we decide on tha

[pve-devel] [PATCH qemu-server 4/5] test: fix tests for changes when printing disk size suffix

2025-05-12 Thread Fiona Ebner
The 'disk-size' format in the JSON schema in pve-common was changed to print more verbose, non-ambiguous disk size suffixes. This requires adapting some tests here. Bump the corresponding build-dependency in d/control. Signed-off-by: Fiona Ebner --- debian/control | 2 +

[pve-devel] [PATCH manager 2/5] vzdump: use verbose size suffix when logging archive file size

2025-05-12 Thread Fiona Ebner
The single-letter suffixes are ambiguous and especially in the context of disks, the powers of ten are usually used. Use exact suffixes instead when logging the archive file size. Signed-off-by: Fiona Ebner --- PVE/VZDump.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --g

[pve-devel] [RFC common/manager/qemu-server 0/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB

2025-05-12 Thread Fiona Ebner
The single-letter suffixes are ambiguous and especially in the context of disks, the powers of ten are usually used. Proxmox VE uses multiples of 1024 however. By adapting format_size() to use the verbose suffixes all newly written or re-written sizes will use the more verbose/explicit suffix. The

[pve-devel] [PATCH common 1/5] fix #3900: schema: support and prefer sizes with verbose suffixes {K, M, G, T}iB

2025-05-12 Thread Fiona Ebner
The single-letter suffixes are ambiguous and especially in the context of disks, the powers of ten are usually used. Proxmox VE uses multiples of 1024 however. By adapting format_size() to use the verbose suffixes all newly written or re-written sizes will use the more verbose/explicit suffix. The

Re: [pve-devel] [PATCH docs 1/7] pvecm: drop notes about old version incompatibilities

2025-05-12 Thread Thomas Lamprecht
Am 07.05.25 um 17:22 schrieb Kevin Schneider: > On 29.04.25 15:57, Aaron Lauterer wrote: >> Signed-off-by: Aaron Lauterer >> --- >> pvecm.adoc | 12 >> 1 file changed, 12 deletions(-) >> >> diff --git a/pvecm.adoc b/pvecm.adoc >> index 18f7389..47e42e2 100644 >> --- a/pvecm.adoc >>

Re: [pve-devel] [RFC qemu 1/1] block/rbd: add @keyring-file option to BlockdevOptionsRbd

2025-05-12 Thread Fiona Ebner
Am 12.05.25 um 12:57 schrieb DERUMIER, Alexandre: > for blockdev, do we still use a ceph config file in /var/run for > potential others rbd client options ? Not currently, but we can add that later if we consider it worth it. We would need to merge with the storage's already existing ceph.conf and

Re: [pve-devel] [RFC qemu 1/1] block/rbd: add @keyring-file option to BlockdevOptionsRbd

2025-05-12 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- for blockdev, do we still use a ceph config file in /var/run for potential others rbd client options ? Message initial De: Fiona Ebner À: pve-devel@lists.proxmox.com Cc: alexandre.derum...@groupe-cyllene.com Objet: [RFC qemu 1/1] block/rbd: add @keyring-f

[pve-devel] applied: [PATCH storage] esxi plugin: remove invalid fixme

2025-05-12 Thread Wolfgang Bumiller
applied, thanks On Fri, May 09, 2025 at 01:31:59PM +0200, Fiona Ebner wrote: > No other plugin activates the storage inside the path() method either. > The caller needs to ensure that the storage is activated before using > the result of path(). > > Signed-off-by: Fiona Ebner > --- > src/PVE/St

Re: [pve-devel] SPAM: RE: [!!ACHTUNG extern!!] - Re: SPAM: [PATCH pve-network v4 1/2] ipam: add Nautobot plugin - range workaround questions

2025-05-12 Thread Hannes Duerr
On 5/9/25 11:34, lou.lecriv...@wdz.de wrote: Re, Ok, thanks for clarifying. Indeed the offset parameter is ineffective (I have looked at the Nautobot code this morning). Tbqh I don't really like having to create then delete an object in Nautobot for this, but I guess there's no other way, gi

[pve-devel] [PATCH docs] fix #6388: disk health: sync list of scanned devices

2025-05-12 Thread Fabian Grünbichler
taken straight from the man page. Signed-off-by: Fabian Grünbichler --- Notes: switched to a list to avoid weird reflows in the middle of device paths, but not too happy about that either.. pve-disk-health-monitoring.adoc | 13 ++--- 1 file changed, 10 insertions(+), 3 deletion