[pve-devel] superseded: [PATCH qemu-server] virtiofs: prevent issue with Windows OS and too many files

2025-05-02 Thread Fiona Ebner
v2 here: https://lore.proxmox.com/pve-devel/20250502142133.59401-1-f.eb...@proxmox.com/ ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 qemu-server] virtiofs: prevent issue with Windows OS and too many files

2025-05-02 Thread Fiona Ebner
As reported in the community forum [0] and the virtio-win project [1], virtiofsd will run into its open file limit when used with a Windows guest that reads too many files. It's also reported that the issue does not occur with Linux guests and a workaround is using '--inode-file-handles=mandatory'

Re: [pve-devel] [PATCH qemu-server] virtiofs: prevent issue with Windows OS and too many files

2025-05-02 Thread Markus Frank
On 2025-05-02 14:13, Fiona Ebner wrote: Am 02.05.25 um 13:52 schrieb Markus Frank: On 2025-04-28 12:17, Fiona Ebner wrote: As reported in the community forum [0] and the virtio-win project [1], virtiofsd will run into its open file limit when used with a Windows guest that reads too many fil

Re: [pve-devel] [PATCH qemu-server] virtiofs: prevent issue with Windows OS and too many files

2025-05-02 Thread Fiona Ebner
Am 02.05.25 um 13:52 schrieb Markus Frank: > On 2025-04-28 12:17, Fiona Ebner wrote: >> As reported in the community forum [0] and the virtio-win project [1], >> virtiofsd will run into its open file limit when used with a Windows >> guest that reads too many files. It's also reported that the issu

[pve-devel] [PATCH proxmox_dart_api_client 1/1] fix typos

2025-05-02 Thread Michael Köppl
In addition to user-facing errors, a few internal variable names are also fixed. Signed-off-by: Michael Köppl --- lib/src/client.dart | 2 +- lib/src/handle_ticket_response.dart | 7 --- lib/src/models/pve_cluster_resources_model.dart | 4 ++-- lib/src

[pve-devel] [PATCH pve_flutter_frontend 1/2] fix typos

2025-05-02 Thread Michael Köppl
Signed-off-by: Michael Köppl --- While reviewing another series, I noticed a few typos in user-facing errors. While I was at it, also fixed typos for a few variables. README.md| 2 +- lib/pages/main_layout_slim.dart | 2 +- lib/widgets/pve

[pve-devel] [PATCH pve_flutter_frontend 2/2] ui: make LXC containers naming more consistent

2025-05-02 Thread Michael Köppl
To avoid confusion for users, consistent naming for LXC containers is applied. Since the main screen uses the plural "Virtual Machines", LXC containers is now also plural. Signed-off-by: Michael Köppl --- lib/pages/main_layout_slim.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [pve-devel] [PATCH qemu-server] virtiofs: prevent issue with Windows OS and too many files

2025-05-02 Thread Markus Frank
Hello, On 2025-04-28 12:17, Fiona Ebner wrote: As reported in the community forum [0] and the virtio-win project [1], virtiofsd will run into its open file limit when used with a Windows guest that reads too many files. It's also reported that the issue does not occur with Linux guests and a wor

Re: [pve-devel] [PATCH flutter_frontend 1/1] fix #4976: ui: Nodes offline

2025-05-02 Thread Michael Köppl
The commit message is not very descriptive. Also, please run dart format on these changes. There are some wrong indentations, missing spaces, trailing spaces, etc. I also added 3 comments inline. Apart from that, I tested this by manually stopping a node I was currently looking at in the node

Re: [pve-devel] [RFC manager 1/2] fix #5244 pveceph: install: add new repository for offline installation

2025-05-02 Thread Christoph Heiss
Tested both patches on a fresh PVE 8.4 installation, setting up Ceph by manually providing a repo in /etc/apt/sources.list.d/ and then installing it - through the web interface and - with `pveceph -repository offline -version squid` Tested-by: Christoph Heiss On Wed Apr 23, 2025 at 3:28 PM CEST,

Re: [pve-devel] [PATCH dart_api_client 1/1] fix #4976: Request errors are

2025-05-02 Thread Michael Köppl
Hi, thanks for tackling this. Noticed a few small things. Find the comments inline. Generally, please run dart format on these changes. Every changed block contains wrong indentation. Also, the commit message needs to be fixed. On 4/29/25 15:16, Alexander Abraham wrote: This commit adds more

Re: [pve-devel] [PATCH ha-manager 09/15] manager: apply colocation rules when selecting service nodes

2025-05-02 Thread Fiona Ebner
Am 30.04.25 um 13:09 schrieb Daniel Kral: > On 3/25/25 16:12, Daniel Kral wrote: >>   sub select_service_node { >> -    my ($groups, $online_node_usage, $sid, $service_conf, >> $current_node, $try_next, $tried_nodes, $maintenance_fallback, >> $best_scored) = @_; >> +    # TODO Cleanup this signatur

Re: [pve-devel] [PATCH pve_flutter_frontend] widgets: migrate from ButtonBar to OverflowBar

2025-05-02 Thread Michael Köppl
On 4/24/25 18:25, Shan Shaji wrote: The `ButtonBar` widget has been deprecated as of Flutter v3.21.0-10.0.pre. This patch replaces instance of `ButtonBar` with `OverflowBar`. Signed-off-by: Shan Shaji Quickly tested this by comparing the behavior of the previously implemented ButtonBar and t