Re: [pve-devel] [PATCH storage 2/2] fix #6224: disks: get: set timeout for retrieval of SMART stat data

2025-04-14 Thread Daniel Kral
Thanks for the review, Max! :) On 4/11/25 18:04, Max Carrara wrote: On Fri Apr 11, 2025 at 5:08 PM CEST, Daniel Kral wrote: As mentioned in the Bugzilla and indicated above, I haven't found any clear indicator for this happening besides that the most affected devices seem to be USB devices, whi

[pve-devel] [PATCH proxmox-firewall 1/2] firewall: use proxmox_log

2025-04-14 Thread Stefan Hanreich
The firewall did not yet use proxmox-log as its logging provider. Adapt the existing code to setup logging via proxmox-log over the current custom solution and import proxmox-log in all files as an alias to the log cate. This commit removes the ability to debug proxmox-firewall via running it in t

Re: [pve-devel] [PATCH v4 pve-common 01/12] introduce PVE::Path

2025-04-14 Thread Wolfgang Bumiller
Just so this is up to date, I noted an API weirdness off list: `path_push()` and `path_pop()` are exactly the same - API wise - as `path_join()` and `path_parent()` - they return a new string. This is not how you'd expect push to work. Given that *perl's* `push` uses a by-reference parameter, we s

[pve-devel] [PATCH pve-docs 1/1] firewall: update 'useful commands' section with new subcommands

2025-04-14 Thread Stefan Hanreich
Migrating proxmox-firewall to the proxmox_log crate has removed the RUST_LOG environment variable, among other things. Additionally, the proxmox-firewall binary now has subcommands for dumping the generated firewall ruleset. Update the documentation to provide information on how to use the new subc

[pve-devel] [PATCH docs/proxmox-firewall 0/3] migrate proxmox-firewall to proxmox-log + introduce subcommands

2025-04-14 Thread Stefan Hanreich
Since we now have proxmox-log as the standard crate for logging purposes, migrate proxmox-firewall to the new logging crate. The old logging setup was also tied with the debugging mechanisms described in the documentation. I used that opportunity to implement specific subcommands for debugging pro

[pve-devel] [PATCH proxmox-firewall 2/2] firewall: add subcommands to proxmox-firewall binary

2025-04-14 Thread Stefan Hanreich
pve-firewall supports several subcommands for starting / stopping the firewall, as well as debugging. proxmox-firewall currently only ran in foreground when executed and had no real means of dumping the generated ruleset other than running it with log level trace and capturing the log output. The

[pve-devel] [PATCH pve-kernel] cherry-pick additional fix for AMD Epyc genua systems

2025-04-14 Thread Stoiko Ivanov
reports in our community forum say, that some systems still run into a boot-loop with the latest proxmox-kernel-6.14 (6.14.0-2): https://forum.proxmox.com/threads/164497/post-762978 Pulling in this patch here (or preventing the module from being loaded) fixes the issue for them. As our test-system

Re: [pve-devel] [PATCH v1 pve-storage 8/8] pluginbase: document import and export methods

2025-04-14 Thread Wolfgang Bumiller
On Tue, Apr 01, 2025 at 11:40:14AM +0200, Fiona Ebner wrote: > Am 01.04.25 um 10:40 schrieb Fabian Grünbichler: > > On March 26, 2025 3:20 pm, Max Carrara wrote: > >> +=head3 $plugin->volume_export(\%scfg, $storeid, $fh, $volname, $format [, > >> $snapshot, $base_snapshot, $with_snapshots]) > >> +

Re: [pve-devel] [RFC PATCH 2/2] common: btrfs: lower minimum amount of disks for raid10 to 2

2025-04-14 Thread Christoph Heiss
On Fri Jan 10, 2025 at 6:00 PM CET, Daniel Kral wrote: > As the installer allows single-disk RAID0 configurations and BTRFS > allows to create a filesystem with the RAID10 profile with only two > disks since kernel version 5.15 [0], lower the minimum amount of disks > the installer requires for a B

[pve-devel] [PATCH docs] calendar-events: add a note about `systemd-analyze calendar`

2025-04-14 Thread Shannon Sterz
this is mentioned in the `systemd.time(7)` manpage, but adding it here to should give it more exposure. it's very handy and hopefully avoids some frustration for users less familiar with calendar events. Signed-off-by: Shannon Sterz --- calendar-events.adoc | 5 + 1 file changed, 5 insertion

Re: [pve-devel] [PATCH manager 1/1] fix #6311: ui: prevent consent text from showing twice for oidc

2025-04-14 Thread Gabriel Goller
Oof, didn't test with OIDC, my bad. Not an OIDC expert, so would be nice if someone else chimes in, but it works as advertised with a simple keycloak server setup. Consider: Tested-by: Gabriel Goller ___ pve-devel mailing list pve-devel@lists.proxm

Re: [pve-devel] [RFC PATCH 1/2] install: btrfs: fix raid level falling back to single mode

2025-04-14 Thread Christoph Heiss
On Fri Jan 10, 2025 at 6:00 PM CET, Daniel Kral wrote: > From a user's perspective, the BTRFS single mode has been removed since > d85180e ("tui: rename raid levels 0/1 to align with GUI installer"). The > user can now only select at least the "RAID0" level, but if a user > selects any raid level w

[pve-devel] [PATCH qemu-server] fix #6317: backup: use correct cleanup_fleecing_images helper

2025-04-14 Thread Wolfgang Bumiller
The local one is specific for `allocate_fleecing_images` and has a comment stating to use the one from `PVE::QemuConfig` in all other cases. The `cleanup` sub already called this, but only if the VM was running. We do allocate fleecing images for previously-stopped VMs as well, though, so we also

Re: [pve-devel] [PVE-User] Proxmox VE 8.4 released!

2025-04-14 Thread Federico Alves via pve-devel
--- Begin Message --- How do we upgrade from 8 to 8.4 using apt or any command-line commands? On Wed, Apr 9, 2025 at 8:17 AM Thomas Lamprecht wrote: > Hi All! > > We are excited to announce that our latest software version 8.4 for > Proxmox Virtual Environment is now available for download. This

Re: [pve-devel] [PATCH v1 pve-storage 7/8] pluginbase: document volume operations

2025-04-14 Thread Wolfgang Bumiller
On Wed, Apr 02, 2025 at 06:32:14PM +0200, Max Carrara wrote: > On Mon Mar 31, 2025 at 5:12 PM CEST, Fabian Grünbichler wrote: > > On March 26, 2025 3:20 pm, Max Carrara wrote: > > > Add docstrings for the following methods: > > > - list_volumes > > > - get_volume_attribute > > > - update_volume_att