[pve-devel] [RFC pve-kernel] add disable_write_zeroes quirk for Crucial T700 and T705

2025-03-19 Thread Stoiko Ivanov
The patch seems to indeed improve the performance of BLKZEROOUT and other operations that use write_zeroes for both drives. Tested with LVM-thick LVs on both drives, as LVM seems to pass-through the write_zeroes_max_bytes property (going by the output of: /sys/block/nvmeXn1/queue/write_zeroes_max_

[pve-devel] [PATCH qemu] revert hpet changes to fix performance regression

2025-03-19 Thread Fiona Ebner
As reported in the community forum [0][1], QEMU processes for Linux guests would consume more CPU on the host after an update to QEMU 9.2. The issue was reproduced and bisecting pointed to QEMU commit f0ccf77078 ("hpet: fix and cleanup persistence of interrupt status"). Some quick experimentation

Re: [pve-devel] [PATCH access-control v3 1/1] fix #4234: add library functions for openid optional userinfo request

2025-03-19 Thread Thomas Skinner
On Mon, Mar 17, 2025 at 7:12 AM Fabian Grünbichler wrote: > > On March 6, 2025 4:20 pm, Mira Limbeck wrote: > > > > > > On 2/8/25 06:42, Thomas Skinner wrote: > >> Signed-off-by: Thomas Skinner > >> --- > >> src/PVE/API2/OpenId.pm | 6 +- > >> src/PVE/Auth/OpenId.pm | 7 +++ > >> 2 files

Re: [pve-devel] [PATCH access-control v3 1/1] fix #4411: openid: add logic for openid groups support

2025-03-19 Thread Thomas Skinner
On Tue, Mar 18, 2025 at 4:34 AM Mira Limbeck wrote: > > On 3/17/25 13:18, Fabian Grünbichler wrote: > > On February 13, 2025 12:03 pm, Fabian Grünbichler wrote: > >> > >>> Mira Limbeck hat am 12.02.2025 15:51 CET > >>> geschrieben: > >>> > >>> > >>> On 2/11/25 06:40, Thomas Skinner wrote: >

Re: [pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

2025-03-19 Thread Christoph Heiss
On Tue Mar 4, 2025 at 11:49 AM CET, Maximiliano Sandoval wrote: > Whenever a filesystem is selected we show the size selection stack page. > > At the moment entering any raid setup, then entering the Advanced > Options page and then selecting any non-raid setup will show the > raiddisk page since i

Re: [pve-devel] [PATCH-SERIES pve-network v3] Add Nautobot IPAM support

2025-03-19 Thread Lou Lecrivain via pve-devel
--- Begin Message --- Hannes, I appreciate the swift review. I talked with my colleague in Cc and there's no issue with being co-authors. So let's go forward with your proposition. Thank you for taking care of it! Best regards De : Hannes Dürr Envoyé : me

Re: [pve-devel] [!!ACHTUNG extern!!] - Re: [PATCH pve-network v3 1/3] ipam: nautobot: base plugin

2025-03-19 Thread Lou Lecrivain via pve-devel
--- Begin Message --- Re, Ok so. Answering on that. By default, the status "Active" already exists for fresh installs. However, since the users are free to define whatever status they want (and delete the pre-existing ones!), I thought it'd be best if we checked it did exist first. There could be

Re: [pve-devel] [PATCH proxmox-mail-forward 2/2] switch to proxmox-log

2025-03-19 Thread Gabriel Goller
On 18.03.2025 11:48, Fabian Grünbichler wrote: based on the rest of the discussion, this will be rebased on top of the builder from https://lore.proxmox.com/pve-devel/20250218161311.558674-2-g.gol...@proxmox.com/ ? yep ___ pve-devel mailing list p

Re: [pve-devel] [PATCH proxmox-i18n v2 2/2] make: add proxmox-datacenter-manager translations

2025-03-19 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > Maximiliano Sandoval writes: > >> Maximiliano Sandoval writes: >> >>> Maximiliano Sandoval writes: >>> Maximiliano Sandoval writes: > Maximiliano Sandoval writes: > >> The catalog-{lang}.mo files are generated only with strings that are

Re: [pve-devel] [PATCH pve-network v3 1/3] ipam: nautobot: base plugin

2025-03-19 Thread Hannes Dürr
On 3/6/25 12:08, lou.lecriv...@orange.fr wrote: [...] +sub verify_api { +my ($class, $plugin_config) = @_; + +my $url = $plugin_config->{url}; +my $namespace = $plugin_config->{namespace}; +my $headers = default_headers($plugin_config); + +# check that the namespace exists

Re: [pve-devel] [PATCH-SERIES pve-network v3] Add Nautobot IPAM support

2025-03-19 Thread Hannes Dürr
In general the plugin implementation seems sensible, the only thing I didn't quite understand is the need for `get_status_ip`, more on that inline. The series no longer applies to master, as there have been patches that add a fingerprint parameter to the API request [0]. For testing purposes I

Re: [pve-devel] [PATCH manager] ui: tag: only set lowercased tags

2025-03-19 Thread Dominik Csapak
On 3/19/25 09:58, Maximiliano Sandoval wrote: At the moment, the color of the preview tag won't match the final tag once it is added if the tag contained uppercase letters. With this patch the color in the tag being created will match the color of the final tag added to a guest. Signed-off-by: M

Re: [pve-devel] [RFC PATCH manager] WIP: api: implement node-independent bulk actions

2025-03-19 Thread Dominik Csapak
On 3/18/25 12:30, Stefan Hanreich wrote: This would be really interesting for applying the SDN configuration as well, where I'm currently calling the existing bulk-call. Really like the design with the start / check callbacks, that should make this quite flexible. On 3/18/25 11:39, Dominik Csapa

[pve-devel] [PATCH manager] ui: tag: only set lowercased tags

2025-03-19 Thread Maximiliano Sandoval
At the moment, the color of the preview tag won't match the final tag once it is added if the tag contained uppercase letters. With this patch the color in the tag being created will match the color of the final tag added to a guest. Signed-off-by: Maximiliano Sandoval --- www/manager6/form/Tag.

Re: [pve-devel] [PATCH proxmox-ve-rs 1/1] partial fix #6226: macros: add LDAP_UDP macro

2025-03-19 Thread Stefan Hanreich
On 3/19/25 09:50, Christoph Heiss wrote: > On Tue Mar 18, 2025 at 4:38 PM CET, Stefan Hanreich wrote: >> Add LDAP_UDP macro to the firewall to support LDAP implementations >> that use UDP as well, such as Windows AD [1] >> >> [1] >> https://learn.microsoft.com/de-de/troubleshoot/windows-server/

Re: [pve-devel] [PATCH manager] ui: do not split translatable strings

2025-03-19 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > Splitting the strings adds extra work to translators as they now have > less context to work with. > > Signed-off-by: Maximiliano Sandoval ping. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.pr

Re: [pve-devel] [PATCH proxmox-ve-rs 1/1] partial fix #6226: macros: add LDAP_UDP macro

2025-03-19 Thread Christoph Heiss
On Tue Mar 18, 2025 at 4:38 PM CET, Stefan Hanreich wrote: > Add LDAP_UDP macro to the firewall to support LDAP implementations > that use UDP as well, such as Windows AD [1] > > [1] > https://learn.microsoft.com/de-de/troubleshoot/windows-server/active-directory/config-firewall-for-ad-domains-and

Re: [pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

2025-03-19 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > Whenever a filesystem is selected we show the size selection stack page. > > At the moment entering any raid setup, then entering the Advanced > Options page and then selecting any non-raid setup will show the > raiddisk page since it is still the visible child. >

[pve-devel] applied-series: [PATCH proxmox-mail-forward 2/2] run rustfmt

2025-03-19 Thread Fabian Grünbichler
thanks On March 10, 2025 11:22 am, Maximiliano Sandoval wrote: > With rust 2024 edition. > > Signed-off-by: Maximiliano Sandoval > --- > src/main.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/main.rs b/src/main.rs > index 4662ffa..795b0f2 100644 > --- a/src/ma