Re: [pve-devel] [PATCH-SERIES pve-network v3] Add Nautobot IPAM support

2025-03-15 Thread Lou Lecrivain via pve-devel
--- Begin Message --- Re Hannes, You're welcome :) Sorry for the "from:", my mistake, must've slipped through before sending the patches (I may have forgot to signoff). Noted for the Co-developed-by. Would it be OK for you to edit that in or do I have to resend the patch series? MfG __

Re: [pve-devel] [PATCH-SERIES pve-network v3] Add Nautobot IPAM support

2025-03-15 Thread Hannes Dürr
sorry my mistake, it looked to me as if the mail did not go to the mailing list, but it did. On 3/6/25 12:08, lou.lecriv...@orange.fr wrote: From: Lou Lecrivain Following review from Hannes, I have made some improvements to the form of the code for the pve-network part. No functional changes

[pve-devel] [PATCH storage v3 1/4] add standard option for VM disk formats in file-based storages

2025-03-15 Thread Markus Frank
Signed-off-by: Markus Frank --- v3: * removed 'optional => 1' * changed description src/PVE/Storage/Plugin.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 65cf43f..c15dc44 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PV

[pve-devel] applied-series: [PATCH v2 1/2] isisd: fix bit flag collision in options field

2025-03-15 Thread Thomas Lamprecht
On 14/03/2025 10:52, Gabriel Goller wrote: > Resolve conflict between F_ISIS_UNIT_TEST and ISIS_OPT_DUMMY_AS_LOOPBACK > which were both using the same bit value (0x01). This collision caused > unit test mode to be unintentionally enabled when DUMMY_AS_LOOPBACK was set. > > Link: https://github.com

[pve-devel] [PATCH v4 qemu-server 10/11] blockdev: add backing_chain support

2025-03-15 Thread Alexandre Derumier via pve-devel
--- Begin Message --- We need to define name-nodes for all backing chain images, to be able to live rename them with blockdev-reopen For linked clone, we don't need to definebase image(s) chain. They are auto added with #block nodename. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm

Re: [pve-devel] [PATCH pve-network 1/5] controllers: fix maximum value for ASN

2025-03-15 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>According to my testing, when using the `autort` for RT auto- >>derivation >>(from the frr patch) causes issues because it doesn't work with 32 >>bits >>ASNs, effectively calling the fallback to restarting frr to apply the >>config (which ignores the autort instruction). ye

[pve-devel] [PATCH proxmox-perl-rs 3/3] pve: tfa: write char comparison more succinctly

2025-03-15 Thread Maximiliano Sandoval
Fixes the manual_pattern_char_comparison clippy lint. Signed-off-by: Maximiliano Sandoval --- pve-rs/src/tfa.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pve-rs/src/tfa.rs b/pve-rs/src/tfa.rs index 66dca3d..2cd7396 100644 --- a/pve-rs/src/tfa.rs +++ b/pve-rs/src/tfa