The split_list() helper will return a list, and assignment in scalar
context would result in the number of elements, instead of having the
desired array reference, that the BTRFS plugin expects.
Signed-off-by: Fiona Ebner
---
src/PVE/CLI/pvesm.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletio
I want to apply the series with a small follow-up, i.e.
> btrfs: avoid superfluous check in foreach_snapshot_of_subvol() helper
>
> The helper iterates with the BTRFS_SNAPSHOT_REGEX regular expression,
> so there will always be a snapshot name.
>
> Signed-off-by: Fiona Eb
For a 'raw' volume, the path includes the '/disk.raw' suffix, but the
check expects the containing subvolume directory.
Signed-off-by: Fiona Ebner
---
src/PVE/Storage/BTRFSPlugin.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.p
I noticed that btrfs incremental export/import does not currently work
when testing Maximiliano's series[0]. While these fixes don't make it
work either, they should make life easier for a future developer
actually tackling that feature.
[0]:
https://lore.proxmox.com/pve-devel/20250219111740.2008
The subvolume itself cannot be included if there is a base snapshot
or the command would fail with e.g.
> ERROR: subvolume /mnt/btrfs/images/400/vm-400-disk-0 is not read-only
Signed-off-by: Fiona Ebner
---
src/PVE/Storage/BTRFSPlugin.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
On Thu Feb 20, 2025 at 3:37 PM CET, Alexander Abraham wrote:
> The Flutter frontend of PVE was not compilable for Android
> with the versions of different tools set in the project files.
> The versions of the tools causing this problem was updated
> and the app compiles for Android.
>
> Signed-off-
Am 20.02.25 um 18:50 schrieb Daniel Kral:
> On 2/20/25 15:46, Fiona Ebner wrote:
>> Am 11.02.25 um 17:08 schrieb Daniel Kral:
>>> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
>>> index ed5ede30..827e54b7 100644
>>> --- a/PVE/QemuMigrate.pm
>>> +++ b/PVE/QemuMigrate.pm
>>> @@ -158,15 +158,13
Am 11.02.25 um 17:07 schrieb Daniel Kral:
> == Possible squash ==
>
> I was unsure how granular the patches here should be, so I left it at
> the finest granularity to make reviewing easier, but there's room for
> squashing patches together:
>
> - qemu-server #10-#14,
> - pve-container #3-#5, and
Am 21.02.25 um 09:30 schrieb Daniel Kral:
> On 2/20/25 15:23, Fiona Ebner wrote:
>> Am 11.02.25 um 17:08 schrieb Daniel Kral:
>>> Asserts whether the target storage supports storing cloudinit images,
>>> i.e. VM images, before creating a cloudinit image on the target storage.
>>>
>>> Without the ch
Am 21.02.25 um 09:27 schrieb Daniel Kral:
> On 2/20/25 15:09, Fiona Ebner wrote:
>> Am 11.02.25 um 17:08 schrieb Daniel Kral:
>>> Since 0541eeb8 ("use property strings for drive options") the user input
>>> of a volume with allocation support must be a pair of a PVE-managed
>>> storage and an arbit
On 2/20/25 14:29, Fiona Ebner wrote:
Rest of the container patches also LGTM from a glance, but I know
they'll change in v3.
Thank you very much for the review and also the off-list help on this!
I'll still be waiting on comments about the squashing suggestions and if
some of the more indepen
On 2/20/25 15:23, Fiona Ebner wrote:
Am 11.02.25 um 17:08 schrieb Daniel Kral:
Asserts whether the target storage supports storing cloudinit images,
i.e. VM images, before creating a cloudinit image on the target storage.
Without the check in place, a cloudinit image can be created on the
stora
On 2/20/25 15:09, Fiona Ebner wrote:
Am 11.02.25 um 17:08 schrieb Daniel Kral:
Since 0541eeb8 ("use property strings for drive options") the user input
of a volume with allocation support must be a pair of a PVE-managed
storage and an arbitrary string (i.e. the volume name or the size of a
new d
13 matches
Mail list logo
