Re: [pve-devel] [PATCH access-control v2 1/1] fix #4411: openid: add logic for openid groups support

2025-02-05 Thread Thomas Skinner
On Fri, Jan 24, 2025 at 4:18 AM Fabian Grünbichler wrote: > > On December 24, 2024 9:24 pm, Thomas Skinner wrote: > > Signed-off-by: Thomas Skinner > > --- > > src/PVE/API2/OpenId.pm | 68 > > src/PVE/AccessControl.pm | 13 +--- > > src/PVE/Auth/Ope

[pve-devel] [PATCH network] sdn: factor out frr config generation and writing

2025-02-05 Thread Gabriel Goller
Previously the frr config generation and writing was only done in the evpn plugin. This means that it was not possible to create a standalone bgp and isis plugin without an evpn plugin in place. (The config would just never be written.) To fix this, factor out the frr generation and writing into a

Re: [pve-devel] [PATCH proxmox-i18n v2 2/2] make: add proxmox-datacenter-manager translations

2025-02-05 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > Maximiliano Sandoval writes: > >> The catalog-{lang}.mo files are generated only with strings that are >> relevant to the proxmox-datacenter-manager instead of the whole >> {lang}.po file. The msgmerge command will produce all strings containing >> in the {lang}.

Re: [pve-devel] [RFC v1 pve-storage 0/6] RFC: Tighter API Control for Storage Plugins

2025-02-05 Thread Max Carrara
On Wed Feb 5, 2025 at 12:17 PM CET, Wolfgang Bumiller wrote: > Overall thoughts - this is a bit much at once... > > 1) It doesn't build. The loader fails, claiming that `DirPlugin` is not > derived from `PVE::Storage::Plugin`. Presumably because you only > `require` it which does not set up the `@I

Re: [pve-devel] [PATCH patches 1/1] fix #6142: ui: dc options: allow custom CIDRs for migration network

2025-02-05 Thread Stefan Hanreich
somehow the repo in the title got messed up, this patch is for pve-manager. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH patches 1/1] fix #6142: ui: dc options: allow custom CIDRs for migration network

2025-02-05 Thread Stefan Hanreich
Sometimes the desired migration network is not configured on any network interfaces on the node. For instance, if there is a full-mesh network the CIDR for the router IPs is not configured on any network interface, but still a valid choice as migration network. This patch fixes this by allowing use

[pve-devel] applied-series: [PATCH manager v1 1/2] ui: qemu: add vnc clipboard hint for migration

2025-02-05 Thread Fiona Ebner
Am 27.01.25 um 12:57 schrieb Markus Frank: > Signed-off-by: Markus Frank applied both patches, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container] api: restore: keep not backed-up volumes

2025-02-05 Thread Fiona Ebner
Same rationale as in pve-manager commit 5f855ccf ("ui: restore: improve warning for restoring container with same ID"): it's surprising to (new) users that all owned mount point volumes are erased upon container restore, even those that are not currently selected for backup. This is different from

Re: [pve-devel] [PATCH docs v2 1/6] ceph: add anchors for use in troubleshooting section

2025-02-05 Thread Max Carrara
On Wed Feb 5, 2025 at 11:08 AM CET, Alexander Zeidler wrote: > Signed-off-by: Alexander Zeidler > --- > v2: > * add two missing anchors to be usable via xref > To keep things short: - Docs now build again (tested with both `make update` and `make deb`). - Installed the .deb packages on my devel

[pve-devel] [PATCH manager] fix #6138: ui: storage content: use locale for sorting filenames

2025-02-05 Thread Dominik Csapak
by using 'localeCompare'. Assume the files 'a', 'B' and 'c'. The current default sorting results in : 'B' 'a' 'c' (C collation) With this patch we use locale dependent sorting, so the browser/client setting controls how it's sorted. For example with english, the list becomes: 'a' 'B' 'c' Whic

[pve-devel] [PATCH pve-docs v3] fix #5644: Split the section on creating a swap partition on a ZVol.

2025-02-05 Thread Alexander Abraham
The section "SWAP on ZFS" was split into two parts. The first part contains general instructions on how to create a swap partition and how to set the level of "swappiness". The second part contains a warning about creating a swap partition on a ZFS volume.The official ZFS documentation, which has b

Re: [pve-devel] [RFC v1 pve-storage 2/6] rework plugin loading and registration mechanism

2025-02-05 Thread Wolfgang Bumiller
On Thu, Jan 30, 2025 at 03:51:20PM +0100, Max Carrara wrote: > This commit changes how plugins, both inbuilt and custom, are loaded > and registered by the `PVE::Storage` module from the ground up. > > This is done for mainly two reasons: > > 1. Unifying the plugin loading mechanism so that inbu

Re: [pve-devel] [RFC v1 pve-storage 3/6] introduce compile-time checks for prohibited sub overrides

2025-02-05 Thread Wolfgang Bumiller
On Wed, Feb 05, 2025 at 12:41:28PM +0100, Wolfgang Bumiller wrote: > I'd say this patch is the main thing to aid in API compatibility and > should be possible to do without all the refactoring before it? > > So whether we want to do this (one way or another) should probably be > decided separately

Re: [pve-devel] [RFC v1 pve-storage 3/6] introduce compile-time checks for prohibited sub overrides

2025-02-05 Thread Wolfgang Bumiller
I'd say this patch is the main thing to aid in API compatibility and should be possible to do without all the refactoring before it? So whether we want to do this (one way or another) should probably be decided separately from the rest of the series. The other deprecation attribute introduced in

Re: [pve-devel] [RFC v1 pve-storage 1/6] version: introduce PVE::Storage::Version

2025-02-05 Thread Wolfgang Bumiller
On Thu, Jan 30, 2025 at 03:51:19PM +0100, Max Carrara wrote: > The purpose of this module is to separate the handling of the Storage > API's version from the remaining code while also providing additional > mechanisms to handle changes to the Storage API more gracefully. > > The first such mechani

Re: [pve-devel] [RFC v1 pve-storage 0/6] RFC: Tighter API Control for Storage Plugins

2025-02-05 Thread Wolfgang Bumiller
Overall thoughts - this is a bit much at once... 1) It doesn't build. The loader fails, claiming that `DirPlugin` is not derived from `PVE::Storage::Plugin`. Presumably because you only `require` it which does not set up the `@ISA`... (Followed by a bunch of "Plugin 'foo' is already loaded" errors

Re: [pve-devel] [PATCH docs 1/6] ceph: add anchors for use in troubleshooting section

2025-02-05 Thread Alexander Zeidler
On Tue Feb 4, 2025 at 10:52 AM CET, Max Carrara wrote: > On Tue Feb 4, 2025 at 10:22 AM CET, Alexander Zeidler wrote: >> On Mon Feb 3, 2025 at 5:19 PM CET, Max Carrara wrote: >> > On Mon Feb 3, 2025 at 3:27 PM CET, Alexander Zeidler wrote: >> >> Signed-off-by: Alexander Zeidler >> >> --- >> > >> >

[pve-devel] [PATCH docs v2 6/6] pvecm: remove node: mention Ceph and its steps for safe removal

2025-02-05 Thread Alexander Zeidler
as it has already been missed in the past or the proper procedure was not known. Signed-off-by: Alexander Zeidler --- v2: * no changes pvecm.adoc | 47 +++ 1 file changed, 47 insertions(+) diff --git a/pvecm.adoc b/pvecm.adoc index cffea6d..a65736d 1

[pve-devel] [PATCH docs v2 4/6] ceph: osd: revise and expand the section "Destroy OSDs"

2025-02-05 Thread Alexander Zeidler
Existing information is slightly modified and retained. Add information: * Mention and link to the sections "Troubleshooting" and "Replace OSDs" * CLI commands (pveceph) must be executed on the affected node * Check in advance the "Used (%)" of OSDs to avoid blocked I/O * Check and wait until the

[pve-devel] [PATCH docs v2 5/6] ceph: maintenance: revise and expand section "Replace OSDs"

2025-02-05 Thread Alexander Zeidler
Remove redundant information that is already described in section “Destroy OSDs” and link to it. Mention and link to the troubleshooting section, as replacing the OSD may not fix the underyling problem. Mention that the replacement disk should be of the same type and size and comply with the reco

[pve-devel] [PATCH docs v2 1/6] ceph: add anchors for use in troubleshooting section

2025-02-05 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- v2: * add two missing anchors to be usable via xref pve-disk-health-monitoring.adoc | 1 + pveceph.adoc| 8 pvecm.adoc | 1 + 3 files changed, 10 insertions(+) diff --git a/pve-disk-health-monitoring.adoc b/p

[pve-devel] [PATCH docs v2 3/6] ceph: troubleshooting: revise and add frequently needed information

2025-02-05 Thread Alexander Zeidler
Existing information is slightly modified and retained. Add information: * List which logs are usually helpful for troubleshooting * Explain how to acknowledge listed Ceph crashes and view details * List common causes of Ceph problems and link to recommendations for a healthy cluster * Briefly d

[pve-devel] [PATCH docs v2 2/6] ceph: correct heading capitalization

2025-02-05 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- v2: * no changes pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 93c2f8d..90bb975 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -768,7 +768,7 @@ Nautilus: PG merging and autotuning].

Re: [pve-devel] [PATCH access-control] api: role: remove role references from acl rules on role deletion

2025-02-05 Thread Fiona Ebner
Am 05.02.25 um 10:21 schrieb Daniel Kral: > On 2/3/25 12:49, Fiona Ebner wrote: >> Am 04.12.24 um 16:11 schrieb Daniel Kral: >>> Let the API endpoint `DELETE /access/roles/{roleid}` or command >>> `pveum role delete ` remove any ACL rules in the user >>> configuration, which reference the removed r

Re: [pve-devel] [PATCH access-control] api: role: remove role references from acl rules on role deletion

2025-02-05 Thread Daniel Kral
On 2/3/25 12:49, Fiona Ebner wrote: Am 04.12.24 um 16:11 schrieb Daniel Kral: Let the API endpoint `DELETE /access/roles/{roleid}` or command `pveum role delete ` remove any ACL rules in the user configuration, which reference the removed role. Before this change, the removal of a role has caus