Re: [pve-devel] [PATCH pve-nvidia-vgpu-helper v2 3/4] add pve-nvidia-vgpu-helper and Makefile to make dependency installtion more convenient

2025-01-21 Thread Hannes Dürr
On 1/21/25 16:36, Thomas Lamprecht wrote: Am 21.01.25 um 11:47 schrieb Dominik Csapak: It's probably not a bad idea to install the packages for all installed kernel versions? (@Thomas ?) Yeah, would be definitively a nice UX enhancement. sounds good to me, will do. Not super sure about how

Re: [pve-devel] [PATCH pve-nvidia-vgpu-helper v2 3/4] add pve-nvidia-vgpu-helper and Makefile to make dependency installtion more convenient

2025-01-21 Thread Thomas Lamprecht
Am 21.01.25 um 11:47 schrieb Dominik Csapak: > It's probably not a bad idea to install the packages for all installed kernel > versions? (@Thomas ?) Yeah, would be definitively a nice UX enhancement. > Not super sure about how exactly DKMS works, but i think it tries to compile > for all instal

Re: [pve-devel] [PATCH docs] qm, vzdump: add notes regarding backups of windows and VSS

2025-01-21 Thread Aaron Lauterer
On 2025-01-21 13:08, Alexander Zeidler wrote: On Mon Jan 20, 2025 at 3:35 PM CET, Aaron Lauterer wrote: VSS in windows guests with additional backup software in the guest can cause problems. By now the guest agent does support to use a different VSS option. This way, one can switch to one t

Re: [pve-devel] [PATCH docs] qm, vzdump: add notes regarding backups of windows and VSS

2025-01-21 Thread Alexander Zeidler
On Mon Jan 20, 2025 at 3:35 PM CET, Aaron Lauterer wrote: > VSS in windows guests with additional backup software in the guest can > cause problems. By now the guest agent does support to use a different > VSS option. This way, one can switch to one that does not interfere with > other backup solut

Re: [pve-devel] [PATCH pve-nvidia-vgpu-helper v2 4/4] debian: add and install nvidia-vgpu systemd template unit file

2025-01-21 Thread Hannes Dürr
On 1/21/25 11:36, Dominik Csapak wrote: mhmm not sure if it's so good to reuse the exiting name of the nvidia service for this. also not sure how systemd likes it if there is a service 'foo.service' and a template 'foo@.service' (though my guess would be that it's not that big of an issue) i

Re: [pve-devel] [PATCH pve-nvidia-vgpu-helper v2 3/4] add pve-nvidia-vgpu-helper and Makefile to make dependency installtion more convenient

2025-01-21 Thread Dominik Csapak
looked (&tested) mostly the script itself, not at the Makefile Looks mostly OK to me, the only thing i noticed is that we only look at the current running kernel, maybe we should also check if the opt in kernel is installed? e.g. my test was: install pve + this package run 'pve-nvidia-vgpu-hel

Re: [pve-devel] [PATCH pve-nvidia-vgpu-helper v2 4/4] debian: add and install nvidia-vgpu systemd template unit file

2025-01-21 Thread Dominik Csapak
mhmm not sure if it's so good to reuse the exiting name of the nvidia service for this. also not sure how systemd likes it if there is a service 'foo.service' and a template 'foo@.service' (though my guess would be that it's not that big of an issue) i'd like to seee a distinct name for this (ma

[pve-devel] [PATCH pve-manager v2 1/1] debian/control: add pve-nvidia-vgpu-helper as dependency

2025-01-21 Thread Hannes Duerr
the package ships a script that helps to set up Nvidia vgpu drivers. Signed-off-by: Hannes Duerr --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 6c94df09..ab02fd76 100644 --- a/debian/control +++ b/debian/control @@ -89,6 +89,7 @@ Depe

[pve-devel] [PATCH pve-nvidia-vgpu-helper v2 4/4] debian: add and install nvidia-vgpu systemd template unit file

2025-01-21 Thread Hannes Duerr
Signed-off-by: Hannes Duerr --- debian/nvidia-vgpud@.service | 12 debian/rules | 3 +++ 2 files changed, 15 insertions(+) create mode 100644 debian/nvidia-vgpud@.service diff --git a/debian/nvidia-vgpud@.service b/debian/nvidia-vgpud@.service new file mode 100644

[pve-devel] [PATCH pve-nvidia-vgpu-helper v2 2/4] debian/control: add dependency for helper script

2025-01-21 Thread Hannes Duerr
Signed-off-by: Hannes Duerr --- debian/control | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/debian/control b/debian/control index 334bf25..4492b60 100644 --- a/debian/control +++ b/debian/control @@ -8,7 +8,8 @@ Homepage: https://www.proxmox.com Package: pve-nvidia-vgp

[pve-devel] [PATCH pve-nvidia-vgpu-helper v2 3/4] add pve-nvidia-vgpu-helper and Makefile to make dependency installtion more convenient

2025-01-21 Thread Hannes Duerr
we add the pve-nvidia-vgpu-helper script to make the installation of the required nvidia vgpu driver dependencies more convenient. We also add a Makefile to assist in building the debian package and installing the script Signed-off-by: Hannes Duerr --- Makefile | 54 +++

[pve-devel] [PATCH pve-nvidia-vgpu-helper v2 1/4] create a debian package to make the installation of Nvidia vGPU drivers more convenient

2025-01-21 Thread Hannes Duerr
Signed-off-by: Hannes Duerr --- debian/changelog | 5 + debian/control | 15 +++ debian/copyright | 14 ++ debian/rules | 8 debian/source/format | 1 + 5 files changed, 43 insertions(+) create mode 100644 debian/changelog create mod

[pve-devel] [PATCH manager/nvidia-vgpu-helper v2 0/5] reduce setup steps for nvidia vgpu drivers

2025-01-21 Thread Hannes Duerr
Changes in v2: * patches contain all changes to build new repository * make pve-manager depend on this package instead of the other way around * install the script to /usr/bin/ * rename the script to pve-nvidia-vgpu-helper because it is only relevant for PVE(the repository should therefore also b