--- Begin Message ---
>
> > > should this maybe have been vdisk_alloc and it just works by
> accident?
> It's not works fine with vdisk_alloc, because the volume need to be
> created without the size specified but with backing file param
> instead.
> (if I remember, qemu-img is looking at the ba
--- Begin Message ---
>
>
> > > should this maybe have been vdisk_alloc and it just works by
> accident?
> It's not works fine with vdisk_alloc, because the volume need to be
> created without the size specified but with backing file param
> instead.
> (if I remember, qemu-img is looking at the b
Signed-off-by: Christopher Bock
Christopher Bock (1):
add FORMAT_OPTIONS where it's referenced
pveceph.adoc | 4
pvesm.adoc | 4
pveum.adoc | 5 +
3 files changed, 13 insertions(+)
--
2.39.5
___
pve-devel mailing list
pve-devel@l
Am 10.01.25 um 18:05 schrieb Daniel Kral:
> The commit 37a1f42a introduced a conversion step for newly allocated
> volume disks to base volumes for VM templates. This wrongly excluded
> efidisk and tmpstate volumes from this conversion, even though those
> should be converted to base volumes too.
>
--- Begin Message ---
complained by lintian.
Signed-off-by: Jing Luo
---
dab | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dab b/dab
index 7771771..d79afe6 100755
--- a/dab
+++ b/dab
@@ -268,7 +268,7 @@ yourself.
=item I<--exclude
-A comma-separated list of pa
--- Begin Message ---
Il 10/01/2025 13:20, Udo Rader ha scritto:
Hi,
I have been using PVE with BTRFS as root on some nodes for some time now and
all in all it seems to work quite well. What is missing, however, is a deeper
integration into the user interface, for example.
Browsing through th
Am 10.01.25 um 10:32 schrieb DERUMIER, Alexandre:
>>> Maybe it could even be a bug then?
>
> Yes, it's a bug. I just think that libvirt currently only implement
> block-commit with disk blockdev on topnode.
>
> throttle group are not currently implement in libvirt (but I have seen
> some commi
As reported in the enterprise support, using arch aarch64 for a VM in
combination with a new enough Windows ostype would fail:
> qemu-system-aarch64: warning: driftfix 'slew' is not available with this
> machine
> qemu-system-aarch64: Property 'virt-5.1-machine.hpet' not found
Conditionalize set
Am 13.01.25 um 12:58 schrieb DERUMIER, Alexandre:
>
>
>>> For almost all QMP commands, we only need to care about the node
>>> that's
>>> inserted for the drive.
> (yes, that the throttle group in my implementation, and I have a fixed
> name, I'm reusing the "drive-(ide|scsi|virtio)x naming"
>
Am 13.01.25 um 11:47 schrieb DERUMIER, Alexandre via pve-devel:
>>> something like this was what I was afraid of 😉 this basically means
>>> we need to have some way to lookup the nodes based on the structure
>>> of the graph, which probably also means verifying that the structure
>>> matches the ex
> DERUMIER, Alexandre hat am 13.01.2025
> 11:08 CET geschrieben:
>
>
> > Alexandre Derumier via pve-devel hat am
> > 16.12.2024 10:12 CET geschrieben:
>
> >>it would be great if there'd be a summary of the design choices and a
> >>high level summary of what happens to the files and block-no
> DERUMIER, Alexandre hat am 13.01.2025
> 11:47 CET geschrieben:
>
>
> >>something like this was what I was afraid of ;) this basically means
> >>we need to have some way to lookup the nodes based on the structure
> >>of the graph, which probably also means verifying that the structure
> >>ma
The variable has been unused since commit 67af0fa ("rebased pve
patches") back in 2017. There is no comment to why, but before that,
it was used to error out if there were no disks in the vma archive.
This should be possible however, so it's safe to assume this was an
intentional change.
This fixe
--- Begin Message ---
Il 10/01/2025 18:00, Daniel Kral ha scritto:
As the installer allows single-disk RAID0 configurations and BTRFS
allows to create a filesystem with the RAID10 profile with only two
disks since kernel version 5.15 [0], lower the minimum amount of disks
the installer requires f
--- Begin Message ---
Il 10/01/2025 18:00, Daniel Kral ha scritto:
From a user's perspective, the BTRFS single mode has been removed since
d85180e ("tui: rename raid levels 0/1 to align with GUI installer"). The
user can now only select at least the "RAID0" level, but if a user
selects any raid
--- Begin Message ---
>>For almost all QMP commands, we only need to care about the node
>>that's
>>inserted for the drive.
(yes, that the throttle group in my implementation, and I have a fixed
name, I'm reusing the "drive-(ide|scsi|virtio)x naming"
>>And for your use-case, checking that the to
Am 13.01.25 um 11:57 schrieb DERUMIER, Alexandre via pve-devel:
>> Hmm, sounds like it might a bug, I can look into it. If really
>> required
>> to make it work, we can still set fixed node-names on the
>> commandline,
>> but also query them before usage to be sure we have the correct, i.e.
>> curr
--- Begin Message ---
> Hmm, sounds like it might a bug, I can look into it. If really
> required
> to make it work, we can still set fixed node-names on the
> commandline,
> but also query them before usage to be sure we have the correct, i.e.
> currently inserted node.
>>AFAICT, this is because
Am 13.01.25 um 11:06 schrieb Fiona Ebner:
> Am 10.01.25 um 13:30 schrieb DERUMIER, Alexandre:
>> blockdev-reopen don't work with autogenerated nodenames (block#)
>> (not sure if it's a bug or not).
>> That's why I'm currently naming all of them (including backing chain
>> snapshots too)
>
> Hmm, s
--- Begin Message ---
Il 13/01/2025 09:41, Gabriel Goller ha scritto:
Oops, missed this v2!
Consider still the s/Clipboard/clipboard edit and the:
Reviewed-by: Gabriel Goller
Thanks for the review, can you just do the small change when you apply
it or I must do v3?
--
Questa email è stata
--- Begin Message ---
>>something like this was what I was afraid of ;) this basically means
>>we need to have some way to lookup the nodes based on the structure
>>of the graph, which probably also means verifying that the structure
>>matches the expected one (e.g., if we have X snapshots, we expe
--- Begin Message ---
> Alexandre Derumier via pve-devel hat am
> 16.12.2024 10:12 CET geschrieben:
>>it would be great if there'd be a summary of the design choices and a
>>high level summary of what happens to the files and block-node-graph
>>here. it's a bit hard to judge from the code below
Am 10.01.25 um 13:30 schrieb DERUMIER, Alexandre:
> Message initial
> De: Fiona Ebner
> À: Proxmox VE development discussion ,
> f.gruenbich...@proxmox.com
> Cc: "DERUMIER, Alexandre"
> Objet: Re: [pve-devel] [PATCH-SERIES v3 pve-storage/qemu-server/pve-
> qemu] add external qc
On January 10, 2025 6:08 pm, Friedrich Weber wrote:
> On 31/10/2024 11:16, Fabian Grünbichler wrote:
>> to pick up the pinned host keys, instead of relying on them being in the
>> local
>> root user's known hosts file.
>>
>> Signed-off-by: Fabian Grünbichler
>> ---
>
> applied this patch and
>
> Fabian Grünbichler hat am 13.01.2025 10:52 CET
> geschrieben:
>
>
> > DERUMIER, Alexandre hat am
> > 13.01.2025 09:27 CET geschrieben:
> >
> >
> > > + my $path = PVE::Storage::path($storecfg, $volid);
> >
> > >>is this guaranteed to be stable? also across versions? and including
>
> DERUMIER, Alexandre hat am 13.01.2025
> 09:27 CET geschrieben:
>
>
> > + my $path = PVE::Storage::path($storecfg, $volid);
>
> >>is this guaranteed to be stable? also across versions? and including
> >>external storage plugins?
>
> it can't be different than the value we have use for c
I just tested this patch and think it gives very valuable information.
One thing I noticed, more by chance than intentional -- if the host has
a lower cpu-count than the count configured for the VM, the stats will
not be updated. E.g. my pve-host only has 2 cores available and if I
configure 4 cor
Add a checkbox for marking an iso file as required.
This option is used in the backend to determine if the VM should start
up in case the configured ISO file is not available.
By default this box is not visible and disabled.
Signed-off-by: Daniel Herzig
---
www/manager6/form/IsoSelector.js | 2
Enables the 'required' checkbox for the IsoSelector.
If the parameter is not set, the backend will use the default (set to
1).
Behaviour:
* Only send parameter if not default (required=0)
* Checked if parameter is missing (default)
* Unchecked when adding a new CD-ROM
Signed-off-by: Daniel Herzig
This patch series addresses bugzilla entry #4225.
Currently VMs refuse to to start if a configured isofile becomes unavailable,
be it a deleted file or an unavailable network storage.
This patch series introduces a new parameter in Drive.pm, called 'required'.
Depending on whether this parameter
Let all files checked by file_exists appear as existing if the path
does not contain the string 'I_DO_NOT_EXIST'.
Signed-off-by: Daniel Herzig
---
test/run_config2command_tests.pl | 4
1 file changed, 4 insertions(+)
diff --git a/test/run_config2command_tests.pl b/test/run_config2command_t
Let cifs-store appear as online to a call from
PVE::Storage::activate_storage.
Signed-off-by: Daniel Herzig
---
test/run_config2command_tests.pl | 19 +++
1 file changed, 19 insertions(+)
diff --git a/test/run_config2command_tests.pl b/test/run_config2command_tests.pl
index 3f37
Current behaviour prevents a VM from starting, if an ISO file defined
in the configuration becomes unavailable.
The function eject_nonrequired_isos checks on whether a cdrom drive is
marked as 'required' or not. If the parameter 'required' is not
defined, it will assume 'required' to be true and k
Add an nfs-offline storage to allow for comparatative testing
against potentially mocked online storages.
Signed-off-by: Daniel Herzig
---
test/run_config2command_tests.pl | 9 +
1 file changed, 9 insertions(+)
diff --git a/test/run_config2command_tests.pl b/test/run_config2command_test
This adds tests for the errors and warnings issued by
PVE::QemuServer::eject_unrequired_isos.
Empty cmd files were added for the test configurations that are not
expected to have any output (as they die before a command is prepared):
* ide-required-iso-missing.conf
* ide-required-iso-offline-nfs.c
Eject by setting file to none.
Signed-off-by: Daniel Herzig
---
www/manager6/qemu/HardwareView.js | 43 +++
1 file changed, 43 insertions(+)
diff --git a/www/manager6/qemu/HardwareView.js
b/www/manager6/qemu/HardwareView.js
index 59e670db..5d1c18a5 100644
--- a/www/
Strip log_warn wrapper for catching warnings on testruns.
Signed-off-by: Daniel Herzig
---
test/run_config2command_tests.pl | 4
1 file changed, 4 insertions(+)
diff --git a/test/run_config2command_tests.pl b/test/run_config2command_tests.pl
index 71b00e9a..8df4f4e8 100755
--- a/test/run_c
Ease EXPECT_ERROR and EXPECT_WARN string matching with errors/warnings
that have more than one trailing newline.
Signed-off-by: Daniel Herzig
---
test/run_config2command_tests.pl | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/test/run_config2command_tests.pl b/test/r
This stub function can be used for mocking a file's existance in testruns.
Signed-off-by: Daniel Herzig
---
PVE/QemuServer.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 5cde94a1..d07c170e 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServe
Add parameter to allow for marking a drive as required.
Signed-off-by: Daniel Herzig
---
PVE/QemuServer/Drive.pm | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
index 7b298454..b816fbec 100644
--- a/PVE/QemuServer/Driv
--- Begin Message ---
>
> +sub generate_backing_blockdev {
> + my ($storecfg, $snapshots, $deviceid, $drive, $id) = @_;
> +
> + my $snapshot = $snapshots->{$id};
> + my $order = $snapshot->{order};
> + my $parentid = $snapshot->{parent};
> + my $snap_fmt_nodename = "fmt-$deviceid-$
--- Begin Message ---
> + my $path = PVE::Storage::path($storecfg, $volid);
>>is this guaranteed to be stable? also across versions? and including
>>external storage plugins?
it can't be different than the value we have use for command line
generation. But I think that I should use $path dir
Oops, missed this v2!
Consider still the s/Clipboard/clipboard edit and the:
Reviewed-by: Gabriel Goller
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--- Begin Message ---
> + #change aio if io_uring is not supported on target
> + if ($dst_drive->{aio} && $dst_drive->{aio} eq 'io_uring') {
> + my ($dst_storeid) = PVE::Storage::parse_volume_id($dst_drive-
> >{file});
> + my $dst_scfg = PVE::Storage::storage_config($storecfg,
> $dst_storeid)
On 10.01.2025 12:08, Fabio Fantoni via pve-devel wrote:
#: pve-manager/www/manager6/qemu/DisplayEdit.js:98
msgid ""
"You cannot use the default SPICE clipboard if the VNC Clipboard is selected."
msgstr ""
+"Non è possibile utilizzare la clipboard SPICE predefinita se è selezionata "
+"la Clipboar
45 matches
Mail list logo
