Am 06.12.24 um 14:55 schrieb Aaron Lauterer:
> Since we already have the information from the API call, why not add it
> as a (hidden) column. It can be useful to quickly see which ceph
> applications are enabled for a pool in some situations.
>
> Signed-off-by: Aaron Lauterer
> ---
> as mentione
Am 06.12.24 um 14:55 schrieb Aaron Lauterer:
> RBD supports namespaces. To make the management easier and possible via
> the web UI, we need to add API endpoints to:
> * list
> * create
> * delete
> namespaces.
>
> We only allow creatng namespaces for pools that have the RBD application
> set.
>
Am 10.12.24 um 16:11 schrieb Gabriel Goller:
> Return all ip-addresses of an interface, not only the first one. Change
> return schema to resemble the 'agent/network-get-interfaces' qemu call.
> This helps us making the AgentIPView more generic and display the ip on
> both containers and vms.
>
>
Am 09.12.24 um 13:45 schrieb Christoph Heiss:
> Currently, the answer file is only syntax-checked, i.e. if it can be
> parsed as TOML and whether it is of valid structure, but the actual
> answer settings are not looked at.
>
> Patch #2 is a refactoring of the whole locale info generation, as to
>
Add ConsentBanner variable to html template and populate it from the
`datacenter.cfg` config file. Add Datacenter option to set the text and
trigger the popup on login. The max length of the input is 63*1024,
which is a bit less than the max body size for a api request (64*1024).
Signed-off-by: Ga
This allows us to set `maxLength` on it. `enforceMaxLength` will force
extjs to set the `maxLength` property on the underlying inputfield.
Signed-off-by: Gabriel Goller
---
src/form/TextAreaField.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/form/TextAreaField.js b/src/form/TextArea
Signed-off-by: Gabriel Goller
---
pve-gui.adoc | 9 +
1 file changed, 9 insertions(+)
diff --git a/pve-gui.adoc b/pve-gui.adoc
index 8a04bd977796..4eef5cc1b56d 100644
--- a/pve-gui.adoc
+++ b/pve-gui.adoc
@@ -453,6 +453,15 @@ edited under __Datacenter -> Options -> Registered Tags__
or
The consent text is stored in the datacenter.cfg file and is encoded
using base64. This allows us to support multi-line strings and special
characters. To easily edit the text the existing edit-field
ProxmoxTextAreaField is used. It supports editing and saving
multi-line text and converting it to i
The consent-text parameter is the base64-encoded content of the optional
consent-banner which can be displayed before login. The limit is 128kB,
which is less than the pmxcfs file limit, but still enough to also
encode images.
Signed-off-by: Gabriel Goller
---
src/PVE/DataCenterConfig.pm | 6 +++
v3 on the list!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Show the ip/hwaddress of the network interfaces of containers in the summary
tab of the container and in the network tab on a per-interface basis.
This series was originally by Leo Nunner:
https://lore.proxmox.com/pve-devel/20230615094333.66179-1-l.nun...@proxmox.com/
v2, thanks @Dominik:
- sho
Ignore this one please, forgot the --suppress-cc again :(
Sorry for the noise.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
adds a call to /nodes/{node}/lxc/{vmid}/interfaces and merges the
returned data with the existing configuration. This will update the
IPv4 and IPv6 address, as well as the interface name (in case the
container changed it).
Originally-by: Leo Nunner
Signed-off-by: Gabriel Goller
---
www/manager6
Refactor AgentIPView to be generic over container and vms. Reuse it in
the Container Summary to show the ip addresses of the container.
Signed-off-by: Gabriel Goller
---
www/manager6/Makefile | 2 +-
www/manager6/panel/GuestStatusView.js | 139 +-
Return all ip-addresses of an interface, not only the first one. Change
return schema to resemble the 'agent/network-get-interfaces' qemu call.
This helps us making the AgentIPView more generic and display the ip on
both containers and vms.
Signed-off-by: Gabriel Goller
---
src/PVE/API2/LXC.pm |
Show the ip/hwaddress of the network interfaces of containers in the summary
tab of the container and in the network tab on a per-interface basis.
This series was originally by Leo Nunner:
https://lore.proxmox.com/pve-devel/20230615094333.66179-1-l.nun...@proxmox.com/
v2, thanks @Dominik:
- sho
Submitted a v2!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
with your R-B added and the style nit folded in.
On December 10, 2024 1:35 pm, Fiona Ebner wrote:
> Am 10.12.24 um 13:17 schrieb Fabian Grünbichler:
>> these fix various corner cases / spurious warnings for the recently
>> added file_size_info checks.
>>
>
> Thanks for the follow-ups! consider t
--- Begin Message ---
Hello Hannes,
Thank you also very much for the feedback, I appreciate it. It's my first time
writing Perl and contributing to Proxmox :) I was initially in contact with
your colleague S. Hanreich, who told me to start with the Netbox plugin. Given
how significant the diffe
Am 10.12.24 um 13:17 schrieb Fabian Grünbichler:
> these fix various corner cases / spurious warnings for the recently
> added file_size_info checks.
>
Thanks for the follow-ups! consider the series:
Reviewed-by: Fiona Ebner
___
pve-devel mailing lis
Am 10.12.24 um 13:17 schrieb Fabian Grünbichler:
> in case of an array context, it should also return the format, else a caller
> might assume it failed.
>
> Signed-off-by: Fabian Grünbichler
> ---
> v2: fix return value ordering, thanks Fiona!
>
> src/PVE/Storage/ESXiPlugin.pm | 4 +++-
> 1 fi
since `volume_size_info` passes the parsed format to `file_size_info`, which
prints a warning if the format is undef before falling back to auto-detection,
and these should always be treated as raw files anyway.
Signed-off-by: Fabian Grünbichler
---
v2: unchanged
src/PVE/Storage/Plugin.pm
in case this gets called with an explicit format that is none of:
- 'auto-detect'
- 'subvol'
- a member of the list of known "qemu" formats
this should only affect third-party storage plugins that either call this
directly with a format, or via inherited code that gets a format from
parse_volname
these fix various corner cases / spurious warnings for the recently
added file_size_info checks.
changes from v2:
- fix esxi return value order
- replace third patch with new one just adding a warning to the existing
fallback mechanism that already covers this
Fabian Grünbichler (3):
storage:
in case of an array context, it should also return the format, else a caller
might assume it failed.
Signed-off-by: Fabian Grünbichler
---
v2: fix return value ordering, thanks Fiona!
src/PVE/Storage/ESXiPlugin.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/St
Am 10.12.24 um 12:19 schrieb Fabian Grünbichler:
> in case of an array context, it should also return the format, else a caller
> might assume it failed.
>
> Signed-off-by: Fabian Grünbichler
> ---
> src/PVE/Storage/ESXiPlugin.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> di
these fix various corner cases / spurious warnings for the recently
added file_size_info checks.
Fabian Grünbichler (3):
storage: plugin: return 'raw' format when parsing non-image volumes
esxi: fix return value of volume_size_info for vmx volumes
storage: plugin: volume_size_info: fallback
as a safeguard for external storage plugins that
- override parse_volname and return "weird" formats
- but don't override volume_size_info
to prevent them from running into new file_size_info checks that only work for
certain formats we know about.
Signed-off-by: Fabian Grünbichler
---
not sure
since `volume_size_info` passes the parsed format to `file_size_info`, which
prints a warning if the format is undef before falling back to auto-detection,
and these should always be treated as raw files anyway.
Signed-off-by: Fabian Grünbichler
---
src/PVE/Storage/Plugin.pm | 10 +-
in case of an array context, it should also return the format, else a caller
might assume it failed.
Signed-off-by: Fabian Grünbichler
---
src/PVE/Storage/ESXiPlugin.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlug
Thanks for contributing and sending the patch series, we really
appreciate it!
At first glance it looks quite good, I have a few suggestions for changes:
* The plugin is based on the Netbox plugin, I would suggest changing it
to the base plugin. I know Nautobot is a fork of Netbox, but thi
Am 10.12.24 um 10:16 schrieb Shannon Sterz:
> otherwise, `volname.vmdk.raw` would be picked up as a `vmdk` formatted
> image, which may not be desired.
>
> Signed-off-by: Shannon Sterz
> ---
> src/PVE/Storage/ESXiPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, th
otherwise, `volname.vmdk.raw` would be picked up as a `vmdk` formatted
image, which may not be desired.
Signed-off-by: Shannon Sterz
---
src/PVE/Storage/ESXiPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
33 matches
Mail list logo
