[pve-devel] applied-series: [PATCH docs v2 1/2] pvecm: add anchor for the migration network chapter

2024-12-09 Thread Thomas Lamprecht
Am 04.12.24 um 17:07 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > changes since v1: > * new patch > > pvecm.adoc | 1 + > 1 file changed, 1 insertion(+) > > applied both patches, thanks! ___ pve-devel mailing list pve-devel@lists

[pve-devel] applied: [PATCH proxmox-offline-mirror] partially-fix #5958: doc: add additional example for debug packages

2024-12-09 Thread Thomas Lamprecht
Am 05.12.24 um 10:15 schrieb Fabian Grünbichler: > our repositories don't override their section to debug, and they can get quite > big.. > > Signed-off-by: Fabian Grünbichler > --- > docs/offline-mirror.rst | 11 +++ > 1 file changed, 11 insertions(+) > > applied, thanks! __

[pve-devel] applied: [PATCH qemu-server] fix #5980: importdisk: fix spurious warning

2024-12-09 Thread Thomas Lamprecht
Am 09.12.24 um 11:58 schrieb Fabian Grünbichler: > if not target disk is given, it makes no sense to check that it is valid. > > Signed-off-by: Fabian Grünbichler > --- > PVE/CLI/qm.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! __

Re: [pve-devel] [PATCH qemu-server] fix vm shutdown when agent conf is enabled but is not running in the vm

2024-12-09 Thread Fabio Fantoni via pve-devel
--- Begin Message --- Ping Il 26/11/2024 16:19, Fabio Fantoni ha scritto: Checking only vm configuration for choose the shutdown method causes it to always fail, after reaching the timeout, if the qemu agent option in the vm configuration is enabled but the agent is not installed and active in t

Re: [pve-devel] [PATCH] Add UI option for boot optional mapped usb device

2024-12-09 Thread Tyst Marin
Hey Dominik, Appreciate the info and context you provided. I just sent the cla to off...@proxmox.com so hopefully that's good now(my bad for missing that). Hopefully the below answers at least some part of your questions. You are correct in that I'd like to optionally have the same behavior that

[pve-devel] [PATCH installer 4/6] common: setup: include path in error message if file could not be read

2024-12-09 Thread Christoph Heiss
Makes it a bit easier to figure out what went wrong in the error case. Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/setup.rs | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/proxmox-installer-common/src/setup.rs b/proxmox-installer-common/sr

[pve-devel] applied: [PATCH manager v2] api: network: add return schema for interface listing

2024-12-09 Thread Thomas Lamprecht
Am 06.12.24 um 10:24 schrieb Dominik Csapak: > Most options come from the api call parameter list > (`json_config_properties`). The description and types for the remaining > ons are either taken from the manpages, source code or similar > documentation where available. > > Signed-off-by: Dominik C

[pve-devel] [PATCH installer 2/6] country.pl: generate final structure as json at build time directly

2024-12-09 Thread Christoph Heiss
Currently, we generate a custom-format `country.dat` at build time, which we then ship with the installer. In the live environment, this then gets parsed (via regexes) into another format and is finally written out as JSON for e.g. the TUI and auto-installer to consume. Instead, skip the intermedi

[pve-devel] [PATCH installer 5/6] fix #5889: assistant: validate answer email & root password settings

2024-12-09 Thread Christoph Heiss
These checks are basically "free" and can be re-used from the auto-installer 1:1. Signed-off-by: Christoph Heiss --- proxmox-auto-install-assistant/src/main.rs | 9 + proxmox-auto-installer/src/utils.rs| 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/proxmox

[pve-devel] [PATCH installer 1/6] tui: options: simplify unit-test setup

2024-12-09 Thread Christoph Heiss
We already have `SetupInfo::mocked()` since commit c3c9282 ("common: add mocked variants for setup and ISO related info structs"), so use that. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/options.rs | 26 +++--- 1 file changed, 3 insertions(+), 23 deletions(-

[pve-devel] [PATCH installer 3/6] common: setup: read locale info as shipped by the installer directly

2024-12-09 Thread Christoph Heiss
Now that we have a pre-generated `locale-info.json` available, skip generating one on-the-fly and just read that one. Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/setup.rs | 20 +++- proxmox-low-level-installer | 3 --- 2 files changed, 15 insertions

[pve-devel] [PATCH installer 6/6] assistant: validate answer first-boot hook and locale settings

2024-12-09 Thread Christoph Heiss
For the first-boot hook, the check from the auto-installer can be easily re-used. For the locale, as we now have that information available as JSON, include that file in the assistant and use it to verify the answer file settings. Signed-off-by: Christoph Heiss --- proxmox-auto-install-assistan

[pve-devel] [PATCH installer 0/6] assistant: properly validate answer file settings

2024-12-09 Thread Christoph Heiss
Currently, the answer file is only syntax-checked, i.e. if it can be parsed as TOML and whether it is of valid structure, but the actual answer settings are not looked at. Patch #2 is a refactoring of the whole locale info generation, as to generate the final information structure at build-time -

[pve-devel] SPAM: [PATCH pve-network v2 3/4] fix: register details in pve ipam db for add_next_freeip

2024-12-09 Thread Lou Lecrivain via pve-devel
--- Begin Message --- Signed-off-by: lou lecrivain --- src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Ipams/PVEPlugin.pm b/src/PVE/Network/SDN/Ipams/PVEPlugin.pm index 742f1b1..c225655 100644 --- a/src/PVE/Netwo

[pve-devel] SPAM: [PATCH pve-network v2 4/4] update tests following changes to behaviour: - allocating IPs also when prefix-only - PVE IPAM register details for every allocation strategy

2024-12-09 Thread Lou Lecrivain via pve-devel
--- Begin Message --- Signed-off-by: lou lecrivain --- src/test/run_test_subnets.pl| 24 +--- src/test/run_test_vnets_blackbox.pl | 6 ++ 2 files changed, 23 insertions(+), 7 deletions(-) diff --git a/src/test/run_test_subnets.pl b/src/test/run_test_subnets.pl in

[pve-devel] SPAM: [PATCH pve-network v2 0/4] dhcp: always generate dhcp-range

2024-12-09 Thread Lou Lecrivain via pve-devel
--- Begin Message --- Second version of the patch, changes made as seen with Stefan. this patch series re-enables a previously disabled code path in order to allow IP allocation directly from a prefix when no DHCP ranges are configured for a subnet. MfG -- Lou Lecrivain WDZ GmbH Lou Lecrivain (

[pve-devel] SPAM: [PATCH pve-network v2 2/4] dhcp: always generate dhcp-range for dnsmasq

2024-12-09 Thread Lou Lecrivain via pve-devel
--- Begin Message --- (configure_range is now noop) Signed-off-by: lou lecrivain --- src/PVE/Network/SDN/Dhcp.pm | 3 ++- src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 23 ++- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/src/PVE/Network/SDN/Dhcp.pm b/src/

[pve-devel] SPAM: [PATCH pve-network v2 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead

2024-12-09 Thread Lou Lecrivain via pve-devel
--- Begin Message --- Signed-off-by: lou lecrivain --- src/PVE/Network/SDN/Vnets.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/PVE/Network/SDN/Vnets.pm b/src/PVE/Network/SDN/Vnets.pm index 45292e3..4e795f2 100644 --- a/src/PVE/Network/SDN/Vnets.pm +++ b/src/PVE/Netw

[pve-devel] [PATCH qemu-server] fix #5980: importdisk: fix spurious warning

2024-12-09 Thread Fabian Grünbichler
if not target disk is given, it makes no sense to check that it is valid. Signed-off-by: Fabian Grünbichler --- PVE/CLI/qm.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 030bbb3a..4214a7ca 100755 --- a/PVE/CLI/qm.pm +++ b/PVE/CLI/qm.pm

Re: [pve-devel] [RFC PATCH installer] auto: allow a binary executable as the first boot executable

2024-12-09 Thread Christoph Heiss
Apart from one note inline, LGTM overall. On Fri, Dec 06, 2024 at 02:24:55PM +0100, Daniel Kral wrote: > [..] > When the HTTP response is missing the "Content-Length" header, it will > be explicitly stated in the error message. Why mandate the `Content-Length` header tho? For HTTP/1.1, it is only

Re: [pve-devel] [PATCH v3 1/2] log: add perlmod logger and custom formatter

2024-12-09 Thread Gabriel Goller
Substituted by different series: https://lore.proxmox.com/pbs-devel/20241209094329.134802-1-g.gol...@proxmox.com/T/#m5c9212976e74618b0a30085b1ae990efef4a3deb ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailm