[pve-devel] [PATCH manager, docs 0/7] Ceph: add RBD Namespace management

2024-12-06 Thread Aaron Lauterer
The first patch in this series is not related, but adds a new column to the ceph pool panel to also display the application data of the pool. The rest of the series adds the necessary API endpoints and GUI to manage RBD namespaces in a HCI cluster. The Ceph Pool panel in the UI needed a bit more w

[pve-devel] [PATCH manager 5/7] ui: utils: add ceph rbd namespace task names

2024-12-06 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- www/manager6/Utils.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 97dbbae2..d3b978e8 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1993,11 +1993,13 @@ Ext.define('PVE.Utils', {

[pve-devel] [PATCH manager 1/7] ui: ceph pool: add columns for application

2024-12-06 Thread Aaron Lauterer
Since we already have the information from the API call, why not add it as a (hidden) column. It can be useful to quickly see which ceph applications are enabled for a pool in some situations. Signed-off-by: Aaron Lauterer --- as mentioned in the cover letter, this patch has nothing directly to d

[pve-devel] [PATCH manager 6/7] ui: storage rbd: remove hint for manual rbd namespace creation

2024-12-06 Thread Aaron Lauterer
they can now be created with proxmox ve tooling directly Signed-off-by: Aaron Lauterer --- www/manager6/storage/RBDEdit.js | 21 - 1 file changed, 21 deletions(-) diff --git a/www/manager6/storage/RBDEdit.js b/www/manager6/storage/RBDEdit.js index 15fc1304..e41da1e1 100644 -

[pve-devel] [PATCH manager 4/7] ui: ceph pool: add rbd namespace panel

2024-12-06 Thread Aaron Lauterer
This needs a bit of a rework of the Ceph Pool panel because we want to have it right next/below to the pool grid. Additionally we want to en-/disable it if the select pool has RBD as application enabled. Therefore we introduce a new small panel (Ceph.PoolView) that holds the pool and namespace gri

[pve-devel] [PATCH docs 7/7] pveceph: add section for rbd namespaces

2024-12-06 Thread Aaron Lauterer
and a few basic examples on how to manage them. Signed-off-by: Aaron Lauterer --- pveceph.adoc | 41 + 1 file changed, 41 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index da39e7f..a90a6e1 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -760,6

[pve-devel] [PATCH manager 2/7] api: ceph: add rbd namespace management endpoints

2024-12-06 Thread Aaron Lauterer
RBD supports namespaces. To make the management easier and possible via the web UI, we need to add API endpoints to: * list * create * delete namespaces. We only allow creatng namespaces for pools that have the RBD application set. Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph/Pool.pm | 182 +

[pve-devel] [PATCH manager 3/7] pveceph: add pool namespace subcommands

2024-12-06 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- PVE/CLI/pveceph.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm index 488aea04..3a2bb890 100755 --- a/PVE/CLI/pveceph.pm +++ b/PVE/CLI/pveceph.pm @@ -482,6 +482,15 @@ our $cmddef = { my ($data, $

[pve-devel] [RFC PATCH installer] auto: allow a binary executable as the first boot executable

2024-12-06 Thread Daniel Kral
As the initial use case for the first boot feature request [0] was for running shell scripts, the auto installer retrieved the binary as a `String`. Unfortunately, this tries to interpret binary data as UTF-8 and will transform 'invalid' characters to replacement characters [1]. This causes the au

Re: [pve-devel] [PATCH manager 2/2] lxc: show IPs in summary view

2024-12-06 Thread Dominik Csapak
On 12/5/24 18:28, Gabriel Goller wrote: On 04.12.2024 10:25, Dominik Csapak wrote: high level comments/questions (i know they're not you're patches exactly, but still): * maybe it would be better to integrate this into the AgentIPView for vms?  AFAICS the code is very similar and probably just

Re: [pve-devel] [PATCH cluster/docs/manager 0/3] fix #5463: add optional Consent Banner on login

2024-12-06 Thread Gabriel Goller
Sent a v2! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH proxmox-mail-forward 2/2] switch to proxmox-log

2024-12-06 Thread Lukas Wagner
On 2024-12-06 11:40, Gabriel Goller wrote: >> fn main() { >> -    if let Err(err) = syslog::init( >> -    syslog::Facility::LOG_DAEMON, >> -    log::LevelFilter::Info, >> -    Some("proxmox-mail-forward"), >> -    ) { >> +    if let Err(err) = proxmox_log::init_logger("PROXMOX_LOG",

[pve-devel] [PATCH cluster/docs/manager/widget-toolkit v2 0/4] fix #5463: add optional Consent Banner on login

2024-12-06 Thread Gabriel Goller
The consent text is stored in the datacenter.cfg file and is encoded using base64. This allows us to support multi-line strings and special characters. To easily edit the text the existing edit-field ProxmoxTextAreaField is used. It supports editing and saving multi-line text and converting it to i

[pve-devel] [PATCH docs v2 3/4] add consent-banner description

2024-12-06 Thread Gabriel Goller
Signed-off-by: Gabriel Goller --- pve-gui.adoc | 9 + 1 file changed, 9 insertions(+) diff --git a/pve-gui.adoc b/pve-gui.adoc index 8a04bd977796..4eef5cc1b56d 100644 --- a/pve-gui.adoc +++ b/pve-gui.adoc @@ -453,6 +453,15 @@ edited under __Datacenter -> Options -> Registered Tags__ or

[pve-devel] [PATCH manager v2 1/4] show optional consent-banner before login

2024-12-06 Thread Gabriel Goller
Add ConsentBanner variable to html template and populate it from the `datacenter.cfg` config file. Add Datacenter option to set the text and trigger the popup on login. Signed-off-by: Gabriel Goller --- PVE/Service/pveproxy.pm| 13 ++--- www/index.html.tpl |

[pve-devel] [PATCH cluster v2 2/4] add consent-text parameter to datacenter config file

2024-12-06 Thread Gabriel Goller
The consent-text parameter is the base64-encoded content of the optional consent-banner which can be displayed before login. Signed-off-by: Gabriel Goller --- src/PVE/DataCenterConfig.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConf

[pve-devel] [PATCH widget-toolkit v2 4/4] form: set enforceMaxLength on textareafield

2024-12-06 Thread Gabriel Goller
This allows us to set `maxLength` on it. `enforceMaxLength` will force extjs to set the `maxLength` property on the underlying inputfield. Signed-off-by: Gabriel Goller --- src/form/TextAreaField.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/form/TextAreaField.js b/src/form/TextArea

Re: [pve-devel] [RFC PATCH] api: network: add return schema for interface listing

2024-12-06 Thread Dominik Csapak
sent a v2: https://lore.proxmox.com/pve-devel/20241206092407.960823-1-d.csa...@proxmox.com/ ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH proxmox-mail-forward 2/2] switch to proxmox-log

2024-12-06 Thread Gabriel Goller
fn main() { -if let Err(err) = syslog::init( -syslog::Facility::LOG_DAEMON, -log::LevelFilter::Info, -Some("proxmox-mail-forward"), -) { +if let Err(err) = proxmox_log::init_logger("PROXMOX_LOG", LevelFilter::INFO) { eprintln!("unable to initialize sysl

[pve-devel] [PATCH proxmox 1/2] notify: smtp: add missing 'tracing' namespace prefix

2024-12-06 Thread Lukas Wagner
This section of code is only compiled when the 'mail-forwarder' feature is enabled, which might have been the reason why this was missed when the other places where log messages are produced were migrated to 'tracing'. Signed-off-by: Lukas Wagner --- proxmox-notify/src/endpoints/smtp.rs | 2 +-

Re: [pve-devel] SPAM: [PATCH pve-network 2/2] dhcp: generate dhcp-range for dnsmasq even when no dhcp_ranges exist

2024-12-06 Thread Lou Lecrivain via pve-devel
--- Begin Message --- Re, Seems like I did not test this enough, whoops. > Maybe it would make sense to move the whole code of configure_range to > configure_subnet in the Dnsmasq plugin, since the whole subnet gets > configured anyway and make configure_range a noop? Yes, do agree on this one. I

[pve-devel] SPAM: [PATCH pve-network v2] ipam: fix #5496

2024-12-06 Thread Lou Lecrivain via pve-devel
--- Begin Message --- functions were returning undef despite API calls being successfull, due to eval blocks return values not being taken into account. Co-authored-by: Jacob Green Signed-off-by: Lou Lecrivain Tested-by: Stefan Hanreich --- src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 8 ++-

Re: [pve-devel] [PATCH proxmox 1/2] notify: smtp: add missing 'tracing' namespace prefix

2024-12-06 Thread Gabriel Goller
On 06.12.2024 11:10, Lukas Wagner wrote: This section of code is only compiled when the 'mail-forwarder' feature is enabled, which might have been the reason why this was missed when the other places where log messages are produced were migrated to 'tracing'. Oh that's why I didn't get an error

[pve-devel] [PATCH proxmox-mail-forward 2/2] switch to proxmox-log

2024-12-06 Thread Lukas Wagner
The proxmox-notify crate now uses tracing for logging, hence we have to switch to proxmox-log (which configures the appropriate layers/subscribers for tracing). Signed-off-by: Lukas Wagner --- Cargo.toml | 5 ++--- src/main.rs | 16 +++- 2 files changed, 9 insertions(+), 12 deletio

Re: [pve-devel] [RFC PATCH] api: network: add return schema for interface listing

2024-12-06 Thread Thomas Lamprecht
Am 06.12.24 um 09:52 schrieb Dominik Csapak: > On 12/5/24 09:43, Thomas Lamprecht wrote: >> Am 05.12.24 um 09:27 schrieb Dominik Csapak: >>> Most optiosn come from the api call parameter list >>> (`json_config_properties`). The description and types for the remaining >>> ons are either taken from t

Re: [pve-devel] [PATCH manager 2/2] lxc: show IPs in summary view

2024-12-06 Thread Gabriel Goller
On 04.12.2024 10:25, Dominik Csapak wrote: high level comments/questions (i know they're not you're patches exactly, but still): * maybe it would be better to integrate this into the AgentIPView for vms? AFAICS the code is very similar and probably just needs a few adaptions to work there too

[pve-devel] [PATCH manager v2] api: network: add return schema for interface listing

2024-12-06 Thread Dominik Csapak
Most options come from the api call parameter list (`json_config_properties`). The description and types for the remaining ons are either taken from the manpages, source code or similar documentation where available. Signed-off-by: Dominik Csapak --- changes from rfc: * added missing fields * fix

Re: [pve-devel] [PATCH v3 1/2] log: add perlmod logger and custom formatter

2024-12-06 Thread Lukas Wagner
On 2024-12-05 16:10, Gabriel Goller wrote: > Add special logger for perlmod. This one will print everything to > stderr (which will end up in the tasklog) and the errors to journald. > This also includes a custom formatter so that the stderr output will > look like: "INFO: sample message". > > Re

Re: [pve-devel] [RFC PATCH] api: network: add return schema for interface listing

2024-12-06 Thread Dominik Csapak
On 12/5/24 09:43, Thomas Lamprecht wrote: Am 05.12.24 um 09:27 schrieb Dominik Csapak: Most optiosn come from the api call parameter list (`json_config_properties`). The description and types for the remaining ons are either taken from the manpages, source code or similar documentation where ava