--- Begin Message ---
Hi everyone,
Just bumping this patch series since it's been a few weeks :)
Is there anything blocking these patches from being accepted?
I'm happy to address any feedback if so.
Thanks,
Severen
--- End Message ---
___
pve-devel m
Am 03.12.24 um 16:29 schrieb Gabriel Goller:
> Add ConsentBanner variable to html template and populate it from the
> `datacenter.cfg` config file. Add Datacenter option to set the text and
> trigger the popup on login.
>
> Signed-off-by: Gabriel Goller
> ---
> PVE/Service/pveproxy.pm
Am 03.12.24 um 16:29 schrieb Gabriel Goller:
> The consent-text paramter is the base64-encoded content of the optional
> consent-banner which can be displayed before login.
This can get quite big, would be good to set some relatively high limit here,
I think, as our pmxcfs files have a max size an
Am 03.12.24 um 13:23 schrieb Christoph Heiss:
> First off, it defines all auto-installer "parse answer" tests in a
> declaratively manner, such that each test actually represent a single
> rust unit test. Improves developer UX a bit and makes better use of the
> built-in facilities of `cargo test`.
Am 03.12.24 um 11:15 schrieb Christoph Heiss:
> Pretty trivial overall, just re-formats some comments in accordance with
> rustdoc - mostly URLs, which need to be surrounded by < > to be properly
> recognised/parsed.
>
> Christoph Heiss (2):
> tree-wide: fix `cargo doc` warnings
> tree-wide: r
Signed-off-by: Gabriel Goller
---
pve-gui.adoc | 9 +
1 file changed, 9 insertions(+)
diff --git a/pve-gui.adoc b/pve-gui.adoc
index 8a04bd977796..4eef5cc1b56d 100644
--- a/pve-gui.adoc
+++ b/pve-gui.adoc
@@ -453,6 +453,15 @@ edited under __Datacenter -> Options -> Registered Tags__
or
The consent text is stored in the datacenter.cfg file and is encoded
using base64. This allows us to support multi-line strings and special
characters. To easily edit the text the existing edit-field
ProxmoxTextAreaField is used. It supports editing and saving
multi-line text and converting it to i
The consent-text paramter is the base64-encoded content of the optional
consent-banner which can be displayed before login.
Signed-off-by: Gabriel Goller
---
src/PVE/DataCenterConfig.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfi
Add ConsentBanner variable to html template and populate it from the
`datacenter.cfg` config file. Add Datacenter option to set the text and
trigger the popup on login.
Signed-off-by: Gabriel Goller
---
PVE/Service/pveproxy.pm| 4 +++-
www/index.html.tpl | 3 ++-
ww
Defines all auto-installer "parse answer" tests in a declaratively
manner, such that each test actually represent a single rust unit test.
This improves the overall developer experience by having a proper,
separate test function for each answer parsing test - making better use
of the built-in faci
Using the previously introduced `pretty_assertions` crates for object
comparisons improves developer UX quite a bit, making failures easier to
observe and quickly reason about.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/Cargo.toml | 3 +++
proxmox-tui-installer/src/options.rs |
Adds the `pretty_assertions` crate [0] as dev-dependency, which does
this very nicely. This makes failures way easier to observe and quickly
reason about.
See also [1] for the initial discussion about this.
[0] https://docs.rs/pretty_assertions
[1]
https://lore.proxmox.com/pve-devel/a35eafb9-cbb
First off, it defines all auto-installer "parse answer" tests in a
declaratively manner, such that each test actually represent a single
rust unit test. Improves developer UX a bit and makes better use of the
built-in facilities of `cargo test`.
Then it also introduces the `pretty_assertions` crat
This was fixed as a regression for ZFS and Btrfs in [0] and [1],
respectively - to ensure it won't happen again, add some tests as it
should be.
[0] a9e5f37 ("common: allow lowercase and uppercase zfs raid levels")
[1] 33d53b9 ("common: allow lowercase and uppercase btrfs raid levels")
Signed-off
Mostly URLs, which need to be surrounded by < > to be properly
formatted.
Signed-off-by: Christoph Heiss
---
proxmox-auto-install-assistant/src/main.rs | 10 +
proxmox-installer-common/src/options.rs | 6 +++---
proxmox-installer-common/src/utils.rs | 23 ++---
Pretty trivial overall, just re-formats some comments in accordance with
rustdoc - mostly URLs, which need to be surrounded by < > to be properly
recognised/parsed.
Christoph Heiss (2):
tree-wide: fix `cargo doc` warnings
tree-wide: run `cargo fmt`
proxmox-auto-install-assistant/src/main.rs
Signed-off-by: Christoph Heiss
---
proxmox-installer-common/src/options.rs | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/proxmox-installer-common/src/options.rs
b/proxmox-installer-common/src/options.rs
index 6ec7d5c..9720804 100644
--- a/proxmox-installer-
On 2024-12-02 16:29, Thomas Lamprecht wrote:
> Am 02.12.24 um 14:32 schrieb Lukas Wagner:
>> It has been a full year now, so I'd argue it is safe to drop these
>> safety guards now. On the off chance that there are still systems out
>> there which still have these entries in their notifications
18 matches
Mail list logo
