[pve-devel] [PATCH docs 08/12] notification: add documentation for webhook target endpoints.

2024-07-10 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- notifications.adoc | 93 ++ 1 file changed, 93 insertions(+) diff --git a/notifications.adoc b/notifications.adoc index 25a9391..b46f1d5 100644 --- a/notifications.adoc +++ b/notifications.adoc @@ -178,6 +178,99 @@ gotif

[pve-devel] [PATCH proxmox-backup 11/12] docs: notification: add webhook endpoint documentation

2024-07-10 Thread Lukas Wagner
Same information as in pve-docs but translated to restructured text. Signed-off-by: Lukas Wagner --- docs/notifications.rst | 100 + 1 file changed, 100 insertions(+) diff --git a/docs/notifications.rst b/docs/notifications.rst index 4ba8db86..d059fa76 10

[pve-devel] [PATCH widget-toolkit 05/12] notification: add UI for adding/updating webhook targets

2024-07-10 Thread Lukas Wagner
The widgets for editing the headers/secrets were adapted from the 'Tag Edit' dialog from PVE's datacenter options. Apart from that, the new dialog is rather standard. I've decided to put the http method and url in a single row, mostly to save space and also to make it analogous to how an actual ht

[pve-devel] [PATCH manager 07/12] api: add routes for webhook notification endpoints

2024-07-10 Thread Lukas Wagner
These just call the API implementation via the perl-rs bindings. Signed-off-by: Lukas Wagner --- PVE/API2/Cluster/Notifications.pm | 263 +- 1 file changed, 262 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Cluster/Notifications.pm b/PVE/API2/Cluster/Notificati

[pve-devel] [PATCH proxmox-mail-forward 12/12] bump proxmox-notify dependency

2024-07-10 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- Cargo.toml | 2 +- debian/control | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index f39d118..49ca079 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -20,4 +20,4 @@ nix = "0.26" syslog = "6.0" proxmox-sys

[pve-devel] [PATCH proxmox-backup 10/12] ui: utils: enable webhook edit window

2024-07-10 Thread Lukas Wagner
This allows users to add/edit new webhook targets. Signed-off-by: Lukas Wagner --- www/Utils.js | 5 + 1 file changed, 5 insertions(+) diff --git a/www/Utils.js b/www/Utils.js index 4853be36..b715972f 100644 --- a/www/Utils.js +++ b/www/Utils.js @@ -482,6 +482,11 @@ Ext.define('PBS.Utils',

[pve-devel] [PATCH proxmox-perl-rs 04/12] common: notify: add bindings for get_targets

2024-07-10 Thread Lukas Wagner
This allows us to drop the impl of that function on the perl side. Signed-off-by: Lukas Wagner --- common/src/notify.rs | 9 + 1 file changed, 9 insertions(+) diff --git a/common/src/notify.rs b/common/src/notify.rs index fe192d5..0f8a35d 100644 --- a/common/src/notify.rs +++ b/common/s

[pve-devel] [PATCH proxmox-perl-rs 03/12] common: notify: add bindings for webhook API routes

2024-07-10 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- common/src/notify.rs | 63 1 file changed, 63 insertions(+) diff --git a/common/src/notify.rs b/common/src/notify.rs index e1b006b..fe192d5 100644 --- a/common/src/notify.rs +++ b/common/src/notify.rs @@ -19,6 +19,9 @@

[pve-devel] [PATCH proxmox 01/12] notify: implement webhook targets

2024-07-10 Thread Lukas Wagner
This target type allows users to perform HTTP requests to arbitrary third party (notification) services, for instance ntfy.sh/Discord/Slack. The configuration for these endpoints allows one to freely configure the URL, HTTP Method, headers and body. The URL, header values and body support handleba

[pve-devel] [PATCH proxmox 02/12] notify: add api for webhook targets

2024-07-10 Thread Lukas Wagner
All in all pretty similar to other endpoint APIs. One thing worth noting is how secrets are handled. We never ever return the values of previously stored secrets in get_endpoint(s) calls, but only a list of the names of all secrets. This is needed to build the UI, where we display all secrets that

[pve-devel] [PATCH manager 06/12] api: notifications: use get_targets impl from proxmox-notify

2024-07-10 Thread Lukas Wagner
The get_targets API endpoint is now implemented in Rust. Signed-off-by: Lukas Wagner --- PVE/API2/Cluster/Notifications.pm | 34 +-- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/PVE/API2/Cluster/Notifications.pm b/PVE/API2/Cluster/Notifications.pm in

[pve-devel] [PATCH proxmox-backup 09/12] api: notification: add API routes for webhook targets

2024-07-10 Thread Lukas Wagner
Copied and adapted from the Gotify ones. Signed-off-by: Lukas Wagner --- src/api2/config/notifications/mod.rs | 2 + src/api2/config/notifications/webhook.rs | 175 +++ 2 files changed, 177 insertions(+) create mode 100644 src/api2/config/notifications/webhook.rs diff

[pve-devel] [RFC many 00/12] notifications: add support for webhook endpoints

2024-07-10 Thread Lukas Wagner
Sending as an RFC because I don't want this merged yet; that being said, the feature should be mostly finished at this point, I'd appreciate any reviews and feedback. This series adds support for webhook notification targets to PVE and PBS. A webhook is a HTTP API route provided by a third-party

Re: [pve-devel] [PATCH pve-docs] vzdump: add section describing PBS change detection mode

2024-07-10 Thread Christian Ebner
superseded-by version 2: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064599.html ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 pve-docs] vzdump: add section describing PBS change detection mode

2024-07-10 Thread Christian Ebner
Add a concise section about what PBS change detection mode is and what it affects, including a table with a description of the modes. Signed-off-by: Christian Ebner --- vzdump.adoc | 24 1 file changed, 24 insertions(+) diff --git a/vzdump.adoc b/vzdump.adoc index 9b1cb

Re: [pve-devel] [PATCH qemu-server] fix 4493: cloud-init: fix generated Windows config

2024-07-10 Thread Mira Limbeck
There seems to be an issue with the network adapter. Whenever the guest is shutdown and started again it finds a new network adapter. Rebooting instead of shutting down doesn't show the same behavior. I'm not sure yet why this happens, but it seems to be caused by cloudbase-init. ___

Re: [pve-devel] [PATCH manager 2/2] fix#5570 ui: ceph: make MDS ID configurable

2024-07-10 Thread Aaron Lauterer
On 2024-07-10 15:59, Christoph Heiss wrote: On Wed, Jul 10, 2024 at 02:43:00PM GMT, Aaron Lauterer wrote: [..] www/manager6/ceph/ServiceList.js | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/www/manager6/ceph/ServiceList.js b/www/manager6/ceph

Re: [pve-devel] [PATCH manager 2/2] fix#5570 ui: ceph: make MDS ID configurable

2024-07-10 Thread Christoph Heiss
On Wed, Jul 10, 2024 at 04:18:25PM GMT, Aaron Lauterer wrote: > > > On 2024-07-10 15:59, Christoph Heiss wrote: > > On Wed, Jul 10, 2024 at 02:43:00PM GMT, Aaron Lauterer wrote: > > > [..] > > > www/manager6/ceph/ServiceList.js | 21 +++-- > > > 1 file changed, 11 insertions(+)

Re: [pve-devel] [PATCH pve-docs] vzdump: add section describing PBS change detection mode

2024-07-10 Thread Fabian Grünbichler
On June 26, 2024 10:13 am, Christian Ebner wrote: > Add a concise section about what PBS change detection mode is and > what it affects, including a table with a description of the modes. > > Signed-off-by: Christian Ebner > --- > vzdump.adoc | 24 > 1 file changed, 24 i

Re: [pve-devel] [PATCH manager 2/2] fix#5570 ui: ceph: make MDS ID configurable

2024-07-10 Thread Christoph Heiss
On Wed, Jul 10, 2024 at 02:43:00PM GMT, Aaron Lauterer wrote: > [..] > www/manager6/ceph/ServiceList.js | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/www/manager6/ceph/ServiceList.js > b/www/manager6/ceph/ServiceList.js > index 76710146..9075f197

Re: [pve-devel] [PATCH manager 0/2] fix #5570 ceph mds: allow custom MDS IDs from the UI

2024-07-10 Thread Christoph Heiss
Tested this on a small 3-node cluster, works as advertised. Code looks good too, just one small comment on the second patch. But otherwise please consider the series at least: Tested-by: Christoph Heiss On Wed, Jul 10, 2024 at 02:42:58PM GMT, Aaron Lauterer wrote: > The ID for the MDS cannot st

[pve-devel] [PATCH installer 12/14] fix #5536: add post-hook utility for sending notifications after auto-install

2024-07-10 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Cargo.toml| 1 + Makefile | 8 +- debian/install| 1 + proxmox-auto-installer/src/answer.rs | 16 +- .../src/bin/proxmox-auto-installer.rs

[pve-devel] [PATCH installer 04/14] common: simplify filesystem type serializing & Display trait impl

2024-07-10 Thread Christoph Heiss
Implements the proper de-/serializer directly on the type and then use serde_plain::derive_display_from_serialize where applicable, instead of separate serializer functions somewhere else. Signed-off-by: Christoph Heiss --- proxmox-installer-common/Cargo.toml | 1 + proxmox-installer-commo

[pve-devel] [PATCH installer 09/14] tree-wide: convert some more crates to use workspace dependencies

2024-07-10 Thread Christoph Heiss
No functional changes. Signed-off-by: Christoph Heiss --- Cargo.toml| 4 proxmox-auto-install-assistant/Cargo.toml | 14 +++--- proxmox-auto-installer/Cargo.toml | 15 +++ proxmox-chroot/Cargo.toml | 8 p

[pve-devel] [PATCH installer 05/14] common: setup: serialize `target_hd` as string explicitly

2024-07-10 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- proxmox-auto-installer/src/utils.rs | 15 +++ proxmox-installer-common/src/setup.rs | 23 ++- proxmox-tui-installer/src/setup.rs| 2 +- 3 files changed, 14 insertions(+), 26 deletions(-) diff --git a/proxmox-auto-installer

[pve-devel] [PATCH installer 06/14] common: split out installer setup files loading functionality

2024-07-10 Thread Christoph Heiss
This allows re-using this piece of code in e.g. the post hook, instead of having to open-code it there. No functional changes. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/tests/parse-answer.rs | 40 +--- proxmox-installer-common/src/setup.rs| 13 +-- 2

[pve-devel] [PATCH installer 01/14] chroot: print full anyhow message

2024-07-10 Thread Christoph Heiss
This forces anyhow to give more context to the stringified error, which helps tremendously when trying to make sense of these messages. Signed-off-by: Christoph Heiss --- proxmox-chroot/src/main.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-chroot/src/main.

[pve-devel] [PATCH installer 08/14] fetch-answer: move http-related code to gated module in installer-common

2024-07-10 Thread Christoph Heiss
No functional changes. Signed-off-by: Christoph Heiss --- Cargo.toml| 6 ++ proxmox-fetch-answer/Cargo.toml | 17 +-- .../src/fetch_plugins/http.rs | 100 +- proxmox-installer-common/Cargo.toml | 20 +

[pve-devel] [PATCH installer 13/14] fix #5536: post-hook: add some unit tests

2024-07-10 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- proxmox-post-hook/src/main.rs | 126 ++ 1 file changed, 126 insertions(+) diff --git a/proxmox-post-hook/src/main.rs b/proxmox-post-hook/src/main.rs index 9e5680b..dc25a79 100644 --- a/proxmox-post-hook/src/main.rs +++ b/proxmox-

[pve-devel] [PATCH installer 11/14] auto-installer: answer: add `posthook` section

2024-07-10 Thread Christoph Heiss
Adds a new global, optional section to the answerfile. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/src/answer.rs | 11 +++ 1 file changed, 11 insertions(+) diff --git a/proxmox-auto-installer/src/answer.rs b/proxmox-auto-installer/src/answer.rs index aab7198..e27a321 1006

[pve-devel] [PATCH installer 14/14] unconfigured.sh: run proxmox-post-hook after successful auto-install

2024-07-10 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- unconfigured.sh | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/unconfigured.sh b/unconfigured.sh index a39e6ad..34951e7 100755 --- a/unconfigured.sh +++ b/unconfigured.sh @@ -253,7 +253,10 @@ elif [ $start_auto_installer -ne 0 ]; then

[pve-devel] [PATCH installer 10/14] auto-installer: tests: replace left/right with got/expected in output

2024-07-10 Thread Christoph Heiss
Makes more sense and makes debugging easier. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/tests/parse-answer.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-auto-installer/tests/parse-answer.rs b/proxmox-auto-installer/tests/parse-answer.rs index 4509

[pve-devel] [PATCH installer 07/14] debian: strip unused library dependencies

2024-07-10 Thread Christoph Heiss
Rust links in some dynamic libraries even if only used by a disabled feature gate. This is needed due to the upcoming move of the HTTP features into the `proxmox-installer-common` crate. Very similar to how it is done in the `proxmox-backup` repository, which needs the same for very similar reason

[pve-devel] [PATCH installer 03/14] tree-wide: collect hardcoded installer runtime directory strings into constant

2024-07-10 Thread Christoph Heiss
No functional changes. Signed-off-by: Christoph Heiss --- proxmox-auto-installer/src/sysinfo.rs | 10 +++--- proxmox-chroot/src/main.rs| 11 --- proxmox-installer-common/src/lib.rs | 2 ++ proxmox-installer-common/src/setup.rs | 11 ++- 4 files changed, 23 inse

[pve-devel] [PATCH installer 00/14] fix #5536: implement post-(auto-)installation notification mechanism

2024-07-10 Thread Christoph Heiss
This implements a mechanism for post-installation "notifications" via a POST request [0] when using the auto-installer. It's implemented as a separate, small utility to facilitate separation of concerns and make the information gathering easier by having it isolated in one place. Patches #1 throu

[pve-devel] [PATCH installer 02/14] tree-wide: fix some typos

2024-07-10 Thread Christoph Heiss
No functional changes. Signed-off-by: Christoph Heiss --- .../src/bin/proxmox-auto-installer.rs| 2 +- proxmox-chroot/src/main.rs | 2 +- proxmox-fetch-answer/src/fetch_plugins/partition.rs | 12 ++-- 3 files changed, 8 insertions(+), 8 deleti

Re: [pve-devel] [PATCH manager 1/4] ui: homogenize uses of Zstd and SCSI

2024-07-10 Thread Fabian Grünbichler
On April 23, 2024 10:27 am, Maximiliano Sandoval wrote: > See [1, 2] for their spelling. > > [1] https://en.wikipedia.org/wiki/Zstd neither the upstream repo, nor the corresponding RFC indicate that this is the desired spelling (it is "Zstandard", but the short variant is called "zstd" in both pl

[pve-devel] applied: [PATCH proxmox-firewall 1/1] rules: allow vital ICMP(v6) types

2024-07-10 Thread Fabian Grünbichler
On June 10, 2024 2:52 pm, Stefan Hanreich wrote: > There are certain ICMP messages that should always pass through a > firewall irregardless of any other rules. This is particularly > important for ICMPv6. While we already handled NDP, there are certain > control messages that should always be able

[pve-devel] [PATCH manager 1/2] api: ceph mds: avoid creating MDS when ID starts with number

2024-07-10 Thread Aaron Lauterer
Ceph MDS IDs cannot start with a number [0]. [0] https://docs.ceph.com/en/latest/man/8/ceph-mds/ Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph/MDS.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Ceph/MDS.pm b/PVE/API2/Ceph/MDS.pm index 6fc0ae45..d99eebe6 100644 --- a/PVE/API

[pve-devel] [PATCH manager 2/2] fix#5570 ui: ceph: make MDS ID configurable

2024-07-10 Thread Aaron Lauterer
Since the ID of an MDS cannot start with a number [0], we cannot just use the hostname in all situations, as they are allowed to start with a number. By having an extra field for the MDS ID, we can check for that via a regex. This field is filled with the hostname when the host on which it should

[pve-devel] [PATCH manager 0/2] fix #5570 ceph mds: allow custom MDS IDs from the UI

2024-07-10 Thread Aaron Lauterer
The ID for the MDS cannot start with a number [0]. The first patch adds a check for this. The second patch is the actual fix, by reworking the edit window when adding new MDS'. By allowing the users to set the name of the MDS directly, we can catch the situation where the hostname starts with a n

Re: [pve-devel] [PATCH manager] fix #5010: ceph: pool set only changed properties

2024-07-10 Thread Christoph Heiss
Tested it on a simple 3-node cluster - first without setting `nosizechange` on a pool, then w/ the patch applied. Does what it says on the tin, avoids a task error while allowing setting other properties when `nosizechange` is active. On Tue, Jul 09, 2024 at 01:41:16PM GMT, Aaron Lauterer wrote: >

Re: [pve-devel] [PATCH proxmox-offline-mirror 2/2] build: execute dh-cargo-built-using

2024-07-10 Thread Fabian Grünbichler
On July 10, 2024 1:03 pm, Fabian Grünbichler wrote: > On July 10, 2024 12:42 pm, Fabian Grünbichler wrote: >> while it is pending a bug fix at the moment to properly pick up all >> dependencies, this ensures the X-Cargo-Built-Using (and soon, >> Static-Built-Using) substvars are actually filled wit

[pve-devel] [PATCH proxmox-offline-mirror v2 2/2] build: execute dh-cargo-built-using

2024-07-10 Thread Fabian Grünbichler
this ensures the X-Cargo-Built-Using (and soon, Static-Built-Using) substvars are actually filled with contents, and allow to find out which rustc version and dependency versions were used to build a particular binary package. Signed-off-by: Fabian Grünbichler --- debian/rules | 3 +++ 1 file ch

[pve-devel] [PATCH proxmox-offline-mirror v2 1/2] build: use cargo wrapper

2024-07-10 Thread Fabian Grünbichler
for package builds to ensure all common flags are actually set. Signed-off-by: Fabian Grünbichler --- Notes: v2: symlink wrapper config in place Makefile | 9 +++-- debian/rules | 11 --- docs/Makefile | 4 ++-- 3 files changed, 17 insertions(+), 7 deletions(-) diff --

[pve-devel] applied: [PATCH manager] pve7to8: fix typo in log message

2024-07-10 Thread Fiona Ebner
Am 10.07.24 um 12:59 schrieb Stoiko Ivanov: > Signed-off-by: Stoiko Ivanov > --- > noticed while pulling the changes over to pmg7to8 > > PVE/CLI/pve7to8.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm > index 940fb5c6..416ec79b

[pve-devel] [PATCH kernel 1/2] add fix for CIFS client memory leak

2024-07-10 Thread Fiona Ebner
As reported in the community forum [0], there currently is a memory leak in the CIFS client code. Reproduced by running a backup with CIFS target storage: > while true; do vzdump 101 --storage cifs --prune-backups keep-last=1; echo 3 > > /proc/sys/vm/drop_caches; done A fix was found on the kern

[pve-devel] [PATCH kernel 2/2] cherry-pick potential fix for NULL pointer deref with AMD Arcturus GPU during boot

2024-07-10 Thread Fiona Ebner
The issue was reported in the enterprise support and is handled by Alexander Zeidler. It has the following trace [0] and causes an issue with the networking down the line, because 'udevadm settle' would time out. The customer reported that mainline kernel 6.9.3 booted fine. Looking at the new commi

Re: [pve-devel] [PATCH proxmox-offline-mirror 2/2] build: execute dh-cargo-built-using

2024-07-10 Thread Fabian Grünbichler
On July 10, 2024 12:42 pm, Fabian Grünbichler wrote: > while it is pending a bug fix at the moment to properly pick up all > dependencies, this ensures the X-Cargo-Built-Using (and soon, > Static-Built-Using) substvars are actually filled with contents, and allow to > find out which rustc version a

[pve-devel] [PATCH manager] pve7to8: fix typo in log message

2024-07-10 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- noticed while pulling the changes over to pmg7to8 PVE/CLI/pve7to8.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm index 940fb5c6..416ec79b 100644 --- a/PVE/CLI/pve7to8.pm +++ b/PVE/CLI/pve7to8.pm @@ -

[pve-devel] [PATCH proxmox-offline-mirror 2/2] build: execute dh-cargo-built-using

2024-07-10 Thread Fabian Grünbichler
while it is pending a bug fix at the moment to properly pick up all dependencies, this ensures the X-Cargo-Built-Using (and soon, Static-Built-Using) substvars are actually filled with contents, and allow to find out which rustc version and dependency versions were used to build a particular binary

[pve-devel] [PATCH proxmox-offline-mirror 1/2] build: use cargo wrapper

2024-07-10 Thread Fabian Grünbichler
for package builds to ensure all common flags are actually set. Signed-off-by: Fabian Grünbichler --- Makefile | 9 +++-- debian/rules | 4 ++-- docs/Makefile | 4 ++-- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index c652bda..ab23b73 100644 ---

[pve-devel] applied-series: [PATCH proxmox-offline-mirror v2 0/5] remove snapshot directories vanished on source also on medium

2024-07-10 Thread Fabian Grünbichler
thanks! On July 9, 2024 12:47 pm, Stoiko Ivanov wrote: > supersedes: > https://lists.proxmox.com/pipermail/pve-devel/2024-June/064278.html > > v1->v2: > * had quite a few chats with Fabian off-list, as noted by him - Thanks! > * noticed that the core-issue was probably an error in using path.is_

Re: [pve-devel] Bug/enhancement 4300 implementation

2024-07-10 Thread Fabian Grünbichler
> Francois Prowse via pve-devel hat am 10.07.2024 > 02:11 CEST geschrieben: > Is it possible to understand how the enhancement (4300) I submitted and > implemented by the dev team will be rolled into the master branch? the patch series got reviewed and is waiting for a v2 as far as I can tell