Signed-off-by: Aaron Lauterer
---
changes:
incorporated additional feedback regarding phrasing, structure and
spelling
pveceph.adoc | 50 ++
1 file changed, 50 insertions(+)
diff --git a/pveceph.adoc b/pveceph.adoc
index 089ac80..9101ba5 100644
--
thanks for the review. one comment inline
On 2024-05-23 14:23, Alexander Zeidler wrote:
On Wed, 2024-05-22 at 10:33 +0200, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
changes since v1:
* incorporated suggested changes in phrasing to fix grammar and
distinguish the steps on how
all text that is going through encode_text will at a later point be
decoded by 'decode_text'. The latter is decoding all percent encoded
characters, even those not originally encoded by 'encode_text'.
This means, to preserve the original data, we first have to at least
percent encode the '%' itsel
Am 17.05.24 um 14:22 schrieb Dominik Csapak:
> On 5/17/24 10:31, Fiona Ebner wrote:
>> Reported in the community forum:
>> https://forum.proxmox.com/threads/145723/post-664612
>>
>> Signed-off-by: Fiona Ebner
>> ---
>> PVE/CLI/pve7to8.pm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
As recently reported in the community forum [0], 6.8 pve kernels would
not be detected correctly by the script. Allow arbitrary newer
versions if already upgraded for future-proofing.
[0]: https://forum.proxmox.com/threads/145723/post-664612
Suggested-by: Dominik Csapak
Signed-off-by: Fiona Ebne
The version of the running QEMU binary is not related to the machine
version and so it's a bit confusing to have the helper in the
'Machine' module. It cannot live in the 'Helpers' module, because that
would lead to a cyclic inclusion Helpers <-> Monitor. Thus,
'QMPHelpers' is chosen as the new hom
There is a possibility that the drive-mirror job is not yet done when
the migration wants to inactivate the source's blockdrives:
> bdrv_co_write_req_prepare: Assertion `!(bs->open_flags & BDRV_O_INACTIVE)'
> failed.
This can be prevented by using the 'write-blocking' copy mode (also
called acti
In Proxmox VE 8, the oldest supported QEMU version is 8.0, so a
check for version 4.2 is not required anymore. The check was also
wrong, because it checked the installed version and not the currently
running one.
Signed-off-by: Fiona Ebner
---
New in v2.
PVE/QemuMigrate.pm | 6 --
1 file c
In Proxmox VE 8, the oldest supported QEMU version is 8.0, so a check
for version 4.0.1 is not required anymore.
Signed-off-by: Fiona Ebner
---
New in v2.
PVE/VZDump/QemuServer.pm | 4
1 file changed, 4 deletions(-)
diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index 8
That regex should be a lot more accurate in what it allows - if it's
good enough for the HTML spec, it should be for us too.
Signed-off-by: Christoph Heiss
---
Proxmox/Makefile | 1 +
Proxmox/Sys.pm | 9 +
proxinstall | 3 ++-
3 files changed, 12 insertions(+), 1 deletion(-)
crea
That regex should be a lot more accurate in what it allows - if it's
good enough for the HTML spec, it should be for us too.
Signed-off-by: Christoph Heiss
---
proxmox-installer-common/Cargo.toml | 1 +
proxmox-installer-common/src/options.rs | 29 -
proxmox-tui-inst
This uses the regex for elements as defined in
the HTML spec to validate emails in the installer. That regex should be
a lot more robust than our current on and cover basically all cases of
email addresses that might be encountered in the while.
Also, patch #6 adds validation for the auto-install
Otherwise, context info is simply lost -- which might contain valuable
information for the user.
Signed-off-by: Christoph Heiss
---
proxmox-auto-installer/src/bin/proxmox-auto-installer.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-auto-installer/src/bin/proxmox-
Signed-off-by: Christoph Heiss
---
proxmox-auto-installer/src/utils.rs | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/proxmox-auto-installer/src/utils.rs
b/proxmox-auto-installer/src/utils.rs
index f752924..7241eec 100644
--- a/proxmox-auto-installer/src/utils.rs
Signed-off-by: Christoph Heiss
---
proxmox-auto-installer/src/utils.rs | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/proxmox-auto-installer/src/utils.rs
b/proxmox-auto-installer/src/utils.rs
index 202ad41..f752924 100644
--- a/proxmox-auto-installer/src/utils.rs
+++
Signed-off-by: Christoph Heiss
---
Cargo.toml| 2 ++
proxmox-auto-install-assistant/Cargo.toml | 2 +-
proxmox-auto-installer/Cargo.toml | 2 +-
proxmox-chroot/Cargo.toml | 2 +-
proxmox-fetch-answer/Cargo.toml | 2 +-
5 files chan
Am 23.05.24 um 11:08 schrieb Fabian Grünbichler:
> one nit below, otherwise very nice to have this!
>
> On May 3, 2024 10:34 am, Fiona Ebner wrote:
>> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
>> index 8d9b35ae..649cfec4 100644
>> --- a/PVE/QemuMigrate.pm
>> +++ b/PVE/QemuMigrate.pm
>>
Am 23.05.24 um 11:03 schrieb Fabian Grünbichler:
> but slight follow-up question below
>
> On May 3, 2024 10:34 am, Fiona Ebner wrote:
>> +use PVE::Storage::Plugin;
>
> this one is only used for a single check_connection call in `prepare`:
>
> if ($scfg->{shared}) {
> # PVE::Stor
ping?
i know we cannot really test this atm but there are a few users/customers
that would like to use/test this
since i marked it experimental i think it should be ok to include this
if its ok code wise
___
pve-devel mailing list
pve-devel@lists.pro
19 matches
Mail list logo
