Re: [pve-devel] [PATCH container] fix #5160: fix move_mount regression for mount point hotplug

2024-03-25 Thread Filip Schauer
Patch v2 is available: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062390.html On 08/01/2024 14:54, Filip Schauer wrote: Set up an Apparmor profile to allow moving mounts for mount point hotplug. This fixes a regression caused by kernel commit 157a3537d6 ("apparmor: Fix regression

Re: [pve-devel] [PATCH container] fix #5160: fix move_mount regression for mount point hotplug

2024-03-25 Thread Filip Schauer
On 25/03/2024 11:29, Fiona Ebner wrote: Am 08.01.24 um 14:54 schrieb Filip Schauer: Set up an Apparmor profile to allow moving mounts for mount point hotplug. This fixes a regression caused by kernel commit 157a3537d6 ("apparmor: Fix regression in mount mediation") The commit introduced move_m

[pve-devel] [PATCH v2 container 2/2] fix undef warning when apparmor changeprofile fails

2024-03-25 Thread Filip Schauer
Fix a "Use of uninitialized value in numeric ne (!=)" warning when syswrite returns undef when trying to change the apparmor profile. Signed-off-by: Filip Schauer --- src/PVE/LXC.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 7db483

[pve-devel] [PATCH v2 container 1/2] fix #5160: fix move_mount regression for mount point hotplug

2024-03-25 Thread Filip Schauer
Set up an Apparmor profile to allow moving mounts for mount point hotplug. This fixes a regression caused by kernel commit 157a3537d6 ("apparmor: Fix regression in mount mediation") The commit introduced move_mount mediation, which now requires move_mount to be allowed in the Apparmor profile. Al

[pve-devel] [PATCH v2 container 0/2] fix #5160: fix move_mount regression for mount point hotplug

2024-03-25 Thread Filip Schauer
Changes since v1: * Fix loading of apparmor profile not working in postinst, since the profile is not found by dh_apparmor. This is fixed by moving pve-container-mounthotplug out of the pve subdirectory. * Fix a perl undef warning when apparmor changeprofile fails. Filip Schauer (2): fix #51

[pve-devel] [PATCH pve-network] fix #5324: non vlanaware zone: add mtu to veth links

2024-03-25 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Zones/VlanPlugin.pm| 3 +++ src/test/zones/vlan/bridge/expected_sdn_interfaces | 4 src/test/zones/vlan/bridge/sdn_config | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/S

[pve-devel] applied: [PATCH cluster] datacenter config: mark notification settings as deprecated/unused

2024-03-25 Thread Thomas Lamprecht
Am 19/01/2024 um 11:30 schrieb Lukas Wagner: > These were part of the first version of the notification overhaul > which was already rolled out in pvetest. To avoid breakage for users > who may have used the version from pvetest, we do not remove them yet > and only mark them as unused or deprecate

[pve-devel] applied: [PATCH docs] installation: update link to installing on top of Debian to bookworm version

2024-03-25 Thread Thomas Lamprecht
Am 22/03/2024 um 12:11 schrieb Christoph Heiss: > Seems this just was forgotten, Buster is quite old at this point. > > Signed-off-by: Christoph Heiss > --- > pve-installation.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! __

Re: [pve-devel] [PATCH-SERIES v3 manager/docs] close #4513: add performance tab for backup jobs

2024-03-25 Thread Fiona Ebner
Am 07.11.23 um 14:49 schrieb Fiona Ebner: > Improve fallback for the 'performance' sub-properties by using a > per-property fallback and honor schema defaults. > > Expose commonly used performance-related properties in the backup job > UI under a new tab. > Ping. Still applies. I need to tell fo

Re: [pve-devel] [PATCH v2 pve-network 0/5] SDN tests in sbuild

2024-03-25 Thread Max Carrara
On Thu Mar 7, 2024 at 4:13 PM CET, Stefan Lendl wrote: > Extract and mock functions that otherwise access system files which is not > possible in a clean sbuild environment. > Namely /etc/network/interfaces as well as /etc/frr/frr.config.local > Disabling DNS tests > > Changes v1 -> v2: > * Disable

Re: [pve-devel] [PATCH v2 pve-network 4/5] tests: disable failing DNS tests

2024-03-25 Thread Max Carrara
On Thu Mar 7, 2024 at 4:13 PM CET, Stefan Lendl wrote: > Signed-off-by: Stefan Lendl > --- > src/test/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/test/Makefile b/src/test/Makefile > index eb59d5f..db70c89 100644 > --- a/src/test/Makefile > +++ b/src/test/

Re: [pve-devel] [PATCH v2 pve-network 3/5] tests: mocking more functions to avoid system access

2024-03-25 Thread Max Carrara
On Thu Mar 7, 2024 at 4:13 PM CET, Stefan Lendl wrote: > previously extracted functions are now mocked in the zone tests > > Signed-off-by: Stefan Lendl > --- > src/test/run_test_zones.pl | 36 +++- > 1 file changed, 35 insertions(+), 1 deletion(-) > > diff --git a

Re: [pve-devel] [PATCH v2 pve-network 2/5] refactor(evpn): extract read_local_frr_config

2024-03-25 Thread Max Carrara
Should just be "evpn: [...]" as per our commit guidelines [0], but this can honestly be changed while applying. Otherwise LGTM! [0]: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages On Thu Mar 7, 2024 at 4:13 PM CET, Stefan Lendl wrote: > to allow mocking local f

Re: [pve-devel] [PATCH v2 pve-network 1/5] refactor(controllers): extract read_etc_network_interfaces

2024-03-25 Thread Max Carrara
Should just be "controllers: [...]" as per our commit guidelines [0], but this can honestly be changed while applying. Otherwise LGTM! [0]: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages On Thu Mar 7, 2024 at 4:13 PM CET, Stefan Lendl wrote: > to allow mocking

[pve-devel] [PATCH container] mountpoint mount: activate PVE-managed volumes during preparation

2024-03-25 Thread Fiona Ebner
Otherwise it was not possible to hotplug a volume that was previously deactivated and requires activation, e.g. an LVM LV that was detached after shutting down the container couldn't be hotplugged anymore later. Signed-off-by: Fiona Ebner --- Requires the following patch to be tested on recent k

Re: [pve-devel] [PATCH container] fix #5160: fix move_mount regression for mount point hotplug

2024-03-25 Thread Fiona Ebner
Am 25.03.24 um 11:29 schrieb Fiona Ebner: > > After shutdown+start, the hotplug worked as expected. Played around a > bit more and something strange happened with LVM as the storage: While > it worked the first time, when I shut down the container, detached the > mount point, started again and the

Re: [pve-devel] [PATCH container] fix #5160: fix move_mount regression for mount point hotplug

2024-03-25 Thread Fiona Ebner
Am 08.01.24 um 14:54 schrieb Filip Schauer: > Set up an Apparmor profile to allow moving mounts for mount point > hotplug. > > This fixes a regression caused by > kernel commit 157a3537d6 ("apparmor: Fix regression in mount mediation") > > The commit introduced move_mount mediation, which now req

Re: [pve-devel] [PATCH manager 9/9] report: add microcode info to better assess possible system impacts

2024-03-25 Thread Thomas Lamprecht
On 22/03/2024 14:59, Alexander Zeidler wrote: > * list availability and installation status of `*microcode` packages > * grep for applied "Early OS Microcode Updates" > * grep for (un)patched CPU vulnerability messages > > Signed-off-by: Alexander Zeidler > --- > PVE/Report.pm | 2 ++ > 1 file c

Re: [pve-devel] [PATCH manager 6/9] report: switch `dmidecode` to quiet to omit almost never needed info

2024-03-25 Thread Thomas Lamprecht
On 22/03/2024 14:59, Alexander Zeidler wrote: > like on this system: > > # dmidecode -t bios > # dmidecode 3.4 > Getting SMBIOS data from sysfs. > SMBIOS 3.0.0 present. > > Handle 0x, DMI type 0, 24 bytes > > Handle 0x005C, DMI type 13, 22 bytes The manual page here states that this

Re: [pve-devel] [PATCH manager 5/9] report: move `lscpu` & cluster info to more appropriate sections

2024-03-25 Thread Thomas Lamprecht
And why are those more appropriate? Both fit's the general "always important" section, so even though they fit the section you moved them too, they also fit the general one, so some actual reasoning here would be good.. On 22/03/2024 14:59, Alexander Zeidler wrote: > Signed-off-by: Alexander Zeidl

Re: [pve-devel] [PATCH manager 2/9] report: add `jobs.cfg` to debug related network/load/backup/etc issues

2024-03-25 Thread Thomas Lamprecht
On 22/03/2024 14:59, Alexander Zeidler wrote: > Suggested-by: Friedrich Weber > Signed-off-by: Alexander Zeidler > --- > PVE/Report.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/Report.pm b/PVE/Report.pm > index d4191769..6014f13e 100644 > --- a/PVE/Report.pm > +++ b/PVE/Repor

Re: [pve-devel] [PATCH manager 3/9] report: add list of upgradable packages

2024-03-25 Thread Thomas Lamprecht
On 22/03/2024 14:59, Alexander Zeidler wrote: > * to easily see if APT already knows about old packages in use and > their exact version > * to reconsider asking for applying updates as a first recommendation > if the list is empty and no updates have been released very recently > > # apt lis

Re: [pve-devel] [PATCH manager 1/9] report: add kernel command line including boot time

2024-03-25 Thread Thomas Lamprecht
On 22/03/2024 14:59, Alexander Zeidler wrote: > While using `/proc/cmdline` would already provide an initial info for > debugging passthrough and similar, the use of `dmesg` is an easy way > to get the boot date as an absolute value for free (additional to the > relative value in `uptime` from `top

[pve-devel] applied: Re: [PATCH cluster] ssh: default to 4096 bit keys when generating

2024-03-25 Thread Thomas Lamprecht
On 21/12/2023 10:46, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > src/PVE/Cluster/Setup.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, (but was a bit to quick with the push before adding Fiona's R-b & T-b, they are still much appreciated) thanks