Re: [pve-devel] [PATCH zfsonlinux v2 2/2] fix #5288: cherry-pick fix for udev-partition links > 16

2024-03-06 Thread Fabian Grünbichler
> Stoiko Ivanov hat am 06.03.2024 14:24 CET geschrieben: > > > see: > https://github.com/openzfs/zfs/pull/15970 > https://github.com/openzfs/zfs/issues/15904 > > for some additional background. FWIW, this one got two approvals upstream in the meantime ;) > Signed-off-by: Stoiko Ivanov > ---

[pve-devel] applied: [PATCH docs 3/9] local-btrfs: unify casing for btrfs

2024-03-06 Thread Thomas Lamprecht
Am 04/03/2024 um 14:22 schrieb Christoph Heiss: > It's mostly spelled BTRFS anyway in our documentation (and also the > official casing AFAICS), so align a few instances where it spelled > lowercase. official spelling is really not consistent and includes at least btrfs, BTRFS and Btrfs – but havi

[pve-devel] applied: [PATCH docs 4/9] getting-help: forum: align wording with pmg-docs

2024-03-06 Thread Thomas Lamprecht
Am 04/03/2024 um 14:22 schrieb Christoph Heiss: > This paragraph as phrased in pmg-docs sounds better & reads easier, so > apply it here too. > > Signed-off-by: Christoph Heiss > --- > getting-help.adoc | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH docs 2/9] asciidoc: introduce `pricing-url` variable, much like pmg-docs

2024-03-06 Thread Thomas Lamprecht
Am 04/03/2024 um 14:22 schrieb Christoph Heiss: > Seems like a pretty sensible thing to do here too. > > Signed-off-by: Christoph Heiss > --- > asciidoc/asciidoc-pve.conf | 1 + > getting-help.adoc | 2 +- > pve-package-repos.adoc | 2 +- > 3 files changed, 3 insertions(+), 2 deleti

[pve-devel] applied: [PATCH docs 1/9] gitignore: add package build outputs

2024-03-06 Thread Thomas Lamprecht
Am 04/03/2024 um 14:22 schrieb Christoph Heiss: > .. much like it many other repos. > > Signed-off-by: Christoph Heiss > --- > .gitignore | 3 +++ > 1 file changed, 3 insertions(+) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.pro

[pve-devel] applied: [PATCH docs] storage: fix zfs over iscsi links

2024-03-06 Thread Thomas Lamprecht
Am 01/03/2024 um 09:21 schrieb Dominik Csapak: > The `_ZFS_over_iSCSI` wiki page is redirected to the legacy page > (for historical reasons), but we want to link to the reference docs > instead. > > for the wiki add the legacy link in a `see also` section, so users can > still reach that page easi

Re: [pve-devel] [PATCH manager] ceph: pool edit: set target ratio to 0 when the value is unset

2024-03-06 Thread Fiona Ebner
Am 06.03.24 um 16:17 schrieb Maximiliano Sandoval: > Fiona Ebner writes: > >> It might be cleaner to just use >> emptyValue: 0, >> in the field declaration like is already done for the "Target Size" >> field. And the same issue is also present for the "Min. # of PGs" field, >> right? > > Thanks

Re: [pve-devel] [PATCH manager] ceph: pool edit: set target ratio to 0 when the value is unset

2024-03-06 Thread Maximiliano Sandoval
Fiona Ebner writes: > It might be cleaner to just use > emptyValue: 0, > in the field declaration like is already done for the "Target Size" > field. And the same issue is also present for the "Min. # of PGs" field, > right? Thanks for the emptyValue tip, I didn't know about it. Unfortunately, I

Re: [pve-devel] [PATCH manager] ceph: pool edit: set target ratio to 0 when the value is unset

2024-03-06 Thread Fiona Ebner
Am 06.03.24 um 15:14 schrieb Maximiliano Sandoval: > If the pool has a target_size_ratio set it might be desirable to unset > its value, e.g. if set by mistake on .mgr. > > Currently unsetting the value won't do anything in the web UI. With this > patch it is set to zero, which the API correctly u

Re: [pve-devel] [PATCH qemu-server 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

2024-03-06 Thread Hannes Dürr
On 3/6/24 15:04, Fiona Ebner wrote: Yes, but the question is what is worse: Needing to re-do the clone or having the VM config on the wrong node? To avoid that, I'd lean towards keeping the behavior of failing the task if deactivating $newvollist fails. After all, at least in case of LVM not

[pve-devel] [PATCH manager] ceph: pool edit: set target ratio to 0 when the value is unset

2024-03-06 Thread Maximiliano Sandoval
If the pool has a target_size_ratio set it might be desirable to unset its value, e.g. if set by mistake on .mgr. Currently unsetting the value won't do anything in the web UI. With this patch it is set to zero, which the API correctly understands and unsets it. one can verify the value set using

[pve-devel] [PATCH qemu-server v2 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

2024-03-06 Thread Hannes Duerr
When a template with disks on LVM is cloned to another node, the volumes are first activated, then cloned and deactivated again after cloning. However, if clones of this template are now created in parallel to other nodes, it can happen that one of the tasks can no longer deactivate the logical vo

Re: [pve-devel] [PATCH qemu-server 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

2024-03-06 Thread Fiona Ebner
Am 06.03.24 um 14:14 schrieb Friedrich Weber: > On 06/03/2024 13:40, Fiona Ebner wrote: >> Am 06.03.24 um 11:47 schrieb Hannes Duerr: >>> @@ -3820,7 +3821,13 @@ __PACKAGE__->register_method({ >>> >>> if ($target) { >>> # always deactivate volumes - avoid lvm LVs to be

[pve-devel] [PATCH zfsonlinux v2 0/2] update ZFS to 2.2.3 and include a fix for udev-links for partitions

2024-03-06 Thread Stoiko Ivanov
changes from v1: * add a fix for #5288 after Fiona managed to reproduce it and we saw it was a known issue addressed by Fabian with a pull-request upstream * add a bit more detail to the submodule-update commit-message minimally tested in my virtual setup, additionally Fiona tested that the fix

[pve-devel] [PATCH zfsonlinux v2 2/2] fix #5288: cherry-pick fix for udev-partition links > 16

2024-03-06 Thread Stoiko Ivanov
see: https://github.com/openzfs/zfs/pull/15970 https://github.com/openzfs/zfs/issues/15904 for some additional background. Signed-off-by: Stoiko Ivanov --- ...rectly-handle-partition-16-and-later.patch | 52 +++ debian/patches/series | 1 + 2 files chang

[pve-devel] [PATCH zfsonlinux v2 1/2] update zfs submodule to 2.2.3 and refresh patches

2024-03-06 Thread Stoiko Ivanov
mostly support for newer kernel-versions, and fixes for the BRT bugs discovered with 2.2.0 (BRT remains disabled by default). The update contains a fix for CVE-2020-24370 in lua (which is present in ZFS for channel-programs, which we do not use) - see: https://github.com/openzfs/zfs/pull/15847 for

Re: [pve-devel] [PATCH qemu-server 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

2024-03-06 Thread Friedrich Weber
On 06/03/2024 13:40, Fiona Ebner wrote: > Am 06.03.24 um 11:47 schrieb Hannes Duerr: >> @@ -3820,7 +3821,13 @@ __PACKAGE__->register_method({ >> >> if ($target) { >> # always deactivate volumes - avoid lvm LVs to be active on >> several nodes >> -PVE

Re: [pve-devel] [PATCH qemu-server 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

2024-03-06 Thread Fiona Ebner
Am 06.03.24 um 11:47 schrieb Hannes Duerr: > @@ -3820,7 +3821,13 @@ __PACKAGE__->register_method({ > > if ($target) { > # always deactivate volumes - avoid lvm LVs to be active on > several nodes > - PVE::Storage::deactivate_volumes($storecfg, $vol

Re: [pve-devel] [PATCH qemu-server 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

2024-03-06 Thread Fiona Ebner
Am 06.03.24 um 12:37 schrieb Friedrich Weber: > Thanks for tackling this! Can confirm this patch demotes the error to a > warning and lets the qmclone task succeed (with a warning). GUI shows > "Warnings: 1" and task log contains: > > can't deactivate LV '/dev/foobar/vm-100-disk-0': Logical volu

Re: [pve-devel] [PATCH qemu-server 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

2024-03-06 Thread Friedrich Weber
Thanks for tackling this! Can confirm this patch demotes the error to a warning and lets the qmclone task succeed (with a warning). GUI shows "Warnings: 1" and task log contains: can't deactivate LV '/dev/foobar/vm-100-disk-0': Logical volume foobar/vm-100-disk-0 in use. WARN: volume deactivatio

[pve-devel] applied: [PATCH pve-common] ticket: remove fallback for SHA1-base64 CSRF prevention tokens

2024-03-06 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH qemu-server 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

2024-03-06 Thread Hannes Duerr
When a template with disks on LVM is cloned to another node, the storage is first activated, then cloned and deactivated again after cloning. However, if clones of this template are now created in parellel to other nodes, it can happen that one of the tasks can no longer deactivate the logical vol

Re: [pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-03-06 Thread Roland Kammerer via pve-devel
--- Begin Message --- On Tue, Mar 05, 2024 at 01:13:08PM +0100, Fabian Grünbichler wrote: > I wonder whether the following wouldn't also work? > > - keep the volume name on the PVE side like the other storage plugins > (which means - encode vital information about the volume there so that > it's p