[pve-devel] SPAM: Re: [PATCH pve-network 1/1] Fixed Netbox API Path

2024-02-20 Thread Jasper Yu via pve-devel
--- Begin Message --- Hi, That's totally fine for me Thanks Jasper Yu About me: https://seadog007.me CV: https://seadog007.work Email: 007sea...@gmail.com, ad...@seadog007.me Phone: +886920498225 On Tue, Feb 20, 2024 at 22:20 Thomas Lamprecht wrote: > Am 20/01/2024 um 18:57 schrieb Jasper Yu

Re: [pve-devel] [PATCH manager v3 04/19] ui: dc: backup: show 'Job ID' column

2024-02-20 Thread Thomas Lamprecht
Am 20/02/2024 um 16:38 schrieb Lukas Wagner: > On 2/20/24 16:23, Thomas Lamprecht wrote: >> I prefer just showing the ID in the advanced section of the General tab >> inside the edit window instead, like your next patch does. >> >> As I'd slightly prefer to avoid showing those rather unwieldy IDs f

Re: [pve-devel] fix #5254: add separate Sys.AccessNetwork privilege

2024-02-20 Thread Hannes Dürr
Tested the patch by 1. * creating a role with 'Datastore.Audit,Datastore.AllocateTemplate,Sys.AccessNetwork' * creating a user with permission for specific {storage} and {node} * downloading the iso via gui 2. * creating a role with 'Datastore.AllocateTemplate,Sys.AccessNetwork' * creatin

Re: [pve-devel] [PATCH manager v3 04/19] ui: dc: backup: show 'Job ID' column

2024-02-20 Thread Lukas Wagner
On 2/20/24 16:23, Thomas Lamprecht wrote: > I prefer just showing the ID in the advanced section of the General tab > inside the edit window instead, like your next patch does. > > As I'd slightly prefer to avoid showing those rather unwieldy IDs for a > feature that's often setup only once, espec

Re: [pve-devel] [PATCH manager v3 04/19] ui: dc: backup: show 'Job ID' column

2024-02-20 Thread Thomas Lamprecht
Am 16/02/2024 um 10:15 schrieb Lukas Wagner: > This is useful for creating matchers based on the 'backup-job' > metadata field. > > Signed-off-by: Lukas Wagner > --- > www/manager6/dc/Backup.js | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/www/manager6/dc/Backup.js

[pve-devel] applied: [PATCH docs] vzdump: remove usage examples involving 'notification-{target, policy}'

2024-02-20 Thread Thomas Lamprecht
Am 14/02/2024 um 10:07 schrieb Lukas Wagner: > Also clarify in one example that using `--mailto` will bypass the > notification system (at least from the user's perspective). > > Signed-off-by: Lukas Wagner > --- > vzdump.adoc | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > >

[pve-devel] [PATCH pve-common] ticket: remove fallback for SHA1-base64 CSRF prevention tokens

2024-02-20 Thread Max Carrara
Signed-off-by: Max Carrara --- As the old inline comment notes, this should've been removed in PVE 7.0 already. src/PVE/Ticket.pm | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/PVE/Ticket.pm b/src/PVE/Ticket.pm index ce8d5c8..c5508ed 100644 --- a/src/PVE/Ticket.pm

[pve-devel] applied: [PATCH docs 2/2] partially fix #5139: document qnetd port requirement

2024-02-20 Thread Thomas Lamprecht
Am 21/12/2023 um 10:29 schrieb Fabian Grünbichler: > we could also add a check somewhere in pve-cluster for this. > > Signed-off-by: Fabian Grünbichler > --- > pvecm.adoc | 3 +++ > 1 file changed, 3 insertions(+) > > applied, with Fiona's proposed changes squashed in as they made sense to me,

[pve-devel] applied: [PATCH docs 1/2] fix #5140: qdevice SSH access documentation

2024-02-20 Thread Thomas Lamprecht
Am 21/12/2023 um 10:29 schrieb Fabian Grünbichler: > rephrase in order to not make it seem like password-based access is required. > > Signed-off-by: Fabian Grünbichler > --- > pvecm.adoc | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > applied, thanks! ___

[pve-devel] applied-series: [PATCH docs v2 0/5] installation and system improvements

2024-02-20 Thread Thomas Lamprecht
Am 25/01/2024 um 12:06 schrieb Christoph Heiss: > This mainly updates the installation section, to bring it up-to-date > with the latest available installer ISO. > > v1: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060814.html > > Changes v1 -> v2: > * rebased on lastest master >

Re: [pve-devel] [PATCH pve-network 1/1] Fixed Netbox API Path

2024-02-20 Thread Thomas Lamprecht
Am 20/01/2024 um 18:57 schrieb Jasper Yu: > --- > src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm > b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm > index 91010bb..666ea70 100644 > --- a/src

[pve-devel] applied: [PATCH v2 pve-network 0/6] external ipams fixes

2024-02-20 Thread Thomas Lamprecht
Am 13/02/2024 um 09:48 schrieb Alexandre Derumier: > multiples ipam fixes > > v2: > add netbox ipam ip_is_gateway fix > > > > Alexandre Derumier (6): > ipams : add_next_freeip : return ip not cidr > sdn: add proxy support for api calls > ipam: phpipam: fix subnet create > ipam: phpipam:

[pve-devel] FOSDEM 2024 feedback (Was: Re: fosdem feeback)

2024-02-20 Thread Gilou via pve-devel
--- Begin Message --- Le 20/02/2024 à 13:58, Gilou via pve-devel a écrit : Overall, I'd do it again, it was nice, but that is not a walk in the park, be advised. People are really willing to engage, and discuss, and were somehow surprised we weren't actually Proxmox employees 😉 Ah, and an addi

Re: [pve-devel] fosdem feeback

2024-02-20 Thread Gilou via pve-devel
--- Begin Message --- Le 05/02/2024 à 10:43, DERUMIER, Alexandre a écrit : Hi, Here a summary of the weekend. First, thanks to you guys to be there, it was great to finally meet you ! Hi, I missed that email, shame on me! Thanks a lot Alexandre for that feedback, this week-end was indeed cra

[pve-devel] applied: [PATCH pve-manager] qemu: bump max cores to 256 by socket

2024-02-20 Thread Thomas Lamprecht
Am 12/01/2024 um 21:08 schrieb Alexandre Derumier: > New epyc cpu already support 168 threads > > qemu 8.1 support 1024 cores with q35 > --- > www/manager6/qemu/ProcessorEdit.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, as even though removing the maximum here (or upp

[pve-devel] applied-series: [PATCH docs 1/3] qm: resource limits: revise section cpulimit

2024-02-20 Thread Thomas Lamprecht
Am 16/01/2024 um 14:22 schrieb Alexander Zeidler: > * precise statements > * increase compactness w/o complexity > * improve section-formatting > > Signed-off-by: Alexander Zeidler > --- > qm.adoc | 40 +--- > 1 file changed, 21 insertions(+), 19 deletions(-)

[pve-devel] applied: [PATCH docs] pvecm: correct network address

2024-02-20 Thread Thomas Lamprecht
Am 16/01/2024 um 14:10 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > pvecm.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists

[pve-devel] applied: [PATCH docs] ballooning: precise example

2024-02-20 Thread Thomas Lamprecht
Am 16/01/2024 um 16:04 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > qm.adoc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://li