Re: [pve-devel] [PATCH manager] ui: node: system: avoid using 'Syslog'

2024-02-15 Thread Fiona Ebner
Am 15.02.24 um 19:25 schrieb Dietmar Maurer: > I can also imaging using "Events" instead of "Syslog". > > - title: 'Syslog', > + title: gettext('Events'), > > IMHO this is easier to translate. > Then at least "System Events". Otherwise it leaves the question "what kind o

Re: [pve-devel] [PATCH manager] ui: node: system: avoid using 'Syslog'

2024-02-15 Thread Fiona Ebner
Am 15.02.24 um 19:20 schrieb Dietmar Maurer: >> The information gathered by the API call comes from the systemd >> journal. While 'Syslog' could be interpreted as a shorthand for >> "System Log", it's better to be explicit to avoid any confusion. > >> -title: 'Syslog', >> +

[pve-devel] [PATCH manager] Update UI and backend integration for OpenID group creation

2024-02-15 Thread Alexis | Dawnalex
This commit introduces significant updates to the UI and backend to support group creation through OpenID. Changes include modifications to the frontend to accommodate new group management functionalities and backend enhancements for seamless OpenID integration. Signed-off-by: Alexis | Dawnalex

[pve-devel] [PATCH access-control] Add OpenID group sync in pve-access-control

2024-02-15 Thread Alexis | Dawnalex
This commit adds the group synchronization feature to OpenID authentication, allowing automatic user group mapping and updates based on the OpenID provider information. Enhances integration and access control within Proxmox VE. Signed-off-by: Alexis | Dawnalex --- src/PVE/API2/OpenId.pm | 83 +

Re: [pve-devel] [PATCH manager] ui: node: system: avoid using 'Syslog'

2024-02-15 Thread Dietmar Maurer
I can also imaging using "Events" instead of "Syslog". - title: 'Syslog', + title: gettext('Events'), IMHO this is easier to translate. > With your change: > > - title: 'Syslog', > + title: gettext('System Log'), > > we now need to translate

Re: [pve-devel] [PATCH manager] ui: node: system: avoid using 'Syslog'

2024-02-15 Thread Dietmar Maurer
> The information gathered by the API call comes from the systemd > journal. While 'Syslog' could be interpreted as a shorthand for > "System Log", it's better to be explicit to avoid any confusion. > - title: 'Syslog', > + title: gettext('System Log'), From Wikipedia: htt

Re: [pve-devel] [PATCH v2 quincy-stable-8 ceph 1/2] patches: include patches regarding RocksDB and dashboard from master

2024-02-15 Thread Max Carrara
On 2/15/24 14:09, Thomas Lamprecht wrote: > Am 26/01/2024 um 16:44 schrieb Max Carrara: >> This commit essentially contains all changes from the following >> commits (most recent last): >> * f35168f6713d5f3fa1aaa8c572d754b61c458d91 >> * 86a553d66e69176940959530d4fedcbcbbab54d9 >> * ab5c03b44d

Re: [pve-devel] [PATCH V2 pve-firewall 1/1] fix #1965: cache firewall/cluster.fw file

2024-02-15 Thread Lukas Wagner
On 11/25/22 15:47, Stefan Hrdlicka wrote: > for large IP sets (for example > 25k) it takes noticable longer to parse the > files, this commit caches the cluster.fw file and reduces parsing time > > Signed-off-by: Stefan Hrdlicka > --- > src/PVE/Firewall.pm | 108 ++---

Re: [pve-devel] [PATCH ceph master 3/3] buildsys: add check for changed ceph-osd sysctl settings

2024-02-15 Thread Thomas Lamprecht
Am 15/02/2024 um 10:40 schrieb Friedrich Weber: > If the ceph-osd sysctl settings template (30-ceph-osd.conf.in) shipped > by upstream changes, our ceph-osd postinst patch will need to be > adapted to apply the new settings on package upgrade. To make sure we > do not forget, store the current chec

[pve-devel] applied: [PATCH ceph quincy-stable-8 2/3] fix #5213: ceph-osd postinst: add patch to avoid connection freezes

2024-02-15 Thread Thomas Lamprecht
Am 15/02/2024 um 10:40 schrieb Friedrich Weber: > Assume there is an open TCP connection to a VM, and ceph-osd is > installed/upgraded on the host on which the PVE firewall is active. > Currently, ceph-osd postinst reloads all sysctl settings. Thus, > installing/upgrading ceph-osd will set the sysc

[pve-devel] applied: [PATCH ceph master 1/3] fix #5213: ceph-osd postinst: add patch to avoid connection freezes

2024-02-15 Thread Thomas Lamprecht
Am 15/02/2024 um 10:40 schrieb Friedrich Weber: > Assume there is an open TCP connection to a VM, and ceph-osd is > installed/upgraded on the host on which the PVE firewall is active. > Currently, ceph-osd postinst reloads all sysctl settings. Thus, > installing/upgrading ceph-osd will set the sysc

Re: [pve-devel] [PATCH v2 quincy-stable-8 ceph 1/2] patches: include patches regarding RocksDB and dashboard from master

2024-02-15 Thread Thomas Lamprecht
Am 26/01/2024 um 16:44 schrieb Max Carrara: > This commit essentially contains all changes from the following > commits (most recent last): > * f35168f6713d5f3fa1aaa8c572d754b61c458d91 > * 86a553d66e69176940959530d4fedcbcbbab54d9 > * ab5c03b44d78c4e4b233ff5a310888592dbb9bb4 > > The series fi

[pve-devel] [PATCH manager] ui: node: system: avoid using 'Syslog'

2024-02-15 Thread Fiona Ebner
Reported in the community forum [0]. Since Proxmox VE 8/Debian 12, rsyslog is not installed by default for new installations anymore [1]. The information gathered by the API call comes from the systemd journal. While 'Syslog' could be interpreted as a shorthand for "System Log", it's better to be e

[pve-devel] [PATCH installer 0/5] proxinstall, tui: improve hostname/FQDN validation

2024-02-15 Thread Christoph Heiss
This series improves various aspects regarding FQDN handling and validation across both the GUI and TUI installer. It (partially) addresses issue #5230 [0] in patch #5, by fixing the regex through which we validate FQDNs in the GUI installer. It also refactors the FQDN validation/parsing in the G

[pve-devel] [PATCH installer 2/5] common: fqdn: implement case-insensitive comparison as per RFC 952

2024-02-15 Thread Christoph Heiss
Multiple DNS-related RFCs (notably RFC 952, RFC 1035 and RFC 4343) reinforce that FQDN must not be case-sensitive. Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/utils.rs | 28 ++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/proxmox-inst

[pve-devel] [PATCH installer 4/5] sys: net: do not allow overlong FQDNs as per RFCs and Debian spec

2024-02-15 Thread Christoph Heiss
Debian limits labels to 63 characters each and the total length to 253 characters [0]. [0] https://manpages.debian.org/stable/manpages/hostname.7.en.html Signed-off-by: Christoph Heiss --- Proxmox/Sys/Net.pm | 5 - test/parse-fqdn.pl | 4 2 files changed, 8 insertions(+), 1 deletion(-)

[pve-devel] [PATCH installer 1/5] common: fqdn: do not allow overlong FQDNs as per Debian spec

2024-02-15 Thread Christoph Heiss
Debian limits labels to 63 characters each and the total length to 253 characters [0]. While at it, reference all the RFCs that apply when parsing FQDNs. [0] https://manpages.debian.org/stable/manpages/hostname.7.en.html Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/utils.rs

[pve-devel] [PATCH installer 5/5] fix #5230: sys: net: properly escape FQDN regex

2024-02-15 Thread Christoph Heiss
Due to interpolation, the \. sequence must be double-escaped. Previously, this would result in a non-escaped dot, thus matching much more liberally than it should. Signed-off-by: Christoph Heiss --- Proxmox/Sys/Net.pm| 2 +- proxmox-installer-common/src/utils.rs | 6 ++ t

[pve-devel] [PATCH installer 3/5] proxinstall: avoid open-coding FQDN sanity check

2024-02-15 Thread Christoph Heiss
.. by moving it into its own subroutine. Makes the whole thing quite a bit neater and easier to maintain. No functional changes. Signed-off-by: Christoph Heiss --- FWIW, might be a nice case for refactoring using perlmod and reusing the (more fleshed-out) Rust implementation from the proxmox-ins

[pve-devel] [PATCH ceph master 1/3] fix #5213: ceph-osd postinst: add patch to avoid connection freezes

2024-02-15 Thread Friedrich Weber
Assume there is an open TCP connection to a VM, and ceph-osd is installed/upgraded on the host on which the PVE firewall is active. Currently, ceph-osd postinst reloads all sysctl settings. Thus, installing/upgrading ceph-osd will set the sysctl setting `net.bridge.bridge-nf-call-iptables` to 0. Th

[pve-devel] [PATCH ceph master+quincy-stable-8 0/3] fix #5213: avoid connection freezes when installing/upgrading ceph-osd

2024-02-15 Thread Friedrich Weber
Currently, installing or upgrading ceph-osd on a host can freeze existing TCP connections to VMs in certain scenarios. See bug #5213 and patch #1 for details. - patch #1 (based on master) adds a patch to ceph-osd postinst. I'll also send an upstream pull request for this one. - patch #2 (based o

[pve-devel] [PATCH ceph quincy-stable-8 2/3] fix #5213: ceph-osd postinst: add patch to avoid connection freezes

2024-02-15 Thread Friedrich Weber
Assume there is an open TCP connection to a VM, and ceph-osd is installed/upgraded on the host on which the PVE firewall is active. Currently, ceph-osd postinst reloads all sysctl settings. Thus, installing/upgrading ceph-osd will set the sysctl setting `net.bridge.bridge-nf-call-iptables` to 0. Th

[pve-devel] [PATCH ceph master 3/3] buildsys: add check for changed ceph-osd sysctl settings

2024-02-15 Thread Friedrich Weber
If the ceph-osd sysctl settings template (30-ceph-osd.conf.in) shipped by upstream changes, our ceph-osd postinst patch will need to be adapted to apply the new settings on package upgrade. To make sure we do not forget, store the current checksum of that file in our Makefile and fail the build ear