If $noprint is set, the output of the command won't be printed to stdout
of the parent process.
Fully backwards-compatible again, only takes effect if the new argument
is actually specified.
Signed-off-by: Christoph Heiss
---
Changes since v1:
* added parameter documentation
Proxmox/Sys/Comm
If the logging subroutine $func returns CMD_FINISHED after processing a
line, the running subprocess is killed early.
This mechanism can be used when e.g. only a certain part of the output
of a (long-running) command is needed, avoiding the extra time it would
take the command to finish properly.
Some detection routines might try to log things and call some
Proxmox::Ui functions all the way down, so just initialize it with the
stdio backend to avoid errors.
Signed-off-by: Christoph Heiss
---
Changes since v1:
* no changes
proxmox-low-level-installer | 1 +
1 file changed, 1 insertion(
This fixes a rather longstanding issue [0][1] with the country
detection, in that it might get completely stuck and thus hangs the
installation.
This is due how Perl, signals and line reading interacts.
A minimal reproducer, how the installer currently works, looks like
this:
```
#!/usr/bin/e
This moves the kill() + waitpid() combo into a separate subroutine,
avoiding open-coding that sequence. wait_for_process() also handles
properly unkillable process (e.g. in D-state) and avoids completely
locking up the installer in such cases. See [0].
For the latter case, a timeout exists (with a
Previously, the I/O loop would continue endlessly until the subprocess
exited.
This explicit handling allows run_command() to be used with e.g.
alarm().
Signed-off-by: Christoph Heiss
---
Changes since v1:
* new patch
Proxmox/Sys/Command.pm | 9 -
test/run-command.pl| 11
For all the details, see patch #6.
TL;DR: SIGALRM does not interrupt line reading using <>, causing the
installer to hang on country detection. Fix it by using
Proxmox::Sys::Command::run_command(), which properly interacts with
SIGALRM.
Patch #1 is a rather mundane fix for some niche cases, #2 is
Am 13.02.24 um 12:52 schrieb Markus Frank:
> Thanks,
>
> I already moved most of the code into a new PVE/QemuServer/Virtiofs.pm
> module.
>
Great! :)
> Just an clarification & question concerning the queue-size:
>
> On 2024-01-31 16:02, Fiona Ebner wrote:
>>> + push @$devices, '-chardev',
Thanks,
I already moved most of the code into a new PVE/QemuServer/Virtiofs.pm module.
Just an clarification & question concerning the queue-size:
On 2024-01-31 16:02, Fiona Ebner wrote:
+ push @$devices, '-chardev',
"socket,id=virtfs$i,path=/var/run/virtiofsd/vm$vmid-fs$i";
+ pu
It's broken since
https://git.proxmox.com/?p=pve-network.git;a=commit;h=3e3cafabaf955d53c4c2d4e346bf5c3a5c6d1852
Signed-off-by: Alexandre Derumier
---
www/manager6/sdn/zones/EvpnEdit.js | 5 +
1 file changed, 5 insertions(+)
diff --git a/www/manager6/sdn/zones/EvpnEdit.js
b/www/manager6/sd
Thanks for the catch!
pushed a fix-up
On Tue, 6 Feb 2024 13:20:51 +0100
Thomas Lamprecht wrote:
> Am 22/01/2024 um 18:58 schrieb Stoiko Ivanov:
> > applied this one to pmg-docs - huge thanks!
> >
> >
> > On Mon, Jul 10, 2023 at 03:49:49PM +0200, Noel Ullreich wrote:
> >> Since the actual sy
On 2/12/24 14:34, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> This commit adds the `set_ceph_crash_conf` function, which dynamically
>> adapts the host's Ceph configuration in order to allow the Ceph crash
>> module's daemon to run without elevated privileges.
>>
On 2/12/24 14:34, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> when creating the cluster's first monitor.
>>
>> Signed-off-by: Max Carrara
>> ---
>> Changes v1 --> v2:
>> * do not enable/restart `ceph-crash` anymore when creating first mon
>> * drop changes to
On 2/12/24 14:33, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> cephconfig: allow writing arbitrary sections
>>
>> This adds support for writing arbitrary sections to 'ceph.conf' while
>> ensuring that already written sections are not duplicated.
>>
>> Sections that
Signed-off-by: Alexandre Derumier
---
src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm
b/src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm
index f3f22b5..bb9f322 100644
--- a/src/PVE/Network/
we want same result than add_next_free_range
Signed-off-by: Alexandre Derumier
---
src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 13 -
src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 2 +-
src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm | 2 +-
3 files changed, 6 insertions(+), 11 deletions
multiples ipam fixes
v2:
add netbox ipam ip_is_gateway fix
Alexandre Derumier (6):
ipams : add_next_freeip : return ip not cidr
sdn: add proxy support for api calls
ipam: phpipam: fix subnet create
ipam: phpipam: fix get_ip_from_mac
ipam: phpipam: add_range_next_freeip
ipam: netbox
Signed-off-by: Alexandre Derumier
---
src/PVE/Network/SDN/Ipams/NetboxPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm
index 14a69d9..d923269 100644
--- a/src/PVE/Network/SDN/Ipams/
Currently is not possible in phpipam to search in specific range,
fallback to full subnet search
Signed-off-by: Alexandre Derumier
---
src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm | 12
1 file changed, 12 insertions(+)
diff --git a/src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm
b/src/PV
Signed-off-by: Alexandre Derumier
---
src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm
b/src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm
index 7b3168d..f3f22b5 100644
--- a/src/PVE/Network/SDN/I
Signed-off-by: Alexandre Derumier
---
src/PVE/Network/SDN.pm | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
index 3af09b5..b8f27d9 100644
--- a/src/PVE/Network/SDN.pm
+++ b/src/PVE/Network/SDN.pm
@@ -264,10 +264,9 @@ sub
On 2/12/24 14:33, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> This adds support for writing arbitrary sections to 'ceph.conf' while
>> ensuring that already written sections are not duplicated.
>>
>> Sections that are associated with the client, for example
>> '[c
On 2/12/24 14:33, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> 1. Comments, irrespective of whether they start with '#' or ';' are
>> now treated the same. Otherwise, sections and key-value pairs with
>> a trailing comment starting with ';' are still parse
On 2/12/24 14:32, Fabian Grünbichler wrote:
> On February 5, 2024 6:54 pm, Max Carrara wrote:
>> Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
>> to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'.
>>
>> This patch therefore also updates the permissio
24 matches
Mail list logo
