[pve-devel] applied: [PATCH v1 installer 04/18] Makefile: fix handling of multiple usr_bin files

2024-02-06 Thread Thomas Lamprecht
Am 23/01/2024 um 18:00 schrieb Aaron Lauterer: > Otherwise the build will fail once we define more than one USR_BIN > file. > > Signed-off-by: Aaron Lauterer > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied this one already, thanks! ___

Re: [pve-devel] [PATCH installer 0/2] expose zfs arc size setting for all products

2024-02-06 Thread Thomas Lamprecht
Am 06/02/2024 um 14:25 schrieb Christoph Heiss: > On Tue, Feb 06, 2024 at 01:49:36PM +0100, Thomas Lamprecht wrote: >> That way it would stay dynamic, e.g., if one increased the memory of >> a PBS or PMG instance, but one could also interpret that as bad thing, >> especially if the MiB number was s

Re: [pve-devel] [PATCH installer 0/2] expose zfs arc size setting for all products

2024-02-06 Thread Christoph Heiss
On Tue, Feb 06, 2024 at 01:49:36PM +0100, Thomas Lamprecht wrote: > Am 30/11/2023 um 11:01 schrieb Christoph Heiss: > > As suggested by Thomas, sets the default to 50% for all non-PVE > > products. > > > > Quickly smoke-tested this, to see if all installer show the correct > > value in the GUI/TUI.

[pve-devel] [PATCH installer] proxinstall, common: remove "off" as zfs checksum option

2024-02-06 Thread Christoph Heiss
See also the thread at [0] for the initial discussion/idea. Disabling checksums is considered an "extraordinarily bad idea" [1] (for pretty obvious reason) and nobody should really ever use it. Thus remove the option completely; just so that users cannot simply disable checksum "for performance r

Re: [pve-devel] applied: [RFC PATCH installer] proxinstall, common: remove deprecated fletcher2 as zfs checksum algorithm

2024-02-06 Thread Christoph Heiss
On Tue, Feb 06, 2024 at 01:17:57PM +0100, Thomas Lamprecht wrote: > Am 22/12/2023 um 11:52 schrieb Christoph Heiss: > > Fletcher-2 has long been deprecated and should not be used anymore > > [0][1], so we probably should not offer it anymore too. It's been > > deprecated since at least over 3 years

Re: [pve-devel] [PATCH installer 0/2] expose zfs arc size setting for all products

2024-02-06 Thread Thomas Lamprecht
Am 30/11/2023 um 11:01 schrieb Christoph Heiss: > As suggested by Thomas, sets the default to 50% for all non-PVE > products. > > Quickly smoke-tested this, to see if all installer show the correct > value in the GUI/TUI. What I'm wondering if we should skip actively setting this as module parame

Re: [pve-devel] applied: [PATCH pmg_docs 1/1] Consistency of GB and GiB pmg

2024-02-06 Thread Thomas Lamprecht
Am 22/01/2024 um 18:58 schrieb Stoiko Ivanov: > applied this one to pmg-docs - huge thanks! > > > On Mon, Jul 10, 2023 at 03:49:49PM +0200, Noel Ullreich wrote: >> Since the actual system-checks are done in GiB and to stay consistent >> with the other docs, change all GB units to GiB >> >> Signed

[pve-devel] applied: [RFC PATCH installer] proxinstall, common: remove deprecated fletcher2 as zfs checksum algorithm

2024-02-06 Thread Thomas Lamprecht
Am 22/12/2023 um 11:52 schrieb Christoph Heiss: > Fletcher-2 has long been deprecated and should not be used anymore > [0][1], so we probably should not offer it anymore too. It's been > deprecated since at least over 3 years, beyond that it's hard to find an > exact date. > > Signed-off-by: Chris

Re: [pve-devel] [PATCH v1 installer 14/18] auto-installer: add fetch answer binary

2024-02-06 Thread Christoph Heiss
On Tue, Jan 23, 2024 at 06:00:49PM +0100, Aaron Lauterer wrote: > [..] > diff --git a/proxmox-auto-installer/src/bin/proxmox-fetch-answer.rs > b/proxmox-auto-installer/src/bin/proxmox-fetch-answer.rs > new file mode 100644 > index 000..baf2bd2 > --- /dev/null > +++ b/proxmox-auto-installer/src

[pve-devel] [PATCH pve-access-control] fix #5190: access-control: openid acr format regex

2024-02-06 Thread Gabriel Goller
Restrict the acr-value regex a little bit so as to align the behavior with PBS. The openid documentation says that the acr-value *should* be an URI [0]. Added a regex that loosely disallows some of the reserved URI characters specified in the RFC [1]. Values like: * "urn:mace:incommon:iap:silver"

[pve-devel] [PATCH v2 proxmox stable-2 2/2] apt: repos: Remove unneeded unwrap for codename variant

2024-02-06 Thread Christian Ebner
The call to next now does not return an Option, but rahter contains a dedicated Unknown variant. Therefore the unwrap call can be avoided and the panic to calls to `pveversion` when /etc/os-release contained `VERSION_CODENAME=trixie` can be avoided. Reported in the community forum: https://forum.p

Re: [pve-devel] [RFC kernel-meta] add proxmox-secure-boot-support package

2024-02-06 Thread Thomas Lamprecht
Am 05/02/2024 um 12:45 schrieb Fabian Grünbichler: > On February 2, 2024 7:23 pm, Thomas Lamprecht wrote: >> seems OK w.r.t. change, but do we want this to be either part of the shim, >> or a separate repo? So that we do not need to ship a new kernel meta package >> when the shim version pinning ne

[pve-devel] applied: [PATCH v2 qemu] fix #4507: add patch to automatically increase NOFILE soft limit

2024-02-06 Thread Thomas Lamprecht
Am 05/02/2024 um 14:13 schrieb Fiona Ebner: > In many configurations, e.g. multiple vNICs with multiple queues or > with many Ceph OSDs, the default soft limit of 1024 is not enough. > QEMU is supposed to work fine with file descriptors >= 1024 and does > not use select() on POSIX. Bump the soft li

Re: [pve-devel] [PATCH proxmox master stable-2 1/2] apt: repos: extend `Codename` by `Unknown` variant

2024-02-06 Thread Christian Ebner
> You only match the current codename and DebianCodename::Unknown(_, _). > Any known newer codename will just fall through to the default arm (and > the default arm can/should be avoided by pulling in the check for the > older codename from above). Ah now I see, thanks for noticing and for clarifi

Re: [pve-devel] [PATCH proxmox master stable-2 1/2] apt: repos: extend `Codename` by `Unknown` variant

2024-02-06 Thread Fiona Ebner
Am 06.02.24 um 09:48 schrieb Christian Ebner: > >>> >>> -if Some(codename) == current_codename.next() { >>> -add_info("ignore-pre-upgrade-warning", >>> message_new(base_suite)); >>> -} else if codename > current_codename { >>> -

Re: [pve-devel] [PATCH proxmox master stable-2 1/2] apt: repos: extend `Codename` by `Unknown` variant

2024-02-06 Thread Christian Ebner
> > > > -if Some(codename) == current_codename.next() { > > -add_info("ignore-pre-upgrade-warning", > > message_new(base_suite)); > > -} else if codename > current_codename { > > -add_info("warning", message_new(base_suite

Re: [pve-devel] [PATCH proxmox master stable-2 1/2] apt: repos: extend `Codename` by `Unknown` variant

2024-02-06 Thread Fiona Ebner
Am 05.02.24 um 18:08 schrieb Christian Ebner: > Instead of returning an Option for the Codename variant, with None for > unknowns, extend the enum by an Unknown variant with additional internal > type to avoid misuse of this variant. > > Co-authored-by: Wolfgang Bumiller > Signed-off-by: Christia