[pve-devel] [PATCH v2 master ceph, quincy-stable 8 ceph, pve-storage, pve-manager 00/11] Fix #4759: Configure Permissions for ceph-crash.service

2024-02-05 Thread Max Carrara
This marks version 02 of the patch series "Fix #4759: Configure Permissions for ceph-crash.service" [0]. Each patch also lists which changes have been made between versions. Other changes not otherwise mentioned in patches: v1 --> v2: * drop patch regarding POSIX compatibility in debian/po

[pve-devel] [PATCH v2 quincy-stable-8 ceph 04/11] patches: add patch that reorders clients used by ceph-crash

2024-02-05 Thread Max Carrara
This patch makes it so that `ceph-crash` attempts to use the non-host-specific keyring before anything else, which avoids unnecessary error messages landing in the systemd-journal in our case. Signed-off-by: Max Carrara --- Changes v1 --> v2: * new ...h-crash-change-order-of-client-names.patc

[pve-devel] [PATCH v2 master ceph 01/11] debian: add patch to fix ceph crash dir permissions in postinst hook

2024-02-05 Thread Max Carrara
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*' to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'. This patch therefore also updates the permissions of '/var/lib/ceph/*/*'. Signed-off-by: Max Carrara --- Changes v1 --> v2: * use `find` instead of

[pve-devel] [PATCH v2 quincy-stable-8 ceph 03/11] debian: add patch to fix ceph crash dir permissions in postinst hook

2024-02-05 Thread Max Carrara
Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*' to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'. This patch therefore also updates the permissions of '/var/lib/ceph/*/*'. Signed-off-by: Max Carrara --- Changes v1 --> v2: * use `find` instead of

[pve-devel] [PATCH v2 pve-manager 09/11] fix #4759: ceph: configure keyring for ceph-crash.service

2024-02-05 Thread Max Carrara
when creating the cluster's first monitor. Signed-off-by: Max Carrara --- Changes v1 --> v2: * do not enable/restart `ceph-crash` anymore when creating first mon * drop changes to function `ceph_service_cmd` as they are no longer needed * create keyring for `ceph-crash` before modifying

[pve-devel] [PATCH v2 pve-manager 11/11] fix #4759: debian/postinst: configure ceph-crash.service and its key

2024-02-05 Thread Max Carrara
This commit adds the `set_ceph_crash_conf` function, which dynamically adapts the host's Ceph configuration in order to allow the Ceph crash module's daemon to run without elevated privileges. This adaptation is only performed if: * Ceph is installed * Ceph is configured ('/etc/pve/ceph.conf' ex

[pve-devel] [PATCH v2 pve-storage 06/11] cephconfig: allow writing arbitrary sections

2024-02-05 Thread Max Carrara
This adds support for writing arbitrary sections to 'ceph.conf' while ensuring that already written sections are not duplicated. Sections that are associated with the client, for example '[client.foo]', are written directly after the '[client]' section. Signed-off-by: Max Carrara --- Changes v1

[pve-devel] [PATCH v2 pve-manager 10/11] ceph: create '/etc/pve/ceph' during `pveceph init`

2024-02-05 Thread Max Carrara
Signed-off-by: Max Carrara --- Changes v1 --> v2: * none PVE/API2/Ceph.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 81c17d6e..7fedb87a 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -192,6 +192,11 @@ __PACKAGE__->register_method

[pve-devel] [PATCH v2 pve-manager 08/11] ceph: fix edge case of wrong files being deleted on purge

2024-02-05 Thread Max Carrara
Having a file named e.g. "60" in your current directory will cause it to be deleted when executing `pveceph purge`. This commit fixes that by making the config hash differ between which values represent file paths and which don't. Signed-off-by: Max Carrara --- Changes v1 --> v2:as * use two ha

[pve-devel] [PATCH v2 pve-storage 05/11] cephconfig: align our parser more with Ceph's parser

2024-02-05 Thread Max Carrara
1. Comments, irrespective of whether they start with '#' or ';' are now treated the same. Otherwise, sections and key-value pairs with a trailing comment starting with ';' are still parsed. Consider this example: [some.section] # inline comment after section foo = bar ; in

[pve-devel] [PATCH v2 master ceph 02/11] patches: add patch that reorders clients used by ceph-crash

2024-02-05 Thread Max Carrara
This patch makes it so that `ceph-crash` attempts to use the non-host-specific keyring before anything else, which avoids unnecessary error messages landing in the systemd-journal in our case. Signed-off-by: Max Carrara --- Changes v1 --> v2: * new ...h-crash-change-order-of-client-names.patc

[pve-devel] [PATCH v2 pve-storage 07/11] amend! cephconfig: allow writing arbitrary sections

2024-02-05 Thread Max Carrara
cephconfig: allow writing arbitrary sections This adds support for writing arbitrary sections to 'ceph.conf' while ensuring that already written sections are not duplicated. Sections that are associated with the client, for example '[client.foo]', are written directly after the '[client]' section

[pve-devel] [PATCH proxmox stable-2 2/2] apt: repos: Remove unneeded unwrap for codename variant

2024-02-05 Thread Christian Ebner
The call to next now does not return an Option, but rahter contains a dedicated Unknown variant. Therefore the unwrap call can be avoided and the panic to calls to `pveversion` when /etc/os-release contained `VERSION_CODENAME=trixie` can be avoided. Reported in the community forum: https://forum.p

Re: [pve-devel] [PATCH qemu] fix #4507: add patch to automatically increase NOFILE soft limit

2024-02-05 Thread Fiona Ebner
Am 12.12.23 um 14:42 schrieb Fiona Ebner: > In many configurations, e.g. multiple vNICs with multiple queues or > with many Ceph OSDs, the default soft limit of 1024 is not enough. > QEMU is supposed to work fine with file descriptors >= 1024 and does > not use select() on POSIX. Bump the soft limi

[pve-devel] [PATCH v2 qemu] fix #4507: add patch to automatically increase NOFILE soft limit

2024-02-05 Thread Fiona Ebner
In many configurations, e.g. multiple vNICs with multiple queues or with many Ceph OSDs, the default soft limit of 1024 is not enough. QEMU is supposed to work fine with file descriptors >= 1024 and does not use select() on POSIX. Bump the soft limit to the allowed hard limit to avoid issues with t

Re: [pve-devel] [PATCH common 1/2] REST environment: warn helpers: use warn instead of printing to stderr

2024-02-05 Thread Fiona Ebner
Am 05.02.24 um 13:38 schrieb Thomas Lamprecht: > Am 05/02/2024 um 13:28 schrieb Fiona Ebner: >> Like this, __WARN__ handlers will still be called. In particular, >> daemons like pvestatd will set a __WARN__ handler and also log >> warnings to syslog. The intention behind introducing log_warn() was

Re: [pve-devel] [RFC common 2/2] REST environment: fork worker: install custom __WARN__ handler

2024-02-05 Thread Fiona Ebner
Am 05.02.24 um 13:39 schrieb Thomas Lamprecht: > Am 05/02/2024 um 13:28 schrieb Fiona Ebner: >> So all warnings will be treated consistently inside a worker task. In >> particular, all warnings will count towards the task warning count and >> be more visible in the UI. Avoids the need to switch exi

Re: [pve-devel] [RFC common 2/2] REST environment: fork worker: install custom __WARN__ handler

2024-02-05 Thread Thomas Lamprecht
Am 05/02/2024 um 13:28 schrieb Fiona Ebner: > So all warnings will be treated consistently inside a worker task. In > particular, all warnings will count towards the task warning count and > be more visible in the UI. Avoids the need to switch existing warnings > to log_warn(). > > When pvedaemon

Re: [pve-devel] [PATCH common 1/2] REST environment: warn helpers: use warn instead of printing to stderr

2024-02-05 Thread Thomas Lamprecht
Am 05/02/2024 um 13:28 schrieb Fiona Ebner: > Like this, __WARN__ handlers will still be called. In particular, > daemons like pvestatd will set a __WARN__ handler and also log > warnings to syslog. The intention behind introducing log_warn() was to > make warnings more visible, not less, so fix th

[pve-devel] [RFC common 2/2] REST environment: fork worker: install custom __WARN__ handler

2024-02-05 Thread Fiona Ebner
So all warnings will be treated consistently inside a worker task. In particular, all warnings will count towards the task warning count and be more visible in the UI. Avoids the need to switch existing warnings to log_warn(). When pvedaemon forked a worker, the worker would inherit its __WARN__ h

[pve-devel] [PATCH common 1/2] REST environment: warn helpers: use warn instead of printing to stderr

2024-02-05 Thread Fiona Ebner
Like this, __WARN__ handlers will still be called. In particular, daemons like pvestatd will set a __WARN__ handler and also log warnings to syslog. The intention behind introducing log_warn() was to make warnings more visible, not less, so fix the semantics to make sure switching from warn to log_

Re: [pve-devel] [PATCH pve-manager 5/8] fix #4759: ceph: configure keyring for ceph-crash.service

2024-02-05 Thread Max Carrara
On 1/31/24 14:17, Fabian Grünbichler wrote: > On January 30, 2024 7:40 pm, Max Carrara wrote: >> when creating the cluster's first monitor. >> >> Signed-off-by: Max Carrara >> --- >> PVE/API2/Ceph/MON.pm | 28 +++- >> PVE/Ceph/Services.pm | 12 ++-- >> PVE/Ceph/Too

Re: [pve-devel] [RFC kernel-meta] add proxmox-secure-boot-support package

2024-02-05 Thread Fabian Grünbichler
On February 2, 2024 7:23 pm, Thomas Lamprecht wrote: > Am 26/01/2024 um 13:05 schrieb Fabian Grünbichler: >> installing it at least gives the admin a heads up if our base Debian release >> is >> ever faster shipping a newer version of shim or Grub, which would look >> (something) like this: >> >>

Re: [pve-devel] applied: [PATCH v2 qemu] add patches to work around stuck guest IO with iothread and VirtIO block/SCSI

2024-02-05 Thread Fiona Ebner
Am 02.02.24 um 19:42 schrieb Thomas Lamprecht: > > basically applied this, thanks. > > Basically, as I went for the v2 [0], as the series file needed some adaption > due to recent v8.1.5 patch I just made a new commit but kept your message and > added an Originally-by Trailer, hope that's all ri

[pve-devel] fosdem feeback

2024-02-05 Thread DERUMIER, Alexandre
Hi, Here a summary of the weekend. First, thanks to you guys to be there, it was great to finally meet you ! users were pretty happy to see finally a proxmox stand at fosdem - we have seen a llooo of people on the stand with questions. (I have 10min break on the full weekend). We alwa