[pve-devel] applied: [PATCH proxmox-i18n] es: Improve translations

2023-11-29 Thread Thomas Lamprecht
Am 29/11/2023 um 14:31 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > Improvements made after going through the three web UIs. > > es.po | 62 +-- > sl.po | 2 +- > 2 files changed, 32 insertions(+), 32 deletio

[pve-devel] applied: [PATCH docs] fix #5089: pvesdn: replace quest(s) -> guest(s)

2023-11-29 Thread Thomas Lamprecht
Am 29/11/2023 um 16:08 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > pvesdn.adoc | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https:/

[pve-devel] [PATCH docs] fix #5089: sdn: fix s/quest/guest/ typo

2023-11-29 Thread Stoiko Ivanov
additionally did a `git grep '\bquest'` for good measure Signed-off-by: Stoiko Ivanov --- pvesdn.adoc | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index fdc6ea7..53293b1 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -381,7 +381,7 @@

[pve-devel] [PATCH docs] fix #5089: pvesdn: replace quest(s) -> guest(s)

2023-11-29 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- pvesdn.adoc | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index fdc6ea7..53293b1 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -381,7 +381,7 @@ Zone:: The associated zone for this VNet Tag:: The unique

[pve-devel] applied: [PATCH pve-network] tests: mocking cfs_lock_file to pass subnet tests

2023-11-29 Thread Thomas Lamprecht
Am 24/11/2023 um 14:16 schrieb Stefan Lendl: > IPAM tries to lock file in clusterfs which it can't when testing as > non-root. > > Mocking cfs_lock_file to emulate locking behavior. > > Signed-off-by: Stefan Lendl > --- > src/test/run_test_subnets.pl | 20 +++- > 1 file changed,

[pve-devel] [PATCH proxmox-i18n] es: Improve translations

2023-11-29 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- Improvements made after going through the three web UIs. es.po | 62 +-- sl.po | 2 +- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/es.po b/es.po index 262e86c..132f82a 100644 ---

[pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

2023-11-29 Thread Maximiliano Sandoval
Note that ACME is already in 3 translatable strings, a similar remark applies to N/A which is already translated in many languages. Signed-off-by: Maximiliano Sandoval --- src/node/DNSView.js | 2 +- src/panel/ACMEDomains.js | 2 +- src/panel/DiskList.js

[pve-devel] applied: [PATCH proxmox-i18n] es: update Spanish translations

2023-11-29 Thread Thomas Lamprecht
Am 28/11/2023 um 12:13 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > es.po | 3934 +++-- > 1 file changed, 1608 insertions(+), 2326 deletions(-) > > applied, thanks! _

Re: [pve-devel] seem than ifupdown2 is installed by default on upgrade (a friend reported me an ipv6 slaac bug)

2023-11-29 Thread DERUMIER, Alexandre
>> >>But here, the non working setup is mixing "inet dhcp" + "inet6 auto" >> >> >>" >>auto vmbr2 >>iface vmbr2 inet dhcp >>   bridge-ports eth0 >>   bridge-stp off >>   bridge-fd 0 >> >>iface vmbr2 inet6 auto >>" Ok, I found the bug, this is because ifupdown2 only allow 1 method for t

[pve-devel] [PATCH manager v2] ui: mark strings translatable

2023-11-29 Thread Maximiliano Sandoval
The string `proxmox.Utils.defaultText + ' (free)'` was inlined as `Default (Unrestricted)` cutting translatable strings makes them harder or even impossible to translate in certain languages. Additionally the extra context makes the work of translators easier. Signed-off-by: Maximiliano Sandoval

[pve-devel] [PATCH widget-toolkit] notify: sendmail: smtp: fix mailto/mailto-user parameter deletion

2023-11-29 Thread Lukas Wagner
Both fields were moved to a separate panel at some point, but this broke parameter deletion behavior (e.g. if a target is modified and switches from using mailto to mailto-user, then mailto should be deleted) Signed-off-by: Lukas Wagner --- src/panel/SendmailEditPanel.js | 7 +++ src/panel/S

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-29 Thread Fiona Ebner
Am 29.11.23 um 10:48 schrieb Dietmar Maurer: >>> So what languages are the problem exactly? Please can you >>> give me an example? >> >> Any right-to-left languages could be broken. > > This is not really true. RTL languages just render string in the other > direction, so string concatenation sti

[pve-devel] applied: [PATCH pve-network] dhcp: dnsmasq: Use dir_glob_foreach for deleting configuration files

2023-11-29 Thread Thomas Lamprecht
Am 28/11/2023 um 09:58 schrieb Stefan Hanreich: > The current invocation is quite unsafe and triggers the taint mode of > Perl. Replacing it with dir_glob_foreach solves those issues. > > Reported-By: Friedrich Weber > Signed-off-by: Stefan Hanreich > --- > I wasn't sure whether directly unlinki

[pve-devel] applied: [PATCH] update kernel to 6.5.11 and ZFS to 2.2.1, refresh patches

2023-11-29 Thread Thomas Lamprecht
Am 28/11/2023 um 16:07 schrieb Stoiko Ivanov: > * for the kernel-patch this includes a rename from 0003+0004 to > 0001+0002 > * for ZFS there was a change in upstream's autotools-setup - I > referenced the commit in the actual patch-file > > minimally tested with a VM with a zfs-pool and an ex

[pve-devel] applied: [PATCH pve-network] api: vnet: fix warning in vnet API

2023-11-29 Thread Thomas Lamprecht
Am 27/11/2023 um 11:23 schrieb Stefan Hanreich: > If zone is not set, we also check the pending changes for a zone key, > since it is set as pending when the Vnet settings have not yet been > applied. > > Signed-off-by: Stefan Hanreich > --- > src/PVE/API2/Network/SDN/Vnets.pm | 2 +- > 1 file c

[pve-devel] applied-series: [PATCH i18n 1/3] german: unify different words of the same meaning

2023-11-29 Thread Thomas Lamprecht
Am 24/11/2023 um 19:28 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > de.po | 38 +++--- > 1 file changed, 19 insertions(+), 19 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-d

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-29 Thread Dietmar Maurer
> > So what languages are the problem exactly? Please can you > > give me an example? > > Any right-to-left languages could be broken. This is not really true. RTL languages just render string in the other direction, so string concatenation still works as expected. > > Am 28/11/2023 um 15:46 s

[pve-devel] applied: [qemu-server] fix: do not allow live-migration with clipboard=vnc

2023-11-29 Thread Fiona Ebner
Am 24.11.23 um 13:32 schrieb Markus Frank: > In the migrate_vm_precondition API function if clipboard > is set to vnc on a running VM the text "clipboard=vnc" > gets added to local_resources so that the GUI blocks execution and shows: > "Can't migrate VM with local resources: clipboard=vnc" > > In

[pve-devel] applied: [PATCH pve-network] validation: add support for arrays to change tracking

2023-11-29 Thread Thomas Lamprecht
Am 22/11/2023 um 13:28 schrieb Stefan Hanreich: > This is needed so dhcp-ranges are properly displayed as changed in the > web UI. > > Also took the chance to properly indent the encode_value function with > our indentation scheme. > > Signed-off-by: Stefan Hanreich > --- > src/PVE/Network/SDN.

[pve-devel] [PATCH zfsonlinux 1/2] cherry-pick fix for data corruption

2023-11-29 Thread Fabian Grünbichler
cherry-picked from 2.2.0-staging, fixing https://github.com/openzfs/zfs/issues/15526 Signed-off-by: Fabian Grünbichler --- ...heck-dnode-and-its-data-for-dirtines.patch | 97 +++ debian/patches/series | 1 + 2 files changed, 98 insertions(+) create mode

[pve-devel] [PATCH pve-kernel 2/2] bump version to 6.5.11-6

2023-11-29 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Makefile | 2 +- debian/changelog | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index f0d119c..991e39e 100644 --- a/Makefile +++ b/Makefile @@ -6,7 +6,7 @@ KERNEL_MIN=5 KERNEL_PATCHLEVEL=11 # increment

[pve-devel] [PATCH pve-kernel 1/2] update zfs to 2.2.0-pve4

2023-11-29 Thread Fabian Grünbichler
which contains the fix for https://github.com/openzfs/zfs/issues/15526 Signed-off-by: Fabian Grünbichler --- submodules/zfsonlinux | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/submodules/zfsonlinux b/submodules/zfsonlinux index e295f30..00036e5 16 --- a/submodules/zfso

[pve-devel] [PATCH zfsonlinux 2/2] bump version to 2.2.0-pve4

2023-11-29 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- debian/changelog | 7 +++ 1 file changed, 7 insertions(+) diff --git a/debian/changelog b/debian/changelog index 5bd9d2a..f2fa727 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +zfs-linux (2.2.0-pve4) bookworm; urgency=medium + +

[pve-devel] (already applied) [PATCH zfsonlinux/kernel 0/4] Fix ZFS data corruption bug

2023-11-29 Thread Fabian Grünbichler
cherry-picked from upstream's staging-2.2.2 and verified using the reproducer script on an affected machine. kernel side (actual fix): Fabian Grünbichler (2): update zfs to 2.2.0-pve4 bump version to 6.5.11-6 Makefile | 2 +- debian/changelog | 6 ++ submodules/zfsonli

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-29 Thread Thomas Lamprecht
Am 29/11/2023 um 09:08 schrieb Maximiliano Sandoval: >>> If its only right-to-left languages, we could just add another helper >>> to assemble lists in the correct order? > > The GNOME l10n guidelines at least have an entry about not splitting > strings. > > While it does not apply to this partic

Re: [pve-devel] [PATCH manager] ui: mark strings translatable

2023-11-29 Thread Maximiliano Sandoval
> btw. @Maximiliano: "Free" is rather a bad original text for the Noted. Will send a v2 in a bit. >> If its only right-to-left languages, we could just add another helper >> to assemble lists in the correct order? The GNOME l10n guidelines at least have an entry about not splitting strings. W