Re: [pve-devel] [PATCH v2 pve-docs 0/6] sdn: Documentation

2023-11-18 Thread Thomas Lamprecht
Am 17/11/2023 um 14:55 schrieb Stefan Lendl: > * Try to homogenize style and format > * Title case naming conventions for configuration options > * Simplify examples > * Re-phrase descriptions > > Changes to v1 -> v2: > > * Split changes per chapter. > * Use multi-line heading format like in the

[pve-devel] applied: [PATCH novnc v14 4/6] add "show clipboard button" patch to series

2023-11-18 Thread Thomas Lamprecht
please add some reference for why you do this next time, "qemu-server will gain VGA clipboard support so this can be used for virtual machines too in the future" could be already enough, as then one knows where to look at for information about where this is used. Am 14/11/2023 um 10:22 schrieb

Re: [pve-devel] [PATCH v4 pve-network 10/33] api: add endpoints for managing PVE IPAM

2023-11-18 Thread Thomas Lamprecht
Am 17/11/2023 um 12:39 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich > --- > src/PVE/API2/Network/SDN.pm | 6 + > src/PVE/API2/Network/SDN/Ipam.pm | 221 ++ > src/PVE/API2/Network/SDN/Makefile | 2 +- > 3 files changed, 228 insertions(+), 1 delet

Re: [pve-devel] [PATCH v4 cluster/network/manager/qemu-server/container/docs 00/33] Add support for DHCP servers to SDN

2023-11-18 Thread DERUMIER, Alexandre
>>* dnsmasq and IPv6 (and DHCP in general) do not really play well >>together, >>    so using subnets with IPv6 configured is wonky It should be fixed my last patches. The default gw with RA is still buggy for me. I wonder if after 8.1 release, we shouldn't also implement static configuration (t

Re: [pve-devel] [PATCH v4 pve-manager 20/33] sdn: ipam: add ipam panel

2023-11-18 Thread DERUMIER, Alexandre
On 11/17/23 16:04, DERUMIER, Alexandre wrote: > I wonder if this panel could be integrated in zone panel (accessible > from the tree). >>I fear that this might overload the panel a bit. I was think about a new menu > as It's not related to the sdn configuration itself. (and don't need > sdn relo

[pve-devel] [PATCH pve-network 6/7] dnsmasq: fix ipv6 support

2023-11-18 Thread Alexandre Derumier
ether file should have 1 line by mac address with ip4+ip6 ip6 address should be in braced [ip6] for now: don't update ip6 through bus as it seem to be incorrect Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 64 + 1 file changed, 37 inse

[pve-devel] [PATCH pve-network 2/7] api2: ipam : remove add|del_mapping in mac/ip management

2023-11-18 Thread Alexandre Derumier
only register/del ip in ipam here. The dhcp mapping is done a vm start. Signed-off-by: Alexandre Derumier --- src/PVE/API2/Network/SDN/Ipam.pm | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/PVE/API2/Network/SDN/Ipam.pm b/src/PVE/API2/Network/SDN/Ipam.pm index e71ca7d..722baa4 100

[pve-devel] [PATCH pve-network 5/7] dnsmasq: enable dbus && purge old ip lease on reservation

2023-11-18 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm b/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm index 652b146..b469272 100644 --- a/src/PVE/Network/SDN/Dhcp/Dnsma

[pve-devel] [PATCH pve-network 3/7] dhcp : remove del_ip_mapping

2023-11-18 Thread Alexandre Derumier
The cleanup is done in add_ip_mapping Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 34 - src/PVE/Network/SDN/Dhcp/Plugin.pm | 5 - 2 files changed, 39 deletions(-) diff --git a/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm b/src/PVE/Networ

[pve-devel] [PATCH pve-network 0/7] dhcp v4

2023-11-18 Thread Alexandre Derumier
Apply on top of stefan patch v4 series changes: - fix tests from last stefan patches changes - dnsmasq: update lease cache through bus (for ipv4 only) - dnsmasq: use static range to avoid to distribute dynamic ips - dnsmasq: fix ipv6 config && ethers format dhcpv6 ip distribution works fine

[pve-devel] [PATCH pve-network 4/7] dnsmasq: configure static range for each subnet

2023-11-18 Thread Alexandre Derumier
we don't want dynamic lease, simply define each subnet as a static range. dhcp-range defined on a subnet is only used by ipam plugin. This will also allow to use dhcp subnet without need to define a range. Can be usefull for external ipam like phpipam, where you can't define ranges. Signed-off-b

[pve-devel] [PATCH pve-network 7/7] dhcp : dnsmasq: generate dbus policy

2023-11-18 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm b/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm index 0dd6436..7b54532 100644 --- a/src/PVE/Network/SDN/Dhcp/Dnsmasq

[pve-devel] [PATCH pve-network 1/7] fix subnet tests

2023-11-18 Thread Alexandre Derumier
- add vmid in in ipam.db - remove ip value in ipam.db (is already the key) Signed-off-by: Alexandre Derumier --- src/test/run_test_subnets.pl | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/test/run_test_subnets.pl b/src/test/run_test_subnets.pl ind