Re: [pve-devel] [PATCH v4 cluster/network/manager/qemu-server/container/docs 00/33] Add support for DHCP servers to SDN

2023-11-17 Thread DERUMIER, Alexandre
ok, I have fixed ipv6 support (tested with linux && windows). reservation by mac seem to be work. (Maybe the dbus update is wrong, I need to test it more deeply). I'll send a patch tommorow. Message initial De: "DERUMIER, Alexandre" Répondre à: Proxmox VE development discussi

[pve-devel] applied: [PATCH installer] tui: fix interface sort order

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 18:30 schrieb Stoiko Ivanov: > currently when multiple nics are present in a system the TUI > sometimes selects the wrong interface (not the one that has the > default gateway/dhcp lease) > > I assume this is due to HashMap's values yielding an iterator in > arbitrary order > > S

[pve-devel] [PATCH installer] tui: fix interface sort order

2023-11-17 Thread Stoiko Ivanov
currently when multiple nics are present in a system the TUI sometimes selects the wrong interface (not the one that has the default gateway/dhcp lease) I assume this is due to HashMap's values yielding an iterator in arbitrary order Signed-off-by: Stoiko Ivanov --- sadly a bit difficult to test

[pve-devel] applied: [PATCH installer] tui: bootdisk zfs config: add a maximum value to the `copies` option

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 17:32 schrieb Stefan Sterz: > according to `man zfsprops` the copies option can only be 1, 2, or 3. > limit the field to 3, as setting higher options can't work anyway. > > Signed-off-by: Stefan Sterz > --- > i would have added a `min_value` of 1 too, but `IntegerEditView` is > b

[pve-devel] applied: [PATCH zfsonlinux] pick bug-fixes staged for 2.2.1

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 15:03 schrieb Stoiko Ivanov: > ZFS 2.2.1 is currently being prepared, but the 3 patches added here > seem quite relevant, as the might cause dataloss/panics on setups > which run `zpool upgrade`. > See upstreams discussion for 2.2.1: > https://github.com/openzfs/zfs/pull/15498/ > a

[pve-devel] [PATCH installer] tui: bootdisk zfs config: add a maximum value to the `copies` option

2023-11-17 Thread Stefan Sterz
according to `man zfsprops` the copies option can only be 1, 2, or 3. limit the field to 3, as setting higher options can't work anyway. Signed-off-by: Stefan Sterz --- i would have added a `min_value` of 1 too, but `IntegerEditView` is based on `NumericEditView` and that doesn't offer a minimal

Re: [pve-devel] [PATCH v4 cluster/network/manager/qemu-server/container/docs 00/33] Add support for DHCP servers to SDN

2023-11-17 Thread DERUMIER, Alexandre
>>I've checked the documentation and it seems to support it (in our case >>at least, since we have direct connection - correct me if I am wrong): >>From [1], the documentation for dhcp-host: >>" Note that in IPv6 DHCP, the hardware address may not be available, >>though it normally is for direc

[pve-devel] applied: [RFC PATCH installer 1/2] ui: stdio: replace newlines with whitespaces in prompt messages

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 14:45 schrieb Christoph Heiss: > The line-based protocol currently used cannot handle this properly, so > introduce this as a stop-gap measure - otherwise messages might be cut > off. > > This makes it work for now, and the text is wrapped correctely for the > screen width in the

Re: [pve-devel] [PATCH v4 cluster/network/manager/qemu-server/container/docs 00/33] Add support for DHCP servers to SDN

2023-11-17 Thread Stefan Hanreich
On 11/17/23 17:05, Stefan Hanreich wrote: > Maybe the issue here are the respective fwbr interfaces inbetween? I guess that's unlikely since that would affect VMs as well I suppose ___ pve-devel mailing list pve-devel@lists.proxmox.com https://list

Re: [pve-devel] [PATCH v4 cluster/network/manager/qemu-server/container/docs 00/33] Add support for DHCP servers to SDN

2023-11-17 Thread Stefan Hanreich
On 11/17/23 16:47, DERUMIER, Alexandre wrote: >>>   * dnsmasq and IPv6 (and DHCP in general) do not really play well >>> together, >>>     so using subnets with IPv6 configured is wonky > > I didn't have tested yet, but it's seem that dnsmasq only support old > classic duid reservation and not m

[pve-devel] applied: [PATCH container v2] setup: fix architecture detection for NixOS containers

2023-11-17 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v4 cluster/network/manager/qemu-server/container/docs 00/33] Add support for DHCP servers to SDN

2023-11-17 Thread DERUMIER, Alexandre
>>  * dnsmasq and IPv6 (and DHCP in general) do not really play well >>together, >>    so using subnets with IPv6 configured is wonky I didn't have tested yet, but it's seem that dnsmasq only support old classic duid reservation and not mac ? because kea allow mac reservation for https://kea.re

[pve-devel] applied-series: [PATCH v2 many 00/52] revamp notifications; smtp endpoints; system mail

2023-11-17 Thread Thomas Lamprecht
applied the whole series, much thanks, really nice work here! Also applied the follow-ups from Dominik, thanks for helping out! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH access-control 1/2] allow up to three levels of pool nesting

2023-11-17 Thread Fabian Grünbichler
> Wolfgang Bumiller hat am 17.11.2023 11:00 CET > geschrieben: > > > On Thu, Nov 16, 2023 at 04:31:25PM +0100, Fabian Grünbichler wrote: > > with ACLs being inherited along the pool hierarchy. > > > > Signed-off-by: Fabian Grünbichler > > --- > > src/PVE/AccessControl.pm | 10 -- > >

Re: [pve-devel] [PATCH access-control 2/2] pools: record parent/subpool information

2023-11-17 Thread Fabian Grünbichler
> Wolfgang Bumiller hat am 17.11.2023 11:10 CET > geschrieben: > > > On Thu, Nov 16, 2023 at 04:31:26PM +0100, Fabian Grünbichler wrote: > > and ensure a missing intermediate pool exists at all times. > > > > Signed-off-by: Fabian Grünbichler > > --- > > > > Notes: > > a "missing link"

Re: [pve-devel] [PATCH manager 1/2] api: pools: support nested pools

2023-11-17 Thread Fabian Grünbichler
> Wolfgang Bumiller hat am 17.11.2023 12:58 CET > geschrieben: > minor issue > > diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm > > index 51ac71941..54e744558 100644 > > --- a/PVE/API2/Pool.pm > > +++ b/PVE/API2/Pool.pm > > @@ -354,6 +476,9 @@ __PACKAGE__->register_method ({ > > > >

[pve-devel] applied: [PATCH manager] pvesh: proxy handler: fix handling array parameters

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 15:58 schrieb Fiona Ebner: > As reported in the community forum and reproduced locally, issuing a > QEMU guest agent command would lead to an error when proxying to > another node: > >> root@pve8a2 ~ # pvesh create /nodes/pve8a1/qemu/126/agent/exec --command >> 'whoami' >> Wide c

Re: [pve-devel] [PATCH v4 pve-manager 20/33] sdn: ipam: add ipam panel

2023-11-17 Thread Stefan Hanreich
On 11/17/23 16:04, DERUMIER, Alexandre wrote: > I wonder if this panel could be integrated in zone panel (accessible > from the tree). I fear that this might overload the panel a bit. > as It's not related to the sdn configuration itself. (and don't need > sdn reload) > > I think yhis could a

Re: [pve-devel] [PATCH manager 2/2] ui: fw: allow selecting network interface for rules using combogrid

2023-11-17 Thread Wolfgang Bumiller
just some thoughts from my side: On Thu, May 11, 2023 at 11:46:20AM +0200, Christoph Heiss wrote: > For nodes, VMs and CTs we can show the user a list of available network > interfaces (as that information is available) when creating a new > firewall rule, much like it is already done in similar p

Re: [pve-devel] [PATCH v4 pve-network 06/33] subnet: vnet: refactor IPAM related methods

2023-11-17 Thread Stefan Hanreich
On 11/17/23 15:13, Stefan Lendl wrote: > If an IP was found, the loop will just start again. > This should be (tested): > > last if $ip; Ah yes, I fixed the symptom of this already elsewhere but here it makes a lot more sense! ___ pve-devel mailing

Re: [pve-devel] [PATCH manager v14 5/6] add clipboard checkbox to VM Options

2023-11-17 Thread Dominik Csapak
one minor nit inline, but not a blocker for me did not test again, but the changes are small enough imho aside from that, this patch (and the series since i already reviewed the previous versions and there did not change anything) Reviewed-by: Dominik Csapak On 11/14/23 10:22, Markus Frank wr

[pve-devel] applied: [PATCH pve-docs] gitignore

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 15:40 schrieb Stefan Lendl: > build output and temporary intermediate files > > Signed-off-by: Stefan Lendl > --- > .gitignore | 11 +++ > 1 file changed, 11 insertions(+) > > applied, same & same as the others, thanks! ___

Re: [pve-devel] [PATCH v4 pve-manager 20/33] sdn: ipam: add ipam panel

2023-11-17 Thread DERUMIER, Alexandre
I wonder if this panel could be integrated in zone panel (accessible from the tree). as It's not related to the sdn configuration itself. (and don't need sdn reload) I think yhis could allow to give permissions to user to manage ips in the zone, without need to access to datacenter panel --

[pve-devel] [PATCH manager 2/2] ui: vm wizard: allow second iso for windows vms

2023-11-17 Thread Dominik Csapak
This is useful for adding the virtio-win iso for new installs, and thus we change the default disk type to scsi and network type to virtio. Signed-off-by: Dominik Csapak --- there is still a bug (can look into it monday) where when the the checkbox is unselected again, the default disk is ide1 in

[pve-devel] [PATCH manager 1/2] ui: refactor iso selector out of the cd input panel

2023-11-17 Thread Dominik Csapak
and make it into a proper field it's intended to be used like a single field and exactly as before Signed-off-by: Dominik Csapak --- www/manager6/Makefile| 1 + www/manager6/form/IsoSelector.js | 107 +++ www/manager6/qemu/CDEdit.js | 38 ++

[pve-devel] applied: [PATCH pve-container] gitignore

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 15:30 schrieb Stefan Lendl: > build output > > Signed-off-by: Stefan Lendl > --- > .gitignore | 4 > 1 file changed, 4 insertions(+) > create mode 100644 .gitignore > > applied, same w.r.t. commit subject and glob specificness __

[pve-devel] applied: [PATCH pve-manager] gitignore

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 15:26 schrieb Stefan Lendl: > build outputs > > Signed-off-by: Stefan Lendl > --- > .gitignore | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > applied, same w.r.t. actual commit message, single words are never a good idea for them. I also made the globs mo

[pve-devel] [PATCH manager] pvesh: proxy handler: fix handling array parameters

2023-11-17 Thread Fiona Ebner
As reported in the community forum and reproduced locally, issuing a QEMU guest agent command would lead to an error when proxying to another node: > root@pve8a2 ~ # pvesh create /nodes/pve8a1/qemu/126/agent/exec --command > 'whoami' > Wide character in die at /usr/share/perl5/PVE/RESTHandler.pm

[pve-devel] applied: [PATCH pve-network] gitignore

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 15:23 schrieb Stefan Lendl: > build outputs > > Signed-off-by: Stefan Lendl > --- > .gitignore | 5 + > 1 file changed, 5 insertions(+) > create mode 100644 .gitignore > > applied, but same here, added an actual subject and a more specific glob for the build-dir...

[pve-devel] applied: [PATCH qemu-server] gitignore

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 15:20 schrieb Stefan Lendl: > build output and .vscode > > Signed-off-by: Stefan Lendl > --- > .gitignore | 2 ++ > 1 file changed, 2 insertions(+) > > applied, with the build-dir made slightly more specific by using /qemu-server-[0-9]*/ and the subject changed to something me

[pve-devel] [PATCH pve-docs] gitignore

2023-11-17 Thread Stefan Lendl
build output and temporary intermediate files Signed-off-by: Stefan Lendl --- .gitignore | 11 +++ 1 file changed, 11 insertions(+) diff --git a/.gitignore b/.gitignore index 36e2dd5..4f95ee9 100644 --- a/.gitignore +++ b/.gitignore @@ -5,3 +5,14 @@ *.tmp *.epub *.swp +/#*# +/.pve-do

[pve-devel] [PATCH pve-container] gitignore

2023-11-17 Thread Stefan Lendl
build output Signed-off-by: Stefan Lendl --- .gitignore | 4 1 file changed, 4 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 000..e9d7353 --- /dev/null +++ b/.gitignore @@ -0,0 +1,4 @@ +/pve-container-*/ +/*.deb +/*.buildin

[pve-devel] [PATCH pve-manager] gitignore

2023-11-17 Thread Stefan Lendl
build outputs Signed-off-by: Stefan Lendl --- .gitignore | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index a6ab4ea7..a4093add 100644 --- a/.gitignore +++ b/.gitignore @@ -4,7 +4,8 @@ dest/ *.buildinfo *.changes -www/manager6/OnlineHelp

[pve-devel] [PATCH pve-network] gitignore

2023-11-17 Thread Stefan Lendl
build outputs Signed-off-by: Stefan Lendl --- .gitignore | 5 + 1 file changed, 5 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 000..6370dfa --- /dev/null +++ b/.gitignore @@ -0,0 +1,5 @@ +/libpve-network-perl-*/ +*.deb +/*.

[pve-devel] [PATCH qemu-server] gitignore

2023-11-17 Thread Stefan Lendl
build output and .vscode Signed-off-by: Stefan Lendl --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index e48cf98..caaef23 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,5 @@ sparsecp vmtar build qm.bash-completion +/.vscode/ +/qemu-server-*/

Re: [pve-devel] [PATCH v4 pve-network 06/33] subnet: vnet: refactor IPAM related methods

2023-11-17 Thread Stefan Lendl
Stefan Hanreich writes: > @@ -230,10 +227,28 @@ sub next_free_ip { > my $plugin_config = $ipam_cfg->{ids}->{$ipamid}; > my $plugin = > PVE::Network::SDN::Ipams::Plugin->lookup($plugin_config->{type}); > eval { > - $cidr = $plugin->add_next_freeip($plugin_config, $subnet

Re: [pve-devel] [PATCH pve-docs] sdn: update documentation

2023-11-17 Thread Stefan Lendl
sent v2 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-network] sdn: allow deletion of empty subnet with gateway

2023-11-17 Thread Stefan Lendl
If the gateway IP is last remaining IP in the subnet (in IPAM), allow deleting the subnet. Signed-off-by: Stefan Lendl --- src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Ipams/PVEPlugin.pm b/src/PVE

[pve-devel] [PATCH zfsonlinux] pick bug-fixes staged for 2.2.1

2023-11-17 Thread Stoiko Ivanov
ZFS 2.2.1 is currently being prepared, but the 3 patches added here seem quite relevant, as the might cause dataloss/panics on setups which run `zpool upgrade`. See upstreams discussion for 2.2.1: https://github.com/openzfs/zfs/pull/15498/ and the most critical issue: https://github.com/openzfs/zfs

[pve-devel] [PATCH v2 pve-docs 6/6] sdn: Examples

2023-11-17 Thread Stefan Lendl
Signed-off-by: Stefan Lendl --- pvesdn.adoc | 486 +++- 1 file changed, 180 insertions(+), 306 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index 450955d..17135cc 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -508,74 +508,96 @@ key:: An API

[pve-devel] [PATCH v2 pve-docs 2/6] sdn: Zones

2023-11-17 Thread Stefan Lendl
Signed-off-by: Stefan Lendl --- pvesdn.adoc | 185 ++-- 1 file changed, 93 insertions(+), 92 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index 562e081..8a71c03 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -86,189 +86,190 @@ in your SDN set

[pve-devel] [PATCH v2 pve-docs 4/6] sdn: Controllers

2023-11-17 Thread Stefan Lendl
Signed-off-by: Stefan Lendl --- pvesdn.adoc | 56 + 1 file changed, 31 insertions(+), 25 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index c4b77f0..73d3dee 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -336,36 +336,41 @@ DNS Zone Prefix

[pve-devel] [PATCH v2 pve-docs 1/6] sdn: installation, overview and main configuration

2023-11-17 Thread Stefan Lendl
refs only work with subsequent patches Signed-off-by: Stefan Lendl --- pvesdn.adoc | 67 + 1 file changed, 37 insertions(+), 30 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index b796c5e..562e081 100644 --- a/pvesdn.adoc +++ b/pvesdn.ad

[pve-devel] [PATCH v2 pve-docs 3/6] sdn: VNets and Subnets

2023-11-17 Thread Stefan Lendl
Signed-off-by: Stefan Lendl --- pvesdn.adoc | 46 -- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index 8a71c03..c4b77f0 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -272,32 +272,40 @@ MTU:: Because VXLAN en

[pve-devel] [PATCH v2 pve-docs 0/6] sdn: Documentation

2023-11-17 Thread Stefan Lendl
* Try to homogenize style and format * Title case naming conventions for configuration options * Simplify examples * Re-phrase descriptions Changes to v1 -> v2: * Split changes per chapter. * Use multi-line heading format like in the original file. I used search and replace to "revert" and now

[pve-devel] [PATCH v2 pve-docs 5/6] sdn: IPAM

2023-11-17 Thread Stefan Lendl
Signed-off-by: Stefan Lendl --- pvesdn.adoc | 66 ++--- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index 73d3dee..450955d 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -425,56 +425,56 @@ Loopback:: Use

[pve-devel] applied: [PATCH v4 pve-cluster 01/33] add priv/macs.db

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 12:39 schrieb Stefan Hanreich: > From: Alexandre Derumier > > use to cache mac-ip list association. > > can be use by external ipam, firewall,etc for fast lookup > > Signed-off-by: Alexandre Derumier > --- > src/PVE/Cluster.pm | 1 + > src/pmxcfs/status.c | 1 + > 2 files ch

[pve-devel] applied: [PATCH cluster v4 1/1] add profiles.cfg to cluster fs

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 12:45 schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > src/PVE/Cluster.pm | 1 + > src/pmxcfs/status.c | 1 + > 2 files changed, 2 insertions(+) > > I'm currently preparing a version bump, and it might be easier for all if this is already included, even if we'd

[pve-devel] [PATCH installer 2/2] tui: install progress: use ok/cancel as button text for installer prompt

2023-11-17 Thread Christoph Heiss
The GTK installer/UI module in the low-level installer does the same. Messages used with this are worded for this, using yes/no instead can be quite confusing (e.g. Proxmox::Install::ask_existing_vg_rename_or_abort()) Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/main.rs

[pve-devel] [RFC PATCH installer 1/2] ui: stdio: replace newlines with whitespaces in prompt messages

2023-11-17 Thread Christoph Heiss
The line-based protocol currently used cannot handle this properly, so introduce this as a stop-gap measure - otherwise messages might be cut off. This makes it work for now, and the text is wrapped correctely for the screen width in the TUI anyway - which is the only user of this so far. Will be

Re: [pve-devel] [RFC qemu-server 3/4] fix #4474: qemu api: add overrule-shutdown parameter to stop endpoint

2023-11-17 Thread Wolfgang Bumiller
This one LGTM. On Thu, Jan 26, 2023 at 09:32:13AM +0100, Friedrich Weber wrote: > The new `overrule-shutdown` parameter is boolean and defaults to 0. If > it is 1, all active `qmshutdown` tasks by the current user for the same > VM are aborted before attempting to stop the VM. > > Passing `overru

Re: [pve-devel] [RFC container 2/4] fix #4474: lxc api: add overrule-shutdown parameter to stop endpoint

2023-11-17 Thread Wolfgang Bumiller
On Thu, Jan 26, 2023 at 09:32:12AM +0100, Friedrich Weber wrote: > The new `overrule-shutdown` parameter is boolean and defaults to 0. If > it is 1, all active `vzshutdown` tasks by the current user for the same > CT are aborted before attempting to stop the CT. > > Passing `overrule-shutdown=1` i

Re: [pve-devel] [RFC guest-common 4/4] guest helpers: add helper to overrule active tasks of a specific type

2023-11-17 Thread Wolfgang Bumiller
Patch itself LGTM, just a note on sending patch series in general: If you number patches throughout a whole series rather than the individual repositories (as in, this one is labeled 4/4 instead of 1/1), it would be nice if the order also helps determine dependencies. Since the sub introduced her

Re: [pve-devel] [PATCH docs 1/2] pci passthrough: mention incompatibility with ballooning

2023-11-17 Thread Friedrich Weber
I took another look at ballooning+PCI passthrough and reporting of memory usage with Markus. Apparently QEMU does not *always* map the complete guest memory -- at least it didn't with a passed-through NIC. So both the warning as well as the docs section may be worded too strongly ("Ballooning is no

Re: [pve-devel] applied: [PATCH installer] tui: fix changing between non-LVM and LVM filesystem in bootdisk chooser

2023-11-17 Thread Christoph Heiss
Thanks! On Fri, Nov 17, 2023 at 01:20:31PM +0100, Thomas Lamprecht wrote: > > Am 17/11/2023 um 13:12 schrieb Christoph Heiss: > > Happens due to a force-unwrap() under the false assumption that the > > disk for LVM configurations always exists when switching to a LVM > > filesystem. > > This fai

Re: [pve-devel] [RFC manager/container/qemu-server/guest-common 0/4] fix #4474: stop tasks may overrule shutdown tasks

2023-11-17 Thread Wolfgang Bumiller
On Wed, Sep 27, 2023 at 11:04:26AM +0200, Friedrich Weber wrote: > Lost track of this a bit, reviving due to user interest [1]. > > As the series does not apply anymore, I'll send a new version in any > case, but wanted to ask for feedback before I do. > > My questions from the cover letter still

Re: [pve-devel] [PATCH v5 qemu-server 4/4] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-11-17 Thread Thomas Lamprecht
no in-depth review, but a meta style issue and some nits in line, the former could be fixed up on applying, the nits are not really important in general. Am 17/11/2023 um 13:17 schrieb Hannes Duerr: > adds vendor and product information for SCSI devices to the json schema and > checks in the VM cr

Re: [pve-devel] [PATCH v4 qemu-server 4/4] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-11-17 Thread Hannes Dürr
New Version can be found here: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060429.html On 11/17/23 12:53, Hannes Duerr wrote: adds vendor and product information for SCSI devices to the json schema and checks in the VM create/update API call if it is possible to add these to QEMU

[pve-devel] applied: [PATCH installer] tui: fix changing between non-LVM and LVM filesystem in bootdisk chooser

2023-11-17 Thread Thomas Lamprecht
Am 17/11/2023 um 13:12 schrieb Christoph Heiss: > Happens due to a force-unwrap() under the false assumption that the > disk for LVM configurations always exists when switching to a LVM > filesystem. > This fails spectacularly with a panic when switching from e.g. Btrfs to > ext4 in the filesystem

[pve-devel] [PATCH v5 qemu-server 4/4] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-11-17 Thread Hannes Duerr
adds vendor and product information for SCSI devices to the json schema and checks in the VM create/update API call if it is possible to add these to QEMU as a device option Signed-off-by: Hannes Duerr --- PVE/API2/Qemu.pm| 39 +++ PVE/QemuServer.pm

[pve-devel] [PATCH v5 qemu-server 2/4] Move NEW_DISK_RE to QemuServer/Drive.pm

2023-11-17 Thread Hannes Duerr
Move it due to better context and preparation of fix Signed-off-by: Hannes Duerr --- PVE/API2/Qemu.pm| 10 -- PVE/QemuServer/Drive.pm | 1 + 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 38bdaab..b9c8f20 100644 --- a/PVE

[pve-devel] [PATCH v5 qemu-server 3/4] drive: Create get_scsi_devicetype

2023-11-17 Thread Hannes Duerr
Encapsulation of the functionality for determining the scsi device type in a new function for reusability in QemuServer/Drive.pm Signed-off-by: Hannes Duerr --- PVE/QemuServer.pm | 29 - PVE/QemuServer/Drive.pm | 35 ++- 2 files

[pve-devel] [PATCH v5 qemu-server 1/4] Move path_is_scsi to QemuServer/Drive.pm

2023-11-17 Thread Hannes Duerr
Prepare for introduction of new helper Signed-off-by: Hannes Duerr --- PVE/QemuServer.pm | 62 + PVE/QemuServer/Drive.pm | 61 2 files changed, 62 insertions(+), 61 deletions(-) diff --git a/PVE/QemuServer.pm

[pve-devel] [PATCH v5 qemu-server 0/4] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-11-17 Thread Hannes Duerr
changes in v2: - when calling the API to create/update a VM, check whether the devices are "scsi-hd" or "scsi-cd" devices,where there is the option to add vendor and product information, if not error out - change the format in product_fmt and vendor_fmt to a pattern that only allows 40 characters c

[pve-devel] [PATCH installer] tui: fix changing between non-LVM and LVM filesystem in bootdisk chooser

2023-11-17 Thread Christoph Heiss
Happens due to a force-unwrap() under the false assumption that the disk for LVM configurations always exists when switching to a LVM filesystem. This fails spectacularly with a panic when switching from e.g. Btrfs to ext4 in the filesystem chooser. Fixes: eda9fa0 ("fix #4856: tui: bootdisk: use c

Re: [pve-devel] [PATCH manager 1/2] api: pools: support nested pools

2023-11-17 Thread Wolfgang Bumiller
minor issue On Fri, Nov 17, 2023 at 08:09:10AM +0100, Fabian Grünbichler wrote: > since poolid can now contain `/`, it's not possible to use it (properly) as > path parameter anymore. > > accordingly: > - merge `read_pool` (`GET /pools/{poolid}`) into 'index' (`GET > /pools/?poolid={poolid}`) (

[pve-devel] [PATCH pve-network 0/2] dnsmasq: fix dhcp leases

2023-11-17 Thread Alexandre Derumier
This need to deploy permission for dbus uk.org.thekelleys.dnsmasq.* /etc/dbus-1/system.d/dnsmasq-pve.conf I don't have added patch for this. http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd";>

[pve-devel] [PATCH pve-network 1/2] dnsmasq: configure static range for each subnet

2023-11-17 Thread Alexandre Derumier
we don't want dynamic lease, simply define each subnet as a static range. dhcp-range defined on a subnet is only used by ipam plugin. This will also allow to use dhcp subnet without need to define a range. Can be usefull for external ipam like phpipam, where you can't define ranges. Signed-off-b

[pve-devel] [PATCH pve-network 2/2] dnsmasq: enable dbus && purge old ip lease on reservation

2023-11-17 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm b/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm index 2db7f4f..f4225d0 100644 --- a/src/PVE/Network/SDN/Dhcp/Dnsma

[pve-devel] [PATCH v4 qemu-server 4/4] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-11-17 Thread Hannes Duerr
adds vendor and product information for SCSI devices to the json schema and checks in the VM create/update API call if it is possible to add these to QEMU as a device option Signed-off-by: Hannes Duerr --- PVE/API2/Qemu.pm| 39 +++ PVE/QemuServer.pm

[pve-devel] [PATCH v4 qemu-server 2/4] Move NEW_DISK_RE to QemuServer/Drive.pm

2023-11-17 Thread Hannes Duerr
Move it due to better context and preparation of fix Signed-off-by: Hannes Duerr --- PVE/API2/Qemu.pm| 10 -- PVE/QemuServer/Drive.pm | 1 + 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 38bdaab..b9c8f20 100644 --- a/PVE

[pve-devel] [PATCH v4 qemu-server 1/4] Move path_is_scsi to QemuServer/Drive.pm

2023-11-17 Thread Hannes Duerr
Prepare for introduction of new helper Signed-off-by: Hannes Duerr --- PVE/QemuServer.pm | 62 + PVE/QemuServer/Drive.pm | 61 2 files changed, 62 insertions(+), 61 deletions(-) diff --git a/PVE/QemuServer.pm

[pve-devel] [PATCH v4 qemu-server 0/4] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-11-17 Thread Hannes Duerr
changes in v2: - when calling the API to create/update a VM, check whether the devices are "scsi-hd" or "scsi-cd" devices,where there is the option to add vendor and product information, if not error out - change the format in product_fmt and vendor_fmt to a pattern that only allows 40 characters c

[pve-devel] [PATCH v4 qemu-server 3/4] drive: Create get_scsi_devicetype

2023-11-17 Thread Hannes Duerr
Encapsulation of the functionality for determining the scsi device type in a new function for reusability in QemuServer/Drive.pm Signed-off-by: Hannes Duerr --- PVE/QemuServer.pm | 29 - PVE/QemuServer/Drive.pm | 35 ++- 2 files

[pve-devel] [PATCH v4 qemu-server 26/33] nic online bridge/vlan change: link disconnect/reconnect

2023-11-17 Thread Stefan Hanreich
From: Alexandre Derumier We want to notify guest of the change, so it can resubmit dhcp request, or send gratuitous arp,... Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 5e1

[pve-devel] [PATCH v4 qemu-server 23/33] api2: create|restore|clone: add_free_ip

2023-11-17 Thread Stefan Hanreich
From: Alexandre Derumier Co-Authored-by: Stefan Lendl Signed-off-by: Stefan Hanreich Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 6 ++ PVE/QemuServer.pm | 15 +++ 2 files changed, 21 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 38bdaab..

[pve-devel] [PATCH v4 pve-manager 18/33] sdn: add DHCP option to Zone dialogue

2023-11-17 Thread Stefan Hanreich
Co-Authored-by: Stefan Lendl Signed-off-by: Stefan Hanreich --- www/manager6/sdn/zones/Base.js | 6 -- www/manager6/sdn/zones/SimpleEdit.js | 10 ++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/www/manager6/sdn/zones/Base.js b/www/manager6/sdn/zones/Base.js

[pve-devel] [PATCH v4 pve-network 16/33] add add_dhcp_mapping

2023-11-17 Thread Stefan Hanreich
From: Alexandre Derumier Signed-off-by: Alexandre Derumier --- src/PVE/Network/SDN/Dhcp.pm | 9 --- src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 40 - src/PVE/Network/SDN/Dhcp/Plugin.pm | 2 +- src/PVE/Network/SDN/Vnets.pm| 15 +++ 4 files cha

[pve-devel] [PATCH v4 pve-manager 20/33] sdn: ipam: add ipam panel

2023-11-17 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- www/css/ext6-pve.css | 22 ++- www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 12 +- www/manager6/sdn/IpamEdit.js | 78 ++ www/manager6/tree/DhcpTree.js | 267 ++ 5 files changed, 372 i

[pve-devel] [PATCH v4 pve-container 31/33] vm_apply_pending: add|del ips from ipam for offline changes

2023-11-17 Thread Stefan Hanreich
From: Alexandre Derumier Co-Authored-by: Stefan Hanreich Signed-off-by: Alexandre Derumier --- src/PVE/LXC/Config.pm | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index c884313..823a2b9 100644 --- a/src/PVE/LXC/Config.pm +++

[pve-devel] [PATCH v4 pve-container 28/33] vm_destroy: remove ips from ipam for all interfaces

2023-11-17 Thread Stefan Hanreich
From: Alexandre Derumier Signed-off-by: Alexandre Derumier --- src/PVE/LXC.pm | 16 1 file changed, 16 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index b6df6d6..4472e0f 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -46,6 +46,7 @@ use PVE::LXC::Tools; my

[pve-devel] [PATCH manager v4 1/1] api: add guest profile api endpoint

2023-11-17 Thread Dominik Csapak
basic CRUD for the profile section config Signed-off-by: Dominik Csapak --- PVE/API2/Cluster.pm | 7 + PVE/API2/Cluster/Makefile| 1 + PVE/API2/Cluster/Profiles.pm | 239 +++ 3 files changed, 247 insertions(+) create mode 100644 PVE/API2/Cluster/

[pve-devel] [PATCH container v4 3/3] pct: register and init the profiles plugins

2023-11-17 Thread Dominik Csapak
we have to that here, so the properties/options are correctly configured when using that feature on the cli Signed-off-by: Dominik Csapak --- src/PVE/CLI/pct.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index a0b9bce..e579b7a 100755 --- a/s

[pve-devel] [PATCH container v4 1/3] add the CT profiles plugin

2023-11-17 Thread Dominik Csapak
simply uses the json_config_properties for the ct config and maps them to "ct_${opt}" Signed-off-by: Dominik Csapak --- src/PVE/Makefile | 1 + src/PVE/Profiles/CT.pm| 28 src/PVE/Profiles/Makefile | 4 3 files changed, 33 insertions(+) create mo

[pve-devel] [PATCH cluster v4 1/1] add profiles.cfg to cluster fs

2023-11-17 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm index cfa2583..c01bf89 100644 --- a/src/PVE/Cluster.pm +++ b/src/PVE/Cluster.pm @@ -80,6 +80,7 @@ my $observed = { 's

[pve-devel] [PATCH container v4 2/3] api: add profile option to create ct api call

2023-11-17 Thread Dominik Csapak
we use the profile cfg as the 'param' hash, but overwrite the values with the ones from the api call, so one can overwrite options from the profile easily Signed-off-by: Dominik Csapak --- src/PVE/API2/LXC.pm | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/PVE/AP

[pve-devel] [PATCH guest-common v4 1/1] add profiles section config plugin

2023-11-17 Thread Dominik Csapak
this is intended to house custom profiles which can be used on guest creation instead of manually needing to specify every option. we do special things here: * we always set 'allow_unknown' to 1, because when using the guest specific parts in the cli, we cannot depend on the other one, else we

[pve-devel] [PATCH qemu-server v4 2/3] api: add profile option to create vm api call

2023-11-17 Thread Dominik Csapak
we use the the profile cfg as the 'param' hash, but overwrite the values with the ones from the api call, so one can overwrite options from the profile easily also we add the used profile to the meta info in the config, since it might be interesting which one was used Signed-off-by: Dominik Csapa

[pve-devel] [PATCH qemu-server v4 3/3] qm: register and init the profiles plugins

2023-11-17 Thread Dominik Csapak
we have to that here, so the properties/options are correctly configured when using that feature on the cli Signed-off-by: Dominik Csapak --- PVE/CLI/qm.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index b17b4fe2..82240ba3 100755 --- a/PVE/CLI/qm.pm

[pve-devel] [PATCH cluster/guest-common/qemu-server/container/manager v4] add backend profile support

2023-11-17 Thread Dominik Csapak
This series aims to provide profile support when creating guests (ct/vm) so that users can reuse options without having to specify them every time. UI is still not done, but sending the backend again. changes from v3: * adapt to the changes in section config regarding the 'init' -> now `init(pr

[pve-devel] [PATCH qemu-server v4 1/3] add the VM profiles plugin

2023-11-17 Thread Dominik Csapak
simply uses the json_config_properties for the vm config and maps them to "vm_${opt}" Signed-off-by: Dominik Csapak --- PVE/Makefile | 1 + PVE/Profiles/Makefile | 5 + PVE/Profiles/VM.pm| 28 3 files changed, 34 insertions(+) create mode 100644 P

[pve-devel] [PATCH v4 pve-docs 33/33] sdn: dhcp: Add documentation for DHCP

2023-11-17 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- pvesdn.adoc | 122 1 file changed, 122 insertions(+) diff --git a/pvesdn.adoc b/pvesdn.adoc index b796c5e..24878e2 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -79,6 +79,9 @@ In addition to this, the followi

[pve-devel] [PATCH v4 pve-container 27/33] nic hotplug : add|del ips in ipam

2023-11-17 Thread Stefan Hanreich
From: Alexandre Derumier Co-Authored-by: Stefan Hanreich Signed-off-by: Alexandre Derumier --- src/PVE/LXC.pm| 17 + src/PVE/LXC/Config.pm | 12 2 files changed, 29 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 8f53b53..b6df6d6 100644 --

[pve-devel] [PATCH v4 pve-container 30/33] vm_clone : create ips in ipams

2023-11-17 Thread Stefan Hanreich
From: Alexandre Derumier also delete ips in case of failure Signed-off-by: Alexandre Derumier --- src/PVE/API2/LXC.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index e15de28..ee4fdca 100644 --- a/src/PVE/API2/LXC.pm +++ b

[pve-devel] [PATCH v4 pve-container 29/33] vm_create|restore: create ips in ipam

2023-11-17 Thread Stefan Hanreich
From: Alexandre Derumier also delete ips on create failure Co-Authored-by: Stefan Hanreich Signed-off-by: Alexandre Derumier --- src/PVE/API2/LXC.pm | 4 src/PVE/LXC.pm | 13 + 2 files changed, 17 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm ind

[pve-devel] [PATCH v4 qemu-server 21/33] vmnic add|remove : add|del ip in ipam

2023-11-17 Thread Stefan Hanreich
From: Alexandre Derumier Co-Authored-by: Stefan Lendl Signed-off-by: Stefan Hanreich Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 40 1 file changed, 40 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index c465fb6..5f15c

[pve-devel] [PATCH v4 qemu-server 24/33] vm_destroy: delete ip from ipam

2023-11-17 Thread Stefan Hanreich
From: Alexandre Derumier Co-Authored-By: Stefan Hanreich Signed-off-by: Stefan Hanreich Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 17 + 1 file changed, 17 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b92743c..b4cb741 100644 --- a/PVE/

[pve-devel] [PATCH v4 qemu-server 22/33] vm_start : vm-network-scripts: add_dhcp_reservation

2023-11-17 Thread Stefan Hanreich
From: Alexandre Derumier Signed-off-by: Stefan Hanreich Signed-off-by: Alexandre Derumier --- vm-network-scripts/pve-bridge | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vm-network-scripts/pve-bridge b/vm-network-scripts/pve-bridge index d37ce33..e8f8798 100755 --- a/vm-network-scripts

[pve-devel] [PATCH v4 pve-network 08/33] sdn: dhcp: add dnsmasq plugin

2023-11-17 Thread Stefan Hanreich
The plugin creates a dnsmasq@ service that spawns a dnsmasq instance that handles dhcp for that zone. The configuration files for a dnsmasq instance lie within /etc/dnsmasq.d/ The plugin generates the following configuration files: * 00-default.conf Contains the default global configuration for

[pve-devel] [PATCH v4 pve-network 09/33] sdn: dhcp: add helper for creating DHCP leases

2023-11-17 Thread Stefan Hanreich
This helper can be used to create DHCP entries for a specific zone. It is used by the API to create DHCP leases for VMs/CTs. Co-Authored-By: Alexandre Derumier Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Dhcp.pm | 115 +++ src/PVE/Network/SDN/Makefile

  1   2   >