[pve-devel] Update LXC vzdump to support BTRFS

2023-11-03 Thread Thomas Freudenberg
Hi everyone, in case that we need support for BTRFS SNAPSHOT Backups, I have patched the file: /usr/share/perl5/PVE/LXC.pm and added support to mount BTRFS SNAPSHOT SUBVOL. If interested let me know if I should send in a patch. Cheers Tom 1795a1796,1813 > } elsif ($scfg->{

[pve-devel] [PATCH pve-access-control 1/1] add logging for ACL and user status change

2023-11-03 Thread Andrew A. Vasilyev
Signed-off-by: "Andrew A. Vasilyev" --- src/PVE/API2/ACL.pm | 2 ++ src/PVE/API2/User.pm | 4 2 files changed, 6 insertions(+) diff --git src/PVE/API2/ACL.pm src/PVE/API2/ACL.pm index f0c9efb..6ec23d7 100644 --- src/PVE/API2/ACL.pm +++ src/PVE/API2/ACL.pm @@ -183,8 +183,10 @@ __PACKAGE__->r

[pve-devel] [RFC PATCH qemu-server 3/4] api: add profile option to create vm api call

2023-11-03 Thread Dominik Csapak
we use the the profile cfg as the 'param' hash, but overwrite the values with the ones from the api call, so one can overwrite options from the profile easily also we add the used profile to the meta info in the config, since it might be interesting which one was used Signed-off-by: Dominik Csapa

[pve-devel] [RFC PATCH container 3/3] pct: register and init the profiles plugins

2023-11-03 Thread Dominik Csapak
we have to that here, so the properties/options are correctly configured when using that feature on the cli Signed-off-by: Dominik Csapak --- src/PVE/CLI/pct.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index a0b9bce..e579b7a 100755 --- a/s

[pve-devel] [RFC PATCH container 2/3] api: add profile option to create ct api call

2023-11-03 Thread Dominik Csapak
we use the profile cfg as the 'param' hash, but overwrite the values with the ones from the api call, so one can overwrite options from the profile easily Signed-off-by: Dominik Csapak --- src/PVE/API2/LXC.pm | 24 1 file changed, 24 insertions(+) diff --git a/src/PVE/A

[pve-devel] [RFC PATCH manager 1/1] api: add guest profile api endpoint

2023-11-03 Thread Dominik Csapak
basic CRUD for the profile section config Signed-off-by: Dominik Csapak --- PVE/API2/Cluster.pm | 6 + PVE/API2/Cluster/Makefile| 1 + PVE/API2/Cluster/Profiles.pm | 230 +++ 3 files changed, 237 insertions(+) create mode 100644 PVE/API2/Cluster/

[pve-devel] [RFC PATCH qemu-server 4/4] qm: register and init the profiles plugins

2023-11-03 Thread Dominik Csapak
we have to that here, so the properties/options are correctly configured when using that feature on the cli Signed-off-by: Dominik Csapak --- PVE/CLI/qm.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index b17b4fe2..82240ba3 100755 --- a/PVE/CLI/qm.pm

[pve-devel] applied: [PATCH installer 0/2] rustfmt & clippy warning fix

2023-11-03 Thread Thomas Lamprecht
On 03/11/2023 10:49, Christoph Heiss wrote: > First patch is just a mechanical rustfmt, which I apparently missed to > check during review - that's on me. Second patch fixes a longer-standing > clippy warning. > > Christoph Heiss (2): > tui, common: run rustfmt > tui: fix clippy warning > >

[pve-devel] [RFC PATCH container 1/3] add the CT profiles plugin

2023-11-03 Thread Dominik Csapak
simply uses the json_config_properties for the ct config and maps them to "ct_${opt}" Signed-off-by: Dominik Csapak --- src/PVE/Makefile | 1 + src/PVE/Profiles/CT.pm| 37 + src/PVE/Profiles/Makefile | 4 3 files changed, 42 insertions(+)

[pve-devel] [RFC PATCH cluster/guest-common/qemu-server/container/manager] add backend profile support

2023-11-03 Thread Dominik Csapak
This series aims to provide profile support when creating guests (ct/vm) so that users can reuse options without having to specify them every time. Sending as RFC because I don't quite like some things with the current implementation and I'm not quite sure in which direction I should take this. Al

[pve-devel] [RFC PATCH qemu-server 2/4] add the VM profiles plugin

2023-11-03 Thread Dominik Csapak
simply uses the json_config_properties for the vm config and maps them to "vm_${opt}" Signed-off-by: Dominik Csapak --- PVE/Makefile | 1 + PVE/Profiles/Makefile | 5 + PVE/Profiles/VM.pm| 37 + 3 files changed, 43 insertions(+) create mode

[pve-devel] [RFC PATCH guest-common 1/1] add profiles section config plugin

2023-11-03 Thread Dominik Csapak
this is intended to house custom profiles which can be used on guest creation instead of manually needing to specify every option. we do special things here: * we always set 'allow_unknown' to 1, because when using the guest specific parts in the cli, we cannot depend on the other one, else we

[pve-devel] [RFC PATCH qemu-server 1/4] meta info: allow additional properties to be given

2023-11-03 Thread Dominik Csapak
we'll need this since we want to record the profile used for creation, which we get from outside Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 0568b2bc..

[pve-devel] [RFC PATCH cluster 1/1] add profiles.cfg to cluster fs

2023-11-03 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm index cfa2583..c01bf89 100644 --- a/src/PVE/Cluster.pm +++ b/src/PVE/Cluster.pm @@ -80,6 +80,7 @@ my $observed = { 's

Re: [pve-devel] [PATCH pve-storage] fix #1611: implement import of base-images for LVM-thin Storage

2023-11-03 Thread Fiona Ebner
Am 16.10.23 um 13:59 schrieb Hannes Duerr: > In the bugtracker wolfgang suggested two different approaches. In my > opinion this approach is the cleaner one, but please let me know what > you think > I slightly prefer this approach, because here, the base image conversion is done after import whi

[pve-devel] [PATCH installer 0/2] rustfmt & clippy warning fix

2023-11-03 Thread Christoph Heiss
First patch is just a mechanical rustfmt, which I apparently missed to check during review - that's on me. Second patch fixes a longer-standing clippy warning. Christoph Heiss (2): tui, common: run rustfmt tui: fix clippy warning proxmox-installer-common/src/setup.rs | 1 - pro

[pve-devel] [PATCH installer 2/2] tui: fix clippy warning

2023-11-03 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs index 3216868..2e5a194 100644 --- a/proxmox-tui-installer/src/main.rs +++ b/proxmox-tui-i

[pve-devel] [PATCH installer 1/2] tui, common: run rustfmt

2023-11-03 Thread Christoph Heiss
While at it, move rustfmt.toml to the repo root, to share it with the other crate. Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/setup.rs | 1 - proxmox-tui-installer/src/options.rs | 12 ++-- proxmox-tui-installer/src/setup.rs

Re: [pve-devel] [PATCH v2 container 1/1] Add device passthrough

2023-11-03 Thread Wolfgang Bumiller
On Thu, Nov 02, 2023 at 03:28:22PM +0100, Filip Schauer wrote: > > On 30/10/2023 14:34, Wolfgang Bumiller wrote: > > On Tue, Oct 24, 2023 at 02:55:53PM +0200, Filip Schauer wrote: > > > Add a dev[n] argument to the container config to pass devices through to > > > a container. A device can be pass