Re: [pve-devel] [PATCH qemu-server] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-10-30 Thread Thomas Lamprecht
I mean, the properties are relatively straight forward, but some commit message would be still nice to have – e.g., how did you check if the values propagate into the guest, can this On 25/10/2023 14:37, Hannes Duerr wrote: > Signed-off-by: Hannes Duerr > --- > PVE/QemuServer.pm | 12 +

Re: [pve-devel] [PATCH v2 container 1/1] Add device passthrough

2023-10-30 Thread Wolfgang Bumiller
On Tue, Oct 24, 2023 at 02:55:53PM +0200, Filip Schauer wrote: > Add a dev[n] argument to the container config to pass devices through to > a container. A device can be passed by its path. Alternatively a mapped > USB device can be passed through with usbmapping=. > > Signed-off-by: Filip Schauer

[pve-devel] applied: [PATCH docs] sysadmin: revise firmware chapter, add firmware repo section

2023-10-30 Thread Thomas Lamprecht
Am 30/10/2023 um 13:10 schrieb Alexander Zeidler: > Chapter "Firmware Updates": > * improve the structure and clarity of information provided > * mention which update methods are when available/recommended > * add information about the already pre-installed pve-firmware package > * emphasise the im

Re: [pve-devel] [PATCH v2 guest-common 1/1] Add foreach_passthrough_device

2023-10-30 Thread Wolfgang Bumiller
On Tue, Oct 24, 2023 at 02:55:54PM +0200, Filip Schauer wrote: > Add a function to iterate over passthrough devices of a provided > container config. As container specific code this should be in pve-container. > > Signed-off-by: Filip Schauer > --- > src/PVE/AbstractConfig.pm | 44

[pve-devel] applied: [PATCH docs] ha-manager, software updates: add useful BlockIds

2023-10-30 Thread Thomas Lamprecht
Am 30/10/2023 um 12:20 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > ha-manager.adoc | 5 + > system-software-updates.adoc | 1 + > 2 files changed, 6 insertions(+) > > applied, with s/BlockIds/anchors/ in the subject, easier to understand when copied in

[pve-devel] [PATCH manager 1/2] ui: BulkActions: rework filters and include tags

2023-10-30 Thread Dominik Csapak
This moves the filters out of the grid header for the BulkActions and puts them into their own fieldset above the grid. With that, we can easily include a tags filter (one include and one exclude list). The filter fieldset is collapsible and shows the active filters in parenthesis. aside from that

[pve-devel] [PATCH manager 2/2] ui: BulkAction: add clear filters button

2023-10-30 Thread Dominik Csapak
to be able to clear all of them at once Signed-off-by: Dominik Csapak --- sending this as a separate patch since i'm not sure if the button is worth it. if deemed appropriate could also be squashed into the previous patch www/manager6/window/BulkAction.js | 26 ++ 1 file

[pve-devel] [PATCH docs] sysadmin: revise firmware chapter, add firmware repo section

2023-10-30 Thread Alexander Zeidler
Chapter "Firmware Updates": * improve the structure and clarity of information provided * mention which update methods are when available/recommended * add information about the already pre-installed pve-firmware package * emphasise the importance of CPU microcode updates, how to interpret versio

[pve-devel] [PATCH manager] ui: lxc: add edit window for device passthrough

2023-10-30 Thread Filip Schauer
Signed-off-by: Filip Schauer --- Depends on: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059616.html www/manager6/Makefile | 1 + www/manager6/Utils.js | 11 +++ www/manager6/lxc/DeviceEdit.js | 158 + www/manager6/lxc/Resources

[pve-devel] [PATCH docs] ha-manager, software updates: add useful BlockIds

2023-10-30 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- ha-manager.adoc | 5 + system-software-updates.adoc | 1 + 2 files changed, 6 insertions(+) diff --git a/ha-manager.adoc b/ha-manager.adoc index 8390782..53330a1 100644 --- a/ha-manager.adoc +++ b/ha-manager.adoc @@ -260,6 +260,7 @@ This all

Re: [pve-devel] [PATCH 00/12] installer: add crate for common code

2023-10-30 Thread Aaron Lauterer
Sorry, I missed to patch the Makefile and thanks for sending a patch for that [0]. The Makefile has another bug that I encountered during the RFC phase of the auto installer [0]. I could include that already in a V2 or add it to the auto installer series where the problem actually starts to sho