Re: [pve-devel] [PATCH qemu-server] Fix: cpu hotplug feature can't be changed online

2023-10-23 Thread DERUMIER, Alexandre
Am 10.10.23 um 17:37 schrieb Alexandre Derumier: > The cpus are passed as devices with specific id only when cpu hotplug > is enable > at start. > We can't enable/disable it online or vcpu hotplug api will thrown > errors > not finding core id. >>When removing cores after enabling the option this

Re: [pve-devel] [PATCH v4 qemu-server 2/2] remote-migration: add target-cpu && target-reboot params

2023-10-23 Thread DERUMIER, Alexandre
Hi Fiona, >>In case of 'restart' migration, we do want to start the VM anyways, >>so >>it's actually better, because we can catch config issues early :) Now >>that I think about it, can we also just start the target VM in >>prelaunch >>mode (instead of incoming migration mode), do the NBD migrati

[pve-devel] [PATCH v5 storage 0/1] fix #254: iscsi: add support for multipath iscsi targets

2023-10-23 Thread Yuri Konotopov via pve-devel
--- Begin Message --- Changes since v4: * rebased on top of master branch Changes since v3: * drop redundant `m` modifier from `ISCSI_TARGET_RE` regexp * drop redundant group from `iscsi_session_list` regexp * improve stop loop condition in `iscsi_discovery` Changes since v2: * custom config

[pve-devel] [PATCH v5 storage 1/1] fix #254: iscsi: add support for multipath iscsi targets

2023-10-23 Thread Yuri Konotopov via pve-devel
--- Begin Message --- With this patch Proxmox now tries to login to all discovered portals in case some of them are not logged yet. In case of multipath configuration when initially configured portal is missing for some reason Proxmox don't lose iscsi storage now and can succesfully restore iscsi c

Re: [pve-devel] [PATCH v4 storage 1/1] fix #254: iscsi: add support for multipath iscsi targets

2023-10-23 Thread Yuri Konotopov via pve-devel
--- Begin Message --- 23.10.2023 12:11, Dominik Csapak пишет: Hi, Hi, Dominik! sorry but I just noticed that it seems you did not create this patch on top of our current master? at least here it does not apply cleanly, since the files got moved to src/ (in may already) so could you pleas

Re: [pve-devel] [PATCH docs] faq: change to inline anchors to land on the actual questions

2023-10-23 Thread Thomas Lamprecht
Am 23/10/2023 um 17:31 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > pve-faq.adoc | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/pve-faq.adoc b/pve-faq.adoc > index 93fef32..2388673 100644 > --- a/pve-faq.adoc > +++ b/pve-faq.adoc > @@ -

[pve-devel] applied: [PATCH docs] installation: document UP indicator in network setup

2023-10-23 Thread Thomas Lamprecht
Am 23/10/2023 um 17:11 schrieb Maximiliano Sandoval R: > See > https://git.proxmox.com/?p=pve-installer.git;a=commit;h=124ca33f9fb3780a76f0b5fd57952e69823852c8. > > Signed-off-by: Maximiliano Sandoval R > --- > pve-installation.adoc | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-)

[pve-devel] applied-series: [PATCH font-logos/manager v2 0/5] fix #2435: lxc: show distro and privileged status in summary

2023-10-23 Thread Thomas Lamprecht
Am 20/10/2023 um 15:33 schrieb Dominik Csapak: > the series looks mostly fine to me, i wrote two small > comments in the relevant patches, but both > are not super important to fix IMO > > aside from that consider this series > > Reviewed-by: Dominik Csapak > Tested-by: Dominik Csapak With you

[pve-devel] [PATCH docs] faq: change to inline anchors to land on the actual questions

2023-10-23 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- pve-faq.adoc | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/pve-faq.adoc b/pve-faq.adoc index 93fef32..2388673 100644 --- a/pve-faq.adoc +++ b/pve-faq.adoc @@ -77,8 +77,7 @@ CPU. It is not limited to Linux guests but allows arbit

[pve-devel] [PATCH docs] installation: document UP indicator in network setup

2023-10-23 Thread Maximiliano Sandoval R
See https://git.proxmox.com/?p=pve-installer.git;a=commit;h=124ca33f9fb3780a76f0b5fd57952e69823852c8. Signed-off-by: Maximiliano Sandoval R --- pve-installation.adoc | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pve-installation.adoc b/pve-installation.adoc index aa4

[pve-devel] applied: [PATCH qemu-server] vzdump: assemble: improve error messages

2023-10-23 Thread Thomas Lamprecht
Am 23/10/2023 um 10:59 schrieb Fiona Ebner: > by including the errno. Might make it clearer what the issue is in > cases like: https://forum.proxmox.com/threads/135261/ > > Also add the missing newlines, the missing "to" in the second message, > switch to the more common "or die" and avoid line bl

[pve-devel] [PATCH manager 5/5] fix #4497: ui/acme: switch to new meta endpoint

2023-10-23 Thread Folke Gleumes
Besides the switch from tos to meta endpoint, this fixes a visual bug, where the 'Accept TOS' button would show up, even if no ToS was needed. Signed-off-by: Folke Gleumes --- www/manager6/node/ACME.js | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/www/manager6/

[pve-devel] [PATCH manager 3/5] fix #4497: api/acme: deprecate tos endpoint in favor of meta

2023-10-23 Thread Folke Gleumes
The ToS endpoint ignored data that is needed to detect if EAB needs to be used. Instead of adding a new endpoint that does the same request, the tos endpoint is deprecated and replaced by the meta endpoint, that returns all information returned by the directory. Signed-off-by: Folke Gleumes ---

[pve-devel] [PATCH acme 1/5] fix #4497: add support for external account bindings

2023-10-23 Thread Folke Gleumes
implementation acording to rfc855 section 7.3.4 Signed-off-by: Folke Gleumes --- src/PVE/ACME.pm | 43 +++ 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/src/PVE/ACME.pm b/src/PVE/ACME.pm index 3f66182..f65729a 100644 --- a/src/PVE/ACME.pm

[pve-devel] [PATCH acme/manager 0/5] fix #4497: add external account binding support

2023-10-23 Thread Folke Gleumes
This patch series adds functionality to use acme directiories that require the use of external account binding, as specified in rfc 8555 section 7.3.4. To avoid code duplication and redundant calls to the CA, the `/cluster/acme/tos` endpoint has been deprecated and it's function will be covered by

[pve-devel] [PATCH manager 4/5] fix #4497: cli/acme: detect eab and ask for credentials

2023-10-23 Thread Folke Gleumes
Since external account binding is advertised the same way as the ToS, it can be detected when creating an account and asked for if needed. Signed-off-by: Folke Gleumes --- PVE/CLI/pvenode.pm | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvenode.pm

[pve-devel] [PATCH manager 2/5] fix #4497: acme: add support for external account bindings

2023-10-23 Thread Folke Gleumes
Signed-off-by: Folke Gleumes --- PVE/API2/ACMEAccount.pm | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/PVE/API2/ACMEAccount.pm b/PVE/API2/ACMEAccount.pm index b790843a..daae18d8 100644 --- a/PVE/API2/ACMEAccount.pm +++ b/PVE/API2/ACMEAccount.pm @@

Re: [pve-devel] [RFC v2 pve-container pve-manager 0/3] add partial restore

2023-10-23 Thread Christian Ebner
Oh, okay! I was not aware of these patches, thanks for letting me know. Yes, being consistent with the UI/API for both VM and LXC restores is desired. I was planning on doing the VM part next, but since there already is a patch series for this I will definitely work on a common denominator for t

Re: [pve-devel] [WIP v2 cluster/network/manager/qemu-server/container 00/10] Add support for DHCP servers to SDN

2023-10-23 Thread Stefan Lendl
PS: Sorry for double posting. this mail was sent with invalid In-Reply-To and References Headers. I sent it again with the correct Headers after I managed to correctly setup my mail client. Stefan Lendl writes: > I am currently working on the SDN feature. This is an initial review of > the pat

Re: [pve-devel] [RFC v2 pve-container pve-manager 0/3] add partial restore

2023-10-23 Thread Fiona Ebner
Am 23.10.23 um 13:18 schrieb Christian Ebner: > This patch series adds functionality to partially restore containers > from backup, by allowing the user to selectively include/exclude > mountpoints for restore. Mountpoints not included in the backup will not > be deleted and recreated but rather at

Re: [pve-devel] [WIP v2 cluster/network/manager/qemu-server/container 00/10] Add support for DHCP servers to SDN

2023-10-23 Thread Stefan Lendl
I am currently working on the SDN feature. This is an initial review of the patch series and I am trying to make a strong case against ephemeral DHCP IP reservation. The current state of the patch series invokes the IPAM on every VM/CT start/stop to add or remove the IP from the IPAM. This trig

Re: [pve-devel] [RFC pve-container] backup: do not delete not backed-up mps on restore

2023-10-23 Thread Christian Ebner
There is an newer version of the patch, see https://lists.proxmox.com/pipermail/pve-devel/2023-October/059566.html Please ignore this one. > On 17.10.2023 14:38 CEST Christian Ebner wrote: > > > The current behaviour of the restore is to recreate all backed up > mountpoints and remove all pr

[pve-devel] [RFC v2 pve-container pve-manager 1/3] backup: do not delete not backed-up mps on restore

2023-10-23 Thread Christian Ebner
The current behaviour of the restore is to recreate all backed up mountpoints and remove all previous ones, causing potential data loss on restore when the mountpoint was not included in the backup and the user not aware of this behaviour. By checking the mountpoint configuration from the backup,

[pve-devel] [RFC v2 pve-container pve-manager 3/3] ui: lxc restore: add selective mountpoint restore

2023-10-23 Thread Christian Ebner
Adds a grid to the lxc backup restore window allowing the user to select mountpoints which should be included/excluded from a restore. Signed-off-by: Christian Ebner --- changes since v1: not present in v1 www/manager6/Makefile | 1 + www/manager6/grid/BackupRestoreTar

[pve-devel] [RFC v2 pve-container pve-manager 0/3] add partial restore

2023-10-23 Thread Christian Ebner
This patch series adds functionality to partially restore containers from backup, by allowing the user to selectively include/exclude mountpoints for restore. Mountpoints not included in the backup will not be deleted and recreated but rather attached to the container as unused disk after the resto

[pve-devel] [RFC v2 pve-container pve-manager 2/3] api: allow to exclude mountpoins from restore

2023-10-23 Thread Christian Ebner
Adds an optional parameter which allows to specify the names of mountpoints which should be excluded from restore. These mountpoints are not (re-)created and files located below the mountpoint are not restored from backup. Signed-off-by: Christian Ebner --- changes since v1: not present in

Re: [pve-devel] [WIP v2 cluster/network/manager/qemu-server/container 00/10] Add support for DHCP servers to SDN

2023-10-23 Thread Stefan Lendl
I am currently working on the SDN feature. This is an initial review of the patch series and I am trying to make a strong case against ephemeral DHCP IP reservation. The current state of the patch series invokes the IPAM on every VM/CT start/stop to add or remove the IP from the IPAM. This trig

Re: [pve-devel] [PATCH installer] install: install correct grub metapackage for the current boot-mode

2023-10-23 Thread Fabian Grünbichler
On September 28, 2023 4:05 pm, Stoiko Ivanov wrote: > grub packages in debian split between: > * meta-packages, which handles (among other things) the reinstalling > grub to the actual device/ESP in case of a version upgrade (grub-pc, > grub-efi-amd64) > * bin-packages, which contain the actual

[pve-devel] [PATCH qemu-server] vzdump: assemble: improve error messages

2023-10-23 Thread Fiona Ebner
by including the errno. Might make it clearer what the issue is in cases like: https://forum.proxmox.com/threads/135261/ Also add the missing newlines, the missing "to" in the second message, switch to the more common "or die" and avoid line bloat while at it. Signed-off-by: Fiona Ebner --- PVE

Re: [pve-devel] [PATCH v4 storage 1/1] fix #254: iscsi: add support for multipath iscsi targets

2023-10-23 Thread Dominik Csapak
Hi, sorry but I just noticed that it seems you did not create this patch on top of our current master? at least here it does not apply cleanly, since the files got moved to src/ (in may already) so could you please rebase your patches on the current master branch and send it again? (i did not