[pve-devel] [PATCH proxmox-widget-toolkit] schema: endpoint types: don't translate endpoint type names

2023-10-09 Thread Lukas Wagner
... that are not really translatable. Signed-off-by: Lukas Wagner --- src/Schema.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Schema.js b/src/Schema.js index a7ffdf8..e0f583a 100644 --- a/src/Schema.js +++ b/src/Schema.js @@ -39,12 +39,12 @@ Ext.define('Proxmox.

Re: [pve-devel] [PATCH v2 proxmox-i18n] update German translation

2023-10-09 Thread Lukas Wagner
Some comments inline. On 10/9/23 15:21, Hannes Duerr wrote: Signed-off-by: Hannes Duerr --- de.po | 111 -- 1 file changed, 37 insertions(+), 74 deletions(-) diff --git a/de.po b/de.po index fea74f1..4f6de7d 100644 --- a/de.po +++ b/de

[pve-devel] [PATCH proxmox-widget-toolkit] panel: sendmail edit: don't translate 'Proxmox VE' in author field

2023-10-09 Thread Lukas Wagner
The default value is determined by the backend and is never translated (which does not make sense any way for a product name). This was likely just a copy/paste mistake from other from fields. Signed-off-by: Lukas Wagner --- src/panel/SendmailEditPanel.js | 2 +- 1 file changed, 1 insertion(+),

Re: [pve-devel] [PATCH v4 qemu-server 2/2] remote-migration: add target-cpu && target-reboot params

2023-10-09 Thread DERUMIER, Alexandre
Hi Fiona, Thanks for the review. >>There can be other reasons to do a restart-migration, see also >>is so I feel like this >>should be split. One for introducing target-reboot and one for >>introducing target-cpu. yes, sure it can be split in 2 patch, no problem. (v1 had only targetcpu param, b

Re: [pve-devel] [PATCH v2 qemu-server 0/2] Fix ACPI-suspended VMs resuming after migration

2023-10-09 Thread Filip Schauer
v3 patch available: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059387.html On 25/08/2023 14:18, Filip Schauer wrote: Shutdown and reboot commands do infact time out instead of failing immediately on suspended VMs. This is fixed by extending vm_is_paused with the "suspended" runst

[pve-devel] [PATCH v3 qemu-server] Fix ACPI-suspended VMs resuming after migration

2023-10-09 Thread Filip Schauer
Add checks for "suspended" and "prelaunch" runstates when checking whether a VM is paused. This fixes the following issues: * ACPI-suspended VMs automatically resuming after migration * Shutdown and reboot commands timing out instead of failing immediately on suspended VMs Signed-off-by: Filip

[pve-devel] [PATCH v2 proxmox-i18n] update German translation

2023-10-09 Thread Hannes Duerr
Signed-off-by: Hannes Duerr --- de.po | 111 -- 1 file changed, 37 insertions(+), 74 deletions(-) diff --git a/de.po b/de.po index fea74f1..4f6de7d 100644 --- a/de.po +++ b/de.po @@ -747,9 +747,8 @@ msgid "Authentication mode" msgstr "Auth

Re: [pve-devel] [PATCH manager/access-control/proxmox-widget-toolkit v1 0/4] fix #4546: Show warning hint/badge if user account is expiring in next few days

2023-10-09 Thread Philipp Hufnagl
On 10/6/23 15:16, Lukas Wagner wrote: > > > On 9/22/23 16:36, Philipp Hufnagl wrote: >> Currently, when an user account expires, it catches the users by >> surprise. It would be helpful to notify the the user as well as the >> administrator. >> >> This patch highlights such accounts in the use

[pve-devel] [PATCH kernel-helper v2 2/2] proxmox-boot-tool: check if correct grub metapackage is installed

2023-10-09 Thread Stoiko Ivanov
this part of the hook applies only to systems not using pbt for bootmangement. Currently our ISO installs grub-pc unconditionally - and never the conflicting grub-efi-amd64. Both packages are responsible for running grub-install (for the appropriate disks) upon an upgrade of grub. This results in

[pve-devel] [PATCH kernel-helper v2 1/2] proxmox-boot-tool: do not exit early in kernel-hook

2023-10-09 Thread Stoiko Ivanov
update_esps is called first in the actual execution below - exiting early does not work for systems that don't use proxmox-boot-tool if a check added later needs to work there too. Signed-off-by: Stoiko Ivanov --- src/proxmox-boot/zz-proxmox-boot | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[pve-devel] [PATCH kernel-helper/manager v2] check for fitting grub-meta package on uefi systems

2023-10-09 Thread Stoiko Ivanov
v1->v2: * adapted Friedrich's feedback (huge thanks!) ** fixed the wrongly negated check for installed grub-efi-amd64 in the boot-tool hook. ** Rephrased the error-message in pve7to8 to 2 sentences. I tried adding a newline as well, however this results in the message not being printed in

[pve-devel] [PATCH manager v2 1/1] pve7to8: check for proper grub meta-package for bootmode

2023-10-09 Thread Stoiko Ivanov
This should catch installations from our ISO on non-ZFS in uefi mode, which won't get the updated grub efi binary installed upon upgrade, because grub-pc is installed instead of grub-efi-amd64. Adding this to pve7to8 should make this even more visible, than the corresponding patch for promxox-kern

Re: [pve-devel] [PATCH v4 qemu-server 2/2] remote-migration: add target-cpu && target-reboot params

2023-10-09 Thread Fiona Ebner
There can be other reasons to do a restart-migration, see also https://bugzilla.proxmox.com/show_bug.cgi?id=4530, so I feel like this should be split. One for introducing target-reboot and one for introducing target-cpu. For 'target-reboot', the question is if we should call it 'restart' like for

Re: [pve-devel] [PATCH v4 qemu-server 1/2] migration: move livemigration code in a dedicated sub

2023-10-09 Thread Fiona Ebner
Missing your Signed-off-by trailer. Apart from that Reviewed-by: Fiona Ebner ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH proxmox-i18n 1/1] update German translation

2023-10-09 Thread Thomas Lamprecht
Am 09/10/2023 um 11:38 schrieb hd: > --- > de.po | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > On-top of what Lukas mentioned: there are dozens of fuzzy strings in de.po, and applying/reviewing patches has a slight overhead independent of the amount of changes, so I'd be great if y

Re: [pve-devel] [PATCH v2 qemu-server 1/2] Add missing checks for paused runstates

2023-10-09 Thread Fiona Ebner
Am 25.08.23 um 14:18 schrieb Filip Schauer: > Add checks for "suspended" and "prelaunch" runstates when checking > whether a VM is paused. > > This fixes the following issues: > * ACPI-suspended VMs automatically resuming after migration > * Shutdown and reboot commands timing out instead of faili

Re: [pve-devel] [PATCH v2 qemu-server 2/2] Rename vm_is_paused to vm_is_frozen

2023-10-09 Thread Fiona Ebner
Am 25.08.23 um 14:18 schrieb Filip Schauer: > Rename vm_is_paused to vm_is_frozen to avoid confusion with the "paused" > runstate. > I know I suggested renaming the function, but with 'frozen' there is potential for new confusion with fsfreeze, especially with the user-facing warnings/errors. It'

Re: [pve-devel] [PATCH proxmox-i18n 1/1] update German translation

2023-10-09 Thread Lukas Wagner
Hello Hannes, please configure your git client so that the commit author is your full name [1]: git config --global user.name "Firstname Lastname" Also, this patch is missing the 'Signed-off-by' line. That line is auto-generated by git if you provide the right flags to `git commit` or `gi

[pve-devel] [PATCH proxmox-i18n 1/1] update German translation

2023-10-09 Thread hd
--- de.po | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/de.po b/de.po index fea74f1..c647f31 100644 --- a/de.po +++ b/de.po @@ -747,9 +747,8 @@ msgid "Authentication mode" msgstr "Authentifikationsmodus" #: proxmox-widget-toolkit/src/panel/SendmailEditPanel.js:111 -#, f

[pve-devel] [PATCH proxmox-i18n 0/1] update German translation

2023-10-09 Thread hd
I suggest an update of the german translation hd (1): update German translation de.po | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.39.2 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mail

[pve-devel] [PATCH manager] api2tools: check if file changed before reusing its hash

2023-10-09 Thread Maximiliano Sandoval
We cache the hash of this file, it makes sense to first check if the file changed via `stat` and recompute the hash if needed. This is to be in sync with the changes made in https://git.proxmox.com/?p=pmg-api.git;a=commit;h=16d2ff9f8e90db64114a66d78672f5a03f5ee990. Signed-off-by: Maximiliano Sand

Re: [pve-devel] [PATCH 1/1] pve7to8: check for proper grub meta-package for bootmode

2023-10-09 Thread Friedrich Weber
On 04/10/2023 14:05, Stoiko Ivanov wrote: > +} elsif ( ! -f "/usr/share/doc/grub-efi-amd64/changelog.Debian.gz" ) { > + log_warn( > + "System booted in uefi mode but grub-efi-amd64 meta-package not > installed" > + . " new grub versions will not be installed to /boot/efi -"

Re: [pve-devel] [PATCH 2/2] proxmox-boot-tool: check if correct grub metapackage is installed

2023-10-09 Thread Friedrich Weber
On 04/10/2023 14:05, Stoiko Ivanov wrote: > diff --git a/src/proxmox-boot/zz-proxmox-boot > b/src/proxmox-boot/zz-proxmox-boot > index 1adc1b1..0d08dbf 100755 > --- a/src/proxmox-boot/zz-proxmox-boot > +++ b/src/proxmox-boot/zz-proxmox-boot > @@ -215,6 +215,23 @@ disable_systemd_boot_hook() { >